94483 2012-08-20 08:53:20 -0700 [EFL] Enable CSS Text Decoration by default 2012-08-21 15:35:01 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 58491 1 tmpsantos tmpsantos bruno.abinader cdumez g.czajkowski gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 699556 0 tmpsantos 2012-08-20 08:53:20 -0700 The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions. 699559 1 bruno.abinader 2012-08-20 08:58:18 -0700 (In reply to comment #0) > The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions. Awesome news, Thiago! I'll be taking care of EFL build on my CSS3 Text Decoration implementations. So far, in terms of implementation, only "wavy" text decoration style platform support (Cairo-specific bug 94110) and "-webkit-text-decoration-skip" (bug 92801). Other implementations are now pending review / commit-queue flags. 699560 2 159442 tmpsantos 2012-08-20 08:58:44 -0700 Created attachment 159442 Patch 699565 3 159442 tmpsantos 2012-08-20 09:01:23 -0700 Comment on attachment 159442 Patch Removing cq?. Will give time to other developers from the community to comment on this bug. 699792 4 cdumez 2012-08-20 12:26:09 -0700 Looks good. Thanks Thiago. 700529 5 g.czajkowski 2012-08-21 00:11:27 -0700 It's good idea to enable this feature especially if we have Bruno's support. BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)? 700624 6 tmpsantos 2012-08-21 04:52:33 -0700 (In reply to comment #5) > It's good idea to enable this feature especially if we have Bruno's support. > > BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)? Tested MiniBrowser, EWebLauncher and ran a complete layout tests after enabling it locally. No regressions found. 701196 7 159442 webkit.review.bot 2012-08-21 15:34:57 -0700 Comment on attachment 159442 Patch Clearing flags on attachment: 159442 Committed r126197: <http://trac.webkit.org/changeset/126197> 701197 8 webkit.review.bot 2012-08-21 15:35:01 -0700 All reviewed patches have been landed. Closing bug. 159442 2012-08-20 08:58:44 -0700 2012-08-21 15:34:57 -0700 Patch bug-94483-20120820190049.patch text/plain 4273 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDIzZTc2 OWJkZjhkOWVhYzFjZGZjNDIzZmU1YWFjZGIwMWNhNzIwZDguLjU4MWY0YWI4OWVhZjMwYmUxODFi ZWU5M2E1YzJkMmExOThlMTliMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC02NCw2ICs2NCw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BTklNQVRJT05fQVBJ IE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FQSV9URVNUUyBP TikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9CQVRURVJZX1NUQVRV UyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9CTE9CIE9OKQor V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTUzNfVEVYVF9ERUNPUkFU SU9OIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTU19JTUFH RV9TRVQgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1NTX1ZB UklBQkxFUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DVVNU T01fU0NIRU1FX0hBTkRMRVIgT04pCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggYjIwOTJmY2U2NzM3OTdiMWNlOTIxOTEyYmM0MTU1MzU3YmMxNTJk YS4uOGNiNzNiMTkxMTZhZDU3MTkyM2ZlZTc4Y2UwMDRlNGI2N2JhYzBkNiAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDEyLTA4LTIwICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwu Y29tPgorCisgICAgICAgIFtFRkxdIEVuYWJsZSBDU1MgVGV4dCBEZWNvcmF0aW9uIGJ5IGRlZmF1 bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDgz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTItMDgtMTkgIFN0ZXBoYW5pZSBM ZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG1vdW50YWluIGxpb24gdG8g YnVpbGQgY29uZmlnLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1 cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4 IDc5NmM1MDNmN2RkOGNmOTQzNDNjMzFhNDMwZDA5MGI0MzNhNTY2ODguLmM0OTgyOGRmOTU4ZDJj MWJhNTFjZTc4NGY1NjRkYWNlOTUzNDQyZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVh dHVyZUxpc3QucG0KQEAgLTE3MSw3ICsxNzEsNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBk ZWZpbmUgPT4gIkVOQUJMRV9DU1MzX0ZMRVhCT1giLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwk Y3NzM0ZsZXhib3hTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAiY3NzMy10ZXh0LWRlY29y YXRpb24iLCBkZXNjID0+ICJUb2dnbGUgQ1NTMyBUZXh0IERlY29yYXRpb24gc3VwcG9ydCIsCi0g ICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1MzX1RFWFRfREVDT1JBVElPTiIsIGRlZmF1bHQgPT4g MCwgdmFsdWUgPT4gXCRjc3MzVGV4dERlY29yYXRpb25TdXBwb3J0IH0sCisgICAgICBkZWZpbmUg PT4gIkVOQUJMRV9DU1MzX1RFWFRfREVDT1JBVElPTiIsIGRlZmF1bHQgPT4gaXNFZmwoKSwgdmFs dWUgPT4gXCRjc3MzVGV4dERlY29yYXRpb25TdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAi Y3NzLWhpZXJhcmNoaWVzIiwgZGVzYyA9PiAiVG9nZ2xlIENTUyBIaWVyYXJjaHkgc3VwcG9ydCIs CiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1NfSElFUkFSQ0hJRVMiLCBkZWZhdWx0ID0+IDAs IHZhbHVlID0+IFwkY3NzSGllcmFyY2hpZXNTdXBwb3J0IH0sCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQyYzY2YmY4N2Fl ZDE2MDAxZDVkNWM1YTQzOWVmZjEyOGUxOTI4Yi4uOTFiMTNlYjBhZmYxZGQ3MTJhNGUyMDE5OWQz MjZiZGMzNGUyZTY1NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTIwICBUaGlhZ28g TWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIEVuYWJsZSBDU1MgVGV4dCBEZWNvcmF0aW9uIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDgzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRlc3QgdGhhdCB3aWxsIG5v dyBwYXNzIGZyb20gdGhlIHNraXAgbGlzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9UZXN0 RXhwZWN0YXRpb25zOgorCiAyMDEyLTA4LTIwICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0Bn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5ZWNkMWNlNjIwMjNlODIwYzhj YjhiMmNlODVmYTNlZTA5YTZhYThhLi5lNTY2YzdlMmVhOTg2ZWI5NjI0Njg1MGE0ZmRiMDcwYTNh MGM5ZTEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAt NTcsOSArNTcsNiBAQCBCVUdXSzg1MjYyIFNLSVAgOiBmYXN0L2Nzcy9pbWFnZS1yZXNvbHV0aW9u ID0gUEFTUwogLy8gQ1NTIGltYWdlLW9yaWVudGF0aW9uIGlzIG5vdCB5ZXQgZW5hYmxlZC4KIEJV R1dLODkwNTIgU0tJUCA6IGZhc3QvY3NzL2ltYWdlLW9yaWVudGF0aW9uID0gUEFTUwogCi0vLyBD U1MzIFRleHQgRGVjb3JhdGlvbiBzdXBwb3J0IGlzIG5vdCB5ZXQgZW5hYmxlZCAobmVlZHMgRU5B QkxFX0NTUzNfVEVYVF9ERUNPUkFUSU9OKS4KLUJVR1dLNTg0OTEgU0tJUCA6IGZhc3QvY3NzMy10 ZXh0LWRlY29yYXRpb24gPSBQQVNTCi0KIC8vIFRoaXMgdGVzdCBhc3N1bWVzIHdlIGNhbm5vdCBw bGF5IFJUU1AsIGJ1dCB3ZSBjYW4uCiBCVUdXS0VGTCBTS0lQIDogbWVkaWEvdW5zdXBwb3J0ZWQt cnRzcC5odG1sID0gVElNRU9VVAogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cK aW5kZXggNTQ5MDliMWQ1OGJkYmQ1Mzk0ZWQ0OTkwZGQzNjYzMjU1ODZhZGUxZS4uMmEwYjA0YTYw NjgxN2I5NDE0ZjU5MGQ0ODhmMzY4NjZiNjk5MGU1ZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisr KyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTIwICBUaGlhZ28gTWFyY29z IFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEVu YWJsZSBDU1MgVGV4dCBEZWNvcmF0aW9uIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnkgZW5hYmxpbmcgdGhpcyBmZWF0dXJlIGJ5IGRl ZmF1bHQsIGl0IHdpbGwgZ2V0IHRlc3RlZCBieSB0aGUgYm90cworICAgICAgICBhbmQgd2UgY2Fu IG1ha2Ugc3VyZSBubyByZWdyZXNzaW9ucyB3aWxsIGhhcHBlbi4KKworICAgICAgICAqIFNvdXJj ZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCiAyMDEyLTA4LTIwICBEb21pbmlrIFLDtnR0c2No ZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gR2V0IHJp ZCBvZiBwYW5nbyBiYWNrZW5kIHN1cHBvcnQgb25jZSBoYXJmYnV6ei1uZyBpcyB3b3JraW5nCg==