94340 2012-08-17 05:44:35 -0700 Remove RefPtr<Node>s from TextFieldInputType 2022-08-17 12:37:48 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 94324 1 haraken haraken ahmad.saleem792 ap bfulgham eric inferno mifenton morrita rniwa tkent webkit.review.bot oldest_to_newest 698261 0 haraken 2012-08-17 05:44:35 -0700 To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. TextFieldInputType::m_container, TextFieldInputType::m_innerBlock, TextFieldInputType::m_innerText, TextFieldInputType::m_placeholder, TextFieldInputType::m_speechButton and TextFieldInputType::m_innerSpinButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the TextFieldInputType node, which is guaranteed to exist in the subtree of the TextFieldInputType node. 698263 1 159105 haraken 2012-08-17 05:46:58 -0700 Created attachment 159105 Patch 725122 2 tkent 2012-09-20 21:00:28 -0700 I'm very afraid this change causes security regressions. Text field code is really complex. So, I won't set r+ unless Bug 87815 is fixed and the patch uses ID access instead of raw pointers. 725127 3 159105 haraken 2012-09-20 21:02:30 -0700 Comment on attachment 159105 Patch OK. I'll clear r? because I also don't have a strong intention to land this patch. 1891919 4 ahmad.saleem792 2022-08-17 04:41:56 -0700 I can see from Webkit Github source that this patch didn't landed, some examples below: https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L78 https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L337 https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L356 rniwa@webkit.org - Is this needed now or this can be "RESOLVED LATER"? Thanks! 1892016 5 rniwa 2022-08-17 12:37:48 -0700 We're not gonna do this. 159105 2012-08-17 05:46:58 -0700 2012-09-20 21:02:30 -0700 Patch bug-94340-20120817214622.patch text/plain 9096 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uMWQ2ZDY0ZWI4YzgzYzI5N2YwYjRjMDg3YTQ1Yjgw YjhjN2I1MGVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy PE5vZGU+cyBmcm9tIFRleHRGaWVsZElucHV0VHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCByZWZlcmVuY2UgY3ljbGVzIG9mIFJlZlB0 cjxOb2RlPnMsIHdlIHdhbnQgdG8gcmVtb3ZlCisgICAgICAgIHVubmVjZXNzYXJ5IFJlZlB0cjxO b2RlPnMuIFRoZSByYXRpb25hbGUgaXMgZGVzY3JpYmVkIGluIGJ1ZyA5NDMyNC4KKworICAgICAg ICBUZXh0RmllbGRJbnB1dFR5cGU6Om1fY29udGFpbmVyLCBUZXh0RmllbGRJbnB1dFR5cGU6Om1f aW5uZXJCbG9jaywKKyAgICAgICAgVGV4dEZpZWxkSW5wdXRUeXBlOjptX2lubmVyVGV4dCwgVGV4 dEZpZWxkSW5wdXRUeXBlOjptX3BsYWNlaG9sZGVyLAorICAgICAgICBUZXh0RmllbGRJbnB1dFR5 cGU6Om1fc3BlZWNoQnV0dG9uIGFuZCBUZXh0RmllbGRJbnB1dFR5cGU6Om1faW5uZXJTcGluQnV0 dG9uCisgICAgICAgIGRvIG5vdCBuZWVkIHRvIGJlIFJlZlB0cjxOb2RlPnMsIGJlY2F1c2UgdGhl eSBhcmUgZ3VhcmFudGVlZCB0byBwb2ludCB0bworICAgICAgICB0aGUgc2hhZG93IERPTSB0cmVl IG9mIHRoZSBUZXh0RmllbGRJbnB1dFR5cGUgbm9kZSwgd2hpY2ggaXMgZ3VhcmFudGVlZCB0bwor ICAgICAgICBleGlzdCBpbiB0aGUgc3VidHJlZSBvZiB0aGUgVGV4dEZpZWxkSW5wdXRUeXBlIG5v ZGUuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAg ICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRG aWVsZElucHV0VHlwZTo6VGV4dEZpZWxkSW5wdXRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OlRl eHRGaWVsZElucHV0VHlwZTo6Y3JlYXRlU2hhZG93U3VidHJlZSk6CisgICAgICAgIChXZWJDb3Jl OjpUZXh0RmllbGRJbnB1dFR5cGU6OmNvbnRhaW5lckVsZW1lbnQpOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjppbm5lckJsb2NrRWxlbWVudCk6CisgICAgICAgIChXZWJD b3JlOjpUZXh0RmllbGRJbnB1dFR5cGU6OmlubmVyVGV4dEVsZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjppbm5lclNwaW5CdXR0b25FbGVtZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6c3BlZWNoQnV0dG9uRWxlbWVudCk6Cisg ICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGRJbnB1dFR5cGU6OnBsYWNlaG9sZGVyRWxlbWVudCk6 CisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGRJbnB1dFR5cGU6OmRlc3Ryb3lTaGFkb3dTdWJ0 cmVlKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6dXBkYXRlUGxhY2Vo b2xkZXJUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6YXR0YWNo KToKKyAgICAgICAgKiBodG1sL1RleHRGaWVsZElucHV0VHlwZS5oOgorICAgICAgICAoVGV4dEZp ZWxkSW5wdXRUeXBlKToKKwogMjAxMi0wOC0xNyAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gUmVuYW1lIFNwaW5CdXR0b25FbGVtZW50OjpT dGVwQWN0aW9uSGFuZGxlciB0byBTcGluQnV0dG9uT3duZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv VGV4dEZpZWxkSW5wdXRUeXBlLmNwcAppbmRleCAxNDA2M2M3YWEwNThjYjE4ZjRlNjBkYTI2MDA0 ODVhZTdjM2E0OWFmLi5jYWI2NTQ0NWQ4M2Q3YmVkZTQxZDczMThiODQ2MTU1NWEzYzM3NjE0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCkBAIC01OCw2ICs1 OCwxNCBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiBUZXh0RmllbGRJbnB1dFR5cGU6 OlRleHRGaWVsZElucHV0VHlwZShIVE1MSW5wdXRFbGVtZW50KiBlbGVtZW50KQogICAgIDogSW5w dXRUeXBlKGVsZW1lbnQpCisgICAgLCBtX2NvbnRhaW5lcigwKQorICAgICwgbV9pbm5lckJsb2Nr KDApCisgICAgLCBtX2lubmVyVGV4dCgwKQorICAgICwgbV9wbGFjZWhvbGRlcigwKQorICAgICwg bV9pbm5lclNwaW5CdXR0b24oMCkKKyNpZiBFTkFCTEUoSU5QVVRfU1BFRUNIKQorICAgICwgbV9z cGVlY2hCdXR0b24oMCkKKyNlbmRpZgogewogfQogCkBAIC0yMjYsOSArMjM0LDE0IEBAIHZvaWQg VGV4dEZpZWxkSW5wdXRUeXBlOjpjcmVhdGVTaGFkb3dTdWJ0cmVlKCkKIHsKICAgICBBU1NFUlQo ZWxlbWVudCgpLT5zaGFkb3coKSk7CiAKLSAgICBBU1NFUlQoIW1faW5uZXJUZXh0KTsKKyAgICBB U1NFUlQoIW1fY29udGFpbmVyKTsKICAgICBBU1NFUlQoIW1faW5uZXJCbG9jayk7CisgICAgQVNT RVJUKCFtX2lubmVyVGV4dCk7CisgICAgQVNTRVJUKCFtX3BsYWNlaG9sZGVyKTsKICAgICBBU1NF UlQoIW1faW5uZXJTcGluQnV0dG9uKTsKKyNpZiBFTkFCTEUoSU5QVVRfU1BFRUNIKQorICAgIEFT U0VSVCghbV9zcGVlY2hCdXR0b24pOworI2VuZGlmCiAKICAgICBEb2N1bWVudCogZG9jdW1lbnQg PSBlbGVtZW50KCktPmRvY3VtZW50KCk7CiAgICAgQ2hyb21lQ2xpZW50KiBjaHJvbWVDbGllbnQg PSBkb2N1bWVudC0+cGFnZSgpID8gZG9jdW1lbnQtPnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgp IDogMDsKQEAgLTIzNywzMSArMjUwLDM2IEBAIHZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjpjcmVh dGVTaGFkb3dTdWJ0cmVlKCkKICAgICBib29sIGNyZWF0ZXNDb250YWluZXIgPSBzaG91bGRIYXZl U3BpbkJ1dHRvbiB8fCBuZWVkc0NvbnRhaW5lcigpIHx8IHNob3VsZEFkZERlY29yYXRpb25zOwog CiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAgbV9pbm5lclRleHQgPSBUZXh0Q29udHJv bElubmVyVGV4dEVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCk7CisgICAgUmVmUHRyPFRleHRDb250 cm9sSW5uZXJUZXh0RWxlbWVudD4gaW5uZXJUZXh0ID0gVGV4dENvbnRyb2xJbm5lclRleHRFbGVt ZW50OjpjcmVhdGUoZG9jdW1lbnQpOworICAgIG1faW5uZXJUZXh0ID0gaW5uZXJUZXh0LmdldCgp OwogICAgIGlmICghY3JlYXRlc0NvbnRhaW5lcikgewogICAgICAgICBlbGVtZW50KCktPnVzZXJB Z2VudFNoYWRvd1Jvb3QoKS0+YXBwZW5kQ2hpbGQobV9pbm5lclRleHQsIGVjKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAogICAgIFNoYWRvd1Jvb3QqIHNoYWRvd1Jvb3QgPSBlbGVtZW50KCkt PnVzZXJBZ2VudFNoYWRvd1Jvb3QoKTsKLSAgICBtX2NvbnRhaW5lciA9IEhUTUxEaXZFbGVtZW50 OjpjcmVhdGUoZG9jdW1lbnQpOworICAgIFJlZlB0cjxIVE1MRGl2RWxlbWVudD4gY29udGFpbmVy ID0gSFRNTERpdkVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCk7CisgICAgbV9jb250YWluZXIgPSBj b250YWluZXIuZ2V0KCk7CiAgICAgbV9jb250YWluZXItPnNldFNoYWRvd1BzZXVkb0lkKCItd2Vi a2l0LXRleHRmaWVsZC1kZWNvcmF0aW9uLWNvbnRhaW5lciIpOwogICAgIHNoYWRvd1Jvb3QtPmFw cGVuZENoaWxkKG1fY29udGFpbmVyLCBlYyk7CiAKLSAgICBtX2lubmVyQmxvY2sgPSBUZXh0Q29u dHJvbElubmVyRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50KTsKKyAgICBSZWZQdHI8VGV4dENvbnRy b2xJbm5lckVsZW1lbnQ+IGlubmVyQmxvY2sgPSBUZXh0Q29udHJvbElubmVyRWxlbWVudDo6Y3Jl YXRlKGRvY3VtZW50KTsKKyAgICBtX2lubmVyQmxvY2sgPSBpbm5lckJsb2NrLmdldCgpOwogICAg IG1faW5uZXJCbG9jay0+YXBwZW5kQ2hpbGQobV9pbm5lclRleHQsIGVjKTsKICAgICBtX2NvbnRh aW5lci0+YXBwZW5kQ2hpbGQobV9pbm5lckJsb2NrLCBlYyk7CiAKICNpZiBFTkFCTEUoSU5QVVRf U1BFRUNIKQogICAgIEFTU0VSVCghbV9zcGVlY2hCdXR0b24pOwogICAgIGlmIChlbGVtZW50KCkt PmlzU3BlZWNoRW5hYmxlZCgpKSB7Ci0gICAgICAgIG1fc3BlZWNoQnV0dG9uID0gSW5wdXRGaWVs ZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCk7CisgICAgICAgIFJlZlB0cjxJ bnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVudD4gc3BlZWNoQnV0dG9uID0gSW5wdXRGaWVsZFNw ZWVjaEJ1dHRvbkVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCk7CisgICAgICAgIG1fc3BlZWNoQnV0 dG9uID0gc3BlZWNoQnV0dG9uLmdldCgpOwogICAgICAgICBtX2NvbnRhaW5lci0+YXBwZW5kQ2hp bGQobV9zcGVlY2hCdXR0b24sIGVjKTsKICAgICB9CiAjZW5kaWYKIAogICAgIGlmIChzaG91bGRI YXZlU3BpbkJ1dHRvbikgewotICAgICAgICBtX2lubmVyU3BpbkJ1dHRvbiA9IFNwaW5CdXR0b25F bGVtZW50OjpjcmVhdGUoZG9jdW1lbnQsICp0aGlzKTsKKyAgICAgICAgUmVmUHRyPFNwaW5CdXR0 b25FbGVtZW50PiBpbm5lclNwaW5CdXR0b24gPSBTcGluQnV0dG9uRWxlbWVudDo6Y3JlYXRlKGRv Y3VtZW50LCAqdGhpcyk7CisgICAgICAgIG1faW5uZXJTcGluQnV0dG9uID0gaW5uZXJTcGluQnV0 dG9uLmdldCgpOwogICAgICAgICBtX2NvbnRhaW5lci0+YXBwZW5kQ2hpbGQobV9pbm5lclNwaW5C dXR0b24sIGVjKTsKICAgICB9CiAKQEAgLTI3MSw1MCArMjg5LDUwIEBAIHZvaWQgVGV4dEZpZWxk SW5wdXRUeXBlOjpjcmVhdGVTaGFkb3dTdWJ0cmVlKCkKIAogSFRNTEVsZW1lbnQqIFRleHRGaWVs ZElucHV0VHlwZTo6Y29udGFpbmVyRWxlbWVudCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fY29u dGFpbmVyLmdldCgpOworICAgIHJldHVybiBtX2NvbnRhaW5lcjsKIH0KIAogSFRNTEVsZW1lbnQq IFRleHRGaWVsZElucHV0VHlwZTo6aW5uZXJCbG9ja0VsZW1lbnQoKSBjb25zdAogewotICAgIHJl dHVybiBtX2lubmVyQmxvY2suZ2V0KCk7CisgICAgcmV0dXJuIG1faW5uZXJCbG9jazsKIH0KIAog SFRNTEVsZW1lbnQqIFRleHRGaWVsZElucHV0VHlwZTo6aW5uZXJUZXh0RWxlbWVudCgpIGNvbnN0 CiB7CiAgICAgQVNTRVJUKG1faW5uZXJUZXh0KTsKLSAgICByZXR1cm4gbV9pbm5lclRleHQuZ2V0 KCk7CisgICAgcmV0dXJuIG1faW5uZXJUZXh0OwogfQogCiBIVE1MRWxlbWVudCogVGV4dEZpZWxk SW5wdXRUeXBlOjppbm5lclNwaW5CdXR0b25FbGVtZW50KCkgY29uc3QKIHsKLSAgICByZXR1cm4g bV9pbm5lclNwaW5CdXR0b24uZ2V0KCk7CisgICAgcmV0dXJuIG1faW5uZXJTcGluQnV0dG9uOwog fQogCiAjaWYgRU5BQkxFKElOUFVUX1NQRUVDSCkKIEhUTUxFbGVtZW50KiBUZXh0RmllbGRJbnB1 dFR5cGU6OnNwZWVjaEJ1dHRvbkVsZW1lbnQoKSBjb25zdAogewotICAgIHJldHVybiBtX3NwZWVj aEJ1dHRvbi5nZXQoKTsKKyAgICByZXR1cm4gbV9zcGVlY2hCdXR0b247CiB9CiAjZW5kaWYKIAog SFRNTEVsZW1lbnQqIFRleHRGaWVsZElucHV0VHlwZTo6cGxhY2Vob2xkZXJFbGVtZW50KCkgY29u c3QKIHsKLSAgICByZXR1cm4gbV9wbGFjZWhvbGRlci5nZXQoKTsKKyAgICByZXR1cm4gbV9wbGFj ZWhvbGRlcjsKIH0KIAogdm9pZCBUZXh0RmllbGRJbnB1dFR5cGU6OmRlc3Ryb3lTaGFkb3dTdWJ0 cmVlKCkKIHsKICAgICBJbnB1dFR5cGU6OmRlc3Ryb3lTaGFkb3dTdWJ0cmVlKCk7Ci0gICAgbV9p bm5lclRleHQuY2xlYXIoKTsKLSAgICBtX3BsYWNlaG9sZGVyLmNsZWFyKCk7Ci0gICAgbV9pbm5l ckJsb2NrLmNsZWFyKCk7CisgICAgbV9pbm5lclRleHQgPSAwOworICAgIG1fcGxhY2Vob2xkZXIg PSAwOworICAgIG1faW5uZXJCbG9jayA9IDA7CiAjaWYgRU5BQkxFKElOUFVUX1NQRUVDSCkKLSAg ICBtX3NwZWVjaEJ1dHRvbi5jbGVhcigpOworICAgIG1fc3BlZWNoQnV0dG9uID0gMDsKICNlbmRp ZgogICAgIGlmIChtX2lubmVyU3BpbkJ1dHRvbikKICAgICAgICAgbV9pbm5lclNwaW5CdXR0b24t PnJlbW92ZVNwaW5CdXR0b25Pd25lcigpOwotICAgIG1faW5uZXJTcGluQnV0dG9uLmNsZWFyKCk7 Ci0gICAgbV9jb250YWluZXIuY2xlYXIoKTsKKyAgICBtX2lubmVyU3BpbkJ1dHRvbiA9IDA7Cisg ICAgbV9jb250YWluZXIgPSAwOwogfQogCiB2b2lkIFRleHRGaWVsZElucHV0VHlwZTo6ZGlzYWJs ZWRBdHRyaWJ1dGVDaGFuZ2VkKCkKQEAgLTQwMSwyNyArNDE5LDI4IEBAIHZvaWQgVGV4dEZpZWxk SW5wdXRUeXBlOjp1cGRhdGVQbGFjZWhvbGRlclRleHQoKQogICAgIFN0cmluZyBwbGFjZWhvbGRl clRleHQgPSB1c2VzRml4ZWRQbGFjZWhvbGRlcigpID8gZml4ZWRQbGFjZWhvbGRlcigpIDogZWxl bWVudCgpLT5zdHJpcHBlZFBsYWNlaG9sZGVyKCk7CiAgICAgaWYgKHBsYWNlaG9sZGVyVGV4dC5p c0VtcHR5KCkpIHsKICAgICAgICAgaWYgKG1fcGxhY2Vob2xkZXIpIHsKLSAgICAgICAgICAgIG1f cGxhY2Vob2xkZXItPnBhcmVudE5vZGUoKS0+cmVtb3ZlQ2hpbGQobV9wbGFjZWhvbGRlci5nZXQo KSwgZWMpOworICAgICAgICAgICAgbV9wbGFjZWhvbGRlci0+cGFyZW50Tm9kZSgpLT5yZW1vdmVD aGlsZChtX3BsYWNlaG9sZGVyLCBlYyk7CiAgICAgICAgICAgICBBU1NFUlQoIWVjKTsKLSAgICAg ICAgICAgIG1fcGxhY2Vob2xkZXIuY2xlYXIoKTsKKyAgICAgICAgICAgIG1fcGxhY2Vob2xkZXIg PSAwOwogICAgICAgICB9CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgaWYgKCFtX3BsYWNl aG9sZGVyKSB7Ci0gICAgICAgIG1fcGxhY2Vob2xkZXIgPSBIVE1MRGl2RWxlbWVudDo6Y3JlYXRl KGVsZW1lbnQoKS0+ZG9jdW1lbnQoKSk7CisgICAgICAgIFJlZlB0cjxIVE1MRGl2RWxlbWVudD4g cGxhY2Vob2xkZXIgPSBIVE1MRGl2RWxlbWVudDo6Y3JlYXRlKGVsZW1lbnQoKS0+ZG9jdW1lbnQo KSk7CisgICAgICAgIG1fcGxhY2Vob2xkZXIgPSBwbGFjZWhvbGRlci5nZXQoKTsKICAgICAgICAg bV9wbGFjZWhvbGRlci0+c2V0U2hhZG93UHNldWRvSWQoIi13ZWJraXQtaW5wdXQtcGxhY2Vob2xk ZXIiKTsKICAgICAgICAgZWxlbWVudCgpLT51c2VyQWdlbnRTaGFkb3dSb290KCktPmluc2VydEJl Zm9yZShtX3BsYWNlaG9sZGVyLCBtX2NvbnRhaW5lciA/IG1fY29udGFpbmVyLT5uZXh0U2libGlu ZygpIDogaW5uZXJUZXh0RWxlbWVudCgpLT5uZXh0U2libGluZygpLCBlYyk7CiAgICAgICAgIEFT U0VSVCghZWMpOwogICAgIH0KICAgICBtX3BsYWNlaG9sZGVyLT5zZXRJbm5lclRleHQocGxhY2Vo b2xkZXJUZXh0LCBlYyk7CiAgICAgQVNTRVJUKCFlYyk7Ci0gICAgZWxlbWVudCgpLT5maXhQbGFj ZWhvbGRlclJlbmRlcmVyKG1fcGxhY2Vob2xkZXIuZ2V0KCksIG1fY29udGFpbmVyID8gbV9jb250 YWluZXIuZ2V0KCkgOiBtX2lubmVyVGV4dC5nZXQoKSk7CisgICAgZWxlbWVudCgpLT5maXhQbGFj ZWhvbGRlclJlbmRlcmVyKG1fcGxhY2Vob2xkZXIsIG1fY29udGFpbmVyID8gbV9jb250YWluZXIg OiBtX2lubmVyVGV4dCk7CiB9CiAKIHZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjphdHRhY2goKQog ewogICAgIElucHV0VHlwZTo6YXR0YWNoKCk7Ci0gICAgZWxlbWVudCgpLT5maXhQbGFjZWhvbGRl clJlbmRlcmVyKG1fcGxhY2Vob2xkZXIuZ2V0KCksIG1fY29udGFpbmVyID8gbV9jb250YWluZXIu Z2V0KCkgOiBtX2lubmVyVGV4dC5nZXQoKSk7CisgICAgZWxlbWVudCgpLT5maXhQbGFjZWhvbGRl clJlbmRlcmVyKG1fcGxhY2Vob2xkZXIsIG1fY29udGFpbmVyID8gbV9jb250YWluZXIgOiBtX2lu bmVyVGV4dCk7CiB9CiAKIGJvb2wgVGV4dEZpZWxkSW5wdXRUeXBlOjphcHBlbmRGb3JtRGF0YShG b3JtRGF0YUxpc3QmIGxpc3QsIGJvb2wgbXVsdGlwYXJ0KSBjb25zdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmgKaW5kZXggYTUwYmRmODhmZDY5Y2UyMDNhOGI1ZjhhYWE1 OWQ2OTRhMTM1MWU5YS4uY2E4NDFjZGE1ZDdiZmI3YWFhOTM2N2YxMDcxZjc1ODBhYTBhMzVmNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5oCkBAIC04OSwxMyArODks MTMgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc3BpbkJ1dHRvblN0ZXBEb3duKCkgT1ZF UlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHNwaW5CdXR0b25TdGVwVXAoKSBPVkVSUklERTsKIAot ICAgIFJlZlB0cjxIVE1MRWxlbWVudD4gbV9jb250YWluZXI7Ci0gICAgUmVmUHRyPEhUTUxFbGVt ZW50PiBtX2lubmVyQmxvY2s7Ci0gICAgUmVmUHRyPEhUTUxFbGVtZW50PiBtX2lubmVyVGV4dDsK LSAgICBSZWZQdHI8SFRNTEVsZW1lbnQ+IG1fcGxhY2Vob2xkZXI7Ci0gICAgUmVmUHRyPFNwaW5C dXR0b25FbGVtZW50PiBtX2lubmVyU3BpbkJ1dHRvbjsKKyAgICBIVE1MRWxlbWVudCogbV9jb250 YWluZXI7CisgICAgSFRNTEVsZW1lbnQqIG1faW5uZXJCbG9jazsKKyAgICBIVE1MRWxlbWVudCog bV9pbm5lclRleHQ7CisgICAgSFRNTEVsZW1lbnQqIG1fcGxhY2Vob2xkZXI7CisgICAgU3BpbkJ1 dHRvbkVsZW1lbnQqIG1faW5uZXJTcGluQnV0dG9uOwogI2lmIEVOQUJMRShJTlBVVF9TUEVFQ0gp Ci0gICAgUmVmUHRyPEhUTUxFbGVtZW50PiBtX3NwZWVjaEJ1dHRvbjsKKyAgICBIVE1MRWxlbWVu dCogbV9zcGVlY2hCdXR0b247CiAjZW5kaWYKIH07CiAK