94339 2012-08-17 05:28:30 -0700 Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton 2012-08-19 18:08:25 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94324 1 haraken haraken mifenton morrita tkent webkit.review.bot oldest_to_newest 698251 0 haraken 2012-08-17 05:28:30 -0700 To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the SearchInputType node, which is guaranteed to exist in the subtree of the SearchInputType node. 698254 1 159101 haraken 2012-08-17 05:30:47 -0700 Created attachment 159101 Patch 699122 2 159101 tkent 2012-08-19 17:52:34 -0700 Comment on attachment 159101 Patch ok 699127 3 159101 webkit.review.bot 2012-08-19 18:08:21 -0700 Comment on attachment 159101 Patch Clearing flags on attachment: 159101 Committed r125984: <http://trac.webkit.org/changeset/125984> 699128 4 webkit.review.bot 2012-08-19 18:08:25 -0700 All reviewed patches have been landed. Closing bug. 159101 2012-08-17 05:30:47 -0700 2012-08-19 18:08:21 -0700 Patch bug-94339-20120817213011.patch text/plain 4534 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uMTEzMzQyNTg4YmZhMzNlOTNlNjg1MTA0YTcxYmEx OGZiZWM0MzMzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy IGZyb20gU2VhcmNoSW5wdXRUeXBlOjptX3Jlc3VsdHNCdXR0b24gYW5kIFNlYXJjaElucHV0VHlw ZTo6bV9jYW5jZWxCdXR0b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk0MzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVG8gYXZvaWQgcmVmZXJlbmNlIGN5Y2xlcyBvZiBSZWZQdHI8Tm9kZT5zLCB3ZSB3 YW50IHRvIHJlbW92ZSB1bm5lY2Vzc2FyeQorICAgICAgICBSZWZQdHI8Tm9kZT5zLiBUaGUgcmF0 aW9uYWxlIGlzIGRlc2NyaWJlZCBpbiBidWcgOTQzMjQuCisKKyAgICAgICAgU2VhcmNoSW5wdXRU eXBlOjptX3Jlc3VsdHNCdXR0b24gYW5kIFNlYXJjaElucHV0VHlwZTo6bV9jYW5jZWxCdXR0b24g ZG8gbm90CisgICAgICAgIG5lZWQgdG8gYmUgUmVmUHRyPE5vZGU+cywgYmVjYXVzZSB0aGV5IGFy ZSBndWFyYW50ZWVkIHRvIHBvaW50IHRvIHRoZSBzaGFkb3cKKyAgICAgICAgRE9NIHRyZWUgb2Yg dGhlIFNlYXJjaElucHV0VHlwZSBub2RlLCB3aGljaCBpcyBndWFyYW50ZWVkIHRvIGV4aXN0IGlu IHRoZQorICAgICAgICBzdWJ0cmVlIG9mIHRoZSBTZWFyY2hJbnB1dFR5cGUgbm9kZS4KKworICAg ICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9T ZWFyY2hJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoSW5wdXRUeXBlOjpT ZWFyY2hJbnB1dFR5cGUpOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoSW5wdXRUeXBlOjpjcmVh dGVTaGFkb3dTdWJ0cmVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlYXJjaElucHV0VHlwZTo6cmVz dWx0c0J1dHRvbkVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoSW5wdXRUeXBlOjpj YW5jZWxCdXR0b25FbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlNlYXJjaElucHV0VHlwZTo6 ZGVzdHJveVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAoV2ViQ29yZTo6U2VhcmNoSW5wdXRUeXBl OjpzdWJ0cmVlSGFzQ2hhbmdlZCk6CisgICAgICAgICogaHRtbC9TZWFyY2hJbnB1dFR5cGUuaDoK KyAgICAgICAgKFNlYXJjaElucHV0VHlwZSk6CisKIDIwMTItMDgtMTcgIFlvc2hpZnVtaSBJbm91 ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbRm9ybXNdIFJlbmFtZSBTcGluQnV0 dG9uRWxlbWVudDo6U3RlcEFjdGlvbkhhbmRsZXIgdG8gU3BpbkJ1dHRvbk93bmVyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1NlYXJjaElucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL1NlYXJjaElucHV0VHlwZS5jcHAKaW5kZXggOTU4ODc4Y2VkMjcwNDk4MTcyN2Nh NTAxY2E3NDkyYTc5YTNhMTgwOC4uMDlmMDc5Yjc5YTZhNTJhMWZjMDVmYjQxNTMyMDMzMDQ2MTJk N2UwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9TZWFyY2hJbnB1dFR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvU2VhcmNoSW5wdXRUeXBlLmNwcApAQCAtNDUsNiAr NDUsOCBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiBpbmxpbmUgU2VhcmNoSW5wdXRU eXBlOjpTZWFyY2hJbnB1dFR5cGUoSFRNTElucHV0RWxlbWVudCogZWxlbWVudCkKICAgICA6IEJh c2VUZXh0SW5wdXRUeXBlKGVsZW1lbnQpCisgICAgLCBtX3Jlc3VsdHNCdXR0b24oMCkKKyAgICAs IG1fY2FuY2VsQnV0dG9uKDApCiAgICAgLCBtX3NlYXJjaEV2ZW50VGltZXIodGhpcywgJlNlYXJj aElucHV0VHlwZTo6c2VhcmNoRXZlbnRUaW1lckZpcmVkKQogewogfQpAQCAtOTcsMjEgKzk5LDIz IEBAIHZvaWQgU2VhcmNoSW5wdXRUeXBlOjpjcmVhdGVTaGFkb3dTdWJ0cmVlKCkKICAgICBBU1NF UlQodGV4dFdyYXBwZXIpOwogCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAgbV9yZXN1 bHRzQnV0dG9uID0gU2VhcmNoRmllbGRSZXN1bHRzQnV0dG9uRWxlbWVudDo6Y3JlYXRlKGVsZW1l bnQoKS0+ZG9jdW1lbnQoKSk7CisgICAgUmVmUHRyPFNlYXJjaEZpZWxkUmVzdWx0c0J1dHRvbkVs ZW1lbnQ+IHJlc3VsdHNCdXR0b24gPSBTZWFyY2hGaWVsZFJlc3VsdHNCdXR0b25FbGVtZW50Ojpj cmVhdGUoZWxlbWVudCgpLT5kb2N1bWVudCgpKTsKKyAgICBtX3Jlc3VsdHNCdXR0b24gPSByZXN1 bHRzQnV0dG9uLmdldCgpOwogICAgIGNvbnRhaW5lci0+aW5zZXJ0QmVmb3JlKG1fcmVzdWx0c0J1 dHRvbiwgdGV4dFdyYXBwZXIsIGVjKTsKIAotICAgIG1fY2FuY2VsQnV0dG9uID0gU2VhcmNoRmll bGRDYW5jZWxCdXR0b25FbGVtZW50OjpjcmVhdGUoZWxlbWVudCgpLT5kb2N1bWVudCgpKTsKKyAg ICBSZWZQdHI8U2VhcmNoRmllbGRDYW5jZWxCdXR0b25FbGVtZW50PiBjYW5jZWxCdXR0b24gPSBT ZWFyY2hGaWVsZENhbmNlbEJ1dHRvbkVsZW1lbnQ6OmNyZWF0ZShlbGVtZW50KCktPmRvY3VtZW50 KCkpOworICAgIG1fY2FuY2VsQnV0dG9uID0gY2FuY2VsQnV0dG9uLmdldCgpOwogICAgIGNvbnRh aW5lci0+aW5zZXJ0QmVmb3JlKG1fY2FuY2VsQnV0dG9uLCB0ZXh0V3JhcHBlci0+bmV4dFNpYmxp bmcoKSwgZWMpOwogfQogCiBIVE1MRWxlbWVudCogU2VhcmNoSW5wdXRUeXBlOjpyZXN1bHRzQnV0 dG9uRWxlbWVudCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fcmVzdWx0c0J1dHRvbi5nZXQoKTsK KyAgICByZXR1cm4gbV9yZXN1bHRzQnV0dG9uOwogfQogCiBIVE1MRWxlbWVudCogU2VhcmNoSW5w dXRUeXBlOjpjYW5jZWxCdXR0b25FbGVtZW50KCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9jYW5j ZWxCdXR0b24uZ2V0KCk7CisgICAgcmV0dXJuIG1fY2FuY2VsQnV0dG9uOwogfQogCiB2b2lkIFNl YXJjaElucHV0VHlwZTo6aGFuZGxlS2V5ZG93bkV2ZW50KEtleWJvYXJkRXZlbnQqIGV2ZW50KQpA QCAtMTM1LDggKzEzOSw4IEBAIHZvaWQgU2VhcmNoSW5wdXRUeXBlOjpoYW5kbGVLZXlkb3duRXZl bnQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiB2b2lkIFNlYXJjaElucHV0VHlwZTo6ZGVzdHJveVNo YWRvd1N1YnRyZWUoKQogewogICAgIFRleHRGaWVsZElucHV0VHlwZTo6ZGVzdHJveVNoYWRvd1N1 YnRyZWUoKTsKLSAgICBtX3Jlc3VsdHNCdXR0b24uY2xlYXIoKTsKLSAgICBtX2NhbmNlbEJ1dHRv bi5jbGVhcigpOworICAgIG1fcmVzdWx0c0J1dHRvbiA9IDA7CisgICAgbV9jYW5jZWxCdXR0b24g PSAwOwogfQogCiB2b2lkIFNlYXJjaElucHV0VHlwZTo6c3RhcnRTZWFyY2hFdmVudFRpbWVyKCkK QEAgLTE3Miw3ICsxNzYsNyBAQCBib29sIFNlYXJjaElucHV0VHlwZTo6c2VhcmNoRXZlbnRzU2hv dWxkQmVEaXNwYXRjaGVkKCkgY29uc3QKIAogdm9pZCBTZWFyY2hJbnB1dFR5cGU6OnN1YnRyZWVI YXNDaGFuZ2VkKCkKIHsKLSAgICBpZiAobV9jYW5jZWxCdXR0b24uZ2V0KCkpCisgICAgaWYgKG1f Y2FuY2VsQnV0dG9uKQogICAgICAgICB0b1JlbmRlclNlYXJjaEZpZWxkKGVsZW1lbnQoKS0+cmVu ZGVyZXIoKSktPnVwZGF0ZUNhbmNlbEJ1dHRvblZpc2liaWxpdHkoKTsKIAogICAgIC8vIElmIHRo ZSBpbmNyZW1lbnRhbCBhdHRyaWJ1dGUgaXMgc2V0LCB0aGVuIGRpc3BhdGNoIHRoZSBzZWFyY2gg ZXZlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvU2VhcmNoSW5wdXRUeXBlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL1NlYXJjaElucHV0VHlwZS5oCmluZGV4IGVjZTM1YTI1OWYw ODFlMDdiNDBkNDdjYTc3YzI4ODE2MjU1YmY1NWQuLjQ0YmQxYjdjMGEwMzQwOTk5YzBhMjE0NTMy ODUwYzA1NGI3MTZiYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvU2VhcmNoSW5w dXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9TZWFyY2hJbnB1dFR5cGUuaApAQCAt NjQsOCArNjQsOCBAQCBwcml2YXRlOgogICAgIGJvb2wgc2VhcmNoRXZlbnRzU2hvdWxkQmVEaXNw YXRjaGVkKCkgY29uc3Q7CiAgICAgdm9pZCBzdGFydFNlYXJjaEV2ZW50VGltZXIoKTsKIAotICAg IFJlZlB0cjxIVE1MRWxlbWVudD4gbV9yZXN1bHRzQnV0dG9uOwotICAgIFJlZlB0cjxIVE1MRWxl bWVudD4gbV9jYW5jZWxCdXR0b247CisgICAgSFRNTEVsZW1lbnQqIG1fcmVzdWx0c0J1dHRvbjsK KyAgICBIVE1MRWxlbWVudCogbV9jYW5jZWxCdXR0b247CiAgICAgVGltZXI8U2VhcmNoSW5wdXRU eXBlPiBtX3NlYXJjaEV2ZW50VGltZXI7CiB9OwogCg==