94338 2012-08-17 05:18:10 -0700 Remove RefPtr from HTMLTextAreaElement::m_placeholder 2012-08-24 03:08:30 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94324 1 haraken haraken eric inferno mifenton morrita tkent webkit.review.bot oldest_to_newest 698231 0 haraken 2012-08-17 05:18:10 -0700 To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. HTMLTextAreaElement::m_placeholder does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLTextAreaElement node, which is guaranteed to exist in the subtree of the HTMLTextAreaElement node. 698237 1 159096 haraken 2012-08-17 05:20:20 -0700 Created attachment 159096 Patch 702310 2 inferno 2012-08-22 13:58:22 -0700 Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:( 702639 3 haraken 2012-08-22 19:30:56 -0700 (In reply to comment #2) > Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:( It's added by tkent at r90971. It looks like it's not added for a security issue. (Although I believe this patch is safe and will make reference-cycle reasoning simple, I'm not strongly intending to land this patch.) 703930 4 159096 tkent 2012-08-24 02:52:37 -0700 Comment on attachment 159096 Patch Probably ok 703939 5 159096 webkit.review.bot 2012-08-24 03:08:27 -0700 Comment on attachment 159096 Patch Clearing flags on attachment: 159096 Committed r126567: <http://trac.webkit.org/changeset/126567> 703940 6 webkit.review.bot 2012-08-24 03:08:30 -0700 All reviewed patches have been landed. Closing bug. 159096 2012-08-17 05:20:20 -0700 2012-08-24 03:08:26 -0700 Patch bug-94338-20120817211944.patch text/plain 4108 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uMDYwNWY5ZmVmY2EzNmU1MmY1ZjQzNmZiMGE1ZjM3 ZWJlZjE3ZGVmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy IGZyb20gSFRNTFRleHRBcmVhRWxlbWVudDo6bV9wbGFjZWhvbGRlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzMzgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCByZWZlcmVuY2UgY3ljbGVz IG9mIFJlZlB0cjxOb2RlPnMsIHdlIHdhbnQgdG8gcmVtb3ZlCisgICAgICAgIHVubmVjZXNzYXJ5 IFJlZlB0cjxOb2RlPnMuIFRoZSByYXRpb25hbGUgaXMgZGVzY3JpYmVkIGluIGJ1ZyA5NDMyNC4K KworICAgICAgICBIVE1MVGV4dEFyZWFFbGVtZW50OjptX3BsYWNlaG9sZGVyIGRvZXMgbm90IG5l ZWQgdG8gYmUgYSBSZWZQdHI8Tm9kZT4sCisgICAgICAgIGJlY2F1c2UgaXQgaXMgZ3VhcmFudGVl ZCB0byBwb2ludCB0byBhIHNoYWRvdyBET00gdHJlZSBvZiB0aGUKKyAgICAgICAgSFRNTFRleHRB cmVhRWxlbWVudCBub2RlLCB3aGljaCBpcyBndWFyYW50ZWVkIHRvIGV4aXN0IGluIHRoZSBzdWJ0 cmVlCisgICAgICAgIG9mIHRoZSBIVE1MVGV4dEFyZWFFbGVtZW50IG5vZGUuCisKKyAgICAgICAg Tm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGh0bWwvSFRNTFRl eHRBcmVhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50 OjpIVE1MVGV4dEFyZWFFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0QXJlYUVs ZW1lbnQ6OnBsYWNlaG9sZGVyRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4dEFy ZWFFbGVtZW50OjphdHRhY2gpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRBcmVhRWxlbWVu dDo6dXBkYXRlUGxhY2Vob2xkZXJUZXh0KToKKyAgICAgICAgKiBodG1sL0hUTUxUZXh0QXJlYUVs ZW1lbnQuaDoKKyAgICAgICAgKEhUTUxUZXh0QXJlYUVsZW1lbnQpOgorCiAyMDEyLTA4LTE3ICBZ b3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Zvcm1zXSBS ZW5hbWUgU3BpbkJ1dHRvbkVsZW1lbnQ6OlN0ZXBBY3Rpb25IYW5kbGVyIHRvIFNwaW5CdXR0b25P d25lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAKaW5kZXgg YmFkODU3MWQzNTFmNWM4NTUzMzAyMDA0ZmFiMjI4OGZmMDBmNzU2Mi4uNzI4MmE1Y2VkMzU0OTk4 MjUxNjYzYmNmYmI5ZGE0NGUzY2MzNzcwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxU ZXh0QXJlYUVsZW1lbnQuY3BwCkBAIC03Miw2ICs3Miw3IEBAIEhUTUxUZXh0QXJlYUVsZW1lbnQ6 OkhUTUxUZXh0QXJlYUVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1l bnQqCiAgICAgLCBtX3Jvd3MoZGVmYXVsdFJvd3MpCiAgICAgLCBtX2NvbHMoZGVmYXVsdENvbHMp CiAgICAgLCBtX3dyYXAoU29mdFdyYXApCisgICAgLCBtX3BsYWNlaG9sZGVyKDApCiAgICAgLCBt X2lzRGlydHkoZmFsc2UpCiAgICAgLCBtX3dhc01vZGlmaWVkQnlVc2VyKGZhbHNlKQogewpAQCAt NDkwLDEzICs0OTEsMTMgQEAgYm9vbCBIVE1MVGV4dEFyZWFFbGVtZW50OjpzaG91bGRVc2VJbnB1 dE1ldGhvZCgpCiAKIEhUTUxFbGVtZW50KiBIVE1MVGV4dEFyZWFFbGVtZW50OjpwbGFjZWhvbGRl ckVsZW1lbnQoKSBjb25zdAogewotICAgIHJldHVybiBtX3BsYWNlaG9sZGVyLmdldCgpOworICAg IHJldHVybiBtX3BsYWNlaG9sZGVyOwogfQogCiB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OmF0 dGFjaCgpCiB7CiAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmF0dGFjaCgpOwotICAg IGZpeFBsYWNlaG9sZGVyUmVuZGVyZXIobV9wbGFjZWhvbGRlci5nZXQoKSwgaW5uZXJUZXh0RWxl bWVudCgpKTsKKyAgICBmaXhQbGFjZWhvbGRlclJlbmRlcmVyKG1fcGxhY2Vob2xkZXIsIGlubmVy VGV4dEVsZW1lbnQoKSk7CiB9CiAKIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6dXBkYXRlUGxh Y2Vob2xkZXJUZXh0KCkKQEAgLTUwNSwyMSArNTA2LDIyIEBAIHZvaWQgSFRNTFRleHRBcmVhRWxl bWVudDo6dXBkYXRlUGxhY2Vob2xkZXJUZXh0KCkKICAgICBTdHJpbmcgcGxhY2Vob2xkZXJUZXh0 ID0gc3RyaXBwZWRQbGFjZWhvbGRlcigpOwogICAgIGlmIChwbGFjZWhvbGRlclRleHQuaXNFbXB0 eSgpKSB7CiAgICAgICAgIGlmIChtX3BsYWNlaG9sZGVyKSB7Ci0gICAgICAgICAgICB1c2VyQWdl bnRTaGFkb3dSb290KCktPnJlbW92ZUNoaWxkKG1fcGxhY2Vob2xkZXIuZ2V0KCksIGVjKTsKKyAg ICAgICAgICAgIHVzZXJBZ2VudFNoYWRvd1Jvb3QoKS0+cmVtb3ZlQ2hpbGQobV9wbGFjZWhvbGRl ciwgZWMpOwogICAgICAgICAgICAgQVNTRVJUKCFlYyk7Ci0gICAgICAgICAgICBtX3BsYWNlaG9s ZGVyLmNsZWFyKCk7CisgICAgICAgICAgICBtX3BsYWNlaG9sZGVyID0gMDsKICAgICAgICAgfQog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGlmICghbV9wbGFjZWhvbGRlcikgewotICAgICAg ICBtX3BsYWNlaG9sZGVyID0gSFRNTERpdkVsZW1lbnQ6OmNyZWF0ZShkb2N1bWVudCgpKTsKKyAg ICAgICAgUmVmUHRyPEhUTUxEaXZFbGVtZW50PiBwbGFjZWhvbGRlciA9IEhUTUxEaXZFbGVtZW50 OjpjcmVhdGUoZG9jdW1lbnQoKSk7CisgICAgICAgIG1fcGxhY2Vob2xkZXIgPSBwbGFjZWhvbGRl ci5nZXQoKTsKICAgICAgICAgbV9wbGFjZWhvbGRlci0+c2V0U2hhZG93UHNldWRvSWQoIi13ZWJr aXQtaW5wdXQtcGxhY2Vob2xkZXIiKTsKICAgICAgICAgdXNlckFnZW50U2hhZG93Um9vdCgpLT5p bnNlcnRCZWZvcmUobV9wbGFjZWhvbGRlciwgaW5uZXJUZXh0RWxlbWVudCgpLT5uZXh0U2libGlu ZygpLCBlYyk7CiAgICAgICAgIEFTU0VSVCghZWMpOwogICAgIH0KICAgICBtX3BsYWNlaG9sZGVy LT5zZXRJbm5lclRleHQocGxhY2Vob2xkZXJUZXh0LCBlYyk7CiAgICAgQVNTRVJUKCFlYyk7Ci0g ICAgZml4UGxhY2Vob2xkZXJSZW5kZXJlcihtX3BsYWNlaG9sZGVyLmdldCgpLCBpbm5lclRleHRF bGVtZW50KCkpOworICAgIGZpeFBsYWNlaG9sZGVyUmVuZGVyZXIobV9wbGFjZWhvbGRlciwgaW5u ZXJUZXh0RWxlbWVudCgpKTsKIH0KIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MVGV4dEFyZWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJl YUVsZW1lbnQuaAppbmRleCA0ZTZkYjU2M2UzYzljMTJjNWE1MzU3YWQyODI4MzI3MzE3YzRmMDI5 Li42ZTJhYTU4Yjk2OGM2ZGRlNzQzMTIwMTQ3NzBlNjQ3MzAwNTQzYzBlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuaApAQCAtMTE3LDcgKzExNyw3IEBAIHByaXZh dGU6CiAgICAgaW50IG1fcm93czsKICAgICBpbnQgbV9jb2xzOwogICAgIFdyYXBNZXRob2QgbV93 cmFwOwotICAgIFJlZlB0cjxIVE1MRWxlbWVudD4gbV9wbGFjZWhvbGRlcjsKKyAgICBIVE1MRWxl bWVudCogbV9wbGFjZWhvbGRlcjsKICAgICBtdXRhYmxlIFN0cmluZyBtX3ZhbHVlOwogICAgIG11 dGFibGUgYm9vbCBtX2lzRGlydHk7CiAgICAgbXV0YWJsZSBib29sIG1fd2FzTW9kaWZpZWRCeVVz ZXI7Cg==