94330 2012-08-17 03:53:44 -0700 Remove RefPtr from DateInputType::m_pickerElement 2012-08-17 05:26:03 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94324 1 haraken haraken dglazkov mifenton morrita peter+ews tkent webkit.review.bot oldest_to_newest 698166 0 haraken 2012-08-17 03:53:44 -0700 To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is describe in bug 94324. DateInputType::m_pickerElement does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the DateInputType node, which is guaranteed to exist in the subtree of the DateInputType node. 698172 1 159076 haraken 2012-08-17 03:58:04 -0700 Created attachment 159076 Patch 698176 2 159076 tkent 2012-08-17 04:04:02 -0700 Comment on attachment 159076 Patch ok 698177 3 159076 peter+ews 2012-08-17 04:04:16 -0700 Comment on attachment 159076 Patch Attachment 159076 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13522102 698190 4 159085 haraken 2012-08-17 04:30:00 -0700 Created attachment 159085 patch for landing 698247 5 159085 webkit.review.bot 2012-08-17 05:25:31 -0700 Comment on attachment 159085 patch for landing Clearing flags on attachment: 159085 Committed r125886: <http://trac.webkit.org/changeset/125886> 159076 2012-08-17 03:58:04 -0700 2012-08-17 05:26:03 -0700 Patch bug-94330-20120817195728.patch text/plain 3133 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uMmM3MzRiYTVjZGY0YTRlMTZlNTVlMDA5OWU2YWY0 NGQzYmJmMzRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy IGZyb20gRGF0ZUlucHV0VHlwZTo6bV9waWNrZXJFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDMzMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGF2b2lkIHJlZmVyZW5jZSBjeWNsZXMgb2Yg UmVmUHRyPE5vZGU+cywgd2Ugd2FudCB0byByZW1vdmUKKyAgICAgICAgdW5uZWNlc3NhcnkgUmVm UHRyPE5vZGU+cy4gVGhlIHJhdGlvbmFsZSBpcyBkZXNjcmliZSBpbiBidWcgOTQzMjQuCisKKyAg ICAgICAgRGF0ZUlucHV0VHlwZTo6bV9waWNrZXJFbGVtZW50IGRvZXMgbm90IG5lZWQgdG8gYmUg YSBSZWZQdHI8Tm9kZT4sCisgICAgICAgIGJlY2F1c2UgaXQgaXMgZ3VhcmFudGVlZCB0byBwb2lu dCB0byBhIHNoYWRvdyBET00gdHJlZSBvZiB0aGUgRGF0ZUlucHV0VHlwZQorICAgICAgICBub2Rl LCB3aGljaCBpcyBndWFyYW50ZWVkIHRvIGV4aXN0IGluIHRoZSBzdWJ0cmVlIG9mIHRoZSBEYXRl SW5wdXRUeXBlIG5vZGUuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICAqIGh0bWwvRGF0ZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpEYXRlSW5wdXRUeXBlOjpEYXRlSW5wdXRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVJ bnB1dFR5cGU6OmNyZWF0ZVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAoV2ViQ29yZTo6RGF0ZUlu cHV0VHlwZTo6ZGVzdHJveVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAqIGh0bWwvRGF0ZUlucHV0 VHlwZS5oOgorICAgICAgICAoRGF0ZUlucHV0VHlwZSk6CisKIDIwMTItMDgtMTcgIFlvc2hpZnVt aSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbRm9ybXNdIFJlbmFtZSBT cGluQnV0dG9uRWxlbWVudDo6U3RlcEFjdGlvbkhhbmRsZXIgdG8gU3BpbkJ1dHRvbk93bmVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBlLmNwcAppbmRleCA5NjIwNDZhNDJlMTJiNzQ3OTBi NWY3N2FjZGU3NDc4ODA4YzZjN2VjLi40MDA5ZmMwODY0ZGYwZjZmMWZmNzk3OTNkNzg1NWVmM2Ey OGZlNWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUlucHV0VHlwZS5jcHAKQEAgLTUxLDYgKzUx LDcgQEAgc3RhdGljIGNvbnN0IGludCBkYXRlU3RlcFNjYWxlRmFjdG9yID0gODY0MDAwMDA7CiAK IGlubGluZSBEYXRlSW5wdXRUeXBlOjpEYXRlSW5wdXRUeXBlKEhUTUxJbnB1dEVsZW1lbnQqIGVs ZW1lbnQpCiAgICAgOiBCYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUoZWxlbWVudCkKKyAgICAsIG1f cGlja2VyRWxlbWVudCgwKQogewogfQogCkBAIC0xMDIsMTQgKzEwMywxNSBAQCBib29sIERhdGVJ bnB1dFR5cGU6OmlzRGF0ZUZpZWxkKCkgY29uc3QKIHZvaWQgRGF0ZUlucHV0VHlwZTo6Y3JlYXRl U2hhZG93U3VidHJlZSgpCiB7CiAgICAgQmFzZURhdGVBbmRUaW1lSW5wdXRUeXBlOjpjcmVhdGVT aGFkb3dTdWJ0cmVlKCk7Ci0gICAgbV9waWNrZXJFbGVtZW50ID0gQ2FsZW5kYXJQaWNrZXJFbGVt ZW50OjpjcmVhdGUoZWxlbWVudCgpLT5kb2N1bWVudCgpKTsKLSAgICBjb250YWluZXJFbGVtZW50 KCktPmluc2VydEJlZm9yZShtX3BpY2tlckVsZW1lbnQuZ2V0KCksIGlubmVyQmxvY2tFbGVtZW50 KCktPm5leHRTaWJsaW5nKCksIEFTU0VSVF9OT19FWENFUFRJT04pOworICAgIFJlZlB0cjxDYWxl bmRhclBpY2tlckVsZW1lbnQ+IHBpY2tlckVsZW1lbnQgPSBDYWxlbmRhclBpY2tlckVsZW1lbnQ6 OmNyZWF0ZShlbGVtZW50KCktPmRvY3VtZW50KCkpOworICAgIG1fcGlja2VyRWxlbWVudCA9IHBp Y2tlckVsZW1lbnQuZ2V0KCk7CisgICAgY29udGFpbmVyRWxlbWVudCgpLT5pbnNlcnRCZWZvcmUo bV9waWNrZXJFbGVtZW50LCBpbm5lckJsb2NrRWxlbWVudCgpLT5uZXh0U2libGluZygpLCBBU1NF UlRfTk9fRVhDRVBUSU9OKTsKIH0KIAogdm9pZCBEYXRlSW5wdXRUeXBlOjpkZXN0cm95U2hhZG93 U3VidHJlZSgpCiB7CiAgICAgVGV4dEZpZWxkSW5wdXRUeXBlOjpkZXN0cm95U2hhZG93U3VidHJl ZSgpOwotICAgIG1fcGlja2VyRWxlbWVudC5jbGVhcigpOworICAgIG1fcGlja2VyRWxlbWVudCA9 IDA7CiB9CiAKIGJvb2wgRGF0ZUlucHV0VHlwZTo6bmVlZHNDb250YWluZXIoKSBjb25zdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0RhdGVJbnB1dFR5cGUuaAppbmRleCAyZmFkYzQ3YjQ4Y2QwYTM5ZTAwZjQzYjNi ZjExYmEwYTliMjFjMDFmLi5kNDgwNDlkYWFmNjE1M2VmZGRmOTc1MDU2NzQ1ZWZiYzY5Yzg0NGJk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuaApAQCAtNjUsNyArNjUsNyBAQCBwcml2 YXRlOgogICAgIHZpcnR1YWwgYm9vbCBuZWVkc0NvbnRhaW5lcigpIGNvbnN0IE9WRVJSSURFOwog ICAgIHZpcnR1YWwgYm9vbCBzaG91bGRIYXZlU3BpbkJ1dHRvbigpIGNvbnN0IE9WRVJSSURFOwog Ci0gICAgUmVmUHRyPENhbGVuZGFyUGlja2VyRWxlbWVudD4gbV9waWNrZXJFbGVtZW50OworICAg IENhbGVuZGFyUGlja2VyRWxlbWVudCogbV9waWNrZXJFbGVtZW50OwogI2VuZGlmCiB9OwogCg== 159085 2012-08-17 04:30:00 -0700 2012-08-17 05:25:31 -0700 patch for landing bug-94330-20120817202924.patch text/plain 3167 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uMGM4NGU1YTk5ZWJiNjJhNzBiMTYxM2E0NDVlNTAz OWEzMzVlNmFjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy IGZyb20gRGF0ZUlucHV0VHlwZTo6bV9waWNrZXJFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDMzMAorCisgICAgICAgIFJldmlld2VkIGJ5 IEtlbnQgVGFtdXJhLgorCisgICAgICAgIFRvIGF2b2lkIHJlZmVyZW5jZSBjeWNsZXMgb2YgUmVm UHRyPE5vZGU+cywgd2Ugd2FudCB0byByZW1vdmUKKyAgICAgICAgdW5uZWNlc3NhcnkgUmVmUHRy PE5vZGU+cy4gVGhlIHJhdGlvbmFsZSBpcyBkZXNjcmliZSBpbiBidWcgOTQzMjQuCisKKyAgICAg ICAgRGF0ZUlucHV0VHlwZTo6bV9waWNrZXJFbGVtZW50IGRvZXMgbm90IG5lZWQgdG8gYmUgYSBS ZWZQdHI8Tm9kZT4sCisgICAgICAgIGJlY2F1c2UgaXQgaXMgZ3VhcmFudGVlZCB0byBwb2ludCB0 byBhIHNoYWRvdyBET00gdHJlZSBvZiB0aGUgRGF0ZUlucHV0VHlwZQorICAgICAgICBub2RlLCB3 aGljaCBpcyBndWFyYW50ZWVkIHRvIGV4aXN0IGluIHRoZSBzdWJ0cmVlIG9mIHRoZSBEYXRlSW5w dXRUeXBlIG5vZGUuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4K KworICAgICAgICAqIGh0bWwvRGF0ZUlucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE YXRlSW5wdXRUeXBlOjpEYXRlSW5wdXRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVJbnB1 dFR5cGU6OmNyZWF0ZVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAoV2ViQ29yZTo6RGF0ZUlucHV0 VHlwZTo6ZGVzdHJveVNoYWRvd1N1YnRyZWUpOgorICAgICAgICAqIGh0bWwvRGF0ZUlucHV0VHlw ZS5oOgorICAgICAgICAoRGF0ZUlucHV0VHlwZSk6CisKIDIwMTItMDgtMTcgIFlvc2hpZnVtaSBJ bm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbRm9ybXNdIFJlbmFtZSBTcGlu QnV0dG9uRWxlbWVudDo6U3RlcEFjdGlvbkhhbmRsZXIgdG8gU3BpbkJ1dHRvbk93bmVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBlLmNwcAppbmRleCA5NjIwNDZhNDJlMTJiNzQ3OTBiNWY3 N2FjZGU3NDc4ODA4YzZjN2VjLi40Yzk1MjljNTJmNTA3OWRjNWJhZGMxYTg5NjAwMDgzZGQzMWNl NjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUlucHV0VHlwZS5jcHAKQEAgLTUxLDYgKzUxLDkg QEAgc3RhdGljIGNvbnN0IGludCBkYXRlU3RlcFNjYWxlRmFjdG9yID0gODY0MDAwMDA7CiAKIGlu bGluZSBEYXRlSW5wdXRUeXBlOjpEYXRlSW5wdXRUeXBlKEhUTUxJbnB1dEVsZW1lbnQqIGVsZW1l bnQpCiAgICAgOiBCYXNlRGF0ZUFuZFRpbWVJbnB1dFR5cGUoZWxlbWVudCkKKyNpZiBFTkFCTEUo Q0FMRU5EQVJfUElDS0VSKQorICAgICwgbV9waWNrZXJFbGVtZW50KDApCisjZW5kaWYKIHsKIH0K IApAQCAtMTAyLDE0ICsxMDUsMTUgQEAgYm9vbCBEYXRlSW5wdXRUeXBlOjppc0RhdGVGaWVsZCgp IGNvbnN0CiB2b2lkIERhdGVJbnB1dFR5cGU6OmNyZWF0ZVNoYWRvd1N1YnRyZWUoKQogewogICAg IEJhc2VEYXRlQW5kVGltZUlucHV0VHlwZTo6Y3JlYXRlU2hhZG93U3VidHJlZSgpOwotICAgIG1f cGlja2VyRWxlbWVudCA9IENhbGVuZGFyUGlja2VyRWxlbWVudDo6Y3JlYXRlKGVsZW1lbnQoKS0+ ZG9jdW1lbnQoKSk7Ci0gICAgY29udGFpbmVyRWxlbWVudCgpLT5pbnNlcnRCZWZvcmUobV9waWNr ZXJFbGVtZW50LmdldCgpLCBpbm5lckJsb2NrRWxlbWVudCgpLT5uZXh0U2libGluZygpLCBBU1NF UlRfTk9fRVhDRVBUSU9OKTsKKyAgICBSZWZQdHI8Q2FsZW5kYXJQaWNrZXJFbGVtZW50PiBwaWNr ZXJFbGVtZW50ID0gQ2FsZW5kYXJQaWNrZXJFbGVtZW50OjpjcmVhdGUoZWxlbWVudCgpLT5kb2N1 bWVudCgpKTsKKyAgICBtX3BpY2tlckVsZW1lbnQgPSBwaWNrZXJFbGVtZW50LmdldCgpOworICAg IGNvbnRhaW5lckVsZW1lbnQoKS0+aW5zZXJ0QmVmb3JlKG1fcGlja2VyRWxlbWVudCwgaW5uZXJC bG9ja0VsZW1lbnQoKS0+bmV4dFNpYmxpbmcoKSwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiB9CiAK IHZvaWQgRGF0ZUlucHV0VHlwZTo6ZGVzdHJveVNoYWRvd1N1YnRyZWUoKQogewogICAgIFRleHRG aWVsZElucHV0VHlwZTo6ZGVzdHJveVNoYWRvd1N1YnRyZWUoKTsKLSAgICBtX3BpY2tlckVsZW1l bnQuY2xlYXIoKTsKKyAgICBtX3BpY2tlckVsZW1lbnQgPSAwOwogfQogCiBib29sIERhdGVJbnB1 dFR5cGU6Om5lZWRzQ29udGFpbmVyKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvRGF0ZUlucHV0VHlwZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBl LmgKaW5kZXggMmZhZGM0N2I0OGNkMGEzOWUwMGY0M2IzYmYxMWJhMGE5YjIxYzAxZi4uZDQ4MDQ5 ZGFhZjYxNTNlZmRkZjk3NTA1Njc0NWVmYmM2OWM4NDRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9EYXRl SW5wdXRUeXBlLmgKQEAgLTY1LDcgKzY1LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wg bmVlZHNDb250YWluZXIoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxk SGF2ZVNwaW5CdXR0b24oKSBjb25zdCBPVkVSUklERTsKIAotICAgIFJlZlB0cjxDYWxlbmRhclBp Y2tlckVsZW1lbnQ+IG1fcGlja2VyRWxlbWVudDsKKyAgICBDYWxlbmRhclBpY2tlckVsZW1lbnQq IG1fcGlja2VyRWxlbWVudDsKICNlbmRpZgogfTsKIAo=