94297 2012-08-16 22:45:26 -0700 [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows 2012-08-19 19:25:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94195 1 yosin yosin tkent oldest_to_newest 697900 0 yosin 2012-08-16 22:45:26 -0700 There are something wrong in date format detection code: function checkHasShortFormat() { var container = document.createElement("span"); container.innerHTML = "<input type=time id=step60 step=60><input type=time id=step1 step=1>"; document.body.appendChild(container); var hasShortFormat = document.getElementById("step60").offsetWidth != document.getElementById("step1").offsetWidth; container.parentElement.removeChild(container); return hasShortFormat; } 699153 1 159319 yosin 2012-08-19 19:08:48 -0700 Created attachment 159319 Patch 1 699155 2 159319 yosin 2012-08-19 19:09:29 -0700 Comment on attachment 159319 Patch 1 Could you review this patch? Thanks in advance. 699157 3 159319 tkent 2012-08-19 19:11:58 -0700 Comment on attachment 159319 Patch 1 ok 699159 4 159319 yosin 2012-08-19 19:25:15 -0700 Comment on attachment 159319 Patch 1 Clearing flags on attachment: 159319 Committed r125986: <http://trac.webkit.org/changeset/125986> 699160 5 yosin 2012-08-19 19:25:20 -0700 All reviewed patches have been landed. Closing bug. 159319 2012-08-19 19:08:48 -0700 2012-08-19 19:25:15 -0700 Patch 1 bug-94297-20120820110809.patch text/plain 3358 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTg0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWI2YTI4YzQ3ZGJkYjllYWM1YzE3 MTA5YzljYTZkYmVmMDdhMTkwYy4uZjU2MGRjYmJiZDNhYTMwNTI0NGE4NDFlYWZiMTQ3M2MyMWUw OWVkZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTE5ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Rlc3RzXSB0aW1lLW11bHRpcGxlLWZp ZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0bWwgYW5kIHRpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVh cmFuY2UtcHNldWRvLWVsZW1lbnRzLmh0bWwgYXJlIGZhaWxlZCBvbiBDaHJvbWl1bSBXaW5kb3dz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI5Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggdXBkYXRlcyBhIGxvZ2ljIGZvciBkZXRjdGluZyBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1 dCBVSQorICAgICAgICBoYXMgc2Vjb25kIGZpZWxkIG9yIG5vdC4KKworICAgICAgICAqIGZhc3Qv Zm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvcmVzb3VyY2VzL3RpbWUtbXVsdGlwbGUtZmllbGRz LWFwcGVhcmFuY2UuanM6CisgICAgICAgIChjaGVja0hhc1Nob3J0Rm9ybWF0KTogQWRkZWQgIjxi cj4iIGJldHdlZW4gaW5wdXQgZWxlbWVudHMgdG8gYXZvaWQgcm91bmRpbmcgZXJyb3IKKyAgICAg ICAgb24gY2FsY3VsYXRpbmcgcmVuZGVyaW5nIHdpZHRoIG9mIGlucHV0IGVsZW1lbnRzLiBXaGVu IGlucHV0IGVsZW1lbnRzIGFyZSByZW5kZXJlZCBvbgorICAgICAgICBzYW1lIGJhc2VsaW5lLCB3 aWR0aCBvZiBmaXJzdCBvbmUgaXMgMTI2cHggYW5kIHNlY29uZCBpcyAxMjVweC4KKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOiBDaGFuZ2VkIGJ1ZyBpZCBvZiBl bnRyaWVzIENocm9taXVtLU1hYyBzcGVjaWZpYyBidWcgZW50cnksIGJ1ZyA5NDMzOS4KKwogMjAx Mi0wOC0xOSAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENTUCAx LjE6IEFkZCAncGx1Z2luLXR5cGVzJyBhbmQgJ2Zvcm0tYWN0aW9uJyBET00gQVBJLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy9yZXNvdXJj ZXMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS5qcyBiL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvcmVzb3VyY2VzL3RpbWUtbXVsdGlwbGUtZmllbGRz LWFwcGVhcmFuY2UuanMKaW5kZXggOWZmMWI1OTRlYzMyMjcwNzdiZTUwZDAxZmZkNmE2YmI5MGJk MTFlNS4uZWY4ZmFmODQxOTg3ZjRmMWQ5OTcxOGI1ZTg3YTJiMzNhNmRjMjUwOSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy9yZXNvdXJjZXMv dGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3Jlc291cmNlcy90aW1lLW11bHRpcGxlLWZpZWxk cy1hcHBlYXJhbmNlLmpzCkBAIC0xLDcgKzEsNyBAQAogZnVuY3Rpb24gY2hlY2tIYXNTaG9ydEZv cm1hdCgpCiB7CiAgICAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNw YW4iKTsKLSAgICBjb250YWluZXIuaW5uZXJIVE1MID0gIjxpbnB1dCB0eXBlPXRpbWUgaWQ9c3Rl cDYwIHN0ZXA9NjA+PGlucHV0IHR5cGU9dGltZSBpZD1zdGVwMSBzdGVwPTE+IjsKKyAgICBjb250 YWluZXIuaW5uZXJIVE1MID0gIjxpbnB1dCB0eXBlPXRpbWUgaWQ9c3RlcDYwIHN0ZXA9NjA+PGJy PjxpbnB1dCB0eXBlPXRpbWUgaWQ9c3RlcDEgc3RlcD0xPiI7CiAgICAgZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChjb250YWluZXIpOwogICAgIHZhciBoYXNTaG9ydEZvcm1hdCA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJzdGVwNjAiKS5vZmZzZXRXaWR0aCAhPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgic3RlcDEiKS5vZmZzZXRXaWR0aDsKICAgICBjb250YWluZXIucGFyZW50RWxlbWVu dC5yZW1vdmVDaGlsZChjb250YWluZXIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOThhNzk1YTVkZjM4MTgxNTExZDk5YTY0YjJkMGE3 MGMxYjk0ZDM2Zi4uYjExOTMxY2IyYzg3OWM4MzUwZTVjZTgzYWQ4ZmJjNDliNDVmZThiZCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC0x NzYsOCArMTc2LDggQEAgQlVHV0s5NDI4NyBNQUMgV0lOIDogZmFzdC9mb3Jtcy90aW1lLW11bHRp cGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXIKIEJVR1dLOTQyODcgTUFDIFdJ TiA6IGZhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMt YXBwZWFyYW5jZS1zdHlsZS5odG1sID0gTUlTU0lORyBURVhUIElNQUdFIElNQUdFK1RFWFQgUEFT UwogCiAvLyBUZW1wb3JhcnkgZGlzYWJsZWQKLUJVR1dLOTQyOTcgTUFDIFdJTiA6IGZhc3QvZm9y bXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1i YXNpYy5odG1sID0gSU1BR0UgUEFTUwotQlVHV0s5NDI5NyBNQUMgV0lOIDogZmFzdC9mb3Jtcy90 aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLXBzZXVk by1lbGVtZW50cy5odG1sID0gSU1BR0UgUEFTUworQlVHV0s5NDQzOSBNQUMgOiBmYXN0L2Zvcm1z L3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtYmFz aWMuaHRtbCA9IElNQUdFIFBBU1MKK0JVR1dLOTQ0MzkgTUFDIDogZmFzdC9mb3Jtcy90aW1lLW11 bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLXBzZXVkby1lbGVt ZW50cy5odG1sID0gSU1BR0UgUEFTUwogCiAvLyBQcm94aW1pdHkgRXZlbnRzIGlzIG5vdCBzdXBw b3J0ZWQuCiBCVUdXSzkyOTQyIFNLSVAgOiBmYXN0L2RvbS9Qcm94aW1pdHkgPSBQQVNTCg==