94202 2012-08-16 00:54:57 -0700 [GTK] Bad utf8 data is being passed to enchant_dict_check 2012-08-16 10:33:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 696863 0 mario 2012-08-16 00:54:57 -0700 I observed today the following error in the bots, when running certain layout tests like the following one: 23:47:55.622 4977 worker/22 editing/selection/move-by-word-visually-single-space-inline-element.html output stderr lines: 23:47:55.622 4977 enchant_dict_check: assertion `g_utf8_validate(word, len, NULL)' failed 23:47:55.622 4977 enchant_dict_check: assertion `g_utf8_validate(word, len, NULL)' failed 23:47:55.623 4977 enchant_dict_check: assertion `g_utf8_validate(word, len, NULL)' failed 23:47:55.623 4977 enchant_dict_check: assertion `g_utf8_validate(word, len, NULL)' failed [...] << repeats some more times >> So, I briefly investigated the issue and it seems the problem is easily fixable by doing this: --- a/Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp +++ b/Source/WebCore/platform/text/gtk/TextCheckerEnchant.cpp @@ -115,7 +115,7 @@ void TextCheckerEnchant::checkSpellingOfString(const String& string, int& misspe g_utf8_strncpy(word.get(), cstart, wordLength); for (; dictIter != m_enchantDictionaries.end(); ++dictIter) { - if (enchant_dict_check(*dictIter, word.get(), wordLength)) { + if (enchant_dict_check(*dictIter, word.get(), bytes)) { misspellingLocation = start; misspellingLength = wordLength; } else { The explanation is that the 'length' parameter in enchant_dict_check accepts a number of bytes and not the number of utf8 characters, so it will fail in cases like this: word: דעפ => total characters: 3 / total bytes: 6 Thus, of course a call to enchant_dict_check with 3 as length will fail 696869 1 158741 mario 2012-08-16 00:59:10 -0700 Created attachment 158741 Patch proposal Here comes the patch 697248 2 158741 mario 2012-08-16 10:12:48 -0700 Comment on attachment 158741 Patch proposal I am lazy 697261 3 158741 webkit.review.bot 2012-08-16 10:33:46 -0700 Comment on attachment 158741 Patch proposal Clearing flags on attachment: 158741 Committed r125791: <http://trac.webkit.org/changeset/125791> 697262 4 webkit.review.bot 2012-08-16 10:33:49 -0700 All reviewed patches have been landed. Closing bug. 158741 2012-08-16 00:59:10 -0700 2012-08-16 10:33:46 -0700 Patch proposal 0001-2012-08-16-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2482 mario RnJvbSA2MTkxZTk5MzljMzZhODllYzM0Yjk0ZWRjMjBjY2EyYjU2OWU3ZTg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDE2IEF1ZyAyMDEyIDA5OjU3OjIwICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wOC0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEJhZCB1dGY4IGRhdGEgaXMgYmVpbmcgcGFzc2VkIHRvIGVuY2hhbnRf ZGljdF9jaGVjawogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NDIwMgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUGFz cyB0aGUgbnVtYmVyIG9mIGJ5dGVzIGluc3RlYWQgb2YgdGhlIG51bWJlciBvZiBVVEY4IGNoYXJh Y3RlcnMKICAgICAgICB3aGVuIGNhbGxpbmcgZW5jaGFudF9kaWN0X2NoZWNrLgoKICAgICAgICAq IHBsYXRmb3JtL3RleHQvZ3RrL1RleHRDaGVja2VyRW5jaGFudC5jcHA6CiAgICAgICAgKFRleHRD aGVja2VyRW5jaGFudDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKTogVXNlICdieXRlcycgaW5zdGVh ZAogICAgICAgIG9mICd3b3JkTGVuZ3RoJy4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTQgKysrKysrKysrKysrKysKIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDaGVja2VyRW5jaGFudC5jcHAgfCAgMiAr LQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDVlYTEwZGMuLjhmYTJkMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxMi0wOC0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gQmFkIHV0ZjggZGF0YSBpcyBiZWluZyBwYXNzZWQgdG8gZW5jaGFudF9k aWN0X2NoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NDIwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBhc3MgdGhlIG51bWJlciBvZiBieXRlcyBpbnN0ZWFkIG9mIHRoZSBudW1iZXIgb2YgVVRGOCBj aGFyYWN0ZXJzCisgICAgICAgIHdoZW4gY2FsbGluZyBlbmNoYW50X2RpY3RfY2hlY2suCisKKyAg ICAgICAgKiBwbGF0Zm9ybS90ZXh0L2d0ay9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwOgorICAgICAg ICAoVGV4dENoZWNrZXJFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOiBVc2UgJ2J5dGVz JyBpbnN0ZWFkCisgICAgICAgIG9mICd3b3JkTGVuZ3RoJy4KKwogMjAxMi0wOC0xMyAgTWFyaW8g U2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gSW1w bGVtZW50YXRpb24gb2YgYXRrX2VkaXRhYmxlX3RleHRfaW5zZXJ0X3RleHQgaWdub3JlcyAnbGVu Z3RoJyBwYXJhbWV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv Z3RrL1RleHRDaGVja2VyRW5jaGFudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L2d0ay9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCmluZGV4IGFkNjY4YWIuLmYzZjYwZTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZ3RrL1RleHRDaGVja2VyRW5jaGFu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9ndGsvVGV4dENoZWNrZXJF bmNoYW50LmNwcApAQCAtMTE1LDcgKzExNSw3IEBAIHZvaWQgVGV4dENoZWNrZXJFbmNoYW50Ojpj aGVja1NwZWxsaW5nT2ZTdHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcsIGludCYgbWlzc3BlCiAg ICAgICAgICAgICBnX3V0Zjhfc3RybmNweSh3b3JkLmdldCgpLCBjc3RhcnQsIHdvcmRMZW5ndGgp OwogCiAgICAgICAgICAgICBmb3IgKDsgZGljdEl0ZXIgIT0gbV9lbmNoYW50RGljdGlvbmFyaWVz LmVuZCgpOyArK2RpY3RJdGVyKSB7Ci0gICAgICAgICAgICAgICAgaWYgKGVuY2hhbnRfZGljdF9j aGVjaygqZGljdEl0ZXIsIHdvcmQuZ2V0KCksIHdvcmRMZW5ndGgpKSB7CisgICAgICAgICAgICAg ICAgaWYgKGVuY2hhbnRfZGljdF9jaGVjaygqZGljdEl0ZXIsIHdvcmQuZ2V0KCksIGJ5dGVzKSkg ewogICAgICAgICAgICAgICAgICAgICBtaXNzcGVsbGluZ0xvY2F0aW9uID0gc3RhcnQ7CiAgICAg ICAgICAgICAgICAgICAgIG1pc3NwZWxsaW5nTGVuZ3RoID0gd29yZExlbmd0aDsKICAgICAgICAg ICAgICAgICB9IGVsc2UgewotLSAKMS43LjExLjIKCg==