94195 2012-08-16 00:31:01 -0700 [Forms] Enable multiple fields time input UI for Chromium except Android 2012-08-17 02:49:44 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 94196 94297 88970 1 yosin yosin peter tkent oldest_to_newest 696833 0 yosin 2012-08-16 00:31:01 -0700 This is the final step of launching multiple fields time input UI. 696864 1 158738 yosin 2012-08-16 00:55:08 -0700 Created attachment 158738 Patch 1 698022 2 158738 yosin 2012-08-17 01:14:21 -0700 Comment on attachment 158738 Patch 1 Could you review this patch? Thanks in advance. 698029 3 tkent 2012-08-17 01:19:47 -0700 Please fix Bug 94297 before enabling it. 698039 4 tkent 2012-08-17 01:33:45 -0700 (In reply to comment #3) > Please fix Bug 94297 before enabling it. We discussed offline. Bug 94297 is a test code issue, not a production code issue. So we may go ahead with this bug. 698040 5 158738 tkent 2012-08-17 01:34:05 -0700 Comment on attachment 158738 Patch 1 ok 698042 6 158738 yosin 2012-08-17 01:35:27 -0700 Comment on attachment 158738 Patch 1 Clearing flags on attachment: 158738 Committed r125868: <http://trac.webkit.org/changeset/125868> 698043 7 yosin 2012-08-17 01:35:31 -0700 All reviewed patches have been landed. Closing bug. 698078 8 peter 2012-08-17 02:28:14 -0700 What are the plans for enabling this on Android? 698083 9 tkent 2012-08-17 02:30:01 -0700 (In reply to comment #8) > What are the plans for enabling this on Android? Android already has input[type=time] with a different UI. 698105 10 peter 2012-08-17 02:49:44 -0700 (In reply to comment #9) > (In reply to comment #8) > > What are the plans for enabling this on Android? > > Android already has input[type=time] with a different UI. Right, sorry, I misunderstood the title. It seems desirable to me to have the display in the <input> box match between platforms, while, for more convenient editing, Android should continue to use a pop-up for getting actual user input. I'm a bit concerned about Android's date input types becoming very different in terms of feature support, i.e. the step attribute, display in the input box itself (should we display seconds or not), in the future maybe <input type=time multiple />, etcetera. I'll ask around internally here. 158738 2012-08-16 00:55:08 -0700 2012-08-17 01:35:27 -0700 Patch 1 bug-94195-20120816165433.patch text/plain 1955 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI4NmFhNTIxN2E4MTBk Mzg1Mzc5YjQ4YmE5M2RjOGQyMmIwMTlmOC4uNTg5OTFhYmNkZDk0ZjgwZTc4OWE5ZTRkZTUzNzZi YTE2NzYyMDYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA4LTE2ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW0Zvcm1zXSBFbmFi bGUgbXVsdGlwbGUgZmllbGRzIHRpbWUgaW5wdXQgVUkgZm9yIENocm9taXVtIGV4Y2VwdCBBbmRy b2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE5 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggZW5hYmxlcyBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSSBmb3IgQ2hyb21pdW0g ZXhjZXB0CisgICAgICAgIGZvciBBbmRyb2lkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhp c3RpbmcgdGVzdHMgaW4gZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy8KKyAgICAgICAg Y292ZXJzIGFwcGVhcmFuY2UgYW5kIGZ1bmN0aW9uYWxpdHkgb2YgbXVsdGlwbGUgZmllbGRzIHRp bWUgVUkuCisKKyAgICAgICAgQSBtYW51YWwgY2hlY2tpbmcgZm9yIGJyb3dzZXIgZGlzcGxheXMg bXVsdGlwbGUgZmllbGRzIHRpbWUgaW5wdXQgVUkKKyAgICAgICAgaXMgbmVlZGVkLgorCisgICAg ICAgICogYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmUpOiBDaGFuZ2VkIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzSW5wdXRUeXBl VGltZUVuYWJsZWQgdG8gdHJ1ZQorICAgICAgICBpZiBFTkFCTEVfSU5QVVRfVFlQRV9USU1FIGlz IGVuYWJsZWQuCisKKzIwMTItMDgtMTYgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVt Lm9yZz4KKwogICAgICAgICBbRm9ybXNdIFdoZWVsIGV2ZW50IHN1cHBvcnQgaW4gbXVsdGlwbGUg ZmllbGRzIHRpbWUgaW5wdXQgVUkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0MTY2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCmluZGV4IDU5ZWMwNjI4ZDM5 N2MyNTg5N2M5ZGI4NGYyMjE1NTg0N2FjOGI0MmYuLmRhNzg0OWRkYWJkYWJiMGIzY2M2MzZiMWVm NjliM2ZiYTc1Y2VmZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVy aWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcApAQCAtMjI1LDEyICsyMjUsOCBA QCBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzSW5wdXRUeXBlTW9udGhFbmFibGVkID0g dHJ1ZTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKElOUFVUX1RZUEVfVElNRSkKLSNpZiBQTEFURk9S TShDSFJPTUlVTSkgJiYgIU9TKEFORFJPSUQpCi1ib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6 OmlzSW5wdXRUeXBlVGltZUVuYWJsZWQgPSBmYWxzZTsKLSNlbHNlCiBib29sIFJ1bnRpbWVFbmFi bGVkRmVhdHVyZXM6OmlzSW5wdXRUeXBlVGltZUVuYWJsZWQgPSB0cnVlOwogI2VuZGlmCi0jZW5k aWYKIAogI2lmIEVOQUJMRShJTlBVVF9UWVBFX1dFRUspCiAjaWYgUExBVEZPUk0oQ0hST01JVU0p ICYmICFPUyhBTkRST0lEKQo=