94192 2012-08-16 00:02:25 -0700 REGRESSION(r119705): Causing crash on ClusterFuzz due to incorrect layout ordering change (Requested by inferno-sec on #webkit). 2012-08-16 09:38:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 94206 66120 1 webkit.review.bot webkit.review.bot inferno rniwa shinyak oldest_to_newest 696800 0 webkit.review.bot 2012-08-16 00:02:25 -0700 http://trac.webkit.org/changeset/119705 broke the build: Causing crash on ClusterFuzz due to incorrect layout ordering change (Requested by inferno-sec on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 696802 1 158725 webkit.review.bot 2012-08-16 00:03:04 -0700 Created attachment 158725 ROLLOUT of r119705 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 696806 2 158725 inferno 2012-08-16 00:06:24 -0700 Comment on attachment 158725 ROLLOUT of r119705 Clearing flags on attachment: 158725 Committed r125751: <http://trac.webkit.org/changeset/125751> 696807 3 inferno 2012-08-16 00:06:27 -0700 All reviewed patches have been landed. Closing bug. 696903 4 rniwa 2012-08-16 01:39:18 -0700 What!? I don't think rolling out this patch is a good idea. And who did make this decision and why was this not reviewed? 696907 5 webkit.review.bot 2012-08-16 01:45:38 -0700 Re-opened since this is blocked by 94206 696910 6 rniwa 2012-08-16 01:48:46 -0700 Please don't roll out a 2-month old commit like this without consulting the author & the reviewer. 697215 7 ap 2012-08-16 09:36:54 -0700 We still need to fix the crash seen by ClusterFuzz though. Is there another bug tracking that now? 697216 8 inferno 2012-08-16 09:38:22 -0700 (In reply to comment #7) > We still need to fix the crash seen by ClusterFuzz though. Is there another bug tracking that now? cced you on https://bugs.webkit.org/show_bug.cgi?id=91325. 158725 2012-08-16 00:03:04 -0700 2012-08-16 00:06:24 -0700 ROLLOUT of r119705 bug-94192-20120816070842.patch text/plain 4145 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFkNzc1ZjBhZjU1MzFh YjdiY2E4YjQ0OGVlMjhkMDhmYWIzYmI1NS4uYjgzNzE5MmMyYzZmYmUxNDE5ZmY3NDY5MDg0Yjky ODdjOWQzODg1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTE2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE5NzA1LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTk3MDUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk0MTkyCisKKyAgICAgICAgQ2F1c2luZyBjcmFzaCBvbiBDbHVzdGVyRnV6eiBk dWUgdG8gaW5jb3JyZWN0IGxheW91dCBvcmRlcmluZworICAgICAgICBjaGFuZ2UgKFJlcXVlc3Rl ZCBieSBpbmZlcm5vLXNlYyBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGRvbS9DaGFyYWN0ZXJE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNoYXJhY3RlckRhdGE6OnNldERhdGFBbmRVcGRh dGUpOgorICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6dXBkYXRlUG9zaXRpb25BZnRlckFkb3B0aW5nVGV4dFJlcGxhY2VtZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjp0ZXh0V2lsbEJlUmVwbGFjZWQpOgorICAgICAg ICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaDoKKyAgICAgICAgKEZyYW1lU2VsZWN0aW9uKToK KwogMjAxMi0wOC0xNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW0Nocm9taXVtXSBSZWZhY3RvcmluZzogSW50cm9kdWNlIGEgbmV3IGZ1bmN0aW9uIGZvciBz b21lIHBhcnQgb2YgUG9wdXBDb250YWluZXI6OmxheW91dEFuZENhbGN1bGF0ZVdpZGdldFJlY3Qo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuY3BwCmluZGV4IDkxZjVhYzcwZjhjNjkxYjhm M2VmYjc2MzkxYzY0MmI0MGJlMDZkMGQuLmEwOTQxNWVjOTBjYTJmODM5Mzk3YTViOGE0MWJlMWFj ODBiZGYzMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJEYXRhLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2hhcmFjdGVyRGF0YS5jcHAKQEAgLTE4MywxNCAr MTgzLDExIEBAIHZvaWQgQ2hhcmFjdGVyRGF0YTo6c2V0Tm9kZVZhbHVlKGNvbnN0IFN0cmluZyYg bm9kZVZhbHVlLCBFeGNlcHRpb25Db2RlJiBlYykKIAogdm9pZCBDaGFyYWN0ZXJEYXRhOjpzZXRE YXRhQW5kVXBkYXRlKGNvbnN0IFN0cmluZyYgbmV3RGF0YSwgdW5zaWduZWQgb2Zmc2V0T2ZSZXBs YWNlZERhdGEsIHVuc2lnbmVkIG9sZExlbmd0aCwgdW5zaWduZWQgbmV3TGVuZ3RoKQogeworICAg IGlmIChkb2N1bWVudCgpLT5mcmFtZSgpKQorICAgICAgICBkb2N1bWVudCgpLT5mcmFtZSgpLT5z ZWxlY3Rpb24oKS0+dGV4dFdpbGxCZVJlcGxhY2VkKHRoaXMsIG9mZnNldE9mUmVwbGFjZWREYXRh LCBvbGRMZW5ndGgsIG5ld0xlbmd0aCk7CiAgICAgU3RyaW5nIG9sZERhdGEgPSBtX2RhdGE7CiAg ICAgbV9kYXRhID0gbmV3RGF0YTsKLQogICAgIHVwZGF0ZVJlbmRlcmVyKG9mZnNldE9mUmVwbGFj ZWREYXRhLCBvbGRMZW5ndGgpOwotCi0gICAgaWYgKGRvY3VtZW50KCktPmZyYW1lKCkpCi0gICAg ICAgIGRvY3VtZW50KCktPmZyYW1lKCktPnNlbGVjdGlvbigpLT50ZXh0V2FzUmVwbGFjZWQodGhp cywgb2Zmc2V0T2ZSZXBsYWNlZERhdGEsIG9sZExlbmd0aCwgbmV3TGVuZ3RoKTsKLQogICAgIGRv Y3VtZW50KCktPmluY0RPTVRyZWVWZXJzaW9uKCk7CiAgICAgZGlzcGF0Y2hNb2RpZmllZEV2ZW50 KG9sZERhdGEpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNl bGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcApp bmRleCA5Y2NhYTk2MmZiMmYxMWVjZDNjYTQ4MjFmYTQxMWNjZjdhYzU1ZjM2Li5jYzc5YTI4OWM0 OTRmOGZiZWQzZjg0ZjBjMDIxZjM2NDYxYjU3ZmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5n L0ZyYW1lU2VsZWN0aW9uLmNwcApAQCAtNDIyLDggKzQyMiw2IEBAIHN0YXRpYyB2b2lkIHVwZGF0 ZVBvc2l0aW9uQWZ0ZXJBZG9wdGluZ1RleHRSZXBsYWNlbWVudChQb3NpdGlvbiYgcG9zaXRpb24s IENoYXJhCiAgICAgLy8gKHBvc2l0aW9uT2Zmc2V0ID4gb2Zmc2V0ICsgb2xkTGVuZ3RoKSB0byBh dm9pZCBoYXZpbmcgYSBzdGFsZSBvZmZzZXQuCiAgICAgaWYgKHBvc2l0aW9uT2Zmc2V0ID4gb2Zm c2V0ICsgb2xkTGVuZ3RoKQogICAgICAgICBwb3NpdGlvbi5tb3ZlVG9PZmZzZXQocG9zaXRpb25P ZmZzZXQgLSBvbGRMZW5ndGggKyBuZXdMZW5ndGgpOwotCi0gICAgQVNTRVJUKHN0YXRpY19jYXN0 PHVuc2lnbmVkPihwb3NpdGlvbi5vZmZzZXRJbkNvbnRhaW5lck5vZGUoKSkgPD0gbm9kZS0+bGVu Z3RoKCkpOwogfQogCiBzdGF0aWMgaW5saW5lIGJvb2wgbm9kZUlzRGV0YWNoZWRGcm9tRG9jdW1l bnQoTm9kZSogbm9kZSkKQEAgLTQzMyw3ICs0MzEsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgbm9k ZUlzRGV0YWNoZWRGcm9tRG9jdW1lbnQoTm9kZSogbm9kZSkKICAgICByZXR1cm4gaGlnaGVzdC0+ bm9kZVR5cGUoKSA9PSBOb2RlOjpET0NVTUVOVF9GUkFHTUVOVF9OT0RFICYmICFoaWdoZXN0LT5p c1NoYWRvd1Jvb3QoKTsKIH0KIAotdm9pZCBGcmFtZVNlbGVjdGlvbjo6dGV4dFdhc1JlcGxhY2Vk KENoYXJhY3RlckRhdGEqIG5vZGUsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgb2xkTGVuZ3Ro LCB1bnNpZ25lZCBuZXdMZW5ndGgpCit2b2lkIEZyYW1lU2VsZWN0aW9uOjp0ZXh0V2lsbEJlUmVw bGFjZWQoQ2hhcmFjdGVyRGF0YSogbm9kZSwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBvbGRM ZW5ndGgsIHVuc2lnbmVkIG5ld0xlbmd0aCkKIHsKICAgICAvLyBUaGUgZnJhZ21lbnQgY2hlY2sg aXMgYSBwZXJmb3JtYW5jZSBvcHRpbWl6YXRpb24uIFNlZSBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8zMDA2Mi4KICAgICBpZiAoaXNOb25lKCkgfHwgIW5vZGUgfHwgbm9kZUlzRGV0 YWNoZWRGcm9tRG9jdW1lbnQobm9kZSkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL0ZyYW1lU2VsZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmgKaW5kZXggNGE1ODE5NDQ4NDhkMTM4Yjg1YzlhMTFlNWNjMDQ1NGM3ZjhmNzY5Yy4uZmY3 OWE5OGI5MGU5YmE2ODYyN2EwYzI3MzdkMzgxYTJjMTAxMzJlMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRnJhbWVTZWxlY3Rpb24uaApAQCAtMjA0LDcgKzIwNCw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIGRlYnVnUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiwgYm9vbCBzZWxlY3RlZCkgY29uc3Q7CiAK ICAgICB2b2lkIG5vZGVXaWxsQmVSZW1vdmVkKE5vZGUqKTsKLSAgICB2b2lkIHRleHRXYXNSZXBs YWNlZChDaGFyYWN0ZXJEYXRhKiwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBvbGRMZW5ndGgs IHVuc2lnbmVkIG5ld0xlbmd0aCk7CisgICAgdm9pZCB0ZXh0V2lsbEJlUmVwbGFjZWQoQ2hhcmFj dGVyRGF0YSosIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgb2xkTGVuZ3RoLCB1bnNpZ25lZCBu ZXdMZW5ndGgpOwogCiAgICAgdm9pZCBzZXRDYXJldFZpc2libGUoYm9vbCBjYXJldElzVmlzaWJs ZSkgeyBzZXRDYXJldFZpc2liaWxpdHkoY2FyZXRJc1Zpc2libGUgPyBWaXNpYmxlIDogSGlkZGVu KTsgfQogICAgIHZvaWQgY2xlYXJDYXJldFJlY3RJZk5lZWRlZCgpOwo=