94172 2012-08-15 19:26:01 -0700 [Forms] Re-factor fast/forms/number/number-wheel-event.html 2012-08-15 22:37:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94173 94184 94166 1 yosin yosin tkent oldest_to_newest 696645 0 yosin 2012-08-15 19:26:01 -0700 To share code with number input type and multiple fields time input UI. 696720 1 158706 yosin 2012-08-15 21:40:09 -0700 Created attachment 158706 Patch 1 696721 2 158706 yosin 2012-08-15 21:41:12 -0700 Comment on attachment 158706 Patch 1 Could you review this patch? Thanks in advance. 696751 3 158706 tkent 2012-08-15 22:35:34 -0700 Comment on attachment 158706 Patch 1 ok 696752 4 158706 yosin 2012-08-15 22:37:15 -0700 Comment on attachment 158706 Patch 1 Clearing flags on attachment: 158706 Committed r125747: <http://trac.webkit.org/changeset/125747> 696753 5 yosin 2012-08-15 22:37:20 -0700 All reviewed patches have been landed. Closing bug. 158706 2012-08-15 21:40:09 -0700 2012-08-15 22:37:15 -0700 Patch 1 bug-94172-20120816133934.patch text/plain 7023 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjYwZjE5ODNiMGI3YTQyZTNlYzg3 MThiOTY3ZmM4MjAyZTE1M2MyNS4uYmViOTEwNGQ3MGJlNWQxMTNlMTBkM2RjYzJlYjgwYzUwYjI3 ODVmOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE2ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBSZS1mYWN0b3IgZmFzdC9m b3Jtcy9udW1iZXIvbnVtYmVyLXdoZWVsLWV2ZW50Lmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBtb3ZlcyB0ZXN0IGNvZGUgZnJv bSBudW1iZXItd2hlZWwtZXZlbnQuaHRtbCB0byBjb21tb24td2hlZWwtZXZlbnQuanMKKyAgICAg ICAgZm9yIHNoYXJpbmcgdGVzdCBjb2RlIGFtb25nIGlucHV0IHR5cGVzLgorCisgICAgICAgICog ZmFzdC9mb3Jtcy9udW1iZXIvbnVtYmVyLXdoZWVsLWV2ZW50Lmh0bWw6CisgICAgICAgICogZmFz dC9mb3Jtcy9yZXNvdXJjZXMvY29tbW9uLXdoZWVsLWV2ZW50LmpzOgorICAgICAgICAodGVzdFdo ZWVsRXZlbnQpOgorCiAyMDEyLTA4LTE1ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW1Rlc3RzXSBDb3B5IHRvIGZhc3QvZm9ybXMvcmVzb3VyY2VzL2Nv bW1vbi13aGVlbC1ldmVudC5qcyBmcm9tIGZhc3QvZm9ybXMvbnVtYmVyL251bWJlci13aGVlbC1l dmVudC5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL251bWJlci9udW1i ZXItd2hlZWwtZXZlbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL251bWJl ci13aGVlbC1ldmVudC5odG1sCmluZGV4IGE0N2Q2NGU2YTBjYzYzOWY2ZGIzYjFhZDI0ZTdiZDkx ZTFjNDY5ZTQuLjczYTg0MjUxMWIwODk4NjdkM2JiNjJhOWYxOTM5NzVjNWRjNTU0NWYgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL251bWJlci13aGVlbC1ldmVudC5o dG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbnVtYmVyL251bWJlci13aGVlbC1ldmVu dC5odG1sCkBAIC0yLDU4ICsyLDE1IEBACiA8aHRtbD4KIDxoZWFkPgogPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi9yZXNvdXJjZXMvY29tbW9uLXdoZWVsLWV2ZW50LmpzIj48L3NjcmlwdD4KIDwv aGVhZD4KIDxib2R5PgogPHNjcmlwdD4KLWRlc2NyaXB0aW9uKCdUZXN0IGZvciB3aGVlbCBvcGVy YXRpb25zIGZvciAmbHQ7aW5wdXQgdHlwZT1udW1iZXI+Jyk7Ci12YXIgcGFyZW50ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Ci1kb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVu dCk7Ci1wYXJlbnQuaW5uZXJIVE1MID0gJzxpbnB1dCB0eXBlPW51bWJlciBpZD1udW1iZXIgdmFs dWU9MD4gPGlucHV0IGlkPWFub3RoZXI+JzsKLXZhciBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdudW1iZXInKTsKLWlucHV0LmZvY3VzKCk7Ci0KLWZ1bmN0aW9uIGRpc3BhdGNoV2hl ZWxFdmVudChlbGVtZW50LCBkZWx0YVgsIGRlbHRhWSkKLXsKLSAgICB2YXIgZXZlbnQgPSBkb2N1 bWVudC5jcmVhdGVFdmVudCgnV2hlZWxFdmVudCcpOwotICAgIHZhciBkb250Q2FyZSA9IDA7Ci0g ICAgZXZlbnQuaW5pdFdlYktpdFdoZWVsRXZlbnQoZGVsdGFYLCBkZWx0YVksIGRvY3VtZW50LmRl ZmF1bHRWaWV3LCBkb250Q2FyZSwgZG9udENhcmUsIGRvbnRDYXJlLCBkb250Q2FyZSwgZmFsc2Us IGZhbHNlLCBmYWxzZSwgZmFsc2UpOwotICAgIGVsZW1lbnQuZGlzcGF0Y2hFdmVudChldmVudCk7 Ci19Ci0KLWRlYnVnKCdJbml0aWFsIHZhbHVlIGlzIDAuIFdlXCdsbCB3aGVlbCB1cCBieSAxOicp OwotZGlzcGF0Y2hXaGVlbEV2ZW50KGlucHV0LCAwLCAxKTsKLXNob3VsZEJlKCdpbnB1dC52YWx1 ZScsICciMSInKTsKLQotZGVidWcoJ1doZWVsIHVwIGJ5IDEwMDonKTsKLWRpc3BhdGNoV2hlZWxF dmVudChpbnB1dCwgMCwgMTAwKTsKLXNob3VsZEJlKCdpbnB1dC52YWx1ZScsICciMiInKTsKLQot ZGVidWcoJ1doZWVsIGRvd24gYnkgMTonKTsKLWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwg LTEpOwotc2hvdWxkQmUoJ2lucHV0LnZhbHVlJywgJyIxIicpOwotCi1kZWJ1ZygnV2hlZWwgZG93 biBieSAyNTY6Jyk7Ci1kaXNwYXRjaFdoZWVsRXZlbnQoaW5wdXQsIDAsIC0yNTYpOwotc2hvdWxk QmUoJ2lucHV0LnZhbHVlJywgJyIwIicpOwotCi1kZWJ1ZygnRGlzYWJsZWQgaW5wdXQgZWxlbWVu dDonKTsKLWlucHV0LmRpc2FibGVkID0gdHJ1ZTsKLWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwg MCwgMSk7Ci1zaG91bGRCZSgnaW5wdXQudmFsdWUnLCAnIjAiJyk7Ci1pbnB1dC5yZW1vdmVBdHRy aWJ1dGUoJ2Rpc2FibGVkJyk7Ci0KLWRlYnVnKCdSZWFkLW9ubHkgaW5wdXQgZWxlbWVudDonKTsK LWlucHV0LnJlYWRPbmx5ID0gdHJ1ZTsKLWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgMSk7 Ci1zaG91bGRCZSgnaW5wdXQudmFsdWUnLCAnIjAiJyk7Ci1pbnB1dC5yZWFkT25seSA9IGZhbHNl OwotCi1kZWJ1ZygnTm8gZm9jdXM6Jyk7Ci1kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYW5vdGhl cicpLmZvY3VzKCk7Ci1kaXNwYXRjaFdoZWVsRXZlbnQoaW5wdXQsIDAsIDEpOwotc2hvdWxkQmUo J2lucHV0LnZhbHVlJywgJyIwIicpOwotCi1wYXJlbnQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChw YXJlbnQpOwordGVzdFdoZWVsRXZlbnQoeworICAgICdpbnB1dFR5cGUnIDogJ251bWJlcicsCisg ICAgJ2luaXRpYWxWYWx1ZScgOiAnMCcsCisgICAgJ3N0ZXBVcFZhbHVlMScgOiAnMScsCisgICAg J3N0ZXBVcFZhbHVlMicgOiAnMicgfSk7CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi8u Li9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgogPC9ib2R5Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZXNvdXJjZXMvY29tbW9uLXdoZWVs LWV2ZW50LmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yZXNvdXJjZXMvY29tbW9uLXdoZWVs LWV2ZW50LmpzCmluZGV4IGE0N2Q2NGU2YTBjYzYzOWY2ZGIzYjFhZDI0ZTdiZDkxZTFjNDY5ZTQu LjIyNGU2YTllNGRiYjIyNWExMWZiOTMxNzAzN2IyYjUzNDM1YzY5NWQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvcmVzb3VyY2VzL2NvbW1vbi13aGVlbC1ldmVudC5qcworKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Jlc291cmNlcy9jb21tb24td2hlZWwtZXZlbnQuanMK QEAgLTEsMTcgKzEsMyBAQAotPCFET0NUWVBFIGh0bWw+Ci08aHRtbD4KLTxoZWFkPgotPHNjcmlw dCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Njcmlw dD4KLTwvaGVhZD4KLTxib2R5PgotPHNjcmlwdD4KLWRlc2NyaXB0aW9uKCdUZXN0IGZvciB3aGVl bCBvcGVyYXRpb25zIGZvciAmbHQ7aW5wdXQgdHlwZT1udW1iZXI+Jyk7Ci12YXIgcGFyZW50ID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7Ci1kb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHBhcmVudCk7Ci1wYXJlbnQuaW5uZXJIVE1MID0gJzxpbnB1dCB0eXBlPW51bWJlciBpZD1udW1i ZXIgdmFsdWU9MD4gPGlucHV0IGlkPWFub3RoZXI+JzsKLXZhciBpbnB1dCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdudW1iZXInKTsKLWlucHV0LmZvY3VzKCk7Ci0KIGZ1bmN0aW9uIGRpc3Bh dGNoV2hlZWxFdmVudChlbGVtZW50LCBkZWx0YVgsIGRlbHRhWSkKIHsKICAgICB2YXIgZXZlbnQg PSBkb2N1bWVudC5jcmVhdGVFdmVudCgnV2hlZWxFdmVudCcpOwpAQCAtMjAsNDEgKzYsNTMgQEAg ZnVuY3Rpb24gZGlzcGF0Y2hXaGVlbEV2ZW50KGVsZW1lbnQsIGRlbHRhWCwgZGVsdGFZKQogICAg IGVsZW1lbnQuZGlzcGF0Y2hFdmVudChldmVudCk7CiB9CiAKLWRlYnVnKCdJbml0aWFsIHZhbHVl IGlzIDAuIFdlXCdsbCB3aGVlbCB1cCBieSAxOicpOwotZGlzcGF0Y2hXaGVlbEV2ZW50KGlucHV0 LCAwLCAxKTsKLXNob3VsZEJlKCdpbnB1dC52YWx1ZScsICciMSInKTsKLQotZGVidWcoJ1doZWVs IHVwIGJ5IDEwMDonKTsKLWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgMTAwKTsKLXNob3Vs ZEJlKCdpbnB1dC52YWx1ZScsICciMiInKTsKLQotZGVidWcoJ1doZWVsIGRvd24gYnkgMTonKTsK LWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgLTEpOwotc2hvdWxkQmUoJ2lucHV0LnZhbHVl JywgJyIxIicpOwotCi1kZWJ1ZygnV2hlZWwgZG93biBieSAyNTY6Jyk7Ci1kaXNwYXRjaFdoZWVs RXZlbnQoaW5wdXQsIDAsIC0yNTYpOwotc2hvdWxkQmUoJ2lucHV0LnZhbHVlJywgJyIwIicpOwot Ci1kZWJ1ZygnRGlzYWJsZWQgaW5wdXQgZWxlbWVudDonKTsKLWlucHV0LmRpc2FibGVkID0gdHJ1 ZTsKLWRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgMSk7Ci1zaG91bGRCZSgnaW5wdXQudmFs dWUnLCAnIjAiJyk7Ci1pbnB1dC5yZW1vdmVBdHRyaWJ1dGUoJ2Rpc2FibGVkJyk7Ci0KLWRlYnVn KCdSZWFkLW9ubHkgaW5wdXQgZWxlbWVudDonKTsKLWlucHV0LnJlYWRPbmx5ID0gdHJ1ZTsKLWRp c3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgMSk7Ci1zaG91bGRCZSgnaW5wdXQudmFsdWUnLCAn IjAiJyk7Ci1pbnB1dC5yZWFkT25seSA9IGZhbHNlOwotCi1kZWJ1ZygnTm8gZm9jdXM6Jyk7Ci1k b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYW5vdGhlcicpLmZvY3VzKCk7Ci1kaXNwYXRjaFdoZWVs RXZlbnQoaW5wdXQsIDAsIDEpOwotc2hvdWxkQmUoJ2lucHV0LnZhbHVlJywgJyIwIicpOwotCi1w YXJlbnQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChwYXJlbnQpOwotPC9zY3JpcHQ+Ci08c2NyaXB0 IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KLTwvYm9keT4KLTwvaHRtbD4KK3ZhciBpbnB1dDsKK2Z1bmN0aW9uIHRlc3RXaGVlbEV2ZW50 KHBhcmFtZXRlcnMpCit7CisgICAgdmFyIGlucHV0VHlwZSA9IHBhcmFtZXRlcnNbJ2lucHV0VHlw ZSddOworICAgIHZhciBpbml0aWFsVmFsdWUgPSBwYXJhbWV0ZXJzWydpbml0aWFsVmFsdWUnXTsK KyAgICB2YXIgc3RlcFVwVmFsdWUxID0gcGFyYW1ldGVyc1snc3RlcFVwVmFsdWUxJ107CisgICAg dmFyIHN0ZXBVcFZhbHVlMiA9IHBhcmFtZXRlcnNbJ3N0ZXBVcFZhbHVlMiddOworICAgIGRlc2Ny aXB0aW9uKCdUZXN0IGZvciB3aGVlbCBvcGVyYXRpb25zIGZvciAmbHQ7aW5wdXQgdHlwZT0nICsg aW5wdXRUeXBlICsgJz4nKTsKKyAgICB2YXIgcGFyZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnZGl2Jyk7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChwYXJlbnQpOworICAgIHBh cmVudC5pbm5lckhUTUwgPSAnPGlucHV0IHR5cGU9JyArIGlucHV0VHlwZSArICcgaWQ9dGVzdCB2 YWx1ZT0iJyArIGluaXRpYWxWYWx1ZSArICciPiA8aW5wdXQgaWQ9YW5vdGhlcj4nOworICAgIGlu cHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKTsKKyAgICBpbnB1dC5mb2N1cygp OworCisgICAgZGVidWcoJ0luaXRpYWwgdmFsdWUgaXMgJyArIGluaXRpYWxWYWx1ZSArICcuIFdl XCdsbCB3aGVlbCB1cCBieSAnICsgc3RlcFVwVmFsdWUxICsgJzonKTsKKyAgICBkaXNwYXRjaFdo ZWVsRXZlbnQoaW5wdXQsIDAsIDEpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnaW5wdXQu dmFsdWUnLCBzdGVwVXBWYWx1ZTEpOworCisgICAgZGVidWcoJ1doZWVsIHVwIGJ5IDEwMDonKTsK KyAgICBkaXNwYXRjaFdoZWVsRXZlbnQoaW5wdXQsIDAsIDEwMCk7CisgICAgc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCdpbnB1dC52YWx1ZScsIHN0ZXBVcFZhbHVlMik7CisKKyAgICBkZWJ1ZygnV2hl ZWwgZG93biBieSAxOicpOworICAgIGRpc3BhdGNoV2hlZWxFdmVudChpbnB1dCwgMCwgLTEpOwor ICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnaW5wdXQudmFsdWUnLCBzdGVwVXBWYWx1ZTEpOwor CisgICAgZGVidWcoJ1doZWVsIGRvd24gYnkgMjU2OicpOworICAgIGRpc3BhdGNoV2hlZWxFdmVu dChpbnB1dCwgMCwgLTI1Nik7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdpbnB1dC52YWx1 ZScsIGluaXRpYWxWYWx1ZSk7CisKKyAgICBkZWJ1ZygnRGlzYWJsZWQgaW5wdXQgZWxlbWVudDon KTsKKyAgICBpbnB1dC5kaXNhYmxlZCA9IHRydWU7CisgICAgZGlzcGF0Y2hXaGVlbEV2ZW50KGlu cHV0LCAwLCAxKTsKKyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZhbHVlJywgaW5p dGlhbFZhbHVlKTsKKyAgICBpbnB1dC5yZW1vdmVBdHRyaWJ1dGUoJ2Rpc2FibGVkJyk7CisKKwor ICAgIGRlYnVnKCdSZWFkLW9ubHkgaW5wdXQgZWxlbWVudDonKTsKKyAgICBpbnB1dC5yZWFkT25s eSA9IHRydWU7CisgICAgZGlzcGF0Y2hXaGVlbEV2ZW50KGlucHV0LCAwLCAxKTsKKyAgICBzaG91 bGRCZUVxdWFsVG9TdHJpbmcoJ2lucHV0LnZhbHVlJywgaW5pdGlhbFZhbHVlKTsKKyAgICBpbnB1 dC5yZWFkT25seSA9IGZhbHNlOworCisgICAgZGVidWcoJ05vIGZvY3VzOicpOworICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdhbm90aGVyJykuZm9jdXMoKTsKKyAgICBkaXNwYXRjaFdoZWVs RXZlbnQoaW5wdXQsIDAsIDEpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnaW5wdXQudmFs dWUnLCBpbml0aWFsVmFsdWUpOworCisgICAgcGFyZW50LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQo cGFyZW50KTsKK30K