93880 2012-08-13 12:18:11 -0700 [Qt] Clean up exception handling 2012-08-13 13:13:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60842 1 hausmann hausmann cmarcelo kenneth oldest_to_newest 693933 0 hausmann 2012-08-13 12:18:11 -0700 [Qt] Clean up exception handling 693935 1 158070 hausmann 2012-08-13 12:22:14 -0700 Created attachment 158070 Patch 693941 2 158070 kenneth 2012-08-13 12:25:48 -0700 Comment on attachment 158070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > Source/WebCore/ChangeLog:10 > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. you want it to be garbage collected? 693947 3 hausmann 2012-08-13 12:28:22 -0700 (In reply to comment #2) > (From update of attachment 158070 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > Source/WebCore/ChangeLog:10 > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > you want it to be garbage collected? No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. 693949 4 kenneth 2012-08-13 12:29:58 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 158070 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > > > Source/WebCore/ChangeLog:10 > > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > > > you want it to be garbage collected? > > No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. I guessed so, maybe that could be rewritten to be more clear for non JS guys like me. 693955 5 hausmann 2012-08-13 12:33:13 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 158070 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=158070&action=review > > > > > > > Source/WebCore/ChangeLog:10 > > > > + was thrown. Naturally the caller must store that ValueRef on the stack in order to get caught > > > > + by the garbage collector, otherwise the callee would have to use JSValueProtect on it. > > > > > > you want it to be garbage collected? > > > > No :) caught in the sense of _marked_ so that the GC does not delete it on the heap. > > I guessed so, maybe that could be rewritten to be more clear for non JS guys like me. Good point, will do :) 693993 6 cmarcelo 2012-08-13 13:08:47 -0700 LGTM. 694001 7 hausmann 2012-08-13 13:13:23 -0700 Committed r125439: <http://trac.webkit.org/changeset/125439> 158070 2012-08-13 12:22:14 -0700 2012-08-13 12:30:23 -0700 Patch bug-93880-20120813212252.patch text/plain 5044 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQwMjY0Y2I5ZGYwNTA3 ZTlhODBhZDExMTA0YWQ2MTIyODRiMDE5MC4uMGQ5NjM1Y2RkMzI4YjA0MDNhYzdhZTQ0MTUxNzFm MzA0NGU0YmUxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA4LTEzICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAorICAgICAgICBbUXRdIENs ZWFuIHVwIGV4Y2VwdGlvbiBoYW5kbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTM4ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgSlNDIEMgQVBJIHVzZXMgYSBKU1ZhbHVlUmVmKiBleGNlcHRp b24gcGFyYW1ldGVyIHRvIGluZGljYXRlIHRvIHRoZSBjYWxsZXIgdGhhdCBhbiBleGNlcHRpb24K KyAgICAgICAgd2FzIHRocm93bi4gTmF0dXJhbGx5IHRoZSBjYWxsZXIgbXVzdCBzdG9yZSB0aGF0 IFZhbHVlUmVmIG9uIHRoZSBzdGFjayBpbiBvcmRlciB0byBnZXQgY2F1Z2h0CisgICAgICAgIGJ5 IHRoZSBnYXJiYWdlIGNvbGxlY3Rvciwgb3RoZXJ3aXNlIHRoZSBjYWxsZWUgd291bGQgaGF2ZSB0 byB1c2UgSlNWYWx1ZVByb3RlY3Qgb24gaXQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBv bmUgc3VjaCBjYXNlIHdoZXJlIGluIGZhY3QgdGhlIGV4Y2VwdGlvbiBwb2ludGVyIHdhcyBwYXNz ZWQgYXMgemVybyB0byB0aGUKKyAgICAgICAgY2FsbGVlIGFuZCB0aHVzIGlnbm9yZWQuIFRoZSBw YXRjaCBhbHNvIHJlbW92ZXMgYW4gdW51c2VkIGV4Y2VwdGlvbiBwYXJhbWV0ZXIuCisKKyAgICAg ICAgKiBicmlkZ2UvcXQvcXRfY2xhc3MuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6UXRD bGFzczo6ZmFsbGJhY2tPYmplY3QpOgorICAgICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmNw cDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OlF0UnVudGltZU1ldGhvZDo6UXRSdW50aW1lTWV0 aG9kKToKKyAgICAgICAgKiBicmlkZ2UvcXQvcXRfcnVudGltZS5oOgorCisyMDEyLTA4LTEzICBT aW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKwogICAgICAgICBbUXRd IFBvcnQgbWV0YSBtZXRob2Qvc2lnbmFsL3Nsb3QgaGFuZGxpbmcgaW4gcnVuLXRpbWUgYnJpZGdl IHRvIHVzZSBKU0MgQyBBUEkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzNDc2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9x dF9jbGFzcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfY2xhc3MuY3BwCmluZGV4 IDYyNDhlZTM1MjgzNjE0YWQyMmU4NjA5NWQyYmYwN2M2MGQ4NjhhN2YuLmUyNDY3NmEyOWQ2N2M0 NDg3NTJiNDY4YTk3MTMyYzZiMDdkYjY4NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9jbGFzcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X2Ns YXNzLmNwcApAQCAtNzEsMTQgKzcxLDE4IEBAIEpTVmFsdWUgUXRDbGFzczo6ZmFsbGJhY2tPYmpl Y3QoRXhlY1N0YXRlKiBleGVjLCBJbnN0YW5jZSogaW5zdCwgUHJvcGVydHlOYW1lIGlkCiB7CiAg ICAgUXRJbnN0YW5jZSogcXRpbnN0ID0gc3RhdGljX2Nhc3Q8UXRJbnN0YW5jZSo+KGluc3QpOwog ICAgIEpTQ29udGV4dFJlZiBjb250ZXh0ID0gdG9SZWYoZXhlYyk7Ci0gICAgSlNWYWx1ZVJlZiog ZXhjZXB0aW9uID0gMDsKKyAgICBKU1ZhbHVlUmVmIGV4Y2VwdGlvbiA9IDA7CiAKICAgICBVU3Ry aW5nIHVzdHJpbmcoaWRlbnRpZmllci5wdWJsaWNOYW1lKCkpOwogICAgIGNvbnN0IFFCeXRlQXJy YXkgbmFtZSA9IFFTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBRQ2hhcio+KHVzdHJpbmcu Y2hhcmFjdGVycygpKSwgdXN0cmluZy5sZW5ndGgoKSkudG9MYXRpbjEoKTsKIAogICAgIC8vIEZp cnN0IHNlZSBpZiB3ZSBoYXZlIGEgY2FjaGUgaGl0Ci0gICAgaWYgKFF0UnVudGltZU1ldGhvZCog bWV0aG9kID0gcXRpbnN0LT5tX21ldGhvZHMudmFsdWUobmFtZSkpCi0gICAgICAgIHJldHVybiB0 b0pTKG1ldGhvZC0+anNPYmplY3RSZWYoY29udGV4dCwgZXhjZXB0aW9uKSk7CisgICAgaWYgKFF0 UnVudGltZU1ldGhvZCogbWV0aG9kID0gcXRpbnN0LT5tX21ldGhvZHMudmFsdWUobmFtZSkpIHsK KyAgICAgICAgSlNWYWx1ZSBvYmogPSB0b0pTKG1ldGhvZC0+anNPYmplY3RSZWYoY29udGV4dCwg JmV4Y2VwdGlvbikpOworICAgICAgICBpZiAoZXhjZXB0aW9uKQorICAgICAgICAgICAgcmV0dXJu IHRocm93RXJyb3IoZXhlYywgdG9KUyhleGVjLCBleGNlcHRpb24pKTsKKyAgICAgICAgcmV0dXJu IG9iajsKKyAgICB9CiAKICAgICAvLyBOb3BlLCBjcmVhdGUgYW4gZW50cnkKICAgICBjb25zdCBR Qnl0ZUFycmF5IG5vcm1hbCA9IFFNZXRhT2JqZWN0Ojpub3JtYWxpemVkU2lnbmF0dXJlKG5hbWUu Y29uc3REYXRhKCkpOwpAQCAtMTA5LDkgKzExMywxMiBAQCBKU1ZhbHVlIFF0Q2xhc3M6OmZhbGxi YWNrT2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywgSW5zdGFuY2UqIGluc3QsIFByb3BlcnR5TmFtZSBp ZAogICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIAogICAgIGludCBmbGFncyA9IG1ldGFN ZXRob2QubWV0aG9kVHlwZSgpID09IFFNZXRhTWV0aG9kOjpTaWduYWwgPyBRdFJ1bnRpbWVNZXRo b2Q6Ok1ldGhvZElzU2lnbmFsIDogMDsKLSAgICBRdFJ1bnRpbWVNZXRob2QqIG1ldGhvZCA9IG5l dyBRdFJ1bnRpbWVNZXRob2QoY29udGV4dCwgZXhjZXB0aW9uLCBzdGF0aWNfY2FzdDxRdEluc3Rh bmNlKj4oaW5zdCktPmdldE9iamVjdCgpLCBub3JtYWwsIGluZGV4LCBmbGFncywgcXRpbnN0KTsK KyAgICBRdFJ1bnRpbWVNZXRob2QqIG1ldGhvZCA9IG5ldyBRdFJ1bnRpbWVNZXRob2QoY29udGV4 dCwgc3RhdGljX2Nhc3Q8UXRJbnN0YW5jZSo+KGluc3QpLT5nZXRPYmplY3QoKSwgbm9ybWFsLCBp bmRleCwgZmxhZ3MsIHF0aW5zdCk7CiAgICAgcXRpbnN0LT5tX21ldGhvZHMuaW5zZXJ0KG5hbWUs IG1ldGhvZCk7Ci0gICAgcmV0dXJuIHRvSlMobWV0aG9kLT5qc09iamVjdFJlZihjb250ZXh0LCBl eGNlcHRpb24pKTsKKyAgICBKU1ZhbHVlIG9iaiA9IHRvSlMobWV0aG9kLT5qc09iamVjdFJlZihj b250ZXh0LCAmZXhjZXB0aW9uKSk7CisgICAgaWYgKGV4Y2VwdGlvbikKKyAgICAgICAgcmV0dXJu IHRocm93RXJyb3IoZXhlYywgdG9KUyhleGVjLCBleGNlcHRpb24pKTsKKyAgICByZXR1cm4gb2Jq OwogfQogCiAvLyBUaGlzIGZ1bmN0aW9uYWxpdHkgaXMgaGFuZGxlZCBieSB0aGUgZmFsbGJhY2sg Y2FzZSBhYm92ZS4uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1 bnRpbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCmluZGV4 IGNhYTkyMGM4ZGNlYWI0NWI3ZmUyODE0ZWE2NDk4M2E0ZjI3NDc0MTguLjIxMWU0Zjk0MGY4M2E3 YmY1ODU5Yjk0YjZjYzE0ZTgyNTM4NzRkYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jy aWRnZS9xdC9xdF9ydW50aW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRf cnVudGltZS5jcHAKQEAgLTEyOTAsNyArMTI5MCw3IEBAIHN0YXRpYyBKU0NsYXNzUmVmIHByb3Rv dHlwZUZvclNpZ25hbHNBbmRTbG90cygpCiAgICAgcmV0dXJuIGNsczsKIH0KIAotUXRSdW50aW1l TWV0aG9kOjpRdFJ1bnRpbWVNZXRob2QoSlNDb250ZXh0UmVmIGN0eCwgSlNWYWx1ZVJlZiogZXhj ZXB0aW9uLCBRT2JqZWN0KiBvYmplY3QsIGNvbnN0IFFCeXRlQXJyYXkmIGlkZW50aWZpZXIsIGlu dCBpbmRleCwgaW50IGZsYWdzLCBRdEluc3RhbmNlKiBpbnN0YW5jZSkKK1F0UnVudGltZU1ldGhv ZDo6UXRSdW50aW1lTWV0aG9kKEpTQ29udGV4dFJlZiBjdHgsIFFPYmplY3QqIG9iamVjdCwgY29u c3QgUUJ5dGVBcnJheSYgaWRlbnRpZmllciwgaW50IGluZGV4LCBpbnQgZmxhZ3MsIFF0SW5zdGFu Y2UqIGluc3RhbmNlKQogICAgIDogbV9vYmplY3Qob2JqZWN0KQogICAgICwgbV9pZGVudGlmaWVy KGlkZW50aWZpZXIpCiAgICAgLCBtX2luZGV4KGluZGV4KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuaCBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9x dF9ydW50aW1lLmgKaW5kZXggNzYzYWNiYTVkMDU5ZTgxOThiYmY2ZTRlZjBkOTNiMWM0ZmFkYzUz Ni4uMTQxZWYyNWEwMTZjYzJmMmFmMDM0MzMwM2Y3MzNjYzAwZjlkYzIwZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9icmlkZ2UvcXQvcXRfcnVudGltZS5oCkBAIC0xMDIsNyArMTAyLDcgQEAgcHVibGljOgogICAg ICAgICBBbGxvd1ByaXZhdGUgPSAyCiAgICAgfTsKIAotICAgIFF0UnVudGltZU1ldGhvZChKU0Nv bnRleHRSZWYsIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbiwgUU9iamVjdCosIGNvbnN0IFFCeXRlQXJy YXkmIGlkZW50aWZpZXIsIGludCBzaWduYWxJbmRleCwgaW50IGZsYWdzLCBRdEluc3RhbmNlKik7 CisgICAgUXRSdW50aW1lTWV0aG9kKEpTQ29udGV4dFJlZiwgUU9iamVjdCosIGNvbnN0IFFCeXRl QXJyYXkmIGlkZW50aWZpZXIsIGludCBzaWduYWxJbmRleCwgaW50IGZsYWdzLCBRdEluc3RhbmNl Kik7CiAgICAgflF0UnVudGltZU1ldGhvZCgpOwogCiAgICAgc3RhdGljIEpTVmFsdWVSZWYgY2Fs bChKU0NvbnRleHRSZWYgY3R4LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYgdGhp c09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1lbnRz W10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbik7Cg==