93868 2012-08-13 11:03:26 -0700 [Qt] Simplify storage and reduce size of QtConnectionObject 2012-08-13 13:33:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60842 1 hausmann hausmann cmarcelo webkit.review.bot oldest_to_newest 693834 0 hausmann 2012-08-13 11:03:26 -0700 [Qt] Simplify storage and reduce size of QtConnectionObject 693845 1 158049 hausmann 2012-08-13 11:11:43 -0700 Created attachment 158049 Patch 693868 2 158049 kenneth 2012-08-13 11:26:12 -0700 Comment on attachment 158049 Patch im ok with this. 693977 3 cmarcelo 2012-08-13 12:56:36 -0700 LGTM. 694026 4 158049 webkit.review.bot 2012-08-13 13:33:34 -0700 Comment on attachment 158049 Patch Clearing flags on attachment: 158049 Committed r125442: <http://trac.webkit.org/changeset/125442> 694027 5 webkit.review.bot 2012-08-13 13:33:38 -0700 All reviewed patches have been landed. Closing bug. 158049 2012-08-13 11:11:43 -0700 2012-08-13 13:33:34 -0700 Patch bug-93868-20120813201221.patch text/plain 5014 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQwMjY0Y2I5ZGYwNTA3 ZTlhODBhZDExMTA0YWQ2MTIyODRiMDE5MC4uMjI5NGE0ZWFhM2U4YzczYjBhNzYzMmExNzNjOGMz ZTk2ZDdlOTMzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA4LTEzICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAorICAgICAgICBbUXRdIFNp bXBsaWZ5IHN0b3JhZ2UgYW5kIHJlZHVjZSBzaXplIG9mIFF0Q29ubmVjdGlvbk9iamVjdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM4NjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29ubmVjdGlv biBvYmplY3QgaXMgYSBjaGlsZCBvZiB0aGUgc2VuZGVyIFFPYmplY3QsIHNvIHdlIGNhbiB1c2Ug cGFyZW50KCkKKyAgICAgICAgd2hlbmV2ZXIgd2UgbmVlZCB0aGUgc2VuZGVyIGluc3RlYWQgb2Yg a2VlcGluZyBhbiBleHRyYSBRT2JqZWN0IHBvaW50ZXIuIEFsc28KKyAgICAgICAgUXRDb25uZWN0 aW9uT2JqZWN0IGtlcHQgYSBSZWZQdHIgdG8gdGhlIEluc3RhbmNlLCBidXQgYWN0dWFsbHkgb25s eSBuZWVkZWQgdGhlCisgICAgICAgIHJvb3Qgb2JqZWN0LCBzbyB3ZSBjYW4gc3RvcmUgYSBwb2lu dGVyIHRvIHRoYXQgaW5zdGVhZC4KKworICAgICAgICAqIGJyaWRnZS9xdC9xdF9ydW50aW1lLmNw cDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OlF0Q29ubmVjdGlvbk9iamVjdDo6UXRDb25uZWN0 aW9uT2JqZWN0KToKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OlF0Q29ubmVjdGlvbk9iamVjdDo6 flF0Q29ubmVjdGlvbk9iamVjdCk6CisgICAgICAgIChKU0M6OkJpbmRpbmdzOjpRdENvbm5lY3Rp b25PYmplY3Q6OmV4ZWN1dGUpOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6UXRDb25uZWN0aW9u T2JqZWN0OjptYXRjaCk6CisgICAgICAgICogYnJpZGdlL3F0L3F0X3J1bnRpbWUuaDoKKyAgICAg ICAgKFF0Q29ubmVjdGlvbk9iamVjdCk6CisKKzIwMTItMDgtMTMgIFNpbW9uIEhhdXNtYW5uICA8 c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gUG9ydCBtZXRhIG1ldGhv ZC9zaWduYWwvc2xvdCBoYW5kbGluZyBpbiBydW4tdGltZSBicmlkZ2UgdG8gdXNlIEpTQyBDIEFQ SQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM0NzYK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwIGIv U291cmNlL1dlYkNvcmUvYnJpZGdlL3F0L3F0X3J1bnRpbWUuY3BwCmluZGV4IGNhYTkyMGM4ZGNl YWI0NWI3ZmUyODE0ZWE2NDk4M2E0ZjI3NDc0MTguLmYxZGU0ZmU2MGMzNjdkMWY0MDRkMDFlNWY0 MGU2YTFlYWI1MTBhZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9y dW50aW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5jcHAK QEAgLTE1MjUsOCArMTUyNSw3IEBAIFFNdWx0aU1hcDxRT2JqZWN0KiwgUXRDb25uZWN0aW9uT2Jq ZWN0Kj4gUXRDb25uZWN0aW9uT2JqZWN0Ojpjb25uZWN0aW9uczsKIFF0Q29ubmVjdGlvbk9iamVj dDo6UXRDb25uZWN0aW9uT2JqZWN0KEpTQ29udGV4dFJlZiBjb250ZXh0LCBQYXNzUmVmUHRyPFF0 SW5zdGFuY2U+IHNlbmRlckluc3RhbmNlLCBpbnQgc2lnbmFsSW5kZXgsIEpTT2JqZWN0UmVmIHJl Y2VpdmVyLCBKU09iamVjdFJlZiByZWNlaXZlckZ1bmN0aW9uKQogICAgIDogUU9iamVjdChzZW5k ZXJJbnN0YW5jZS0+Z2V0T2JqZWN0KCkpCiAgICAgLCBtX2NvbnRleHQoSlNDb250ZXh0R2V0R2xv YmFsQ29udGV4dChjb250ZXh0KSkKLSAgICAsIG1fc2VuZGVySW5zdGFuY2Uoc2VuZGVySW5zdGFu Y2UpCi0gICAgLCBtX29yaWdpbmFsU2VuZGVyKG1fc2VuZGVySW5zdGFuY2UtPmdldE9iamVjdCgp KQorICAgICwgbV9yb290T2JqZWN0KHNlbmRlckluc3RhbmNlLT5yb290T2JqZWN0KCkpCiAgICAg LCBtX3NpZ25hbEluZGV4KHNpZ25hbEluZGV4KQogICAgICwgbV9yZWNlaXZlcihyZWNlaXZlcikK ICAgICAsIG1fcmVjZWl2ZXJGdW5jdGlvbihyZWNlaXZlckZ1bmN0aW9uKQpAQCAtMTUzOCw5ICsx NTM3LDcgQEAgUXRDb25uZWN0aW9uT2JqZWN0OjpRdENvbm5lY3Rpb25PYmplY3QoSlNDb250ZXh0 UmVmIGNvbnRleHQsIFBhc3NSZWZQdHI8UXRJbnN0YW4KIAogUXRDb25uZWN0aW9uT2JqZWN0Ojp+ UXRDb25uZWN0aW9uT2JqZWN0KCkKIHsKLSAgICAvLyBXZSBjYW4gc2FmZWx5IHVzZSBtX29yaWdp bmFsU2VuZGVyIGJlY2F1c2UgY29ubmVjdGlvbiBvYmplY3Qgd2lsbCBuZXZlciBvdXRsaXZlIHRo ZSBzZW5kZXIsCi0gICAgLy8gd2hpY2ggaXMgaXRzIFFPYmplY3QgcGFyZW50LgotICAgIGNvbm5l Y3Rpb25zLnJlbW92ZShtX29yaWdpbmFsU2VuZGVyLCB0aGlzKTsKKyAgICBjb25uZWN0aW9ucy5y ZW1vdmUocGFyZW50KCksIHRoaXMpOwogCiAgICAgaWYgKG1fcmVjZWl2ZXIpCiAgICAgICAgIEpT VmFsdWVVbnByb3RlY3QobV9jb250ZXh0LCBtX3JlY2VpdmVyKTsKQEAgLTE2MzYsMTQgKzE2MzMs NyBAQCBpbnQgUXRDb25uZWN0aW9uT2JqZWN0OjpxdF9tZXRhY2FsbChRTWV0YU9iamVjdDo6Q2Fs bCBfYywgaW50IF9pZCwgdm9pZCAqKl9hKQogCiB2b2lkIFF0Q29ubmVjdGlvbk9iamVjdDo6ZXhl Y3V0ZSh2b2lkKiogYXJndikKIHsKLSAgICBRT2JqZWN0KiBzZW5kZXIgPSBtX3NlbmRlckluc3Rh bmNlLT5nZXRPYmplY3QoKTsKLSAgICBpZiAoIXNlbmRlcikgewotICAgICAgICBxV2FybmluZygp IDw8ICJzZW5kZXIgZGVsZXRlZCwgY2Fubm90IGRlbGl2ZXIgc2lnbmFsIjsKLSAgICAgICAgcmV0 dXJuOwotICAgIH0KLQotICAgIEFTU0VSVChzZW5kZXIgPT0gbV9vcmlnaW5hbFNlbmRlcik7Ci0K KyAgICBRT2JqZWN0KiBzZW5kZXIgPSBwYXJlbnQoKTsKICAgICBjb25zdCBRTWV0YU9iamVjdCog bWV0YSA9IHNlbmRlci0+bWV0YU9iamVjdCgpOwogICAgIGNvbnN0IFFNZXRhTWV0aG9kIG1ldGhv ZCA9IG1ldGEtPm1ldGhvZChtX3NpZ25hbEluZGV4KTsKIApAQCAtMTY1NSwxMSArMTY0NSwxMCBA QCB2b2lkIFF0Q29ubmVjdGlvbk9iamVjdDo6ZXhlY3V0ZSh2b2lkKiogYXJndikKIAogICAgIC8v IFRPRE86IHJlbW92ZSBvbmNlIGNvbnZlcnNpb24gZnVuY3Rpb25zIHVzZSBKU0MgQVBJLgogICAg IEV4ZWNTdGF0ZSogZXhlYyA9IDo6dG9KUyhtX2NvbnRleHQpOwotICAgIFJlZlB0cjxSb290T2Jq ZWN0PiByb290T2JqZWN0ID0gbV9zZW5kZXJJbnN0YW5jZS0+cm9vdE9iamVjdCgpOwogCiAgICAg Zm9yIChpbnQgaSA9IDA7IGkgPCBhcmdjOyBpKyspIHsKICAgICAgICAgaW50IGFyZ1R5cGUgPSBt ZXRob2QucGFyYW1ldGVyVHlwZShpKTsKLSAgICAgICAgYXJnc1tpXSA9IDo6dG9SZWYoZXhlYywg Y29udmVydFFWYXJpYW50VG9WYWx1ZShleGVjLCByb290T2JqZWN0LCBRVmFyaWFudChhcmdUeXBl LCBhcmd2W2krMV0pKSk7CisgICAgICAgIGFyZ3NbaV0gPSA6OnRvUmVmKGV4ZWMsIGNvbnZlcnRR VmFyaWFudFRvVmFsdWUoZXhlYywgbV9yb290T2JqZWN0LCBRVmFyaWFudChhcmdUeXBlLCBhcmd2 W2krMV0pKSk7CiAgICAgfQogCiAgICAgSlNPYmplY3RDYWxsQXNGdW5jdGlvbihtX2NvbnRleHQs IG1fcmVjZWl2ZXJGdW5jdGlvbiwgbV9yZWNlaXZlciwgYXJnYywgYXJncy5kYXRhKCksIDApOwpA QCAtMTY2Nyw3ICsxNjU2LDcgQEAgdm9pZCBRdENvbm5lY3Rpb25PYmplY3Q6OmV4ZWN1dGUodm9p ZCoqIGFyZ3YpCiAKIGJvb2wgUXRDb25uZWN0aW9uT2JqZWN0OjptYXRjaChKU0NvbnRleHRSZWYg Y29udGV4dCwgUU9iamVjdCogc2VuZGVyLCBpbnQgc2lnbmFsSW5kZXgsIEpTT2JqZWN0UmVmIHJl Y2VpdmVyLCBKU09iamVjdFJlZiByZWNlaXZlckZ1bmN0aW9uKQogewotICAgIGlmIChzZW5kZXIg IT0gbV9vcmlnaW5hbFNlbmRlciB8fCBzaWduYWxJbmRleCAhPSBtX3NpZ25hbEluZGV4KQorICAg IGlmIChzZW5kZXIgIT0gcGFyZW50KCkgfHwgc2lnbmFsSW5kZXggIT0gbV9zaWduYWxJbmRleCkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEpTVmFsdWVSZWYqIGlnbm9yZWRFeGNlcHRpb24g PSAwOwogICAgIGNvbnN0IGJvb2wgcmVjZWl2ZXJNYXRjaCA9ICghcmVjZWl2ZXIgJiYgIW1fcmVj ZWl2ZXIpIHx8IChyZWNlaXZlciAmJiBtX3JlY2VpdmVyICYmIEpTVmFsdWVJc0VxdWFsKGNvbnRl eHQsIHJlY2VpdmVyLCBtX3JlY2VpdmVyLCBpZ25vcmVkRXhjZXB0aW9uKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5oIGIvU291cmNlL1dlYkNvcmUv YnJpZGdlL3F0L3F0X3J1bnRpbWUuaAppbmRleCA3NjNhY2JhNWQwNTllODE5OGJiZjZlNGVmMGQ5 M2IxYzRmYWRjNTM2Li45MDQ4ZTRlMDE1MjQ2M2Y1YWQzNDZjYWY1MjYzYWJhZDMwYWI1YWNmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfcnVudGltZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JyaWRnZS9xdC9xdF9ydW50aW1lLmgKQEAgLTE0MSwxMCArMTQxLDcgQEAg cHVibGljOgogCiBwcml2YXRlOgogICAgIEpTR2xvYmFsQ29udGV4dFJlZiBtX2NvbnRleHQ7Ci0g ICAgUmVmUHRyPFF0SW5zdGFuY2U+IG1fc2VuZGVySW5zdGFuY2U7Ci0KLSAgICAvLyBXZSB1c2Ug dGhpcyBhcyBrZXkgaW4gYWN0aXZlIGNvbm5lY3Rpb25zIG11bHRpbWFwLgotICAgIFFPYmplY3Qq IG1fb3JpZ2luYWxTZW5kZXI7CisgICAgUmVmUHRyPFJvb3RPYmplY3Q+IG1fcm9vdE9iamVjdDsK IAogICAgIGludCBtX3NpZ25hbEluZGV4OwogICAgIEpTT2JqZWN0UmVmIG1fcmVjZWl2ZXI7Cg==