93839 2012-08-13 06:35:54 -0700 [V8] Rename v8ValueToWebCoreDOMStringList() to toDOMStringList() 2012-08-13 19:22:12 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693616 0 haraken 2012-08-13 06:35:54 -0700 For naming consistency with toWebCoreString() and toWebCoreAtomicString(), we can rename v8ValueToWebCoreDOMStringList() to toDOMStringList(). ("WebCore" wouldn't be needed because it's clear from "DOMStringList".) 693620 1 157984 haraken 2012-08-13 06:37:37 -0700 Created attachment 157984 Patch 694302 2 haraken 2012-08-13 17:53:42 -0700 Committed r125483: <http://trac.webkit.org/changeset/125483> 157984 2012-08-13 06:37:37 -0700 2012-08-13 19:22:12 -0700 Patch bug-93839-20120813223706.patch text/plain 6404 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uMDhjMTkzMmMwYTAxNzM1MzUxYTM1NDFkMzk3NWM2 ZmZmNTU2MjY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbmFtZSB2 OFZhbHVlVG9XZWJDb3JlRE9NU3RyaW5nTGlzdCgpIHRvIHRvRE9NU3RyaW5nTGlzdCgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgzOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBuYW1pbmcgY29u c2lzdGVuY3kgd2l0aCB0b1dlYkNvcmVTdHJpbmcoKSBhbmQgdG9XZWJDb3JlQXRvbWljU3RyaW5n KCksCisgICAgICAgIHRoaXMgcGF0Y2ggcmVuYW1lcyB2OFZhbHVlVG9XZWJDb3JlRE9NU3RyaW5n TGlzdCgpIHRvIHRvRE9NU3RyaW5nTGlzdCgpLgorICAgICAgICAoIldlYkNvcmUiIHdvdWxkbid0 IGJlIG5lZWRlZCBiZWNhdXNlIGl0J3MgY2xlYXIgZnJvbSAiRE9NU3RyaW5nTGlzdCIuKQorCisg ICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEpTVmFsdWVUb05hdGl2 ZSk6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6b3ZlcmxvYWRlZE1ldGhvZDZDYWxs YmFjayk6CisgICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6b3ZlcmxvYWRlZE1l dGhvZDdDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRlcm5hbDo6b3Zl cmxvYWRlZE1ldGhvZDlDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpUZXN0T2JqVjhJbnRl cm5hbDo6c3RyaW5nQXJyYXlGdW5jdGlvbkNhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9ET01TdHJpbmdMaXN0KToKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAy MDEyLTA4LTEyICBQcmF2aW4gRCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KIAogICAgICAgICB0 YWJsZSBjZWxsLmNlbGxJbmRleCBzaG91bGQgcmV0dXJuIC0xIGlmIHRoZXJlIGlzIG5vIHBhcmVu dCB0YWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JWOC5wbQppbmRleCAwYTlkOWQ3MmZjNDNjMTg5M2QxZWMwNjlhN2Y4MzFkYzAxMjMwYTVj Li40YzBkMGU3MjJkMDY4MWJiMjM4NWRiM2MxMGQ3Mjc2NGUyNDE4MWQ1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzc2 Nyw5ICszNzY3LDkgQEAgc3ViIEpTVmFsdWVUb05hdGl2ZQogICAgIHJldHVybiAidG9JbnQ2NCgk dmFsdWUpIiBpZiAkdHlwZSBlcSAidW5zaWduZWQgbG9uZyBsb25nIiBvciAkdHlwZSBlcSAibG9u ZyBsb25nIjsKICAgICByZXR1cm4gInN0YXRpY19jYXN0PFJhbmdlOjpDb21wYXJlSG93PigkdmFs dWUtPkludDMyVmFsdWUoKSkiIGlmICR0eXBlIGVxICJDb21wYXJlSG93IjsKICAgICByZXR1cm4g InRvV2ViQ29yZURhdGUoJHZhbHVlKSIgaWYgJHR5cGUgZXEgIkRhdGUiOwotICAgIHJldHVybiAi djhWYWx1ZVRvV2ViQ29yZURPTVN0cmluZ0xpc3QoJHZhbHVlKSIgaWYgJHR5cGUgZXEgIkRPTVN0 cmluZ0xpc3QiOworICAgIHJldHVybiAidG9ET01TdHJpbmdMaXN0KCR2YWx1ZSkiIGlmICR0eXBl IGVxICJET01TdHJpbmdMaXN0IjsKICAgICAjIEZJWE1FOiBBZGQgcHJvcGVyIHN1cHBvcnQgZm9y IFRbXSwgVFtdPyBhbmQgc2VxdWVuY2U8VD4uCi0gICAgcmV0dXJuICJ2OFZhbHVlVG9XZWJDb3Jl RE9NU3RyaW5nTGlzdCgkdmFsdWUpIiBpZiAkdHlwZSBlcSAiRE9NU3RyaW5nW10iOworICAgIHJl dHVybiAidG9ET01TdHJpbmdMaXN0KCR2YWx1ZSkiIGlmICR0eXBlIGVxICJET01TdHJpbmdbXSI7 CiAKICAgICBpZiAoJHR5cGUgZXEgIkRPTVN0cmluZyIgb3IgJHR5cGUgZXEgIkRPTVVzZXJEYXRh IikgewogICAgICAgICByZXR1cm4gJHZhbHVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAppbmRleCBiM2Q3NzVlODFkNzBl ODA4Y2I4ZjI4Mzg4ZmY0ZTdkOTUyMzhjMDVkLi5kOWQyMzQzZDZiODk5OGE2OTc5YWY5YzMyMzRk ZWMxYWJmMmVlMDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVjgvVjhUZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvVjgvVjhUZXN0T2JqLmNwcApAQCAtMTYwNSw3ICsxNjA1LDcgQEAgc3RhdGljIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBvdmVybG9hZGVkTWV0aG9kNkNhbGxiYWNrKGNvbnN0IHY4OjpB cmd1bWVudHMmIGFyZ3MKICAgICBpZiAoYXJncy5MZW5ndGgoKSA8IDEpCiAgICAgICAgIHJldHVy biBWOFByb3h5Ojp0aHJvd05vdEVub3VnaEFyZ3VtZW50c0Vycm9yKGFyZ3MuR2V0SXNvbGF0ZSgp KTsKICAgICBUZXN0T2JqKiBpbXAgPSBWOFRlc3RPYmo6OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkp OwotICAgIEVYQ0VQVElPTl9CTE9DSyhSZWZQdHI8RE9NU3RyaW5nTGlzdD4sIGxpc3RBcmcsIHY4 VmFsdWVUb1dlYkNvcmVET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFyZ3Ms IDAsIERlZmF1bHRJc1VuZGVmaW5lZCkpKTsKKyAgICBFWENFUFRJT05fQkxPQ0soUmVmUHRyPERP TVN0cmluZ0xpc3Q+LCBsaXN0QXJnLCB0b0RPTVN0cmluZ0xpc3QoTUFZQkVfTUlTU0lOR19QQVJB TUVURVIoYXJncywgMCwgRGVmYXVsdElzVW5kZWZpbmVkKSkpOwogICAgIGltcC0+b3ZlcmxvYWRl ZE1ldGhvZChsaXN0QXJnKTsKICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKIH0KQEAgLTE2MTYs NyArMTYxNiw3IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb3ZlcmxvYWRlZE1ldGhv ZDdDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzCiAgICAgaWYgKGFyZ3MuTGVuZ3Ro KCkgPCAxKQogICAgICAgICByZXR1cm4gVjhQcm94eTo6dGhyb3dOb3RFbm91Z2hBcmd1bWVudHNF cnJvcihhcmdzLkdldElzb2xhdGUoKSk7CiAgICAgVGVzdE9iaiogaW1wID0gVjhUZXN0T2JqOjp0 b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKLSAgICBFWENFUFRJT05fQkxPQ0soUmVmUHRyPERPTVN0 cmluZ0xpc3Q+LCBhcnJheUFyZywgdjhWYWx1ZVRvV2ViQ29yZURPTVN0cmluZ0xpc3QoTUFZQkVf TUlTU0lOR19QQVJBTUVURVIoYXJncywgMCwgRGVmYXVsdElzVW5kZWZpbmVkKSkpOworICAgIEVY Q0VQVElPTl9CTE9DSyhSZWZQdHI8RE9NU3RyaW5nTGlzdD4sIGFycmF5QXJnLCB0b0RPTVN0cmlu Z0xpc3QoTUFZQkVfTUlTU0lOR19QQVJBTUVURVIoYXJncywgMCwgRGVmYXVsdElzVW5kZWZpbmVk KSkpOwogICAgIGltcC0+b3ZlcmxvYWRlZE1ldGhvZChhcnJheUFyZyk7CiAgICAgcmV0dXJuIHY4 VW5kZWZpbmVkKCk7CiB9CkBAIC0xNjM4LDcgKzE2MzgsNyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IG92ZXJsb2FkZWRNZXRob2Q5Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYg YXJncwogICAgIGlmIChhcmdzLkxlbmd0aCgpIDwgMSkKICAgICAgICAgcmV0dXJuIFY4UHJveHk6 OnRocm93Tm90RW5vdWdoQXJndW1lbnRzRXJyb3IoYXJncy5HZXRJc29sYXRlKCkpOwogICAgIFRl c3RPYmoqIGltcCA9IFY4VGVzdE9iajo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0gICAgRVhD RVBUSU9OX0JMT0NLKFJlZlB0cjxET01TdHJpbmdMaXN0PiwgYXJyYXlBcmcsIHY4VmFsdWVUb1dl YkNvcmVET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFyZ3MsIDAsIERlZmF1 bHRJc1VuZGVmaW5lZCkpKTsKKyAgICBFWENFUFRJT05fQkxPQ0soUmVmUHRyPERPTVN0cmluZ0xp c3Q+LCBhcnJheUFyZywgdG9ET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFy Z3MsIDAsIERlZmF1bHRJc1VuZGVmaW5lZCkpKTsKICAgICBpbXAtPm92ZXJsb2FkZWRNZXRob2Qo YXJyYXlBcmcpOwogICAgIHJldHVybiB2OFVuZGVmaW5lZCgpOwogfQpAQCAtMTgwOSw3ICsxODA5 LDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBzdHJpbmdBcnJheUZ1bmN0aW9uQ2Fs bGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXIKICAgICBUZXN0T2JqKiBpbXAgPSBWOFRlc3RP Ymo6OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkpOwogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwog ICAgIHsKLSAgICBFWENFUFRJT05fQkxPQ0soUmVmUHRyPERPTVN0cmluZ0xpc3Q+LCB2YWx1ZXMs IHY4VmFsdWVUb1dlYkNvcmVET01TdHJpbmdMaXN0KE1BWUJFX01JU1NJTkdfUEFSQU1FVEVSKGFy Z3MsIDAsIERlZmF1bHRJc1VuZGVmaW5lZCkpKTsKKyAgICBFWENFUFRJT05fQkxPQ0soUmVmUHRy PERPTVN0cmluZ0xpc3Q+LCB2YWx1ZXMsIHRvRE9NU3RyaW5nTGlzdChNQVlCRV9NSVNTSU5HX1BB UkFNRVRFUihhcmdzLCAwLCBEZWZhdWx0SXNVbmRlZmluZWQpKSk7CiAgICAgUmVmUHRyPERPTVN0 cmluZ0xpc3Q+IHJlc3VsdCA9IGltcC0+c3RyaW5nQXJyYXlGdW5jdGlvbih2YWx1ZXMsIGVjKTsK ICAgICBpZiAoVU5MSUtFTFkoZWMpKQogICAgICAgICBnb3RvIGZhaWw7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAppbmRleCBhNWU5NWE4N2JmYzA1OWNjNTA0OWFmODMw Yzc2ZWQxZmMzYzZjNTdjLi4yYTIyNTBlOGMyYzliNzgzMzQwY2JkNGRjMjJiODE4NGJjMTQwZGEw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKQEAgLTM1NSw3ICsz NTUsNyBAQCB2b2lkIFN0cmluZ0NhY2hlOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJ bmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogICAgIGluZm8uYWRkSGFzaE1hcChtX3N0cmlu Z0NhY2hlKTsKIH0KICAgICAKLVBhc3NSZWZQdHI8RE9NU3RyaW5nTGlzdD4gdjhWYWx1ZVRvV2Vi Q29yZURPTVN0cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQorUGFzc1JlZlB0 cjxET01TdHJpbmdMaXN0PiB0b0RPTVN0cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZh bHVlKQogewogICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHY4VmFsdWUodjg6OkxvY2FsPHY4OjpW YWx1ZT46Ok5ldyh2YWx1ZSkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5o CmluZGV4IGNhM2FmYjY0OWI2NjZkZTJhNGVkYjEzOTkxNTk1NjY5NDE5MTQ5ZWMuLjcxZDVkMDY3 OTQ4MWMxMGVjODA4ZjBkZTk2NDU5NzFlNzFhMmMyMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5oCkBAIC00MjksNyArNDI5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgU3RyaW5nIGludDMyVG9XZWJDb3JlU3RyaW5nKGludCB2YWx1ZSk7CiAKLSAgICBQYXNz UmVmUHRyPERPTVN0cmluZ0xpc3Q+IHY4VmFsdWVUb1dlYkNvcmVET01TdHJpbmdMaXN0KHY4OjpI YW5kbGU8djg6OlZhbHVlPik7CisgICAgUGFzc1JlZlB0cjxET01TdHJpbmdMaXN0PiB0b0RPTVN0 cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+KTsKIAogICAgIGNsYXNzIFY4UGFyYW1ldGVy QmFzZSB7CiAgICAgcHVibGljOgo=