93825 2012-08-13 05:03:58 -0700 [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback 2012-08-13 07:20:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 42332 1 mikhail.pozdnyakov mikhail.pozdnyakov hausmann kenneth tonikitoo webkit.review.bot oldest_to_newest 693546 0 mikhail.pozdnyakov 2012-08-13 05:03:58 -0700 void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo) { static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFinishLoadForResource(page, frame, identifier, error); } should be void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo) { static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFailLoadForResource(page, frame, identifier, error); } 693551 1 157965 mikhail.pozdnyakov 2012-08-13 05:08:54 -0700 Created attachment 157965 patch 693553 2 157965 cdumez 2012-08-13 05:11:50 -0700 Comment on attachment 157965 patch LGTM. 693618 3 157965 g.czajkowski 2012-08-13 06:36:21 -0700 Comment on attachment 157965 patch Nice catch. 693636 4 157965 webkit.review.bot 2012-08-13 07:20:07 -0700 Comment on attachment 157965 patch Clearing flags on attachment: 157965 Committed r125418: <http://trac.webkit.org/changeset/125418> 693637 5 webkit.review.bot 2012-08-13 07:20:11 -0700 All reviewed patches have been landed. Closing bug. 157965 2012-08-13 05:08:54 -0700 2012-08-13 07:20:06 -0700 patch bug93825 text/plain 1813 mikhail.pozdnyakov Y29tbWl0IGZiNDcwY2ExNDdmMDVkM2JmNzM1ZTI5NTg5MWE4YWY1NTgyMTNiZTQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg TW9uIEF1ZyAxMyAxNTowNzoyNSAyMDEyICswMzAwCgogICAgYnVnOTM4MjUKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU5YmM4YS4uY2M4NWQ1 ZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEyLTA4LTEzICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJdIFtXVFJdIEluamVjdGVkQnVuZGxl UGFnZTo6ZGlkRmFpbExvYWRGb3JSZXNvdXJjZSBpbnZva2VzIHdyb25nIGNhbGxiYWNrCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzgyNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3RlZCBmcm9t IGRpZEZpbmlzaExvYWRGb3JSZXNvdXJjZSgpIGludm9rZSB0byBkaWRGYWlsTG9hZEZvclJlc291 cmNlKCkgaW52b2tlLiAKKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcDoKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRCdW5kbGVQ YWdlOjpkaWRGYWlsTG9hZEZvclJlc291cmNlKToKKwogMjAxMi0wOC0xMiAgTU9SSVRBIEhhamlt ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRlZCBhIHBy b3h5IGFkZHJlc3MgdG8gY29udHJpYnV0b3JzX3dob19hcmVfbm90X2NvbW1pdHRlcnMuCmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlUGFnZS5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVj dGVkQnVuZGxlUGFnZS5jcHAKaW5kZXggZGUzMmNiMC4uMmEzZWMyMCAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3Bw CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5k bGVQYWdlLmNwcApAQCAtNTgwLDcgKzU4MCw3IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpk aWRGaW5pc2hMb2FkRm9yUmVzb3VyY2UoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdLQnVuZGxlCiAK IHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpkaWRGYWlsTG9hZEZvclJlc291cmNlKFdLQnVuZGxl UGFnZVJlZiBwYWdlLCBXS0J1bmRsZUZyYW1lUmVmIGZyYW1lLCB1aW50NjRfdCBpZGVudGlmaWVy LCBXS0Vycm9yUmVmIGVycm9yLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogewotICAgIHN0YXRp Y19jYXN0PEluamVjdGVkQnVuZGxlUGFnZSo+KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8p KS0+ZGlkRmluaXNoTG9hZEZvclJlc291cmNlKHBhZ2UsIGZyYW1lLCBpZGVudGlmaWVyLCBlcnJv cik7CisgICAgc3RhdGljX2Nhc3Q8SW5qZWN0ZWRCdW5kbGVQYWdlKj4oY29uc3RfY2FzdDx2b2lk Kj4oY2xpZW50SW5mbykpLT5kaWRGYWlsTG9hZEZvclJlc291cmNlKHBhZ2UsIGZyYW1lLCBpZGVu dGlmaWVyLCBlcnJvcik7CiB9CiAKIHZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpkaWRTdGFydFBy b3Zpc2lvbmFsTG9hZEZvckZyYW1lKFdLQnVuZGxlRnJhbWVSZWYgZnJhbWUpCg==