93821 2012-08-13 04:39:25 -0700 [V8] Move the ConstructorMode class from V8Binding.h to SafeAllocation.h 2012-08-13 19:24:56 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693533 0 haraken 2012-08-13 04:39:25 -0700 We can factor out the ConstructorMode class from V8Binding.h to SafeAllocation.h. In a follow-up patch, I'd like to rename SafeAllocation to V8ObjectConstructor, if you don't have an objection. 693535 1 157960 haraken 2012-08-13 04:40:47 -0700 Created attachment 157960 Patch 694295 2 haraken 2012-08-13 17:47:24 -0700 Committed r125480: <http://trac.webkit.org/changeset/125480> 157960 2012-08-13 04:40:47 -0700 2012-08-13 19:24:56 -0700 Patch bug-93821-20120813204015.patch text/plain 4554 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uMDQyMjIxYjhiMzBmOWQ2ZDc2ZWY5NmZmY2Q0NzYx NTMyMTAwYzliYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgdGhl IENvbnN0cnVjdG9yTW9kZSBjbGFzcyBmcm9tIFY4QmluZGluZy5oIHRvIFNhZmVBbGxvY2F0aW9u LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzODIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBw YXRjaCBmYWN0b3JzIG91dCB0aGUgQ29uc3RydWN0b3JNb2RlIGNsYXNzIGZyb20gVjhCaW5kaW5n LmggdG8gU2FmZUFsbG9jYXRpb24uaC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2FmZUFsbG9jYXRpb24uaDoKKyAg ICAgICAgKENvbnN0cnVjdG9yTW9kZSk6CisgICAgICAgIChXZWJDb3JlOjpDb25zdHJ1Y3Rvck1v ZGU6OkNvbnN0cnVjdG9yTW9kZSk6CisgICAgICAgIChXZWJDb3JlOjpDb25zdHJ1Y3Rvck1vZGU6 On5Db25zdHJ1Y3Rvck1vZGUpOgorICAgICAgICAoV2ViQ29yZTo6Q29uc3RydWN0b3JNb2RlOjpj dXJyZW50KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4Qmlu ZGluZy5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UmVjdXJzaW9uU2NvcGUuaDoKKwogMjAx Mi0wOC0xMiAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+CiAKICAgICAgICAgdGFi bGUgY2VsbC5jZWxsSW5kZXggc2hvdWxkIHJldHVybiAtMSBpZiB0aGVyZSBpcyBubyBwYXJlbnQg dGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NhZmVBbGxvY2F0 aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TYWZlQWxsb2NhdGlvbi5oCmluZGV4 IGMzYjM0YWViZjNhYThiY2Q3YTQ4OWRiNWU4ZTVmYmE2NWU3ODAzMGIuLjc5OGUwNTJmMDAzM2M5 Njg1NjA1OWZiNjA1OGI0ZWU1MjkzN2YzMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NhZmVBbGxvY2F0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2FmZUFsbG9jYXRpb24uaApAQCAtMzEsMTMgKzMxLDM5IEBACiAjaWZuZGVmIFNhZmVBbGxv Y2F0aW9uX2gKICNkZWZpbmUgU2FmZUFsbG9jYXRpb25faAogCi0jaW5jbHVkZSAiVjhCaW5kaW5n LmgiCisjaW5jbHVkZSAiVjhQZXJJc29sYXRlRGF0YS5oIgogI2luY2x1ZGUgIlY4UmVjdXJzaW9u U2NvcGUuaCIKIAogI2luY2x1ZGUgPHY4Lmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xh c3MgQ29uc3RydWN0b3JNb2RlIHsKK3B1YmxpYzoKKyAgICBlbnVtIE1vZGUgeworICAgICAgICBX cmFwRXhpc3RpbmdPYmplY3QsCisgICAgICAgIENyZWF0ZU5ld09iamVjdAorICAgIH07CisKKyAg ICBDb25zdHJ1Y3Rvck1vZGUoKQorICAgIHsKKyAgICAgICAgVjhQZXJJc29sYXRlRGF0YSogZGF0 YSA9IFY4UGVySXNvbGF0ZURhdGE6OmN1cnJlbnQoKTsKKyAgICAgICAgbV9wcmV2aW91cyA9IGRh dGEtPm1fY29uc3RydWN0b3JNb2RlOworICAgICAgICBkYXRhLT5tX2NvbnN0cnVjdG9yTW9kZSA9 IFdyYXBFeGlzdGluZ09iamVjdDsKKyAgICB9CisKKyAgICB+Q29uc3RydWN0b3JNb2RlKCkKKyAg ICB7CisgICAgICAgIFY4UGVySXNvbGF0ZURhdGEqIGRhdGEgPSBWOFBlcklzb2xhdGVEYXRhOjpj dXJyZW50KCk7CisgICAgICAgIGRhdGEtPm1fY29uc3RydWN0b3JNb2RlID0gbV9wcmV2aW91czsK KyAgICB9CisKKyAgICBzdGF0aWMgYm9vbCBjdXJyZW50KCkgeyByZXR1cm4gVjhQZXJJc29sYXRl RGF0YTo6Y3VycmVudCgpLT5tX2NvbnN0cnVjdG9yTW9kZTsgfQorCitwcml2YXRlOgorICAgIGJv b2wgbV9wcmV2aW91czsKK307CisKIGNsYXNzIFNhZmVBbGxvY2F0aW9uIHsKIHB1YmxpYzoKICAg ICBzdGF0aWMgaW5saW5lIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBuZXdJbnN0YW5jZSh2ODo6SGFu ZGxlPHY4OjpGdW5jdGlvbj4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhCaW5kaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaApp bmRleCBjYTNhZmI2NDliNjY2ZGUyYTRlZGIxMzk5MTU5NTY2OTQxOTE0OWVjLi43N2Q5NjFjNzBm YmQzYTg2OTczMWYyODkwNDMwYjQ1YTUyODg2ZGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuaApAQCAtMzIsMTkgKzMyLDE2IEBACiAjZGVmaW5lIFY4QmluZGluZ19oCiAK ICNpbmNsdWRlICJCaW5kaW5nU2VjdXJpdHkuaCIKLSNpbmNsdWRlICJET01EYXRhU3RvcmUuaCIK ICNpbmNsdWRlICJEb2N1bWVudC5oIgotI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCisjaW5j bHVkZSAiU2FmZUFsbG9jYXRpb24uaCIKICNpbmNsdWRlICJWOEJpbmRpbmdIZWxwZXJzLmgiCiAj aW5jbHVkZSAiVjhCaW5kaW5nTWFjcm9zLmgiCiAjaW5jbHVkZSAiVjhET01Db25maWd1cmF0aW9u LmgiCiAjaW5jbHVkZSAiVjhET01XcmFwcGVyLmgiCi0jaW5jbHVkZSAiVjhHQ0NvbnRyb2xsZXIu aCIKICNpbmNsdWRlICJWOEhpZGRlblByb3BlcnR5TmFtZS5oIgogI2luY2x1ZGUgIlY4UGVySXNv bGF0ZURhdGEuaCIKICNpbmNsdWRlICJWOFByb3h5LmgiCiAjaW5jbHVkZSAiVjhWYWx1ZUNhY2hl LmgiCi0jaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFi bGUuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9BdG9taWNTdHJpbmcuaD4KICNpbmNsdWRlIDx2OC5o PgpAQCAtNzgsMzIgKzc1LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBHQ0V2ZW50 TGlzdGVuZXJzIG1fbGlzdGVuZXJzOwogICAgIH07CiAKLSAgICBjbGFzcyBDb25zdHJ1Y3Rvck1v ZGUgewotICAgIHB1YmxpYzoKLSAgICAgICAgZW51bSBNb2RlIHsKLSAgICAgICAgICAgIFdyYXBF eGlzdGluZ09iamVjdCwKLSAgICAgICAgICAgIENyZWF0ZU5ld09iamVjdAotICAgICAgICB9Owot Ci0gICAgICAgIENvbnN0cnVjdG9yTW9kZSgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIFY4UGVy SXNvbGF0ZURhdGEqIGRhdGEgPSBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7Ci0gICAgICAg ICAgICBtX3ByZXZpb3VzID0gZGF0YS0+bV9jb25zdHJ1Y3Rvck1vZGU7Ci0gICAgICAgICAgICBk YXRhLT5tX2NvbnN0cnVjdG9yTW9kZSA9IFdyYXBFeGlzdGluZ09iamVjdDsKLSAgICAgICAgfQot Ci0gICAgICAgIH5Db25zdHJ1Y3Rvck1vZGUoKQotICAgICAgICB7Ci0gICAgICAgICAgICBWOFBl cklzb2xhdGVEYXRhKiBkYXRhID0gVjhQZXJJc29sYXRlRGF0YTo6Y3VycmVudCgpOwotICAgICAg ICAgICAgZGF0YS0+bV9jb25zdHJ1Y3Rvck1vZGUgPSBtX3ByZXZpb3VzOwotICAgICAgICB9Ci0K LSAgICAgICAgc3RhdGljIGJvb2wgY3VycmVudCgpIHsgcmV0dXJuIFY4UGVySXNvbGF0ZURhdGE6 OmN1cnJlbnQoKS0+bV9jb25zdHJ1Y3Rvck1vZGU7IH0KLQotICAgIHByaXZhdGU6Ci0gICAgICAg IGJvb2wgbV9wcmV2aW91czsKLSAgICB9OwotCiAgICAgLy8gU2luY2Ugdjg6Ok51bGwoaXNvbGF0 ZSkgY3Jhc2hlcyBpZiB3ZSBwYXNzIGEgbnVsbCBpc29sYXRlLAogICAgIC8vIHdlIG5lZWQgdG8g dXNlIHY4TnVsbFdpdGhDaGVjayhpc29sYXRlKSBpZiBhbiBpc29sYXRlIGNhbiBiZSBudWxsLgog ICAgIC8vCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFJlY3Vyc2lv blNjb3BlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFJlY3Vyc2lvblNjb3BlLmgK aW5kZXggNmU1ZjUzZjFkOWRmMTExOWQ0MGM5MjA0NzRmNzJmMzcyNDU2ODNhNy4uNzhiM2YyYjc1 ZDAyMWE5YjIxZmQyYmRlYTliMjhkZjBjMDZhMGYwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhSZWN1cnNpb25TY29wZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4UmVjdXJzaW9uU2NvcGUuaApAQCAtMzIsNyArMzIsNyBAQAogI2RlZmluZSBW OFJlY3Vyc2lvblNjb3BlX2gKIAogI2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIK LSNpbmNsdWRlICJWOEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOFBlcklzb2xhdGVEYXRhLmgiCiAj aW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK