93818 2012-08-13 04:05:44 -0700 [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h 2012-11-13 16:20:10 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 693519 0 haraken 2012-08-13 04:05:44 -0700 We can move the GCEventData class from V8Binding.h to ScriptGCEvent.h. 693524 1 157957 haraken 2012-08-13 04:09:00 -0700 Created attachment 157957 Patch 693797 2 157957 abarth 2012-08-13 10:32:46 -0700 Comment on attachment 157957 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157957&action=review > Source/WebCore/bindings/v8/ScriptGCEvent.h:58 > + GCEventData() : m_startTime(0.0), m_usedHeapSize(0) { } This should be split onto a bunch of lines. > Source/WebCore/bindings/v8/ScriptGCEvent.h:63 > + } Can you add blank lines between member functions that have multi-line bodies? 694381 3 haraken 2012-08-13 18:46:18 -0700 Committed r125494: <http://trac.webkit.org/changeset/125494> 157957 2012-08-13 04:09:00 -0700 2012-08-13 19:24:46 -0700 Patch bug-93818-20120813200828.patch text/plain 5923 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMzZjExMGM1YTc4Mzcx MmQ4NjQ4NTI2ODg2ZGNmMjc5ZTM5M2MyNy4uOTlkYzBjZTY2ZTdiMTE5ZjQ5ZjU1MWY4YTc2MmM4 Njk2NGQyMzE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA4LTEzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgR0NF dmVudERhdGEgY2xhc3MgZnJvbSBWOEJpbmRpbmcuaCB0byBTY3JpcHRHQ0V2ZW50LmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzODE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKDEpIFRoaXMgcGF0Y2gg bW92ZXMgR0NFdmVudERhdGEgY2xhc3MgZnJvbSBWOEJpbmRpbmcuaCB0byBTY3JpcHRHQ0V2ZW50 LmguCisgICAgICAgICgyKSBUaGlzIHBhdGNoIG1ha2VzIEdDRXZlbnREYXRhOjpzdGFydFRpbWUg YW5kIEdDRXZlbnREYXRhOjp1c2VkSGVhcFNpemUKKyAgICAgICAgcHJpdmF0ZSBtZW1iZXJzLgor ICAgICAgICAoMykgVGhpcyBwYXRjaCByZW1vdmVzIHVudXNlZCBmb3J3YXJkIGRlY2xhcmF0aW9u cyBmcm9tIFY4QmluZGluZy5oLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRHQ0V2ZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNjcmlwdEdDRXZlbnQ6OmdjUHJvbG9ndWVDYWxsYmFjayk6CisgICAgICAg IChXZWJDb3JlOjpTY3JpcHRHQ0V2ZW50OjpnY0VwaWxvZ3VlQ2FsbGJhY2spOgorICAgICAgICAq IGJpbmRpbmdzL3Y4L1NjcmlwdEdDRXZlbnQuaDoKKyAgICAgICAgKEdDRXZlbnREYXRhKToKKyAg ICAgICAgKFdlYkNvcmU6OkdDRXZlbnREYXRhOjpHQ0V2ZW50RGF0YSk6CisgICAgICAgIChXZWJD b3JlOjpHQ0V2ZW50RGF0YTo6Y2xlYXIpOgorICAgICAgICAoV2ViQ29yZTo6R0NFdmVudERhdGE6 Omxpc3RlbmVycyk6CisgICAgICAgIChXZWJDb3JlOjpHQ0V2ZW50RGF0YTo6c3RhcnRUaW1lKToK KyAgICAgICAgKFdlYkNvcmU6OkdDRXZlbnREYXRhOjpzZXRTdGFydFRpbWUpOgorICAgICAgICAo V2ViQ29yZTo6R0NFdmVudERhdGE6OnVzZWRIZWFwU2l6ZSk6CisgICAgICAgIChXZWJDb3JlOjpH Q0V2ZW50RGF0YTo6c2V0VXNlZEhlYXBTaXplKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAg ICogYmluZGluZ3MvdjgvVjhQZXJJc29sYXRlRGF0YS5jcHA6CisKIDIwMTItMDgtMTIgIFByYXZp biBEICA8cHJhdmluZC4yazRAZ21haWwuY29tPgogCiAgICAgICAgIHRhYmxlIGNlbGwuY2VsbElu ZGV4IHNob3VsZCByZXR1cm4gLTEgaWYgdGhlcmUgaXMgbm8gcGFyZW50IHRhYmxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRHQ0V2ZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEdDRXZlbnQuY3BwCmluZGV4IGZjMTNhN2U5MzE5 MWNhMjA1YjU0OTQ2ZGUwYWIxMDFjNmEzNWQ3NGEuLmMxODIyN2RlNWQ1YjMxMWY1MzE3ZmU5M2My MGM3MGIzZjIxZDA3MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nj cmlwdEdDRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEdD RXZlbnQuY3BwCkBAIC05MCwyMSArOTAsMjEgQEAgc2l6ZV90IFNjcmlwdEdDRXZlbnQ6OmdldFVz ZWRIZWFwU2l6ZSgpCiB2b2lkIFNjcmlwdEdDRXZlbnQ6OmdjUHJvbG9ndWVDYWxsYmFjayh2ODo6 R0NUeXBlIHR5cGUsIHY4OjpHQ0NhbGxiYWNrRmxhZ3MgZmxhZ3MpCiB7CiAgICAgR0NFdmVudERh dGEqIGdjRXZlbnREYXRhID0gaXNvbGF0ZUdDRXZlbnREYXRhKCk7Ci0gICAgZ2NFdmVudERhdGEt PnN0YXJ0VGltZSA9IFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCk7Ci0gICAgZ2NF dmVudERhdGEtPnVzZWRIZWFwU2l6ZSA9IGdldFVzZWRIZWFwU2l6ZSgpOworICAgIGdjRXZlbnRE YXRhLT5zZXRTdGFydFRpbWUoV1RGOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSk7Cisg ICAgZ2NFdmVudERhdGEtPnNldFVzZWRIZWFwU2l6ZShnZXRVc2VkSGVhcFNpemUoKSk7CiB9CiAK IHZvaWQgU2NyaXB0R0NFdmVudDo6Z2NFcGlsb2d1ZUNhbGxiYWNrKHY4OjpHQ1R5cGUgdHlwZSwg djg6OkdDQ2FsbGJhY2tGbGFncyBmbGFncykKIHsKICAgICBHQ0V2ZW50RGF0YSogZ2NFdmVudERh dGEgPSBpc29sYXRlR0NFdmVudERhdGEoKTsKLSAgICBpZiAoIWdjRXZlbnREYXRhLT51c2VkSGVh cFNpemUpCisgICAgaWYgKCFnY0V2ZW50RGF0YS0+dXNlZEhlYXBTaXplKCkpCiAgICAgICAgIHJl dHVybjsKICAgICBkb3VibGUgZW5kVGltZSA9IFdURjo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdU aW1lKCk7CiAgICAgc2l6ZV90IHVzZWRIZWFwU2l6ZSA9IGdldFVzZWRIZWFwU2l6ZSgpOwotICAg IHNpemVfdCBjb2xsZWN0ZWRCeXRlcyA9IHVzZWRIZWFwU2l6ZSA+IGdjRXZlbnREYXRhLT51c2Vk SGVhcFNpemUgPyAwIDogZ2NFdmVudERhdGEtPnVzZWRIZWFwU2l6ZSAtIHVzZWRIZWFwU2l6ZTsK KyAgICBzaXplX3QgY29sbGVjdGVkQnl0ZXMgPSB1c2VkSGVhcFNpemUgPiBnY0V2ZW50RGF0YS0+ dXNlZEhlYXBTaXplKCkgPyAwIDogZ2NFdmVudERhdGEtPnVzZWRIZWFwU2l6ZSgpIC0gdXNlZEhl YXBTaXplOwogICAgIEdDRXZlbnREYXRhOjpHQ0V2ZW50TGlzdGVuZXJzJiBsaXN0ZW5lcnMgPSBn Y0V2ZW50RGF0YS0+bGlzdGVuZXJzKCk7CiAgICAgZm9yIChHQ0V2ZW50RGF0YTo6R0NFdmVudExp c3RlbmVyczo6aXRlcmF0b3IgaSA9IGxpc3RlbmVycy5iZWdpbigpOyBpICE9IGxpc3RlbmVycy5l bmQoKTsgKytpKQotICAgICAgICAoKmkpLT5kaWRHQyhnY0V2ZW50RGF0YS0+c3RhcnRUaW1lLCBl bmRUaW1lLCBjb2xsZWN0ZWRCeXRlcyk7CisgICAgICAgICgqaSktPmRpZEdDKGdjRXZlbnREYXRh LT5zdGFydFRpbWUoKSwgZW5kVGltZSwgY29sbGVjdGVkQnl0ZXMpOwogICAgIGdjRXZlbnREYXRh LT5jbGVhcigpOwogfQogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0R0NFdmVudC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0R0NF dmVudC5oCmluZGV4IDNiNjI0NjM1Njk3ZWFjMGE0MmM5YjE4YTEzNWY5MjJlNTI1ZDcxMjUuLmYx ZjM2MWNiNWEyYmEwMjZkYmQ5MjQ4ZTI0M2Q5NzYwNWUxZDQ0NmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdEdDRXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRHQ0V2ZW50LmgKQEAgLTQ5LDEwICs0OSwzMyBAQCBzdHJ1Y3Qg SGVhcEluZm8gewogICAgIHNpemVfdCBqc0hlYXBTaXplTGltaXQ7CiB9OwogCi0jaWYgRU5BQkxF KElOU1BFQ1RPUikKLQogY2xhc3MgU2NyaXB0R0NFdmVudExpc3RlbmVyOwogCitjbGFzcyBHQ0V2 ZW50RGF0YSB7CitwdWJsaWM6CisgICAgdHlwZWRlZiBWZWN0b3I8U2NyaXB0R0NFdmVudExpc3Rl bmVyKj4gR0NFdmVudExpc3RlbmVyczsKKworICAgIEdDRXZlbnREYXRhKCkgOiBtX3N0YXJ0VGlt ZSgwLjApLCBtX3VzZWRIZWFwU2l6ZSgwKSB7IH0KKyAgICB2b2lkIGNsZWFyKCkKKyAgICB7Cisg ICAgICAgIG1fc3RhcnRUaW1lID0gMC4wOworICAgICAgICBtX3VzZWRIZWFwU2l6ZSA9IDA7Cisg ICAgfQorICAgIEdDRXZlbnRMaXN0ZW5lcnMmIGxpc3RlbmVycygpIHsgcmV0dXJuIG1fbGlzdGVu ZXJzOyB9CisKKyAgICBkb3VibGUgc3RhcnRUaW1lKCkgeyByZXR1cm4gbV9zdGFydFRpbWU7IH0K KyAgICB2b2lkIHNldFN0YXJ0VGltZShkb3VibGUgc3RhcnRUaW1lKSB7IG1fc3RhcnRUaW1lID0g c3RhcnRUaW1lOyB9CisgICAgc2l6ZV90IHVzZWRIZWFwU2l6ZSgpIHsgcmV0dXJuIG1fdXNlZEhl YXBTaXplOyB9CisgICAgdm9pZCBzZXRVc2VkSGVhcFNpemUoc2l6ZV90IHVzZWRIZWFwU2l6ZSkg eyBtX3VzZWRIZWFwU2l6ZSA9IHVzZWRIZWFwU2l6ZTsgfQorCitwcml2YXRlOgorICAgIGRvdWJs ZSBtX3N0YXJ0VGltZTsKKyAgICBzaXplX3QgbV91c2VkSGVhcFNpemU7CisgICAgR0NFdmVudExp c3RlbmVycyBtX2xpc3RlbmVyczsKK307CisKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQorCiBjbGFz cyBTY3JpcHRHQ0V2ZW50CiB7CiBwdWJsaWM6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Qmlu ZGluZy5oCmluZGV4IGNhM2FmYjY0OWI2NjZkZTJhNGVkYjEzOTkxNTk1NjY5NDE5MTQ5ZWMuLmJh MGJmNDRkOWEyOTQwNGU3ZWE5YzYzYWUzNDJjZTcxYTJjOGQxNDkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC01MiwzMSArNTIsNiBAQAogbmFtZXNwYWNlIFdlYkNv cmUgewogCiAgICAgY2xhc3MgRE9NU3RyaW5nTGlzdDsKLSAgICBjbGFzcyBFdmVudExpc3RlbmVy OwotICAgIGNsYXNzIEV2ZW50VGFyZ2V0OwotICAgIGNsYXNzIEV4dGVybmFsU3RyaW5nVmlzaXRv cjsKLSAgICBjbGFzcyBNZW1vcnlPYmplY3RJbmZvOwotICAgIGNsYXNzIFNjcmlwdEdDRXZlbnRM aXN0ZW5lcjsKLQotICAgIGNsYXNzIEdDRXZlbnREYXRhIHsKLSAgICBwdWJsaWM6Ci0gICAgICAg IHR5cGVkZWYgVmVjdG9yPFNjcmlwdEdDRXZlbnRMaXN0ZW5lcio+IEdDRXZlbnRMaXN0ZW5lcnM7 Ci0KLSAgICAgICAgR0NFdmVudERhdGEoKSA6IHN0YXJ0VGltZSgwLjApLCB1c2VkSGVhcFNpemUo MCkgeyB9Ci0gICAgICAgIHZvaWQgY2xlYXIoKQotICAgICAgICB7Ci0gICAgICAgICAgICBzdGFy dFRpbWUgPSAwLjA7Ci0gICAgICAgICAgICB1c2VkSGVhcFNpemUgPSAwOwotICAgICAgICB9Ci0g ICAgICAgIEdDRXZlbnRMaXN0ZW5lcnMmIGxpc3RlbmVycygpIHsgcmV0dXJuIG1fbGlzdGVuZXJz OyB9Ci0KLSAgICAgICAgLy8gRklYTUU6IE1ha2UgdGhlc2UgbWVtYmVycyBwcml2YXRlLgotICAg ICAgICBkb3VibGUgc3RhcnRUaW1lOwotICAgICAgICBzaXplX3QgdXNlZEhlYXBTaXplOwotCi0g ICAgcHJpdmF0ZToKLSAgICAgICAgR0NFdmVudExpc3RlbmVycyBtX2xpc3RlbmVyczsKLSAgICB9 OwogCiAgICAgY2xhc3MgQ29uc3RydWN0b3JNb2RlIHsKICAgICBwdWJsaWM6CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlcklzb2xhdGVEYXRhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVySXNvbGF0ZURhdGEuY3BwCmluZGV4IGI1NzAyNmE2 NmRmOGQ4ZTJjN2ZkY2RiYzI3NmY3ZWY0YzNlOGI3MzAuLjgwNTZkMzljNWFiNTBlMjdkMTM2YWY3 MDg1MDU2YjY2MjRmZmMzODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4UGVySXNvbGF0ZURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UGVySXNvbGF0ZURhdGEuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiVjhQZXJJc29sYXRlRGF0YS5oIgogCisjaW5jbHVkZSAiU2NyaXB0R0NFdmVu dC5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==