93730 2012-08-10 11:34:28 -0700 Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle 2012-08-12 17:14:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan cmarcelo eric jchaffraix kling koivisto macpherson menard tony webkit.review.bot oldest_to_newest 692725 0 ojan 2012-08-10 11:34:28 -0700 Remove unnecessary null checks from pseudoStyleForElement and adjustRenderStyle 692728 1 157770 ojan 2012-08-10 11:35:40 -0700 Created attachment 157770 Patch 693342 2 157770 webkit.review.bot 2012-08-12 17:14:39 -0700 Comment on attachment 157770 Patch Clearing flags on attachment: 157770 Committed r125384: <http://trac.webkit.org/changeset/125384> 693343 3 webkit.review.bot 2012-08-12 17:14:43 -0700 All reviewed patches have been landed. Closing bug. 157770 2012-08-10 11:35:40 -0700 2012-08-12 17:14:38 -0700 Patch bug-93730-20120810113512.patch text/plain 3476 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk1MzU3M2M1ZjY3MGJh ZDY3OGRhN2I3MzdiZDhkMDBiMmRhNTU0ZC4uNjg3ZDdhY2YxNjI5MjUzYjdjMzI0MGYzYmRhNDky OGZmNWFmMjhhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA4LTEwICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5 IG51bGwgY2hlY2tzIGZyb20gcHNldWRvU3R5bGVGb3JFbGVtZW50IGFuZCBhZGp1c3RSZW5kZXJT dHlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM3 MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwg dGhlIGNhbGxlcnMgb2YgYm90aCBtZXRob2RzIG1ha2Ugc3VyZSB0byBwYXNzIGluIGEgbm9uLW51 bGwgcGFyZW50U3R5bGUuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAg ICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVy Lmg6CisKKzIwMTItMDgtMTAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKwogICAg ICAgICBXcmFwIElOTElORV9GTEVYIGluIGEgI2lmIEVOQUJMRShDU1MzX0ZMRVhCT1gpLgogICAg ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCmluZGV4IGJjYzhjMWY5YzRhZWY2NDNkZDdkZDI4NDJkNjVkMTBkODNjZGUwNzEuLmI2NDJm M2NiMjIxNWYyOWQ2NjJiZWQ1YjQzNGZiYjgxMTA1NGVlMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSZXNvbHZlci5jcHAKQEAgLTE5MDcsNiArMTkwNyw3IEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6 a2V5ZnJhbWVTdHlsZXNGb3JBbmltYXRpb24oRWxlbWVudCogZSwgY29uc3QgUmVuZGVyU3R5bGUq IGVsCiAKIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IFN0eWxlUmVzb2x2ZXI6OnBzZXVkb1N0eWxl Rm9yRWxlbWVudChQc2V1ZG9JZCBwc2V1ZG8sIEVsZW1lbnQqIGUsIFJlbmRlclN0eWxlKiBwYXJl bnRTdHlsZSkKIHsKKyAgICBBU1NFUlQobV9wYXJlbnRTdHlsZSk7CiAgICAgaWYgKCFlKQogICAg ICAgICByZXR1cm4gMDsKIApAQCAtMTkxNCw5ICsxOTE1LDcgQEAgUGFzc1JlZlB0cjxSZW5kZXJT dHlsZT4gU3R5bGVSZXNvbHZlcjo6cHNldWRvU3R5bGVGb3JFbGVtZW50KFBzZXVkb0lkIHBzZXVk bywgRWwKIAogICAgIGluaXRGb3JTdHlsZVJlc29sdmUoZSwgcGFyZW50U3R5bGUsIHBzZXVkbyk7 CiAgICAgbV9zdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsKLQotICAgIGlmIChtX3BhcmVu dFN0eWxlKQotICAgICAgICBtX3N0eWxlLT5pbmhlcml0RnJvbShtX3BhcmVudFN0eWxlKTsKKyAg ICBtX3N0eWxlLT5pbmhlcml0RnJvbShtX3BhcmVudFN0eWxlKTsKIAogICAgIC8vIFNpbmNlIHdl IGRvbid0IHVzZSBwc2V1ZG8tZWxlbWVudHMgaW4gYW55IG9mIG91ciBxdWlyay9wcmludCB1c2Vy IGFnZW50IHJ1bGVzLCBkb24ndCB3YXN0ZSB0aW1lIHdhbGtpbmcKICAgICAvLyB0aG9zZSBydWxl cy4KQEAgLTIwNjksNiArMjA2OCw4IEBAIHN0YXRpYyBib29sIGRvZXNOb3RJbmhlcml0VGV4dERl Y29yYXRpb24oUmVuZGVyU3R5bGUqIHN0eWxlLCBFbGVtZW50KiBlKQogCiB2b2lkIFN0eWxlUmVz b2x2ZXI6OmFkanVzdFJlbmRlclN0eWxlKFJlbmRlclN0eWxlKiBzdHlsZSwgUmVuZGVyU3R5bGUq IHBhcmVudFN0eWxlLCBFbGVtZW50ICplKQogeworICAgIEFTU0VSVChwYXJlbnRTdHlsZSk7CisK ICAgICAvLyBDYWNoZSBvdXIgb3JpZ2luYWwgZGlzcGxheS4KICAgICBzdHlsZS0+c2V0T3JpZ2lu YWxEaXNwbGF5KHN0eWxlLT5kaXNwbGF5KCkpOwogCkBAIC0yMTI4LDcgKzIxMjksNyBAQCB2b2lk IFN0eWxlUmVzb2x2ZXI6OmFkanVzdFJlbmRlclN0eWxlKFJlbmRlclN0eWxlKiBzdHlsZSwgUmVu ZGVyU3R5bGUqIHBhcmVudFN0eQogCiAgICAgICAgIC8vIEZJWE1FOiBEb24ndCBzdXBwb3J0IHRo aXMgbXV0YXRpb24gZm9yIHBzZXVkbyBzdHlsZXMgbGlrZSBmaXJzdC1sZXR0ZXIgb3IgZmlyc3Qt bGluZSwgc2luY2UgaXQncyBub3QgY29tcGxldGVseQogICAgICAgICAvLyBjbGVhciBob3cgdGhh dCBzaG91bGQgd29yay4KLSAgICAgICAgaWYgKHN0eWxlLT5kaXNwbGF5KCkgPT0gSU5MSU5FICYm IHN0eWxlLT5zdHlsZVR5cGUoKSA9PSBOT1BTRVVETyAmJiBwYXJlbnRTdHlsZSAmJiBzdHlsZS0+ d3JpdGluZ01vZGUoKSAhPSBwYXJlbnRTdHlsZS0+d3JpdGluZ01vZGUoKSkKKyAgICAgICAgaWYg KHN0eWxlLT5kaXNwbGF5KCkgPT0gSU5MSU5FICYmIHN0eWxlLT5zdHlsZVR5cGUoKSA9PSBOT1BT RVVETyAmJiBzdHlsZS0+d3JpdGluZ01vZGUoKSAhPSBwYXJlbnRTdHlsZS0+d3JpdGluZ01vZGUo KSkKICAgICAgICAgICAgIHN0eWxlLT5zZXREaXNwbGF5KElOTElORV9CTE9DSyk7CiAKICAgICAg ICAgLy8gQWZ0ZXIgcGVyZm9ybWluZyB0aGUgZGlzcGxheSBtdXRhdGlvbiwgY2hlY2sgdGFibGUg cm93cy4gV2UgZG8gbm90IGhvbm9yIHBvc2l0aW9uOnJlbGF0aXZlIG9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuaAppbmRleCA0NmY5MDlhZDI3ZWRiMTBjZDJmNDZmOTlkM2I2NzQ3MmIzZTU0 YTE5Li40ZTlmZTkxNDhkZTI1NjdhYmJlY2JkMTgzYjEyM2JjZTZjODg1OTIwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVJlc29sdmVyLmgKQEAgLTE0MSw3ICsxNDEsNyBAQCBwdWJsaWM6CiAKICAgICB2 b2lkIGtleWZyYW1lU3R5bGVzRm9yQW5pbWF0aW9uKEVsZW1lbnQqLCBjb25zdCBSZW5kZXJTdHls ZSosIEtleWZyYW1lTGlzdCYpOwogCi0gICAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gcHNldWRv U3R5bGVGb3JFbGVtZW50KFBzZXVkb0lkLCBFbGVtZW50KiwgUmVuZGVyU3R5bGUqIHBhcmVudFN0 eWxlID0gMCk7CisgICAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gcHNldWRvU3R5bGVGb3JFbGVt ZW50KFBzZXVkb0lkLCBFbGVtZW50KiwgUmVuZGVyU3R5bGUqIHBhcmVudFN0eWxlKTsKIAogICAg IFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IHN0eWxlRm9yUGFnZShpbnQgcGFnZUluZGV4KTsKIAo=