93503 2012-08-08 12:02:50 -0700 [WK2] Coding style violation was brought with r125031 2012-08-08 12:55:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov ap cdumez kenneth webkit.review.bot oldest_to_newest 690581 0 mikhail.pozdnyakov 2012-08-08 12:02:50 -0700 Coding style violation was brought with r125031. WKURLResponseCopyMimeType must be renamed to WKURLResponseCopyMIMEType 690590 1 157268 mikhail.pozdnyakov 2012-08-08 12:10:38 -0700 Created attachment 157268 patch 690595 2 157268 cdumez 2012-08-08 12:13:03 -0700 Comment on attachment 157268 patch LGTM. Thanks. 690634 3 157268 webkit.review.bot 2012-08-08 12:55:53 -0700 Comment on attachment 157268 patch Clearing flags on attachment: 157268 Committed r125076: <http://trac.webkit.org/changeset/125076> 690635 4 webkit.review.bot 2012-08-08 12:55:56 -0700 All reviewed patches have been landed. Closing bug. 157268 2012-08-08 12:10:38 -0700 2012-08-08 12:55:52 -0700 patch bug93503 text/plain 4868 mikhail.pozdnyakov Y29tbWl0IGQ4MTIyOTdhMjBhZDJiZTliOTI0MjU1M2I4ODJkZjcxODIxNDRjODQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEF1ZyA4IDIyOjA4OjE5IDIwMTIgKzAzMDAKCiAgICBidWc5MzUwMwoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRl eCA4M2M3MzlkLi41OGRkMWIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTItMDgt MDggIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAK KyAgICAgICAgW1dLMl0gQ29kaW5nIHN0eWxlIHZpb2xhdGlvbiB3YXMgYnJvdWdodCB3aXRoIHIx MjUwMzEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz NTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0tV UkxSZXNwb25zZUNvcHlNaW1lVHlwZSBpcyBjb3JyZWN0ZWQgdG8gV0tVUkxSZXNwb25zZUNvcHlN SU1FVHlwZS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS1VSTFJlc3BvbnNlLmNwcDoKKyAg ICAgICAgKFdLVVJMUmVzcG9uc2VDb3B5TUlNRVR5cGUpOgorICAgICAgICAqIFNoYXJlZC9BUEkv Yy9XS1VSTFJlc3BvbnNlLmg6CisKKzIwMTItMDgtMDggIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1p a2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKICAgICAgICAgW0VGTF0gRUZMIFdlYmtpdCBu ZWVkcyBhIGNsYXNzIHdyYXBwaW5nIGVpbmEgc3RyaW5nc2hhcmUKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjI5CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1VSTFJlc3BvbnNlLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9BUEkvYy9XS1VSTFJlc3BvbnNlLmNwcAppbmRleCAzY2VhOTVkLi5jZWZkMDdkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tVUkxSZXNwb25zZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLVVJMUmVzcG9uc2UuY3BwCkBAIC00 Miw3ICs0Miw3IEBAIFdLVVJMUmVmIFdLVVJMUmVzcG9uc2VDb3B5VVJMKFdLVVJMUmVzcG9uc2VS ZWYgcmVzcG9uc2VSZWYpCiAgICAgcmV0dXJuIHRvQ29waWVkVVJMQVBJKHRvSW1wbChyZXNwb25z ZVJlZiktPnJlc291cmNlUmVzcG9uc2UoKS51cmwoKSk7CiB9CiAKLVdLU3RyaW5nUmVmIFdLVVJM UmVzcG9uc2VDb3B5TWltZVR5cGUoV0tVUkxSZXNwb25zZVJlZiByZXNwb25zZVJlZikKK1dLU3Ry aW5nUmVmIFdLVVJMUmVzcG9uc2VDb3B5TUlNRVR5cGUoV0tVUkxSZXNwb25zZVJlZiByZXNwb25z ZVJlZikKIHsKICAgICByZXR1cm4gdG9Db3BpZWRBUEkodG9JbXBsKHJlc3BvbnNlUmVmKS0+cmVz b3VyY2VSZXNwb25zZSgpLm1pbWVUeXBlKCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL0FQSS9jL1dLVVJMUmVzcG9uc2UuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9B UEkvYy9XS1VSTFJlc3BvbnNlLmgKaW5kZXggYzg0MjYwMC4uODk4OGRmZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLVVJMUmVzcG9uc2UuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tVUkxSZXNwb25zZS5oCkBAIC0zNiw3ICszNiw3IEBAIFdL X0VYUE9SVCBXS1R5cGVJRCBXS1VSTFJlc3BvbnNlR2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9SVCBX S1VSTFJlZiBXS1VSTFJlc3BvbnNlQ29weVVSTChXS1VSTFJlc3BvbnNlUmVmKTsKIAotV0tfRVhQ T1JUIFdLU3RyaW5nUmVmIFdLVVJMUmVzcG9uc2VDb3B5TWltZVR5cGUoV0tVUkxSZXNwb25zZVJl Zik7CitXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tVUkxSZXNwb25zZUNvcHlNSU1FVHlwZShXS1VS TFJlc3BvbnNlUmVmKTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTAzYmU1MS4uZjM5YWQ1ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE5IEBACiAyMDEyLTA4LTA4ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFr b3ZAaW50ZWwuY29tPgogCisgICAgICAgIFtXSzJdIENvZGluZyBzdHlsZSB2aW9sYXRpb24gd2Fz IGJyb3VnaHQgd2l0aCByMTI1MDMxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MzUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdLVVJMUmVzcG9uc2VDb3B5TWltZVR5cGUgaXMgY29ycmVjdGVkIHRvIFdL VVJMUmVzcG9uc2VDb3B5TUlNRVR5cGUuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHA6CisgICAgICAgIChXVFI6OkluamVj dGVkQnVuZGxlUGFnZTo6ZGlkUmVjZWl2ZVJlc3BvbnNlRm9yUmVzb3VyY2UpOgorICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaDoK KyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRyb2xsZXI6OmR1bXBQcm9ncmVzc0ZpbmlzaGVk Q2FsbGJhY2spOiBSZW1vdmVkIHRyYWlsaW5nIHdoaXRlc3BhY2UgdGhhdCB3YXMgYnJvdWdodCB3 aXRoIHRoZSBzYW1lIHJldmlzaW9uLgorCisyMDEyLTA4LTA4ICBNaWtoYWlsIFBvemRueWFrb3Yg IDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCiAgICAgICAgIFtXSzJdIFtXVFJdIFBy b3ZpZGUgUmVzb3VyY2UgUmVzcG9uc2UgZHVtcGluZy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDU0CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcCBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcApp bmRleCA5N2Q0MjFlLi5kZTMyY2IwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3BwCkBAIC0xMDAw LDcgKzEwMDAsNyBAQCB2b2lkIEluamVjdGVkQnVuZGxlUGFnZTo6ZGlkUmVjZWl2ZVJlc3BvbnNl Rm9yUmVzb3VyY2UoV0tCdW5kbGVQYWdlUmVmLCBXS0J1bmRsZQogCiAgICAgV0tSZXRhaW5QdHI8 V0tVUkxSZWY+IHVybCA9IGFkb3B0V0soV0tVUkxSZXNwb25zZUNvcHlVUkwocmVzcG9uc2UpKTsK ICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gdXJsU3RyaW5nID0gYWRvcHRXSyhXS1VSTENv cHlMYXN0UGF0aENvbXBvbmVudCh1cmwuZ2V0KCkpKTsKLSAgICBXS1JldGFpblB0cjxXS1N0cmlu Z1JlZj4gbWltZVR5cGVTdHJpbmcgPSBhZG9wdFdLKFdLVVJMUmVzcG9uc2VDb3B5TWltZVR5cGUo cmVzcG9uc2UpKTsKKyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gbWltZVR5cGVTdHJpbmcg PSBhZG9wdFdLKFdLVVJMUmVzcG9uc2VDb3B5TUlNRVR5cGUocmVzcG9uc2UpKTsKIAogICAgIElu amVjdGVkQnVuZGxlOjpzaGFyZWQoKS5zdHJpbmdCdWlsZGVyKCktPmFwcGVuZCh0b1dURlN0cmlu Zyh1cmxTdHJpbmcpKTsKICAgICBJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkuc3RyaW5nQnVpbGRl cigpLT5hcHBlbmQoIiBoYXMgTUlNRSB0eXBlICIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCmlu ZGV4IDUxMzIwNTEuLjUxN2E1MTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmgKQEAgLTc4LDcg Kzc4LDcgQEAgcHVibGljOgogICAgIHZvaWQgZHVtcFRpdGxlQ2hhbmdlcygpIHsgbV9kdW1wVGl0 bGVDaGFuZ2VzID0gdHJ1ZTsgfQogICAgIHZvaWQgZHVtcEZ1bGxTY3JlZW5DYWxsYmFja3MoKSB7 IG1fZHVtcEZ1bGxTY3JlZW5DYWxsYmFja3MgPSB0cnVlOyB9CiAgICAgdm9pZCBkdW1wRnJhbWVM b2FkQ2FsbGJhY2tzKCkgeyBzZXRTaG91bGREdW1wRnJhbWVMb2FkQ2FsbGJhY2tzKHRydWUpOyB9 Ci0gICAgdm9pZCBkdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkgeyBzZXRTaG91bGREdW1w UHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKHRydWUpOyB9ICAgIAorICAgIHZvaWQgZHVtcFByb2dy ZXNzRmluaXNoZWRDYWxsYmFjaygpIHsgc2V0U2hvdWxkRHVtcFByb2dyZXNzRmluaXNoZWRDYWxs YmFjayh0cnVlKTsgfQogICAgIHZvaWQgZHVtcFJlc291cmNlUmVzcG9uc2VNSU1FVHlwZXMoKSB7 IG1fZHVtcFJlc291cmNlUmVzcG9uc2VNSU1FVHlwZXMgPSB0cnVlOyB9CiAKICAgICB2b2lkIHNl dFNob3VsZER1bXBGcmFtZUxvYWRDYWxsYmFja3MoYm9vbCB2YWx1ZSkgeyBtX2R1bXBGcmFtZUxv YWRDYWxsYmFja3MgPSB2YWx1ZTsgfQo=