93465 2012-08-08 05:02:25 -0700 Set m_isComplete to true in BitmapImage(NativeImagePtr, ImageObserver*). 2012-08-08 22:01:52 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified UNCONFIRMED P2 Normal --- 90375 0 dongseong.hwang webkit-unassigned hclam nick noam skyul webkit.review.bot oldest_to_newest 690165 0 dongseong.hwang 2012-08-08 05:02:25 -0700 This constructor creates a BitmapImage from a platform specific NativeImagePtr. It sets m_frame of the first frame to the given NativeImagePtr. The BitmapImage created does not need decoding because decoding is already done. So, it is proper to set m_isComplete to true. Currently, only OpenVG port sets m_isComplete to true. This change is needed for parallel image decoders. Currently, BitmapImage checks only m_frame in order to determine whether decoding is needed or not. But after parallel image decoders are landed, BitmapImage also needs to check m_isComplete. If m_isComplete is false, BitmapImage will try to decode again, and it can't actually decode because the BitmapImage created from a NativeImagePtr does not have encoded data. 690167 1 157185 dongseong.hwang 2012-08-08 05:04:37 -0700 Created attachment 157185 Patch 691137 2 hclam 2012-08-08 20:15:07 -0700 I suggest we take down the review flag at the moment. It is unclear why we need this because refactoring for ImageSource and BitmapImage hasn't landed yet. We'll also need test for this change. 691188 3 dongseong.hwang 2012-08-08 22:01:52 -0700 (In reply to comment #2) > I suggest we take down the review flag at the moment. It is unclear why we need this because refactoring for ImageSource and BitmapImage hasn't landed yet. We'll also need test for this change. I came close to turn on the review flag of parallel image decoders and RetainedModeBitmapImage. I agreed on you. 157185 2012-08-08 05:04:37 -0700 2012-08-08 21:56:52 -0700 Patch bug-93465-20120808210346.patch text/plain 4493 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRhNDVkODA0ZjkyYzg3 NmU3YzIyMjZiYTc4MWQ4ODdkZWMxOWIyZS4uZjVjYTRlYzY3MDA0YmM0YzljOTAwM2VhOGQ0ODhk OWRmMzMyMmI1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM3IEBACiAyMDEyLTA4LTA4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFNldCBtX2lz Q29tcGxldGUgdG8gdHJ1ZSBpbiBCaXRtYXBJbWFnZShOYXRpdmVJbWFnZVB0ciwgSW1hZ2VPYnNl cnZlciopLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTM0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGNvbnN0cnVjdG9yIGNyZWF0ZXMgYSBCaXRtYXBJbWFnZSBmcm9tIGEgcGxhdGZvcm0gc3Bl Y2lmaWMgTmF0aXZlSW1hZ2VQdHIuCisgICAgICAgIEl0IHNldHMgbV9mcmFtZSBvZiB0aGUgZmly c3QgZnJhbWUgdG8gdGhlIGdpdmVuIE5hdGl2ZUltYWdlUHRyLgorICAgICAgICBUaGUgQml0bWFw SW1hZ2UgY3JlYXRlZCBkb2VzIG5vdCBuZWVkIGRlY29kaW5nIGJlY2F1c2UgZGVjb2RpbmcgaXMg YWxyZWFkeSBkb25lLgorICAgICAgICBTbywgaXQgaXMgcHJvcGVyIHRvIHNldCBtX2lzQ29tcGxl dGUgdG8gdHJ1ZS4gQ3VycmVudGx5LCBvbmx5IE9wZW5WRworICAgICAgICBwb3J0IHNldHMgbV9p c0NvbXBsZXRlIHRvIHRydWUuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMgbmVlZGVkIGZvciBw YXJhbGxlbCBpbWFnZSBkZWNvZGVycy4gQ3VycmVudGx5LAorICAgICAgICBCaXRtYXBJbWFnZSBj aGVja3Mgb25seSBtX2ZyYW1lIGluIG9yZGVyIHRvIGRldGVybWluZSB3aGV0aGVyIGRlY29kaW5n CisgICAgICAgIGlzIG5lZWRlZCBvciBub3QuIEJ1dCBhZnRlciBwYXJhbGxlbCBpbWFnZSBkZWNv ZGVycyBhcmUgbGFuZGVkLAorICAgICAgICBCaXRtYXBJbWFnZSBhbHNvIG5lZWRzIHRvIGNoZWNr IG1faXNDb21wbGV0ZS4gSWYgbV9pc0NvbXBsZXRlIGlzIGZhbHNlLAorICAgICAgICBCaXRtYXBJ bWFnZSB3aWxsIHRyeSB0byBkZWNvZGUgYWdhaW4sIGFuZCBpdCBjYW4ndCBhY3R1YWxseSBkZWNv ZGUKKyAgICAgICAgYmVjYXVzZSB0aGUgQml0bWFwSW1hZ2UgY3JlYXRlZCBmcm9tIGEgTmF0aXZl SW1hZ2VQdHIgZG9lcyBub3QgaGF2ZQorICAgICAgICBlbmNvZGVkIGRhdGEuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBiZWhhdmlvciBpcyB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFnZUNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkJpdG1hcEltYWdlOjpCaXRtYXBJbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvSW1hZ2VDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6Qml0bWFwSW1h Z2UpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Qml0bWFwSW1hZ2U6OkJpdG1hcEltYWdlKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy93eC9JbWFnZVd4LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdl OjpCaXRtYXBJbWFnZSk6CisKKzIwMTItMDgtMDggIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFA Y29tcGFueTEwMC5uZXQ+CisKICAgICAgICAgUmVuYW1lIHR3byBtZXRob2RzIG9mIEltYWdlU291 cmNlIGluIG9yZGVyIHRvIGNsYXJpZnkgdGhlIGludGVudGlvbjogZnJhbWVEdXJhdGlvbkF0SW5k ZXgoKSBhbmQgZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgpLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM0NjQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQml0bWFwSW1hZ2VDYWlyby5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFnZUNhaXJvLmNwcApp bmRleCBlOWZhNWJlOGQyMWFjNTU4YjNlOTQ3YmU2ODFkNjI1ZWY0ODc4YTdmLi40NTg1MGE4MDNh YTRkMDBmYTY3MTA0Mjg3YWI3ZDUzOTk4M2M2OGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFnZUNhaXJvLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9CaXRtYXBJbWFnZUNhaXJvLmNwcApA QCAtNjgsNiArNjgsNyBAQCBCaXRtYXBJbWFnZTo6Qml0bWFwSW1hZ2UoTmF0aXZlSW1hZ2VDYWly byogbmF0aXZlSW1hZ2UsIEltYWdlT2JzZXJ2ZXIqIG9ic2VydmVyKQogICAgIG1fZnJhbWVzWzBd Lm1fZnJhbWUgPSBuYXRpdmVJbWFnZTsKICAgICBtX2ZyYW1lc1swXS5tX2hhc0FscGhhID0gY2Fp cm9fc3VyZmFjZV9nZXRfY29udGVudChzdXJmYWNlKSAhPSBDQUlST19DT05URU5UX0NPTE9SOwog ICAgIG1fZnJhbWVzWzBdLm1faGF2ZU1ldGFkYXRhID0gdHJ1ZTsKKyAgICBtX2ZyYW1lc1swXS5t X2lzQ29tcGxldGUgPSB0cnVlOwogICAgIGNoZWNrRm9yU29saWRDb2xvcigpOwogfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUNHLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCmluZGV4IDg4 YWRhYmZiZjVlNGEwMjdhZmVkYmRhMjBjYTY3OWViMzI2ZmMxYjguLmY1MzIwMzdkNTYxNDQ4NGEw NDk3ZDdmOTk3ZTg1YzIzY2Y4YzJiZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQ0cuY3BwCkBAIC0xMDAsNiArMTAwLDcgQEAgQml0bWFwSW1hZ2U6 OkJpdG1hcEltYWdlKENHSW1hZ2VSZWYgY2dJbWFnZSwgSW1hZ2VPYnNlcnZlciogb2JzZXJ2ZXIp CiAgICAgbV9mcmFtZXNbMF0ubV9mcmFtZSA9IGNnSW1hZ2U7CiAgICAgbV9mcmFtZXNbMF0ubV9o YXNBbHBoYSA9IHRydWU7CiAgICAgbV9mcmFtZXNbMF0ubV9oYXZlTWV0YWRhdGEgPSB0cnVlOwor ICAgIG1fZnJhbWVzWzBdLm1faXNDb21wbGV0ZSA9IHRydWU7CiAKICAgICBjaGVja0ZvclNvbGlk Q29sb3IoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ltYWdlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1h Z2VRdC5jcHAKaW5kZXggMTBmZTFmZWI2ZTg3ZjRmNmE2ODJjMmVlYzRlZTA3YzdlYmFmZDAzYS4u Nzg2NGU5ZjY4ZjY1YTc5MzM0ODZkODU1Y2Y1MmU1MGZiZTVmMGIxOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VRdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VRdC5jcHAKQEAgLTIyNiw2ICsyMjYs NyBAQCBCaXRtYXBJbWFnZTo6Qml0bWFwSW1hZ2UoUUltYWdlKiBpbWFnZSwgSW1hZ2VPYnNlcnZl ciogb2JzZXJ2ZXIpCiAgICAgbV9mcmFtZXNbMF0ubV9mcmFtZSA9IGltYWdlOwogICAgIG1fZnJh bWVzWzBdLm1faGFzQWxwaGEgPSBpbWFnZS0+aGFzQWxwaGFDaGFubmVsKCk7CiAgICAgbV9mcmFt ZXNbMF0ubV9oYXZlTWV0YWRhdGEgPSB0cnVlOworICAgIG1fZnJhbWVzWzBdLm1faXNDb21wbGV0 ZSA9IHRydWU7CiAgICAgY2hlY2tGb3JTb2xpZENvbG9yKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3d4L0ltYWdlV3guY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvSW1hZ2VXeC5jcHAKaW5kZXggNTRiYmRiYjhjMzJi ZTExNDc5NzNmZDExNzE0M2VhNGFhYTk3MDAxYS4uZDdkMGEwZjBkZGE3N2UzNDM4NjA0NTdlNGVh MjhjMjgwOTk3NzFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvd3gvSW1hZ2VXeC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d3gvSW1hZ2VXeC5jcHAKQEAgLTExNCw2ICsxMTQsNyBAQCBCaXRtYXBJbWFnZTo6Qml0bWFwSW1h Z2UoY29uc3Qgd3hCaXRtYXAmIGJpdG1hcCkKICAgICAgICAgbV9mcmFtZXMuZ3JvdygxKTsKICAg ICAgICAgbV9mcmFtZXNbMF0ubV9mcmFtZSA9IGdibXA7CiAgICAgICAgIG1fZnJhbWVzWzBdLm1f aGF2ZU1ldGFkYXRhID0gdHJ1ZTsKKyAgICAgICAgbV9mcmFtZXNbMF0ubV9pc0NvbXBsZXRlID0g dHJ1ZTsKICAgICAgICAgY2hlY2tGb3JTb2xpZENvbG9yKCk7CiAgICAgfQogfQo=