93462 2012-08-08 04:44:57 -0700 [Qt] Add unit test for QObject bindings for scriptable plugins 2022-02-27 23:54:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60842 1 hausmann hausmann oldest_to_newest 690153 0 hausmann 2012-08-08 04:44:57 -0700 [Qt] Add unit test for QObject bindings for scriptable plugins 690155 1 157182 hausmann 2012-08-08 04:48:01 -0700 Created attachment 157182 Patch 690166 2 157182 kenneth 2012-08-08 05:04:17 -0700 Comment on attachment 157182 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > + TestPluginWidget() > + { } why on separate line? > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > + int slotWithReturnValue() { return 42; } Lovely number :-) > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) why not webkit style? 690241 3 hausmann 2012-08-08 06:12:20 -0700 (In reply to comment #2) > (From update of attachment 157182 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157182&action=review > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2189 > > + TestPluginWidget() > > + { } > > why on separate line? OOps. > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2192 > > + int slotWithReturnValue() { return 42; } > > Lovely number :-) > > > Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp:2206 > > + virtual QObject *createPlugin(const QString &, const QUrl &, const QStringList &, const QStringList &) > > why not webkit style? Thanks, will fix these before landing. 690243 4 hausmann 2012-08-08 06:14:37 -0700 Committed r125029: <http://trac.webkit.org/changeset/125029> 157182 2012-08-08 04:48:01 -0700 2022-02-27 23:54:10 -0800 Patch bug-93462-20120808134834.patch text/plain 3125 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU0OGFmMGRlZTU5 NTMyN2RiNjZmYjM0MzU5Yzg1Zjc2NjFiZjA2MGUuLjNkMTdjMjE4MTIzMDM5MWVmODk3Yzk0NzVh N2NkM2I0MmE3MzljNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTItMDgt MDggIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCisgICAgICAg IFtRdF0gQWRkIHVuaXQgdGVzdCBmb3IgUU9iamVjdCBiaW5kaW5ncyBmb3Igc2NyaXB0YWJsZSBw bHVnaW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MzQ2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBiaW5kaW5ncyBjb2RlIGlzIHN1YmplY3QgdG8gcmVmYWN0b3JpbmcgaW4gdGhlIGZ1dHVyZSwg c28gYWRkZWQgYSB1bml0IHRlc3QgdG8gdmVyaWZ5IHRoYXQKKyAgICAgICAgYWNjZXNzaW5nIGFu IGVtYmVkZGVkIFFXaWRnZXQgZnJvbSBKYXZhU2NyaXB0IGdvZXMgdGhyb3VnaCB0aGUgUU9iamVj dCBiaW5kaW5ncy4KKworICAgICAgICAqIHRlc3RzL3FvYmplY3RicmlkZ2UvdHN0X3FvYmplY3Ri cmlkZ2UuY3BwOgorICAgICAgICAodHN0X1FPYmplY3RCcmlkZ2UpOgorICAgICAgICAoVGVzdFBs dWdpbldpZGdldCk6CisgICAgICAgIChUZXN0UGx1Z2luV2lkZ2V0OjpUZXN0UGx1Z2luV2lkZ2V0 KToKKyAgICAgICAgKFRlc3RQbHVnaW5XaWRnZXQ6OnNsb3RXaXRoUmV0dXJuVmFsdWUpOgorICAg ICAgICAoVGVzdFdlYlBhZ2UpOgorICAgICAgICAoVGVzdFdlYlBhZ2U6OlRlc3RXZWJQYWdlKToK KyAgICAgICAgKFRlc3RXZWJQYWdlOjpjcmVhdGVQbHVnaW4pOgorICAgICAgICAodHN0X1FPYmpl Y3RCcmlkZ2U6OnNjcmlwdGFibGVQbHVnaW4pOgorCiAyMDEyLTA4LTA3ICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHRyaXZp YWwgZml4OiBNaXNzZWQgSEFWRV9RVDUgcmVtb3ZhbCBhcyBwYXJ0IG9mIHIxMjQ4NzkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcW9iamVjdGJyaWRnZS90c3RfcW9iamVjdGJy aWRnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FvYmplY3RicmlkZ2UvdHN0X3FvYmpl Y3RicmlkZ2UuY3BwCmluZGV4IGJhNWUyNmM0ZjQ4MzlmYTgzMmM4OGY3Nzg4ZmVhNzM2ZTBiMDVi YTguLmM5NDVkZjYzYTYzZDc2MDc5ODFlZjAwNzM1YjFiOTMyZWUzOTQ1NTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcW9iamVjdGJyaWRnZS90c3RfcW9iamVjdGJyaWRnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xb2JqZWN0YnJpZGdlL3RzdF9xb2JqZWN0 YnJpZGdlLmNwcApAQCAtNjUyLDYgKzY1Miw3IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBx T2JqZWN0V3JhcHBlcldpdGhTYW1lSWRlbnRpdHkoKTsKICAgICB2b2lkIGludHJvc3BlY3RRdE1l dGhvZHNfZGF0YSgpOwogICAgIHZvaWQgaW50cm9zcGVjdFF0TWV0aG9kcygpOworICAgIHZvaWQg c2NyaXB0YWJsZVBsdWdpbigpOwogCiBwcml2YXRlOgogICAgIFFTdHJpbmcgZXZhbEpTKGNvbnN0 IFFTdHJpbmcmIHMpCkBAIC0yMTgxLDUgKzIxODIsNDggQEAgdm9pZCB0c3RfUU9iamVjdEJyaWRn ZTo6d2ViRWxlbWVudFNsb3RPbmx5KCkKICAgICBRQ09NUEFSRShldmFsSlMoIm15V2ViRWxlbWVu dFNsb3RPYmplY3QudGFnTmFtZSIpLCBRU3RyaW5nKCJCT0RZIikpOwogfQogCitjbGFzcyBUZXN0 UGx1Z2luV2lkZ2V0IDogcHVibGljIFFXaWRnZXQgeworICAgIFFfT0JKRUNUCitwdWJsaWM6Cisg ICAgVGVzdFBsdWdpbldpZGdldCgpCisgICAgeyB9CisKK3B1YmxpYyBzbG90czoKKyAgICBpbnQg c2xvdFdpdGhSZXR1cm5WYWx1ZSgpIHsgcmV0dXJuIDQyOyB9Cit9OworCitjbGFzcyBUZXN0V2Vi UGFnZSA6IHB1YmxpYyBRV2ViUGFnZSB7CisgICAgUV9PQkpFQ1QKK3B1YmxpYzoKKyAgICBUZXN0 V2ViUGFnZShRT2JqZWN0KiBwYXJlbnQgPSAwKQorICAgICAgICA6IFFXZWJQYWdlKHBhcmVudCkK KyAgICAgICAgLCBjcmVhdGlvbkNvdW50KDApCisgICAgeyB9CisKKyAgICBpbnQgY3JlYXRpb25D b3VudDsKKworcHJvdGVjdGVkOgorICAgIHZpcnR1YWwgUU9iamVjdCAqY3JlYXRlUGx1Z2luKGNv bnN0IFFTdHJpbmcgJiwgY29uc3QgUVVybCAmLCBjb25zdCBRU3RyaW5nTGlzdCAmLCBjb25zdCBR U3RyaW5nTGlzdCAmKQorICAgIHsKKyAgICAgICAgY3JlYXRpb25Db3VudCsrOworICAgICAgICBy ZXR1cm4gbmV3IFRlc3RQbHVnaW5XaWRnZXQ7CisgICAgfQorfTsKKwordm9pZCB0c3RfUU9iamVj dEJyaWRnZTo6c2NyaXB0YWJsZVBsdWdpbigpCit7CisgICAgUVdlYlZpZXcgdmlldzsKKyAgICBU ZXN0V2ViUGFnZSogcGFnZSA9IG5ldyBUZXN0V2ViUGFnZTsKKyAgICB2aWV3LnNldFBhZ2UocGFn ZSk7CisgICAgcGFnZS0+c2V0UGFyZW50KCZ2aWV3KTsKKyAgICB2aWV3LnNldHRpbmdzKCktPnNl dEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OlBsdWdpbnNFbmFibGVkLCB0cnVlKTsKKworICAgIHBh Z2UtPm1haW5GcmFtZSgpLT5zZXRIdG1sKCI8b2JqZWN0IHdpZHRoPTEwMCBoZWlnaHQ9MTAwIHR5 cGU9XCJhcHBsaWNhdGlvbi94LXF0LXBsdWdpblwiPjwvb2JqZWN0PiIpOworICAgIFFDT01QQVJF KHBhZ2UtPmNyZWF0aW9uQ291bnQsIDEpOworCisgICAgUVZhcmlhbnQgcmVzdWx0ID0gcGFnZS0+ bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgiZG9jdW1lbnQucXVlcnlTZWxlY3Rvcihc Im9iamVjdFwiKS5zbG90V2l0aFJldHVyblZhbHVlKCkiKTsKKyAgICBRQ09NUEFSRShyZXN1bHQu dG9TdHJpbmcoKSwgUUxhdGluMVN0cmluZygiNDIiKSk7Cit9CisKIFFURVNUX01BSU4odHN0X1FP YmplY3RCcmlkZ2UpCiAjaW5jbHVkZSAidHN0X3FvYmplY3RicmlkZ2UubW9jIgo=