93452 2012-08-08 01:47:41 -0700 EventDispatcher::dispatchSimulatedClick should not reuse the same EventDispatcher instance. 2012-08-08 18:11:54 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91290 1 hayato hayato dglazkov dominicc morrita shinyak webkit.review.bot oldest_to_newest 690056 0 hayato 2012-08-08 01:47:41 -0700 This is a follow up issue after https://bugs.webkit.org/show_bug.cgi?id=93322. There is yet another place where the same EventDispatcher instance is reused across event dispatching. In addition to that, in order to simulate a real click, we must use the different dispatchers because we must recalculate event ancestors each time. Current implementation wrongly freezes event ancestors at the first event dispatch. 690060 1 157153 hayato 2012-08-08 01:55:03 -0700 Created attachment 157153 fix simulatedClick 691042 2 157153 webkit.review.bot 2012-08-08 18:11:51 -0700 Comment on attachment 157153 fix simulatedClick Clearing flags on attachment: 157153 Committed r125133: <http://trac.webkit.org/changeset/125133> 691043 3 webkit.review.bot 2012-08-08 18:11:54 -0700 All reviewed patches have been landed. Closing bug. 157153 2012-08-08 01:55:03 -0700 2012-08-08 18:11:50 -0700 fix simulatedClick bug-93452-20120808175437.patch text/plain 4440 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY2N2FiMTI1NmE0MjQw M2E0NjA0N2U1MmJlNmE2MThjMzUyNGFiMS4uMmQ0YjQzOTU5ZjRlYjc2YjQ3MWJlNDEyZDk5MDE1 ZGJjYmQ2MTUyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA4LTA4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBFdmVudERpc3BhdGNoZXI6 OmRpc3BhdGNoU2ltdWxhdGVkQ2xpY2sgc2hvdWxkIG5vdCByZXVzZSB0aGUgc2FtZSBFdmVudERp c3BhdGNoZXIgaW5zdGFuY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzQ1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgaXMgYSBmb2xsb3cgdXAgcGF0Y2ggYWZ0ZXIgcjEyNDk3NS4gIFRoZXJl IGlzIHlldCBhbm90aGVyCisgICAgICAgIHBsYWNlIHdoZXJlIHRoZSBzYW1lIEV2ZW50RGlzcGF0 Y2hlciBpbnN0YW5jZSBpcyByZXVzZWQgYWNyb3NzCisgICAgICAgIGV2ZW50IGRpc3BhdGNoaW5n LgorCisgICAgICAgIEluIGFkZGl0aW9uIHRvIHRoYXQsIGluIG9yZGVyIHRvIHNpbXVsYXRlIGEg cmVhbCBjbGljaywgd2UgbXVzdAorICAgICAgICBkaWZmZXJlbnQgZGlzcGF0Y2hlcnMgYmVjYXVz ZSB3ZSBtdXN0IHJlY2FsY3VsYXRlIGV2ZW50IGFuY2VzdG9ycworICAgICAgICBlYWNoIHRpbWUu ICBDdXJyZW50IGltcGxlbWVudGF0aW9uIHdyb25nbHkgZnJlZXplcyBldmVudCBhbmNlc3RvcnMK KyAgICAgICAgYXQgdGhlIGZpcnN0IGV2ZW50IGRpc3BhdGNoaW5nLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBkb20vRXZl bnREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlz cGF0Y2hTaW11bGF0ZWRDbGljayk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudERpc3BhdGNoZXI6 OkV2ZW50RGlzcGF0Y2hlcik6CisgICAgICAgIChXZWJDb3JlOjpFdmVudERpc3BhdGNoZXI6OmRp c3BhdGNoRXZlbnQpOgorICAgICAgICAqIGRvbS9FdmVudERpc3BhdGNoZXIuaDoKKyAgICAgICAg KEV2ZW50RGlzcGF0Y2hlcik6CisKIDIwMTItMDgtMDcgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyNDk3NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNw YXRjaGVyLmNwcAppbmRleCBkNjJjNWYzNWVkZWFjNGY4MmYxNmVjZmRjMTM1NDYxNjRiNTZlYzkz Li5lMWE2MGYzZDQwYjNhMjk1Zjk3ZmE4MWU2OTBmY2FkZDc1Mjg0Y2I0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMTYzLDggKzE2Myw2IEBAIHZvaWQgRXZlbnRE aXNwYXRjaGVyOjpkaXNwYXRjaFNpbXVsYXRlZENsaWNrKE5vZGUqIG5vZGUsIFBhc3NSZWZQdHI8 RXZlbnQ+IHVuZGVyCiAgICAgaWYgKG5vZGUtPmRpc2FibGVkKCkpCiAgICAgICAgIHJldHVybjsK IAotICAgIEV2ZW50RGlzcGF0Y2hlciBkaXNwYXRjaGVyKG5vZGUpOwotCiAgICAgaWYgKCFnTm9k ZXNEaXNwYXRjaGluZ1NpbXVsYXRlZENsaWNrcykKICAgICAgICAgZ05vZGVzRGlzcGF0Y2hpbmdT aW11bGF0ZWRDbGlja3MgPSBuZXcgSGFzaFNldDxOb2RlKj47CiAgICAgZWxzZSBpZiAoZ05vZGVz RGlzcGF0Y2hpbmdTaW11bGF0ZWRDbGlja3MtPmNvbnRhaW5zKG5vZGUpKQpAQCAtMTc0LDE0ICsx NzIsMTQgQEAgdm9pZCBFdmVudERpc3BhdGNoZXI6OmRpc3BhdGNoU2ltdWxhdGVkQ2xpY2soTm9k ZSogbm9kZSwgUGFzc1JlZlB0cjxFdmVudD4gdW5kZXIKIAogICAgIC8vIHNlbmQgbW91c2Vkb3du IGFuZCBtb3VzZXVwIGJlZm9yZSB0aGUgY2xpY2ssIGlmIHJlcXVlc3RlZAogICAgIGlmIChzZW5k TW91c2VFdmVudHMpCi0gICAgICAgIGRpc3BhdGNoZXIuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRN b3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLm1vdXNlZG93bkV2ZW50LCBub2RlLT5kb2N1 bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRlcmx5aW5nRXZlbnQpKTsKKyAgICAgICAgRXZlbnRE aXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRl KGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCwgbm9kZS0+ZG9jdW1lbnQoKS0+ZGVmYXVsdFZp ZXcoKSwgdW5kZXJseWluZ0V2ZW50KSk7CiAgICAgbm9kZS0+c2V0QWN0aXZlKHRydWUsIHNob3dQ cmVzc2VkTG9vayk7CiAgICAgaWYgKHNlbmRNb3VzZUV2ZW50cykKLSAgICAgICAgZGlzcGF0Y2hl ci5kaXNwYXRjaEV2ZW50KFNpbXVsYXRlZE1vdXNlRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCku bW91c2V1cEV2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRlcmx5aW5n RXZlbnQpKTsKKyAgICAgICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2lt dWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5tb3VzZXVwRXZlbnQsIG5vZGUt PmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCksIHVuZGVybHlpbmdFdmVudCkpOwogICAgIG5vZGUt PnNldEFjdGl2ZShmYWxzZSk7CiAKICAgICAvLyBhbHdheXMgc2VuZCBjbGljawotICAgIGRpc3Bh dGNoZXIuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1l cygpLmNsaWNrRXZlbnQsIG5vZGUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCksIHVuZGVybHlp bmdFdmVudCkpOworICAgIEV2ZW50RGlzcGF0Y2hlcihub2RlKS5kaXNwYXRjaEV2ZW50KFNpbXVs YXRlZE1vdXNlRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuY2xpY2tFdmVudCwgbm9kZS0+ZG9j dW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJseWluZ0V2ZW50KSk7CiAKICAgICBnTm9kZXNE aXNwYXRjaGluZ1NpbXVsYXRlZENsaWNrcy0+cmVtb3ZlKG5vZGUpOwogfQpAQCAtMjAyLDYgKzIw MCw5IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjphZGp1c3RSZWxhdGVkVGFyZ2V0KEV2ZW50KiBl dmVudCwgUGFzc1JlZlB0cjxFdmVudFRhcmdldD4KIEV2ZW50RGlzcGF0Y2hlcjo6RXZlbnREaXNw YXRjaGVyKE5vZGUqIG5vZGUpCiAgICAgOiBtX25vZGUobm9kZSkKICAgICAsIG1fYW5jZXN0b3Jz SW5pdGlhbGl6ZWQoZmFsc2UpCisjaWZuZGVmIE5ERUJVRworICAgICwgbV9ldmVudERpc3BhdGNo ZWQoZmFsc2UpCisjZW5kaWYKIHsKICAgICBBU1NFUlQobm9kZSk7CiAgICAgbV92aWV3ID0gbm9k ZS0+ZG9jdW1lbnQoKS0+dmlldygpOwpAQCAtMjM5LDYgKzI0MCwxMCBAQCB2b2lkIEV2ZW50RGlz cGF0Y2hlcjo6ZW5zdXJlRXZlbnRBbmNlc3RvcnMoRXZlbnQqIGV2ZW50KQogCiBib29sIEV2ZW50 RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVudCkKIHsK KyNpZm5kZWYgTkRFQlVHCisgICAgQVNTRVJUKCFtX2V2ZW50RGlzcGF0Y2hlZCk7CisgICAgbV9l dmVudERpc3BhdGNoZWQgPSB0cnVlOworI2VuZGlmCiAgICAgUmVmUHRyPEV2ZW50PiBldmVudCA9 IHBycEV2ZW50OwogICAgIENoaWxkTm9kZXNMYXp5U25hcHNob3Q6OnRha2VDaGlsZE5vZGVzTGF6 eVNuYXBzaG90KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3Bh dGNoZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuaAppbmRleCAxNGUy OGMxYWQ5ZmMxMzczYjY5ZjNkZWMxOTUxMjkwNzY5ZGIwOWQxLi41YmZlYWQwZDBlNmNiZTBiODAw MzRkNDIyNWE2MGUzMjRkZmFjODM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZl bnREaXNwYXRjaGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5o CkBAIC05Niw2ICs5Niw5IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPE5vZGU+IG1fbm9kZTsKICAg ICBSZWZQdHI8RnJhbWVWaWV3PiBtX3ZpZXc7CiAgICAgYm9vbCBtX2FuY2VzdG9yc0luaXRpYWxp emVkOworI2lmbmRlZiBOREVCVUcKKyAgICBib29sIG1fZXZlbnREaXNwYXRjaGVkOworI2VuZGlm CiB9OwogCiBpbmxpbmUgTm9kZSogRXZlbnREaXNwYXRjaGVyOjpub2RlKCkgY29uc3QK