93411 2012-08-07 16:56:22 -0700 percentage margins + flex incorrectly overflows the flexbox 2012-08-13 00:05:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://plexode.com/u/#2W%3C2V%3E2U%222T%3B-SpxQRKJ7(1I*902Q%0AfPO8100SJwiM90rONumn)olor(salmonrNL7-direction(colrMdth(300STIQrL4Udisplay%3A7JEKHsolid6JT!EIUVrH)olG!border(2S!rGor(orange85STr9!!!!4Umargin(1Y8Jheight(b7-webkit-flexn4Wdiv!style%3Dn*W%2FdivVQr)Jbackground-c6(%3A!2!%20~http://plexode.com/eval3/#ht=PSRSKI**WbrVQQP%25R%25KI**Q P2 Normal --- 62048 1 ojan ojan eric esprehn jchaffraix tabatkins tony webkit.review.bot oldest_to_newest 689619 0 ojan 2012-08-07 16:56:22 -0700 See the test-case in the URL field. The problem is that RenderFlexibleBox::computeMainAxisPreferredSizes incorrectly uses the height for computing percentage margin-top/bottom in column flexboxes. As per CSS2.1 percentage margins and padding should always be computed WRT the containing block's width. When we call layoutIfNeeded in layoutAndPlaceChildren, the margin-top/bottom gets correctly set to the right value, so the flex items size and place correctly, but we compute the wrong preferred child size in RenderFlexibleBox::computeNextFlexLine if there is actually flex on any child. 689746 1 157083 ojan 2012-08-07 18:55:38 -0700 Created attachment 157083 Patch 689749 2 157083 tony 2012-08-07 19:08:10 -0700 Comment on attachment 157083 Patch Stupid bug. Thanks for fixing. 689776 3 tony 2012-08-07 19:44:59 -0700 We probably have the same bug with padding: http://www.w3.org/TR/CSS21/box.html#padding-properties 689886 4 157083 webkit.review.bot 2012-08-07 22:25:50 -0700 Comment on attachment 157083 Patch Clearing flags on attachment: 157083 Committed r124987: <http://trac.webkit.org/changeset/124987> 689887 5 webkit.review.bot 2012-08-07 22:25:54 -0700 All reviewed patches have been landed. Closing bug. 693415 6 tony 2012-08-13 00:05:57 -0700 (In reply to comment #3) > We probably have the same bug with padding: > http://www.w3.org/TR/CSS21/box.html#padding-properties Nevermind. We never interact with style()->padding* directly so this isn't a problem. 157083 2012-08-07 18:55:38 -0700 2012-08-07 22:25:50 -0700 Patch bug-93411-20120807185512.patch text/plain 6637 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTdjZmQ3MzEyNzBhMjcx YjBlODYzZjUzNzdmMjNjMzhkZDExZTNjZC4uMTM3ZDgyYjhhYzkzNWUyMjE5OGM3NDI3ZDBiNjli MDYxOWMwOWY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTA3ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcGVyY2VudGFnZSBtYXJnaW5z ICsgZmxleCBpbmNvcnJlY3RseSBvdmVyZmxvd3MgdGhlIGZsZXhib3gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDExCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGVyY2VudCBtYXJnaW5zIHNob3VsZCBh bHdheXMgYmUgY29tcHV0ZWQgd2l0aCByZXNwZWN0IHRvIHRoZSBjb250YWluaW5nCisgICAgICAg IGJsb2NrJ3Mgd2lkdGgsIG5vdCBpdCdzIGhlaWdodC4gV2Ugd2VyZSBnZXR0aW5nIHRoaXMgd3Jv bmcgaW4gY29sdW1uIGZsb3dzLgorCisgICAgICAgIFRlc3Q6IGNzczMvZmxleGJveC9wZXJjZW50 LW1hcmdpbnMuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlTWFyZ2luVmFs dWUpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJs ZUJveDo6Y29tcHV0ZU1haW5BeGlzUHJlZmVycmVkU2l6ZXMpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyRmxleGlibGVCb3g6OmxheW91dEFuZFBsYWNlQ2hpbGRyZW4pOgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oOgorCiAyMDEyLTA4LTA3ICBNYXJjZWxvIExpcmEg IDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIEFkZCBzdXBwb3J0 IGZvciB0aGUgR2FtZXBhZCBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RmxleGlibGVCb3guY3BwCmluZGV4IGYzYWYwYjg5NWViMTgzODI2ZjI5ZWY0NTQ3OGE1NDk5OTRl OWEzMzguLmZiN2FjZTAzOWZiM2RiMWVkNGI0NmNhNjAzNDNjODE4ODQxYTFlNjkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAtNzU4LDYg Kzc1OCwxNCBAQCBMYXlvdXRVbml0IFJlbmRlckZsZXhpYmxlQm94OjptYXJnaW5Cb3hBc2NlbnRG b3JDaGlsZChSZW5kZXJCb3gqIGNoaWxkKQogICAgIHJldHVybiBhc2NlbnQgKyBmbG93QXdhcmVN YXJnaW5CZWZvcmVGb3JDaGlsZChjaGlsZCk7CiB9CiAKK0xheW91dFVuaXQgUmVuZGVyRmxleGli bGVCb3g6OmNvbXB1dGVNYXJnaW5WYWx1ZShMZW5ndGggbWFyZ2luLCBMYXlvdXRVbml0IGF2YWls YWJsZVNpemUsIFJlbmRlclZpZXcqIHZpZXcpCit7CisgICAgLy8gQ1NTIGFsd2F5cyBjb21wdXRl cyBwZXJjZW50IG1hcmdpbnMgd2l0aCByZXNwZWN0IHRvIHRoZSBjb250YWluaW5nIGJsb2NrJ3Mg d2lkdGgsIGV2ZW4gZm9yIG1hcmdpbi10b3AvbWFyZ2luLWJvdHRvbS4KKyAgICBpZiAobWFyZ2lu LmlzUGVyY2VudCgpKQorICAgICAgICBhdmFpbGFibGVTaXplID0gbG9naWNhbFdpZHRoKCk7Cisg ICAgcmV0dXJuIG1pbmltdW1WYWx1ZUZvckxlbmd0aChtYXJnaW4sIGF2YWlsYWJsZVNpemUsIHZp ZXcpOworfQorCiB2b2lkIFJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlTWFpbkF4aXNQcmVmZXJy ZWRTaXplcyhib29sIHJlbGF5b3V0Q2hpbGRyZW4sIE9yZGVySGFzaFNldCYgb3JkZXJWYWx1ZXMp CiB7CiAgICAgTGF5b3V0VW5pdCBmbGV4Ym94QXZhaWxhYmxlQ29udGVudEV4dGVudCA9IG1haW5B eGlzQ29udGVudEV4dGVudCgpOwpAQCAtNzgwLDExICs3ODgsMTEgQEAgdm9pZCBSZW5kZXJGbGV4 aWJsZUJveDo6Y29tcHV0ZU1haW5BeGlzUHJlZmVycmVkU2l6ZXMoYm9vbCByZWxheW91dENoaWxk cmVuLCBPcmQKICAgICAgICAgLy8gQmVmb3JlIHJ1bm5pbmcgdGhlIGZsZXggYWxnb3JpdGhtLCAn YXV0bycgaGFzIGEgbWFyZ2luIG9mIDAuCiAgICAgICAgIC8vIEFsc28sIGlmIHdlJ3JlIG5vdCBh dXRvIHNpemluZywgd2UgZG9uJ3QgZG8gYSBsYXlvdXQgdGhhdCBjb21wdXRlcyB0aGUgc3RhcnQv ZW5kIG1hcmdpbnMuCiAgICAgICAgIGlmIChpc0hvcml6b250YWxGbG93KCkpIHsKLSAgICAgICAg ICAgIGNoaWxkLT5zZXRNYXJnaW5MZWZ0KG1pbmltdW1WYWx1ZUZvckxlbmd0aChjaGlsZC0+c3R5 bGUoKS0+bWFyZ2luTGVmdCgpLCBmbGV4Ym94QXZhaWxhYmxlQ29udGVudEV4dGVudCwgcmVuZGVy VmlldykpOwotICAgICAgICAgICAgY2hpbGQtPnNldE1hcmdpblJpZ2h0KG1pbmltdW1WYWx1ZUZv ckxlbmd0aChjaGlsZC0+c3R5bGUoKS0+bWFyZ2luUmlnaHQoKSwgZmxleGJveEF2YWlsYWJsZUNv bnRlbnRFeHRlbnQsIHJlbmRlclZpZXcpKTsKKyAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5M ZWZ0KGNvbXB1dGVNYXJnaW5WYWx1ZShjaGlsZC0+c3R5bGUoKS0+bWFyZ2luTGVmdCgpLCBmbGV4 Ym94QXZhaWxhYmxlQ29udGVudEV4dGVudCwgcmVuZGVyVmlldykpOworICAgICAgICAgICAgY2hp bGQtPnNldE1hcmdpblJpZ2h0KGNvbXB1dGVNYXJnaW5WYWx1ZShjaGlsZC0+c3R5bGUoKS0+bWFy Z2luUmlnaHQoKSwgZmxleGJveEF2YWlsYWJsZUNvbnRlbnRFeHRlbnQsIHJlbmRlclZpZXcpKTsK ICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5Ub3AobWluaW11 bVZhbHVlRm9yTGVuZ3RoKGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5Ub3AoKSwgZmxleGJveEF2YWls YWJsZUNvbnRlbnRFeHRlbnQsIHJlbmRlclZpZXcpKTsKLSAgICAgICAgICAgIGNoaWxkLT5zZXRN YXJnaW5Cb3R0b20obWluaW11bVZhbHVlRm9yTGVuZ3RoKGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5C b3R0b20oKSwgZmxleGJveEF2YWlsYWJsZUNvbnRlbnRFeHRlbnQsIHJlbmRlclZpZXcpKTsKKyAg ICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5Ub3AoY29tcHV0ZU1hcmdpblZhbHVlKGNoaWxkLT5z dHlsZSgpLT5tYXJnaW5Ub3AoKSwgZmxleGJveEF2YWlsYWJsZUNvbnRlbnRFeHRlbnQsIHJlbmRl clZpZXcpKTsKKyAgICAgICAgICAgIGNoaWxkLT5zZXRNYXJnaW5Cb3R0b20oY29tcHV0ZU1hcmdp blZhbHVlKGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5Cb3R0b20oKSwgZmxleGJveEF2YWlsYWJsZUNv bnRlbnRFeHRlbnQsIHJlbmRlclZpZXcpKTsKICAgICAgICAgfQogICAgIH0KIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmgKaW5kZXggNjI0ZWYxNjZiNTQz ZDg4OTVlYzMxNTI0MTE0NmZjMTUyMWM1MDYzOC4uMjBiOTY2NjU0NTQ3MWQwZDc2NTkxNTU2ODFm NzJkNDg4ZDkzNTMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsZXhpYmxlQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhp YmxlQm94LmgKQEAgLTExOSw2ICsxMTksNyBAQCBwcml2YXRlOgogICAgIExheW91dFVuaXQgYXZh aWxhYmxlQWxpZ25tZW50U3BhY2VGb3JDaGlsZChMYXlvdXRVbml0IGxpbmVDcm9zc0F4aXNFeHRl bnQsIFJlbmRlckJveCopOwogICAgIExheW91dFVuaXQgbWFyZ2luQm94QXNjZW50Rm9yQ2hpbGQo UmVuZGVyQm94Kik7CiAKKyAgICBMYXlvdXRVbml0IGNvbXB1dGVNYXJnaW5WYWx1ZShMZW5ndGgg bWFyZ2luLCBMYXlvdXRVbml0IGF2YWlsYWJsZVNpemUsIFJlbmRlclZpZXcqKTsKICAgICB2b2lk IGNvbXB1dGVNYWluQXhpc1ByZWZlcnJlZFNpemVzKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgT3Jk ZXJIYXNoU2V0Jik7CiAgICAgTGF5b3V0VW5pdCBsaW5lQnJlYWtMZW5ndGgoKTsKICAgICBMYXlv dXRVbml0IGFkanVzdENoaWxkU2l6ZUZvck1pbkFuZE1heChSZW5kZXJCb3gqLCBMYXlvdXRVbml0 IGNoaWxkU2l6ZSwgTGF5b3V0VW5pdCBmbGV4Ym94QXZhaWxhYmxlQ29udGVudEV4dGVudCk7CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggMDZkZDU1MzM4MzY4ZDg3MWVhYmE0OTc2ZWYyODZjYTQ3ZWJiOWU1OC4uNDNjNTFmZDEx Mjg1ZTBlNzQ1MTg2MDE5ZTBlZWZlNmQ2ZjBjYzA3NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDEyLTA4LTA3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcGVy Y2VudGFnZSBtYXJnaW5zICsgZmxleCBpbmNvcnJlY3RseSBvdmVyZmxvd3MgdGhlIGZsZXhib3gK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzNDExCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MzL2Zs ZXhib3gvcGVyY2VudC1tYXJnaW5zLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3Nz My9mbGV4Ym94L3BlcmNlbnQtbWFyZ2lucy5odG1sOiBBZGRlZC4KKwogMjAxMi0wOC0wNyAgTWFy Y2VsbyBMaXJhICA8bWFyY2Vsby5saXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XSBB ZGQgc3VwcG9ydCBmb3IgdGhlIEdhbWVwYWQgQVBJCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvcGVyY2VudC1tYXJnaW5zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Nz czMvZmxleGJveC9wZXJjZW50LW1hcmdpbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM4ZTAz NTI1MTU1YzFiZDJjZDY0ODVkZTIzNWVkYjQyZDU0YWZhMWYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvcGVyY2VudC1tYXJnaW5zLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDIgQEAKK1BBU1MKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxl eGJveC9wZXJjZW50LW1hcmdpbnMuaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9wZXJj ZW50LW1hcmdpbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jNDU4YWFkZGNjNjhjNGIxM2EzZGYwZmQyOGJl MWJiOWFhYjZlNTMwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94 L3BlcmNlbnQtbWFyZ2lucy5odG1sCkBAIC0wLDAgKzEsMTkgQEAKKzwhRE9DVFlQRSBodG1sPgor PHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9jaGVjay1sYXlv dXQuanMiPjwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSJjaGVja0xheW91dCgnLmZsZXhib3gnKSI+ CisKKzxkaXYgY2xhc3M9ImZsZXhib3giIHN0eWxlPSJkaXNwbGF5Oi13ZWJraXQtZmxleDsgLXdl YmtpdC1mbGV4LWRpcmVjdGlvbjogY29sdW1uOyBiYWNrZ3JvdW5kLWNvbG9yOiBzYWxtb247IGhl aWdodDogMzAwcHg7IHdpZHRoOiA0MDBweDsiPgorICAgIDxkaXYgc3R5bGU9Im1hcmdpbjogMTAl OyBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7IGhlaWdodDogNXB4OyAtd2Via2l0LWZsZXg6IDEi IGRhdGEtZXhwZWN0ZWQtd2lkdGg9MzIwIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PTEzNT48L2Rpdj4K KyAgICA8ZGl2IHN0eWxlPSJtYXJnaW46IDEwJTsgYmFja2dyb3VuZC1jb2xvcjogb3JhbmdlOyBo ZWlnaHQ6IDVweDsiIGRhdGEtZXhwZWN0ZWQtd2lkdGg9MzIwIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0 PTU+PC9kaXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iZmxleGJveCIgc3R5bGU9ImRpc3BsYXk6 LXdlYmtpdC1mbGV4OyBiYWNrZ3JvdW5kLWNvbG9yOiBzYWxtb247IGhlaWdodDogMzAwcHg7IHdp ZHRoOiA0MDBweDsiPgorICAgIDxkaXYgc3R5bGU9Im1hcmdpbjogMTAlOyBiYWNrZ3JvdW5kLWNv bG9yOiBvcmFuZ2U7IGhlaWdodDogNXB4OyAtd2Via2l0LWZsZXg6IDEgNXB4IiBkYXRhLWV4cGVj dGVkLXdpZHRoPTIzNSBkYXRhLWV4cGVjdGVkLWhlaWdodD01PjwvZGl2PgorICAgIDxkaXYgc3R5 bGU9Im1hcmdpbjogMTAlOyBiYWNrZ3JvdW5kLWNvbG9yOiBvcmFuZ2U7IGhlaWdodDogNXB4OyB3 aWR0aDogNXB4IiBkYXRhLWV4cGVjdGVkLXdpZHRoPTUgZGF0YS1leHBlY3RlZC1oZWlnaHQ9NT48 L2Rpdj4KKzwvZGl2PgorCis8L2JvZHk+Cg==