93339 2012-08-06 23:20:11 -0700 [Qt][Win] Build system bug revealed by r124835 2012-08-09 14:57:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 93307 1 ossy ossy abarth eric hausmann jturcotte ossy vestbo zarvai oldest_to_newest 688860 0 ossy 2012-08-06 23:20:11 -0700 r124835 broke the Qt 5 - Windows - MSVC build: link /LIBPATH:"c:\WebKitBuildSlave\qt5\qtbase\lib" /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO /DLL /MANIFEST /MANIFESTFILE:"obj/release\QtWebKit.intermediate.manifest" /VERSION:5.00 /OUT:..\lib\QtWebKit5.dll @C:\Users\WEBKIT~1\AppData\Local\Temp\2\nm5FE9.tmp Creating library ..\lib\QtWebKit5.lib and object ..\lib\QtWebKit5.exp WebCore.lib(JSDocumentCustom.obj) : error LNK2019: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) referenced in function "public: void __thiscall WebCore::JSDocument::setLocation(class JSC::ExecState *,class JSC::JSValue)" (?setLocation@JSDocument@WebCore@@QAEXPAVExecState@JSC@@VJSValue@4@@Z) WebCore.lib(JSDOMWindowCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) WebCore.lib(JSLocationCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) WebCore.lib(JSDocumentCustom.obj) : error LNK2019: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) referenced in function "public: void __thiscall WebCore::JSDocument::setLocation(class JSC::ExecState *,class JSC::JSValue)" (?setLocation@JSDocument@WebCore@@QAEXPAVExecState@JSC@@VJSValue@4@@Z) WebCore.lib(JSDOMWindowCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) WebCore.lib(JSLocationCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) ..\lib\QtWebKit5.dll : fatal error LNK1120: 2 unresolved externals 688861 1 abarth 2012-08-06 23:21:25 -0700 Hi 688867 2 abarth 2012-08-06 23:27:45 -0700 I talked with Ossy a bit in #webkit about this failure, but I'm not sure where to start to fix it. I don't even know which build system is used by this port. It just looks like BindingState.cpp is missing from the build. The apple-win port gets this file via JSBindingAllInOne.cpp. 688868 3 hausmann 2012-08-06 23:32:52 -0700 Yeah, this looks like a dependency problem in the build system perhaps. I don't see anything Windows specific in http://trac.webkit.org/changeset/124835 . It would be interesting to see the entire build log of the bot. My bet is a that a clean build fixes it :/ 688969 4 ossy 2012-08-07 02:10:41 -0700 Clean build solved this problem, so it is a build system bug. 688971 5 hausmann 2012-08-07 02:12:36 -0700 Do you have the original build log somewhere? Would love to see what happened. After all it should be just qmake and nmake. 688973 6 hausmann 2012-08-07 02:13:24 -0700 Found it at http://build.webkit.sed.hu/builders/Qt%20Windows%2032-bit%20Release%20Qt5/builds/1277/steps/compile-webkit/logs/stdio 689036 7 vestbo 2012-08-07 04:33:40 -0700 The SVN revision check in build-webkit fails: 'LC_ALL' is not recognized as an internal or external command, operable program or batch file. Unable to determine current SVN revision in C:/WebKitBuildSlave/szeged-windows-1/qt-windows-32-release/build at C:/WebKitBuildSlave/szeged-windows-1/qt-windows-32-release/build/Tools/Scripts/VCSUtils.pm line 384. This causes us to not do "make incremental", (which does make qmake && make). Target.pri was touched though, so qmake was (should be) run on that, but there might be nother dep that was not picked up due to a missing root make qmake. 691241 8 ossy 2012-08-08 23:06:46 -0700 *** Bug 93580 has been marked as a duplicate of this bug. *** 691243 9 ossy 2012-08-08 23:07:01 -0700 *** Bug 93582 has been marked as a duplicate of this bug. *** 691253 10 ossy 2012-08-08 23:18:21 -0700 I'm picked it up. 691283 11 157407 ossy 2012-08-09 00:20:28 -0700 Created attachment 157407 Patch 691887 12 157407 ossy 2012-08-09 14:57:05 -0700 Comment on attachment 157407 Patch landed in https://trac.webkit.org/changeset/125163 157407 2012-08-09 00:20:28 -0700 2012-08-09 14:57:04 -0700 Patch bug-93339-20120809002000.patch text/plain 2806 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDViYWE3YmJkYzdiYjY2ZmQ0NDlkMDBkM2RjMmRkMzQ4 ZDVhZjc2YS4uOWM5MmJiMGM2N2UwNjg4YjA1ZTA3NGIzOTkxMGFlMGExZjdkMzljNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA4LTA4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XVtXaW5dIEJ1aWxkIHN5c3RlbSBidWcgcmV2ZWFsZWQgYnkgcjEyNDgzNQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBhZGQg IkxDX0FMTD1jIiBvbiBXaW5kb3dzIGluIHN2blJldmlzaW9uRm9yRGlyZWN0b3J5KCkgYW5kIGlu IHBhdGhSZWxhdGl2ZVRvU1ZOUmVwb3NpdG9yeVJvb3RGb3JQYXRoKCkuCisKKyAgICAgICAgKiBT Y3JpcHRzL1ZDU1V0aWxzLnBtOgorICAgICAgICAoaXNXaW5kb3dzKTogQ29waWVkIGZyb20gd2Vi a2l0ZGlycy5wbS4KKyAgICAgICAgKHN2blJldmlzaW9uRm9yRGlyZWN0b3J5KToKKyAgICAgICAg KHBhdGhSZWxhdGl2ZVRvU1ZOUmVwb3NpdG9yeVJvb3RGb3JQYXRoKToKKwogMjAxMi0wOC0wOCAg RGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICB1cGRhdGUgYm90 IHBhcnNpbmcgb2YgbmV3LXJ1bi13ZWJraXQtdGVzdHMnIG91dHB1dApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9WQ1NVdGlscy5wbSBiL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KaW5kZXgg ZGQ0MDRjZTAwZjAwZmU1ODg0OWQ2MWJjZGNjZjQ1ZjMwNzZlNDcxZS4uNGRhNzg3MjBhZTgwMTA4 YjRiNmU5MzBjMDkwMGE4YzgxOWIwYTkyZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9WQ1NV dGlscy5wbQorKysgYi9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCkBAIC0zNjYsNiArMzY2LDEx IEBAIHN1YiBkZXRlcm1pbmVWQ1NSb290KCkKICAgICByZXR1cm4gZGV0ZXJtaW5lU1ZOUm9vdCgp OwogfQogCitzdWIgaXNXaW5kb3dzKCkKK3sKKyAgICByZXR1cm4gKCReTyBlcSAiTVNXaW4zMiIp IHx8IDA7Cit9CisKIHN1YiBzdm5SZXZpc2lvbkZvckRpcmVjdG9yeSgkKQogewogICAgIG15ICgk ZGlyKSA9IEBfOwpAQCAtMzczLDEwICszNzgsMTUgQEAgc3ViIHN2blJldmlzaW9uRm9yRGlyZWN0 b3J5KCQpCiAKICAgICBpZiAoaXNTVk5EaXJlY3RvcnkoJGRpcikpIHsKICAgICAgICAgbXkgJGVz Y2FwZWREaXIgPSBlc2NhcGVTdWJ2ZXJzaW9uUGF0aCgkZGlyKTsKLSAgICAgICAgbXkgJHN2bklu Zm8gPSBgTENfQUxMPUMgc3ZuIGluZm8gJGVzY2FwZWREaXIgfCBncmVwIFJldmlzaW9uOmA7Cisg ICAgICAgIG15ICRjb21tYW5kID0gInN2biBpbmZvICRlc2NhcGVkRGlyIHwgZ3JlcCBSZXZpc2lv bjoiOworICAgICAgICAkY29tbWFuZCA9ICJMQ19BTEw9QyAkY29tbWFuZCIgaWYgIWlzV2luZG93 cygpOworICAgICAgICBteSAkc3ZuSW5mbyA9IGAkY29tbWFuZGA7CiAgICAgICAgICgkcmV2aXNp b24pID0gKCRzdm5JbmZvID1+IG0vUmV2aXNpb246IChcZCspLiovZyk7CiAgICAgfSBlbHNpZiAo aXNHaXREaXJlY3RvcnkoJGRpcikpIHsKLSAgICAgICAgbXkgJGdpdExvZyA9IGBjZCAkZGlyICYm IExDX0FMTD1DIGdpdCBsb2cgLS1ncmVwPSdnaXQtc3ZuLWlkOiAnIC1uIDEgfCBncmVwIGdpdC1z dm4taWQ6YDsKKyAgICAgICAgbXkgJGNvbW1hbmQgPSAiZ2l0IGxvZyAtLWdyZXA9J2dpdC1zdm4t aWQ6ICcgLW4gMSB8IGdyZXAgZ2l0LXN2bi1pZDoiOworICAgICAgICAkY29tbWFuZCA9ICJMQ19B TEw9QyAkY29tbWFuZCIgaWYgIWlzV2luZG93cygpOworICAgICAgICAkY29tbWFuZCA9ICJjZCAk ZGlyICYmICRjb21tYW5kIjsKKyAgICAgICAgbXkgJGdpdExvZyA9IGAkY29tbWFuZGA7CiAgICAg ICAgICgkcmV2aXNpb24pID0gKCRnaXRMb2cgPX4gbS8gK2dpdC1zdm4taWQ6IC4rQChcZCspIC9n KTsKICAgICB9CiAgICAgaWYgKCFkZWZpbmVkKCRyZXZpc2lvbikpIHsKQEAgLTM5NCw5ICs0MDQs MTMgQEAgc3ViIHBhdGhSZWxhdGl2ZVRvU1ZOUmVwb3NpdG9yeVJvb3RGb3JQYXRoKCQpCiAgICAg bXkgJHN2bkluZm87CiAgICAgaWYgKGlzU1ZOKCkpIHsKICAgICAgICAgbXkgJGVzY2FwZWRSZWxh dGl2ZVBhdGggPSBlc2NhcGVTdWJ2ZXJzaW9uUGF0aCgkcmVsYXRpdmVQYXRoKTsKLSAgICAgICAg JHN2bkluZm8gPSBgTENfQUxMPUMgc3ZuIGluZm8gJGVzY2FwZWRSZWxhdGl2ZVBhdGhgOworICAg ICAgICBteSAkY29tbWFuZCA9ICJzdm4gaW5mbyAkZXNjYXBlZFJlbGF0aXZlUGF0aCI7CisgICAg ICAgICRjb21tYW5kID0gIkxDX0FMTD1DICRjb21tYW5kIiBpZiAhaXNXaW5kb3dzKCk7CisgICAg ICAgICRzdm5JbmZvID0gYCRjb21tYW5kYDsKICAgICB9IGVsc2lmIChpc0dpdCgpKSB7Ci0gICAg ICAgICRzdm5JbmZvID0gYExDX0FMTD1DIGdpdCBzdm4gaW5mbyAkcmVsYXRpdmVQYXRoYDsKKyAg ICAgICAgbXkgJGNvbW1hbmQgPSAiZ2l0IHN2biBpbmZvICRyZWxhdGl2ZVBhdGgiOworICAgICAg ICAkY29tbWFuZCA9ICJMQ19BTEw9QyAkY29tbWFuZCIgaWYgIWlzV2luZG93cygpOworICAgICAg ICAkc3ZuSW5mbyA9IGAkY29tbWFuZGA7CiAgICAgfQogCiAgICAgJHN2bkluZm8gPX4gLy4qXlVS TDogKC4qPykkL207Cg==