93334 2012-08-06 21:54:19 -0700 [V8] Move setIsolatedWorldSecurityOrigin() from V8Proxy to ScriptController 2012-08-07 22:30:24 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93095 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 688800 0 haraken 2012-08-06 21:54:19 -0700 The goal is to move m_isolatedWorlds, m_isolatedWorldSecurityOrigins and related methods from V8Proxy to ScriptController. As a starting point, in this bug we move setIsolatedWorldSecurityOrigin(). 688808 1 156861 haraken 2012-08-06 22:09:45 -0700 Created attachment 156861 Patch 689448 2 156861 abarth 2012-08-07 15:00:11 -0700 Comment on attachment 156861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156861&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:183 > void ScriptController::setIsolatedWorldSecurityOrigin(int worldID, PassRefPtr<SecurityOrigin> securityOrigin) A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch. 689628 3 haraken 2012-08-07 17:04:33 -0700 (In reply to comment #2) > A better name for this function is something like setSecurityOriginForIsolatedWorld, but don't feel like you need to go renaming crazy in this patch. This method is exposed to the Chromium WebKit API. If we want to rename it, we should rename the API name too. If you want, I'll do it. WDYT? http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h&exact_package=chromium&q=setIsolatedWorldSecurityOrigin&type=cs&l=258 Either way let me land this patch first. 689701 4 156861 webkit.review.bot 2012-08-07 18:18:20 -0700 Comment on attachment 156861 Patch Clearing flags on attachment: 156861 Committed r124962: <http://trac.webkit.org/changeset/124962> 689702 5 webkit.review.bot 2012-08-07 18:18:23 -0700 All reviewed patches have been landed. Closing bug. 689891 6 abarth 2012-08-07 22:28:27 -0700 It's probably too much work to rename the API. 689896 7 haraken 2012-08-07 22:30:24 -0700 OK, then let's keep it as is. 156861 2012-08-06 22:09:45 -0700 2012-08-07 18:18:19 -0700 Patch bug-93334-20120807140920.patch text/plain 6508 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI5MDRiYjcwZDdlZDVm ODJmYWUxNjE1Y2RjNGFjYTZlMTRhNjhlMC4uZDM2MDU4NmQwODk2N2NhODIyMzQ2YmJjZmQxMTVh NjE2OWUyNzc2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA4LTA2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgc2V0 SXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2luKCkgZnJvbSBWOFByb3h5IHRvIFNjcmlwdENvbnRy b2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz MzM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IGdvYWwgaXMgdG8gbW92ZSBmYWN0b3Igb3V0IFY4UHJveHkgbWV0aG9kcyB0byBTY3JpcHRDb250 cm9sbGVyLgorICAgICAgICBBcyBhIHN0YXJ0aW5nIHBvaW50LCB0aGlzIHBhdGNoIG1vdmVzIHNl dElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbigpLgorCisgICAgICAgIGlzb2xhdGVkV29ybGRz KCkgYW5kIGlzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbnMoKSBhcmUgdGVtcG9yYXJ5IG1ldGhv ZHMuCisgICAgICAgIFRoZXkgd2lsbCBiZSBzb29uIHJlbW92ZWQgYWZ0ZXIgbW92aW5nIGFsbCBy ZWxhdGVkIG1ldGhvZHMKKyAgICAgICAgYW5kIG1faXNvbGF0ZWRXb3JsZHMgYW5kIG1faXNvbGF0 ZWRXb3JsZFNlY3VyaXR5T3JpZ2lucy4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjpzZXRJc29sYXRlZFdvcmxkU2Vj dXJpdHlPcmlnaW4pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAo VjhQcm94eSk6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5Ojppc29sYXRlZFdvcmxkcyk6Cisg ICAgICAgIChXZWJDb3JlOjpWOFByb3h5Ojppc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zKToK KwogMjAxMi0wOC0wNiAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9iZS5jb20+CiAKICAgICAg ICAgW0NTUyBTaGFkZXJzXSBQYXJzZSBtaXggZnVuY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggN2U0OTBkOWY1MjFjMjc0MWJl ZGNkODI0MDI5OTBmMDNlYTczNWE5ZC4uZWQ1ZGM4ODc5M2VhYTEwMzQ0ZGIyMzNhZTBjYmNhYTA0 YWEyMDYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJv bGxlci5jcHAKQEAgLTE4Miw3ICsxODIsMTEgQEAgdm9pZCBTY3JpcHRDb250cm9sbGVyOjpldmFs dWF0ZUluSXNvbGF0ZWRXb3JsZCh1bnNpZ25lZCB3b3JsZElELCBjb25zdCBWZWN0b3I8U2MKIAog dm9pZCBTY3JpcHRDb250cm9sbGVyOjpzZXRJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW4oaW50 IHdvcmxkSUQsIFBhc3NSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IHNlY3VyaXR5T3JpZ2luKQogewot ICAgIG1fcHJveHktPnNldElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbih3b3JsZElELCBzZWN1 cml0eU9yaWdpbik7CisgICAgQVNTRVJUKHdvcmxkSUQpOworICAgIG1fcHJveHktPmlzb2xhdGVk V29ybGRTZWN1cml0eU9yaWdpbnMoKS5zZXQod29ybGRJRCwgc2VjdXJpdHlPcmlnaW4pOworICAg IElzb2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBtX3Byb3h5LT5pc29sYXRlZFdvcmxk cygpLmZpbmQod29ybGRJRCk7CisgICAgaWYgKGl0ZXIgIT0gbV9wcm94eS0+aXNvbGF0ZWRXb3Js ZHMoKS5lbmQoKSkKKyAgICAgICAgaXRlci0+c2Vjb25kLT5zZXRTZWN1cml0eU9yaWdpbihzZWN1 cml0eU9yaWdpbik7CiB9CiAKIC8vIEV2YWx1YXRlIGEgc2NyaXB0IGZpbGUgaW4gdGhlIGVudmly b25tZW50IG9mIHRoaXMgcHJveHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3Bw CmluZGV4IDdjZmE0MmJlZGVkOTdiNDc2MTkyOGM2ZWNiN2JiMmY1ZTAxNjljNDYuLjg4ODIwM2Fi MzY2ZTk4ZTMxZGIyMGY4ZjExZjdkYzM2YWVlNTk1M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4UHJveHkuY3BwCkBAIC0yMTgsMTYgKzIxOCw2IEBAIHY4OjpMb2NhbDx2ODo6QXJyYXk+ IFY4UHJveHk6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKGludCB3b3JsZElELCBjb25zdCBWZWN0 b3I8CiAgICAgcmV0dXJuIGhhbmRsZVNjb3BlLkNsb3NlKHJlc3VsdHMpOwogfQogCi12b2lkIFY4 UHJveHk6OnNldElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbihpbnQgd29ybGRJRCwgUGFzc1Jl ZlB0cjxTZWN1cml0eU9yaWdpbj4gcHJwU2VjdXJpdHlPcmlnaW5JbikKLXsKLSAgICBBU1NFUlQo d29ybGRJRCk7Ci0gICAgUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBzZWN1cml0eU9yaWdpbiA9IHBy cFNlY3VyaXR5T3JpZ2luSW47Ci0gICAgbV9pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zLnNl dCh3b3JsZElELCBzZWN1cml0eU9yaWdpbik7Ci0gICAgSXNvbGF0ZWRXb3JsZE1hcDo6aXRlcmF0 b3IgaXRlciA9IG1faXNvbGF0ZWRXb3JsZHMuZmluZCh3b3JsZElEKTsKLSAgICBpZiAoaXRlciAh PSBtX2lzb2xhdGVkV29ybGRzLmVuZCgpKQotICAgICAgICBpdGVyLT5zZWNvbmQtPnNldFNlY3Vy aXR5T3JpZ2luKHNlY3VyaXR5T3JpZ2luKTsKLX0KLQogUGFzc093blB0cjx2ODo6U2NyaXB0RGF0 YT4gVjhQcm94eTo6cHJlY29tcGlsZVNjcmlwdCh2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IGNvZGUs IENhY2hlZFNjcmlwdCogY2FjaGVkU2NyaXB0KQogewogICAgIC8vIEEgcHNldWRvLXJhbmRvbWx5 IGNob3NlbiBJRCB1c2VkIHRvIHN0b3JlIGFuZCByZXRyaWV2ZSBWOCBTY3JpcHREYXRhIGZyb20K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAppbmRleCA0MDQ1ODRhYjI5YzcxMTJmOTVm Nzg2ZTQ4MDg1ZWU4MDI3ODA3NmI4Li4yZTgyYzExZjA5N2RjZGU3YmZiZmRjNDgwNzg2NTkzMWVk NzYzNzBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCkBAIC00Miw2ICs0Miw3 IEBACiAjaW5jbHVkZSAiV3JhcHBlclR5cGVJbmZvLmgiCiAjaW5jbHVkZSA8djguaD4KICNpbmNs dWRlIDx3dGYvRm9yd2FyZC5oPgorI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8 d3RmL1Bhc3NSZWZQdHIuaD4gLy8gc28gZ2VuZXJhdGVkIGJpbmRpbmdzIGRvbid0IGhhdmUgdG8K ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvVGV4dFBvc2l0aW9u Lmg+CkBAIC03MSw2ICs3MiwxNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgLy8gVGhlIGxp c3Qgb2YgZXh0ZW5zaW9ucyB0aGF0IGFyZSByZWdpc3RlcmVkIGZvciB1c2Ugd2l0aCBWOC4KICAg ICB0eXBlZGVmIFdURjo6VmVjdG9yPHY4OjpFeHRlbnNpb24qPiBWOEV4dGVuc2lvbnM7CiAKKyAg ICAvLyBOb3RlOiBhbHRob3VnaCB0aGUgcG9pbnRlciBpcyByYXcsIHRoZSBpbnN0YW5jZSBpcyBr ZXB0IGFsaXZlIGJ5IGEgc3Ryb25nCisgICAgLy8gcmVmZXJlbmNlIHRvIHRoZSB2OCBjb250ZXh0 IGl0IGNvbnRhaW5zLCB3aGljaCBpcyBub3QgbWFkZSB3ZWFrIHVudGlsIHdlCisgICAgLy8gY2Fs bCB3b3JsZC0+ZGVzdHJveSgpLgorICAgIC8vCisgICAgLy8gRklYTUU6IFdlIHdhbnQgdG8gZXZl bnR1YWxseSBiZSBob2xkaW5nIHdpbmRvdyBzaGVsbHMgaW5zdGVhZCBvZiB0aGUKKyAgICAvLyAg ICAgICAgSXNvbGF0ZWRDb250ZXh0IGRpcmVjdGx5LgorICAgIHR5cGVkZWYgSGFzaE1hcDxpbnQs IFY4SXNvbGF0ZWRDb250ZXh0Kj4gSXNvbGF0ZWRXb3JsZE1hcDsKKworICAgIHR5cGVkZWYgSGFz aE1hcDxpbnQsIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gPiBJc29sYXRlZFdvcmxkU2VjdXJpdHlP cmlnaW5NYXA7CisKICAgICBjbGFzcyBWOFByb3h5IHsKICAgICBwdWJsaWM6CiAgICAgICAgIC8v IFRoZSB0eXBlcyBvZiBqYXZhc2NyaXB0IGVycm9ycyB0aGF0IGNhbiBiZSB0aHJvd24uCkBAIC05 OSw4ICsxMTAsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIGNvbnN0cnVjdG9y cy4KICAgICAgICAgdjg6OkxvY2FsPHY4OjpBcnJheT4gZXZhbHVhdGVJbklzb2xhdGVkV29ybGQo aW50IHdvcmxkSUQsIGNvbnN0IFZlY3RvcjxTY3JpcHRTb3VyY2VDb2RlPiYgc291cmNlcywgaW50 IGV4dGVuc2lvbkdyb3VwKTsKIAotICAgICAgICB2b2lkIHNldElzb2xhdGVkV29ybGRTZWN1cml0 eU9yaWdpbihpbnQgd29ybGRJRCwgUGFzc1JlZlB0cjxTZWN1cml0eU9yaWdpbj4pOwotCiAgICAg ICAgIC8vIEV2YWx1YXRlIGEgc2NyaXB0IGZpbGUgaW4gdGhlIGN1cnJlbnQgZXhlY3V0aW9uIGVu dmlyb25tZW50LgogICAgICAgICAvLyBUaGUgY2FsbGVyIG11c3QgaG9sZCBhbiBleGVjdXRpb24g Y29udGV4dC4KICAgICAgICAgLy8gSWYgY2Fubm90IGV2YWx1dGUgdGhlIHNjcmlwdCwgaXQgcmV0 dXJucyBhbiBlcnJvci4KQEAgLTE3Myw2ICsxODIsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog CiAgICAgICAgIHN0YXRpYyB2b2lkIHJlcG9ydFVuc2FmZUFjY2Vzc1RvKERvY3VtZW50KiB0YXJn ZXREb2N1bWVudCk7CiAKKyAgICAgICAgLy8gRklYTUU6IE1vdmUgbV9pc29sYXRlZFdvcmxkcyB0 byBTY3JpcHRDb250cm9sbGVyIGFuZCByZW1vdmUgdGhpcyBnZXR0ZXIuCisgICAgICAgIElzb2xh dGVkV29ybGRNYXAmIGlzb2xhdGVkV29ybGRzKCkgeyByZXR1cm4gbV9pc29sYXRlZFdvcmxkczsg fQorCisgICAgICAgIC8vIEZJWE1FOiBNb3ZlIG1faXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2lu cyB0byBTY3JpcHRDb250cm9sbGVyIGFuZCByZW1vdmUgdGhpcyBnZXR0ZXIuCisgICAgICAgIElz b2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbk1hcCYgaXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2lu cygpIHsgcmV0dXJuIG1faXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2luczsgfQorCiAgICAgcHJp dmF0ZToKICAgICAgICAgdm9pZCByZXNldElzb2xhdGVkV29ybGRzKCk7CiAKQEAgLTE5MSwxNyAr MjA2LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyBUaGUgaXNvbGF0ZWQgd29y bGRzIHdlIGFyZSB0cmFja2luZyBmb3IgdGhpcyBmcmFtZS4gV2UgaG9sZCB0aGVtIGFsaXZlCiAg ICAgICAgIC8vIGhlcmUgc28gdGhhdCB0aGV5IGNhbiBiZSB1c2VkIGFnYWluIGJ5IGZ1dHVyZSBj YWxscyB0bwogICAgICAgICAvLyBldmFsdWF0ZUluSXNvbGF0ZWRXb3JsZCgpLgotICAgICAgICAv LwotICAgICAgICAvLyBOb3RlOiBhbHRob3VnaCB0aGUgcG9pbnRlciBpcyByYXcsIHRoZSBpbnN0 YW5jZSBpcyBrZXB0IGFsaXZlIGJ5IGEgc3Ryb25nCi0gICAgICAgIC8vIHJlZmVyZW5jZSB0byB0 aGUgdjggY29udGV4dCBpdCBjb250YWlucywgd2hpY2ggaXMgbm90IG1hZGUgd2VhayB1bnRpbCB3 ZQotICAgICAgICAvLyBjYWxsIHdvcmxkLT5kZXN0cm95KCkuCi0gICAgICAgIC8vCi0gICAgICAg IC8vIEZJWE1FOiBXZSB3YW50IHRvIGV2ZW50dWFsbHkgYmUgaG9sZGluZyB3aW5kb3cgc2hlbGxz IGluc3RlYWQgb2YgdGhlCi0gICAgICAgIC8vICAgICAgICBJc29sYXRlZENvbnRleHQgZGlyZWN0 bHkuCi0gICAgICAgIHR5cGVkZWYgSGFzaE1hcDxpbnQsIFY4SXNvbGF0ZWRDb250ZXh0Kj4gSXNv bGF0ZWRXb3JsZE1hcDsKICAgICAgICAgSXNvbGF0ZWRXb3JsZE1hcCBtX2lzb2xhdGVkV29ybGRz OwogICAgICAgICAKLSAgICAgICAgdHlwZWRlZiBIYXNoTWFwPGludCwgUmVmUHRyPFNlY3VyaXR5 T3JpZ2luPiA+IElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbk1hcDsKICAgICAgICAgSXNvbGF0 ZWRXb3JsZFNlY3VyaXR5T3JpZ2luTWFwIG1faXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2luczsK ICAgICB9OwogCg==