93322 2012-08-06 19:12:53 -0700 Don't re-use the same EventDispatcher instance to dispatch events. 2012-08-07 23:33:16 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91290 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 688690 0 hayato 2012-08-06 19:12:53 -0700 Three are some member functions in EventDispatcher, which assume the instance of EventDispatcher is used for only one event. Example: - EventDispatcher::ensureEventAncestor calculates ancestors of node. But once the calculation is done, it never recalculates. The result of the calculation depends on the given event's type(). So it is potentially dangerous to call EventDispatcher::dispatchEvent(Event) twice with different events against the same EventDispatcher instance. We have to make sure the EventDspatcher instance is used only once per event. Currently dispatching 'dblclick' event violates this rule. 688827 1 156868 hayato 2012-08-06 22:38:54 -0700 Created attachment 156868 Fix dblclick event and add ASSERT 689116 2 156868 dglazkov 2012-08-07 07:10:49 -0700 Comment on attachment 156868 Fix dblclick event and add ASSERT ok 689799 3 156868 webkit.review.bot 2012-08-07 20:09:44 -0700 Comment on attachment 156868 Fix dblclick event and add ASSERT Clearing flags on attachment: 156868 Committed r124975: <http://trac.webkit.org/changeset/124975> 689800 4 webkit.review.bot 2012-08-07 20:09:47 -0700 All reviewed patches have been landed. Closing bug. 689952 5 156868 darin 2012-08-07 23:08:39 -0700 Comment on attachment 156868 Fix dblclick event and add ASSERT View in context: https://bugs.webkit.org/attachment.cgi?id=156868&action=review > Source/WebCore/dom/MouseEvent.cpp:-218 > - doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(), > - event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(), > - event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(), > - event()->button(), relatedTarget); This is the correct formatting for a multiple line function call in the WebKit coding style. > Source/WebCore/dom/MouseEvent.cpp:219 > + doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(), > + event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(), > + event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(), > + event()->button(), relatedTarget); Whereas this is incorrect. 689966 6 hayato 2012-08-07 23:33:16 -0700 Oh. Nice catch. Thank you. I think WebKit doesn't like a patch which only fixes style. So I'll fix it if i have a chance later. (In reply to comment #5) > (From update of attachment 156868 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156868&action=review > > > Source/WebCore/dom/MouseEvent.cpp:-218 > > - doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(), > > - event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(), > > - event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(), > > - event()->button(), relatedTarget); > > This is the correct formatting for a multiple line function call in the WebKit coding style. > > > Source/WebCore/dom/MouseEvent.cpp:219 > > + doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(), > > + event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(), > > + event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(), > > + event()->button(), relatedTarget); > > Whereas this is incorrect. 156868 2012-08-06 22:38:54 -0700 2012-08-07 23:08:39 -0700 Fix dblclick event and add ASSERT bug-93322-20120807143829.patch text/plain 5879 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhhMWZkZDczZmFmOGU1 MmQ5NTlmNzE1YTAzNjgzNDZjZDU5NTQxMS4uNWExZWQ2ZmM1NjlkZDJkMWYzMjEyMTg1OWY1Mjdl MjllOWI3YzQ2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDEyLTA4LTA2ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCByZS11c2UgdGhl IHNhbWUgRXZlbnREaXNwYXRjaGVyIGluc3RhbmNlIHRvIGRpc3BhdGNoIGV2ZW50cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgaXMgcG90ZW50aWFs bHkgZGFuZ2Vyb3VzIHRvIGNhbGwKKyAgICAgICAgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaEV2 ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KSB0d2ljZSBmb3IgdGhlCisgICAgICAgIHNhbWUgRXZlbnRE aXNwYXRjaGVyIGluc3RhbmNlLiAgU29tZSBtZW1iZXIgZnVuY3Rpb25zIGluCisgICAgICAgIEV2 ZW50RGlzcGF0Y2hlciBhc3N1bWUgdGhhdCBkaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+ KSBpcworICAgICAgICBuZXZlciBjYWxsZWQgbW9yZSB0aGFuIG9uY2UgaW4gaXRzIGxpZmUgY3lj bGUuCisKKyAgICAgICAgRm9yIGV4YW1wbGUsIEV2ZW50RGlzcGF0Y2hlcjo6ZW5zdXJlRXZlbnRB bmNlc3RvciBuZXZlcgorICAgICAgICByZWNhbGN1bGF0ZXMgYW5jZXN0b3JzIG9mIG5vZGUgZXZl biB3aGVuCisgICAgICAgIGRpc3BhdGNoRXZlbnQoUGFzc1JlZlB0cjxFdmVudCkpIGlzIGNhbGxl ZCBhZ2FpbiB3aXRoIGEgZGlmZmVyZW50CisgICAgICAgIGV2ZW50IHBhcmFtZXRlci4KKworICAg ICAgICBBICdkYmxjbGljaycgZXZlbnQgdmlvbGF0ZXMgdGhpcyBydWxlLiBBICdkYmxjbGljaycg ZGlzcGF0Y2hpbmcKKyAgICAgICAgcmV1c2VzIHRoZSBzYW1lIGRpc3BhdGNoZXIgaW5zdGFuY2Uu ICBTbyBzdG9wIHJlLXVzaW5nIHRoZSBzYW1lCisgICAgICAgIGRpc3BhdGNoZXIgYW5kIGFkZCBB U1NFUlQgdG8gbWFrZSBzdXJlIGRpc3BhdGNoRXZlbnQoKSBpcyBuZXZlcgorICAgICAgICBjYWxs ZWQgbW9yZSB0aGFuIG9uY2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4g ZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGRvbS9FdmVudERpc3BhdGNoZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RXZlbnREaXNwYXRjaGVyOjpFdmVudERpc3BhdGNoZXIpOgorICAgICAg ICAoV2ViQ29yZTo6RXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaEV2ZW50KToKKyAgICAgICAgKiBk b20vRXZlbnREaXNwYXRjaGVyLmg6CisgICAgICAgIChFdmVudERpc3BhdGNoZXIpOgorICAgICAg ICAqIGRvbS9Nb3VzZUV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vdXNlRXZlbnREaXNw YXRjaE1lZGlhdG9yOjpkaXNwYXRjaEV2ZW50KToKKwogMjAxMi0wOC0wNSAgTHVrZSBNYWNwaGVy c29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBudWxsIHBvaW50 ZXIgZGVyZWZlcmVuY2Ugd2hlbiBDU1NQYXJzZXI6OnNpbmtGbG9hdGluZ1ZhbHVlTGlzdCgpIHJl dHVybnMgbnVsbCBhbmQgaXMgcGFzc2VkIHRvIHN0b3JlVmFyaWFibGVEZWNsYXJhdGlvbigpLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCA5YmMwZGJhODIzNDVjNGJl YjUyMjU1ODkwYWEzODY2NWY2YTQ1YWRkLi5hYjRmMjI4YmQ3ODlhOTIyNzUxMDE4NzI0NmRjY2Mx ZGFjOWMzZmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMjAx LDYgKzIwMSw5IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjphZGp1c3RSZWxhdGVkVGFyZ2V0KEV2 ZW50KiBldmVudCwgUGFzc1JlZlB0cjxFdmVudFRhcmdldD4KIEV2ZW50RGlzcGF0Y2hlcjo6RXZl bnREaXNwYXRjaGVyKE5vZGUqIG5vZGUpCiAgICAgOiBtX25vZGUobm9kZSkKICAgICAsIG1fYW5j ZXN0b3JzSW5pdGlhbGl6ZWQoZmFsc2UpCisjaWZuZGVmIE5ERUJVRworICAgICwgbV9ldmVudERp c3BhdGNoZWQoZmFsc2UpCisjZW5kaWYKIHsKICAgICBBU1NFUlQobm9kZSk7CiAgICAgbV92aWV3 ID0gbm9kZS0+ZG9jdW1lbnQoKS0+dmlldygpOwpAQCAtMjM4LDYgKzI0MSwxMCBAQCB2b2lkIEV2 ZW50RGlzcGF0Y2hlcjo6ZW5zdXJlRXZlbnRBbmNlc3RvcnMoRXZlbnQqIGV2ZW50KQogCiBib29s IEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBwcnBFdmVu dCkKIHsKKyNpZm5kZWYgTkRFQlVHCisgICAgQVNTRVJUKCFtX2V2ZW50RGlzcGF0Y2hlZCk7Cisg ICAgbV9ldmVudERpc3BhdGNoZWQgPSB0cnVlOworI2VuZGlmCiAgICAgUmVmUHRyPEV2ZW50PiBl dmVudCA9IHBycEV2ZW50OwogICAgIGV2ZW50LT5zZXRUYXJnZXQoZXZlbnRUYXJnZXRSZXNwZWN0 aW5nU1ZHVGFyZ2V0UnVsZXMobV9ub2RlLmdldCgpKSk7CiAgICAgQVNTRVJUKCFldmVudERpc3Bh dGNoRm9yYmlkZGVuKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlz cGF0Y2hlci5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5oCmluZGV4IDE0 ZTI4YzFhZDlmYzEzNzNiNjlmM2RlYzE5NTEyOTA3NjlkYjA5ZDEuLjViZmVhZDBkMGU2Y2JlMGI4 MDAzNGQ0MjI1YTYwZTMyNGRmYWM4MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9F dmVudERpc3BhdGNoZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVy LmgKQEAgLTk2LDYgKzk2LDkgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8Tm9kZT4gbV9ub2RlOwog ICAgIFJlZlB0cjxGcmFtZVZpZXc+IG1fdmlldzsKICAgICBib29sIG1fYW5jZXN0b3JzSW5pdGlh bGl6ZWQ7CisjaWZuZGVmIE5ERUJVRworICAgIGJvb2wgbV9ldmVudERpc3BhdGNoZWQ7CisjZW5k aWYKIH07CiAKIGlubGluZSBOb2RlKiBFdmVudERpc3BhdGNoZXI6Om5vZGUoKSBjb25zdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlRXZlbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL01vdXNlRXZlbnQuY3BwCmluZGV4IGNmMmUyNjYwYTY1ZTM2MTFmNGI0N2VjZjhlY2U3 YWYyNzM3ZWY1MDIuLjllZGRhNzFlYWJlMTQyMTlhNzJjMTVmZGE1MmI2YWQ1MWJlMGQ5MTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTW91c2VFdmVudC5jcHAKQEAgLTIwNywyMiArMjA3LDIxIEBAIGJvb2wgTW91 c2VFdmVudERpc3BhdGNoTWVkaWF0b3I6OmRpc3BhdGNoRXZlbnQoRXZlbnREaXNwYXRjaGVyKiBk aXNwYXRjaGVyKSBjb25zCiAgICAgZGlzcGF0Y2hlci0+ZGlzcGF0Y2hFdmVudChldmVudCgpKTsK ICAgICBib29sIHN3YWxsb3dFdmVudCA9IGV2ZW50KCktPmRlZmF1bHRIYW5kbGVkKCkgfHwgZXZl bnQoKS0+ZGVmYXVsdFByZXZlbnRlZCgpOwogCisgICAgaWYgKGV2ZW50KCktPnR5cGUoKSAhPSBl dmVudE5hbWVzKCkuY2xpY2tFdmVudCB8fCBldmVudCgpLT5kZXRhaWwoKSAhPSAyKQorICAgICAg ICByZXR1cm4gc3dhbGxvd0V2ZW50OwogICAgIC8vIFNwZWNpYWwgY2FzZTogSWYgaXQncyBhIGRv dWJsZSBjbGljayBldmVudCwgd2UgYWxzbyBzZW5kIHRoZSBkYmxjbGljayBldmVudC4gVGhpcyBp cyBub3QgcGFydAogICAgIC8vIG9mIHRoZSBET00gc3BlY3MsIGJ1dCBpcyB1c2VkIGZvciBjb21w YXRpYmlsaXR5IHdpdGggdGhlIG9uZGJsY2xpY2s9IiIgYXR0cmlidXRlLiBUaGlzIGlzIHRyZWF0 ZWQKICAgICAvLyBhcyBhIHNlcGFyYXRlIGV2ZW50IGluIG90aGVyIERPTS1jb21wbGlhbnQgYnJv d3NlcnMgbGlrZSBGaXJlZm94LCBhbmQgc28gd2UgZG8gdGhlIHNhbWUuCi0gICAgaWYgKGV2ZW50 KCktPnR5cGUoKSA9PSBldmVudE5hbWVzKCkuY2xpY2tFdmVudCAmJiBldmVudCgpLT5kZXRhaWwo KSA9PSAyKSB7Ci0gICAgICAgIFJlZlB0cjxNb3VzZUV2ZW50PiBkb3VibGVDbGlja0V2ZW50ID0g TW91c2VFdmVudDo6Y3JlYXRlKCk7Ci0gICAgICAgIGRvdWJsZUNsaWNrRXZlbnQtPmluaXRNb3Vz ZUV2ZW50KGV2ZW50TmFtZXMoKS5kYmxjbGlja0V2ZW50LCBldmVudCgpLT5idWJibGVzKCksIGV2 ZW50KCktPmNhbmNlbGFibGUoKSwgZXZlbnQoKS0+dmlldygpLAotICAgICAgICAgICAgICAgIGV2 ZW50KCktPmRldGFpbCgpLCBldmVudCgpLT5zY3JlZW5YKCksIGV2ZW50KCktPnNjcmVlblkoKSwg ZXZlbnQoKS0+Y2xpZW50WCgpLCBldmVudCgpLT5jbGllbnRZKCksCi0gICAgICAgICAgICAgICAg ZXZlbnQoKS0+Y3RybEtleSgpLCBldmVudCgpLT5hbHRLZXkoKSwgZXZlbnQoKS0+c2hpZnRLZXko KSwgZXZlbnQoKS0+bWV0YUtleSgpLAotICAgICAgICAgICAgICAgIGV2ZW50KCktPmJ1dHRvbigp LCByZWxhdGVkVGFyZ2V0KTsKLSAgICAgICAgaWYgKGV2ZW50KCktPmRlZmF1bHRIYW5kbGVkKCkp Ci0gICAgICAgICAgICBkb3VibGVDbGlja0V2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwotICAg ICAgICBkaXNwYXRjaGVyLT5kaXNwYXRjaEV2ZW50KGRvdWJsZUNsaWNrRXZlbnQpOwotICAgICAg ICBpZiAoZG91YmxlQ2xpY2tFdmVudC0+ZGVmYXVsdEhhbmRsZWQoKSB8fCBkb3VibGVDbGlja0V2 ZW50LT5kZWZhdWx0UHJldmVudGVkKCkpCi0gICAgICAgICAgICBzd2FsbG93RXZlbnQgPSB0cnVl OwotICAgIH0KLQorICAgIFJlZlB0cjxNb3VzZUV2ZW50PiBkb3VibGVDbGlja0V2ZW50ID0gTW91 c2VFdmVudDo6Y3JlYXRlKCk7CisgICAgZG91YmxlQ2xpY2tFdmVudC0+aW5pdE1vdXNlRXZlbnQo ZXZlbnROYW1lcygpLmRibGNsaWNrRXZlbnQsIGV2ZW50KCktPmJ1YmJsZXMoKSwgZXZlbnQoKS0+ Y2FuY2VsYWJsZSgpLCBldmVudCgpLT52aWV3KCksCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZXZlbnQoKS0+ZGV0YWlsKCksIGV2ZW50KCktPnNjcmVlblgoKSwgZXZlbnQo KS0+c2NyZWVuWSgpLCBldmVudCgpLT5jbGllbnRYKCksIGV2ZW50KCktPmNsaWVudFkoKSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBldmVudCgpLT5jdHJsS2V5KCksIGV2 ZW50KCktPmFsdEtleSgpLCBldmVudCgpLT5zaGlmdEtleSgpLCBldmVudCgpLT5tZXRhS2V5KCks CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQoKS0+YnV0dG9uKCks IHJlbGF0ZWRUYXJnZXQpOworICAgIGlmIChldmVudCgpLT5kZWZhdWx0SGFuZGxlZCgpKQorICAg ICAgICBkb3VibGVDbGlja0V2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgIEV2ZW50RGlz cGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChkaXNwYXRjaGVyLT5ub2RlKCksIE1vdXNlRXZlbnREaXNw YXRjaE1lZGlhdG9yOjpjcmVhdGUoZG91YmxlQ2xpY2tFdmVudCkpOworICAgIGlmIChkb3VibGVD bGlja0V2ZW50LT5kZWZhdWx0SGFuZGxlZCgpIHx8IGRvdWJsZUNsaWNrRXZlbnQtPmRlZmF1bHRQ cmV2ZW50ZWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgcmV0dXJuIHN3YWxsb3dFdmVu dDsKIH0KIAo=