93154 2012-08-03 13:21:58 -0700 REGRESSION(r124632): Added new WebFrameTest.SelectRange which fails on bots (Requested by dimich on #webkit). 2012-08-03 13:24:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93108 1 webkit.review.bot webkit.review.bot abarth dimich oldest_to_newest 687088 0 webkit.review.bot 2012-08-03 13:21:58 -0700 http://trac.webkit.org/changeset/124632 broke the build: Added new WebFrameTest.SelectRange which fails on bots (Requested by dimich on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 687090 1 156445 webkit.review.bot 2012-08-03 13:22:33 -0700 Created attachment 156445 ROLLOUT of r124632 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 687091 2 156445 dimich 2012-08-03 13:24:00 -0700 Comment on attachment 156445 ROLLOUT of r124632 Clearing flags on attachment: 156445 Committed r124646: <http://trac.webkit.org/changeset/124646> 687092 3 dimich 2012-08-03 13:24:03 -0700 All reviewed patches have been landed. Closing bug. 687094 4 dimich 2012-08-03 13:24:50 -0700 It reliably fails on Win Canary bots: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/16451/steps/webkit_unit_tests/logs/stdio with this dump: WebFrameTest.SelectRange: tests\WebFrameTest.cpp(818): error: Value of: std::string(frame->selectionAsText().utf8().data()) Actual: "some test text for testin" Expected: "some test text for testing" tests\WebFrameTest.cpp(827): error: Value of: std::string(frame->selectionAsText().utf8().data()) Actual: "some offscreen test text for testin" Expected: "some offscreen test text for testing" 156445 2012-08-03 13:22:33 -0700 2012-08-03 13:24:00 -0700 ROLLOUT of r124632 bug-93154-20120803202807.patch text/plain 5485 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGZmMGYwNjgwZTUxMjA4YjUwZmZkYzhlMzUyNjgyYWEyZTVkNmQ0MTcuLjU5YTVkYmE4MjkwYmVh YzE3OGZjZWJjNTljYjZhZTIyMTRmYThhYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDgtMDMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjQ2MzIu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyNDYzMgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMxNTQKKworICAgICAg ICBBZGRlZCBuZXcgV2ViRnJhbWVUZXN0LlNlbGVjdFJhbmdlIHdoaWNoIGZhaWxzIG9uIGJvdHMK KyAgICAgICAgKFJlcXVlc3RlZCBieSBkaW1pY2ggb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiB0 ZXN0cy9XZWJGcmFtZVRlc3QuY3BwOgorICAgICAgICAqIHRlc3RzL2RhdGEvc2VsZWN0X3Jhbmdl X2Jhc2ljLmh0bWw6IFJlbW92ZWQuCisgICAgICAgICogdGVzdHMvZGF0YS9zZWxlY3RfcmFuZ2Vf aWZyYW1lLmh0bWw6IFJlbW92ZWQuCisgICAgICAgICogdGVzdHMvZGF0YS9zZWxlY3RfcmFuZ2Vf c2Nyb2xsLmh0bWw6IFJlbW92ZWQuCisKIDIwMTItMDgtMDMgIFRlcnJ5IEFuZGVyc29uICA8dGRh bmRlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQXBwbHkgdGFyZ2V0IGZ1enppbmcgd2hl biBzZW5kaW5nIGEgY29udGV4dCBtZW51IGV2ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAKaW5kZXggYmJmMjYzNjU3M2YwZmNiOTU1ZmI5MzVmNjU2 OThmMWNmYTAxOTI4Ny4uOWI3NDVlMDI5YTMzMmI5YTk2YmI3YmJiY2NjOGVjNGQ4NDQyM2Y0NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFtZVRlc3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcApAQCAt ODA0LDM4ICs4MDQsNCBAQCBURVNUX0YoV2ViRnJhbWVUZXN0LCBHZXRGdWxsSHRtbE9mUGFnZSkK ICAgICBFWFBFQ1RfVFJVRShzZWxlY3Rpb25IdG1sLmlzRW1wdHkoKSk7CiB9CiAKLVRFU1RfRihX ZWJGcmFtZVRlc3QsIFNlbGVjdFJhbmdlKQotewotICAgIHJlZ2lzdGVyTW9ja2VkSHR0cFVSTExv YWQoInNlbGVjdF9yYW5nZV9iYXNpYy5odG1sIik7Ci0gICAgV2ViVmlldyogd2ViVmlldyA9IEZy YW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKG1fYmFzZVVSTCArICJzZWxlY3Rf cmFuZ2VfYmFzaWMuaHRtbCIsIHRydWUpOwotICAgIFdlYkZyYW1lKiBmcmFtZSA9IHdlYlZpZXct Pm1haW5GcmFtZSgpOwotICAgIFdlYlJlY3Qgc3RhcnRXZWJSZWN0OwotICAgIFdlYlJlY3QgZW5k V2ViUmVjdDsKLSAgICB3ZWJWaWV3LT5zZWxlY3Rpb25Cb3VuZHMoc3RhcnRXZWJSZWN0LCBlbmRX ZWJSZWN0KTsKLSAgICBmcmFtZS0+ZXhlY3V0ZUNvbW1hbmQoV2ViU3RyaW5nOjpmcm9tVVRGOCgi VW5zZWxlY3QiKSk7Ci0gICAgRVhQRUNUX0VRKCIiLCBzdGQ6OnN0cmluZyhmcmFtZS0+c2VsZWN0 aW9uQXNUZXh0KCkudXRmOCgpLmRhdGEoKSkpOwotICAgIGZyYW1lLT5zZWxlY3RSYW5nZShXZWJQ b2ludChzdGFydFdlYlJlY3QueCwgc3RhcnRXZWJSZWN0LnkpLCBXZWJQb2ludChlbmRXZWJSZWN0 LnggKyBlbmRXZWJSZWN0LndpZHRoLCBlbmRXZWJSZWN0LnkgKyBlbmRXZWJSZWN0LmhlaWdodCkp OwotICAgIEVYUEVDVF9FUSgic29tZSB0ZXN0IHRleHQgZm9yIHRlc3RpbmciLCBzdGQ6OnN0cmlu ZyhmcmFtZS0+c2VsZWN0aW9uQXNUZXh0KCkudXRmOCgpLmRhdGEoKSkpOwotCi0gICAgcmVnaXN0 ZXJNb2NrZWRIdHRwVVJMTG9hZCgic2VsZWN0X3JhbmdlX3Njcm9sbC5odG1sIik7Ci0gICAgd2Vi VmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRMb2FkKG1fYmFzZVVSTCAr ICJzZWxlY3RfcmFuZ2Vfc2Nyb2xsLmh0bWwiLCB0cnVlKTsKLSAgICBmcmFtZSA9IHdlYlZpZXct Pm1haW5GcmFtZSgpOwotICAgIHdlYlZpZXctPnNlbGVjdGlvbkJvdW5kcyhzdGFydFdlYlJlY3Qs IGVuZFdlYlJlY3QpOwotICAgIGZyYW1lLT5leGVjdXRlQ29tbWFuZChXZWJTdHJpbmc6OmZyb21V VEY4KCJVbnNlbGVjdCIpKTsKLSAgICBFWFBFQ1RfRVEoIiIsIHN0ZDo6c3RyaW5nKGZyYW1lLT5z ZWxlY3Rpb25Bc1RleHQoKS51dGY4KCkuZGF0YSgpKSk7Ci0gICAgZnJhbWUtPnNlbGVjdFJhbmdl KFdlYlBvaW50KHN0YXJ0V2ViUmVjdC54LCBzdGFydFdlYlJlY3QueSksIFdlYlBvaW50KGVuZFdl YlJlY3QueCArIGVuZFdlYlJlY3Qud2lkdGgsIGVuZFdlYlJlY3QueSArIGVuZFdlYlJlY3QuaGVp Z2h0KSk7Ci0gICAgRVhQRUNUX0VRKCJzb21lIG9mZnNjcmVlbiB0ZXN0IHRleHQgZm9yIHRlc3Rp bmciLCBzdGQ6OnN0cmluZyhmcmFtZS0+c2VsZWN0aW9uQXNUZXh0KCkudXRmOCgpLmRhdGEoKSkp OwotCi0gICAgcmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCgic2VsZWN0X3JhbmdlX2lmcmFtZS5o dG1sIik7Ci0gICAgd2ViVmlldyA9IEZyYW1lVGVzdEhlbHBlcnM6OmNyZWF0ZVdlYlZpZXdBbmRM b2FkKG1fYmFzZVVSTCArICJzZWxlY3RfcmFuZ2VfaWZyYW1lLmh0bWwiLCB0cnVlKTsKLSAgICBm cmFtZSA9IHdlYlZpZXctPm1haW5GcmFtZSgpOwotICAgIFdlYkZyYW1lKiBzdWJmcmFtZSA9IGZy YW1lLT5maW5kQ2hpbGRCeUV4cHJlc3Npb24oV2ViU3RyaW5nOjpmcm9tVVRGOCgiL2h0bWwvYm9k eS9pZnJhbWUiKSk7Ci0gICAgd2ViVmlldy0+c2VsZWN0aW9uQm91bmRzKHN0YXJ0V2ViUmVjdCwg ZW5kV2ViUmVjdCk7Ci0gICAgRVhQRUNUX0VRKCJzb21lIHRlc3QgdGV4dCBmb3IgdGVzdGluZyIs IHN0ZDo6c3RyaW5nKHN1YmZyYW1lLT5zZWxlY3Rpb25Bc1RleHQoKS51dGY4KCkuZGF0YSgpKSk7 Ci0gICAgc3ViZnJhbWUtPmV4ZWN1dGVDb21tYW5kKFdlYlN0cmluZzo6ZnJvbVVURjgoIlVuc2Vs ZWN0IikpOwotICAgIEVYUEVDVF9FUSgiIiwgc3RkOjpzdHJpbmcoc3ViZnJhbWUtPnNlbGVjdGlv bkFzVGV4dCgpLnV0ZjgoKS5kYXRhKCkpKTsKLSAgICBzdWJmcmFtZS0+c2VsZWN0UmFuZ2UoV2Vi UG9pbnQoc3RhcnRXZWJSZWN0LngsIHN0YXJ0V2ViUmVjdC55KSwgV2ViUG9pbnQoZW5kV2ViUmVj dC54ICsgZW5kV2ViUmVjdC53aWR0aCwgZW5kV2ViUmVjdC55ICsgZW5kV2ViUmVjdC5oZWlnaHQp KTsKLSAgICBFWFBFQ1RfRVEoInNvbWUgdGVzdCB0ZXh0IGZvciB0ZXN0aW5nIiwgc3RkOjpzdHJp bmcoc3ViZnJhbWUtPnNlbGVjdGlvbkFzVGV4dCgpLnV0ZjgoKS5kYXRhKCkpKTsKLX0KLQogfSAv LyBuYW1lc3BhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvZGF0 YS9zZWxlY3RfcmFuZ2VfYmFzaWMuaHRtbCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv ZGF0YS9zZWxlY3RfcmFuZ2VfYmFzaWMuaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggN2Y3NjUzMjIzMTJlYTlhYzA2YTNhMzVhMzFmZDA2NDM2NWQyODFmMC4uMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL2RhdGEvc2VsZWN0X3JhbmdlX2Jhc2ljLmh0bWwKKysrIC9kZXYvbnVsbApAQCAtMSw5 ICswLDAgQEAKLTxzcGFuIGlkPSd0YXJnZXQnPnNvbWUgdGVzdCB0ZXh0IGZvciB0ZXN0aW5nPC9z cGFuPgotPHNjcmlwdD4KLSAgICBmdW5jdGlvbiBzZWxlY3QoKSB7Ci0gICAgICAgIHZhciByYW5n ZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7Ci0gICAgICAgIHJhbmdlLnNlbGVjdE5vZGUoZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldCcpKTsKLSAgICAgICAgd2luZG93LmdldFNlbGVj dGlvbigpLmFkZFJhbmdlKHJhbmdlKTsKLSAgICB9Ci0gICAgd2luZG93Lm9ubG9hZCA9IHNlbGVj dDsKLTwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9k YXRhL3NlbGVjdF9yYW5nZV9pZnJhbWUuaHRtbCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvZGF0YS9zZWxlY3RfcmFuZ2VfaWZyYW1lLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IGY1Yzk3ZTE4NTUxOTE4NDk4NzdiMzQxMDgzNjA2Yjc4NTk0M2NhMWYuLjAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9kYXRhL3NlbGVjdF9yYW5nZV9pZnJhbWUuaHRtbAorKysgL2Rldi9udWxsCkBA IC0xLDkgKzAsMCBAQAotPGh0bWw+Ci0gIDxib2R5PgotICAgIFRoaXMgaXMgYSB0ZXN0IGNhc2Ug Zm9yIHNlbGVjdGluZyBhIHJhbmdlIHdpdGhpbiBhbiBpZnJhbWUuCi0gICAgPGlmcmFtZSB3aWR0 aD00MDAgaGVpZ2h0PTIwMCBpZD0iaWZyYW1lIiBzcmM9InNlbGVjdF9yYW5nZV9iYXNpYy5odG1s Ij48L2lmcmFtZT4KLSAgPC9ib2R5PgotPC9odG1sPgotPHNjcmlwdD4KLSAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnaWZyYW1lJykuY29udGVudFdpbmRvdy5mb2N1cygpOwotPC9zY3JpcHQ+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvc2VsZWN0X3Jh bmdlX3Njcm9sbC5odG1sIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9kYXRhL3NlbGVj dF9yYW5nZV9zY3JvbGwuaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggOTk0Y2Ey YmI5YzQ4NDgwMmQ3MzM2ZjZhZTA1YWVlMzhmM2E3ZWVjNC4uMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2Rh dGEvc2VsZWN0X3JhbmdlX3Njcm9sbC5odG1sCisrKyAvZGV2L251bGwKQEAgLTEsOSArMCwwIEBA Ci08ZGl2IHN0eWxlPSdoZWlnaHQ6MzAwMHB4Jz4KLSAgICA8c3BhbiBpZD0idGFyZ2V0Ij5zb21l IG9mZnNjcmVlbiB0ZXN0IHRleHQgZm9yIHRlc3Rpbmc8L3NwYW4+Ci08L2Rpdj4KLTxzY3JpcHQ+ Ci0gICAgdmFyIHJhbmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKLSAgICByYW5nZS5zZWxl Y3ROb2RlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKSk7Ci0gICAgd2luZG93Lmdl dFNlbGVjdGlvbigpLmFkZFJhbmdlKHJhbmdlKTsKLSAgICB3aW5kb3cuc2Nyb2xsQnkoMCw1MDAp OwotPC9zY3JpcHQ+Cg==