93152 2012-08-03 13:00:59 -0700 REGRESSION(r124594): Broke PlatformAppBrowserTest.Iframes browser_test on Chromium bots (Requested by dimich on #webkit). 2012-08-03 13:04:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93079 1 webkit.review.bot webkit.review.bot abarth dimich eric oldest_to_newest 687074 0 webkit.review.bot 2012-08-03 13:00:59 -0700 http://trac.webkit.org/changeset/124594 broke the build: Broke PlatformAppBrowserTest.Iframes browser_test on Chromium bots (Requested by dimich on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 687077 1 156442 webkit.review.bot 2012-08-03 13:01:36 -0700 Created attachment 156442 ROLLOUT of r124594 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 687078 2 156442 dimich 2012-08-03 13:04:07 -0700 Comment on attachment 156442 ROLLOUT of r124594 Clearing flags on attachment: 156442 Committed r124644: <http://trac.webkit.org/changeset/124644> 687079 3 dimich 2012-08-03 13:04:09 -0700 All reviewed patches have been landed. Closing bug. 156442 2012-08-03 13:01:36 -0700 2012-08-03 13:04:07 -0700 ROLLOUT of r124594 bug-93152-20120803200711.patch text/plain 7171 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmMyMGNhYTcyZWNlOTNk OGVkNjIyMDkwNTFlNzRkY2JhMjQ3OWM5MC4uODg4NTZiYTA2NjU0NDljMGJhNTlmY2EyNjFjZGUy MmQ3NDk2MmIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA4LTAzICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTI0NTk0LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMjQ1OTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkzMTUyCisKKyAgICAgICAgQnJva2UgUGxhdGZvcm1BcHBCcm93c2VyVGVzdC5J ZnJhbWVzIGJyb3dzZXJfdGVzdCBvbiBDaHJvbWl1bQorICAgICAgICBib3RzIChSZXF1ZXN0ZWQg YnkgZGltaWNoIG9uICN3ZWJraXQpLgorCisgICAgICAgICogYmluZGluZ3MvZ2VuZXJpYy9CaW5k aW5nU2VjdXJpdHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FuQWNjZXNzKToKKyAgICAgICAg KFdlYkNvcmU6OkJpbmRpbmdTZWN1cml0eTo6Y2FuQWNjZXNzRnJhbWUpOgorICAgICAgICAoV2Vi Q29yZTo6QmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvTm9kZSk6CisgICAgICAg ICogYmluZGluZ3MvdjgvQmluZGluZ1N0YXRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmltbWVk aWF0ZWx5UmVwb3J0VW5zYWZlQWNjZXNzVG8pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L0JpbmRp bmdTdGF0ZS5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhE T01XaW5kb3dTaGVsbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRVbnNhZmVKYXZhU2Ny aXB0QWNjZXNzKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKToKKyAgICAgICAgKiBiaW5k aW5ncy92OC9WOFByb3h5Lmg6CisgICAgICAgIChWOFByb3h5KToKKwogMjAxMi0wOC0wMyAgVGVy cnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBcHBseSB0 YXJnZXQgZnV6emluZyB3aGVuIHNlbmRpbmcgYSBjb250ZXh0IG1lbnUgZXZlbnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvQmluZGluZ1NlY3VyaXR5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvQmluZGluZ1NlY3VyaXR5LmNwcAppbmRl eCBhMjk4Y2FlNDc0MjUyMmMxZmU2ZTkwNWY3MjMzZjEwMWRmYzZkM2VmLi4xZjM3Yjc5ZTQ1MGE1 MTAwZmZiMjIyM2MyNGE1NjlmYzBmMGIyYjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9nZW5lcmljL0JpbmRpbmdTZWN1cml0eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvZ2VuZXJpYy9CaW5kaW5nU2VjdXJpdHkuY3BwCkBAIC00MiwyOCArNDIsNDAgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0aWMgYm9vbCBjYW5BY2Nlc3NEb2N1bWVudChC aW5kaW5nU3RhdGUqIHN0YXRlLCBEb2N1bWVudCogdGFyZ2V0RG9jdW1lbnQsIGJvb2wgcmVwb3J0 RXJyb3IpCitzdGF0aWMgYm9vbCBjYW5BY2Nlc3MoRE9NV2luZG93KiBhY3RpdmVXaW5kb3csIERP TVdpbmRvdyogdGFyZ2V0V2luZG93KQogewotICAgIC8vIFdlIGhhdmUgc2VlbiBjcmFzaGVzIHdl cmUgdGhlIHRhcmdldCBpcyAwLCBidXQgd2UgZG9uJ3QgaGF2ZSBhIHRlc3QgY2FzZSBmb3IgaXQu Ci0gICAgaWYgKCF0YXJnZXREb2N1bWVudCkKKyAgICBBU1NFUlQodGFyZ2V0V2luZG93KTsKKyAg ICBpZiAoYWN0aXZlV2luZG93ID09IHRhcmdldFdpbmRvdykKKyAgICAgICAgcmV0dXJuIHRydWU7 CisKKyAgICBpZiAoIWFjdGl2ZVdpbmRvdykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAg RE9NV2luZG93KiBhY3RpdmUgPSBhY3RpdmVXaW5kb3coc3RhdGUpOwotICAgIGlmICghYWN0aXZl KQorICAgIFNlY3VyaXR5T3JpZ2luKiBhY3RpdmVTZWN1cml0eU9yaWdpbiA9IGFjdGl2ZVdpbmRv dy0+c2VjdXJpdHlPcmlnaW4oKTsKKyAgICBTZWN1cml0eU9yaWdpbiogdGFyZ2V0U2VjdXJpdHlP cmlnaW4gPSB0YXJnZXRXaW5kb3ctPnNlY3VyaXR5T3JpZ2luKCk7CisKKyAgICAvLyBXZSBoYXZl IHNlZW4gY3Jhc2hlcyB3ZXJlIHRoZSBzZWN1cml0eSBvcmlnaW4gb2YgdGhlIHRhcmdldCBoYXMg bm90IGJlZW4KKyAgICAvLyBpbml0aWFsaXplZC4gRGVmZW5kIGFnYWluc3QgdGhhdC4KKyAgICBp ZiAoIXRhcmdldFNlY3VyaXR5T3JpZ2luKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBp ZiAoYWN0aXZlLT5zZWN1cml0eU9yaWdpbigpLT5jYW5BY2Nlc3ModGFyZ2V0RG9jdW1lbnQtPnNl Y3VyaXR5T3JpZ2luKCkpKQorICAgIGlmIChhY3RpdmVTZWN1cml0eU9yaWdpbi0+Y2FuQWNjZXNz KHRhcmdldFNlY3VyaXR5T3JpZ2luKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBpZiAo cmVwb3J0RXJyb3IpCi0gICAgICAgIGltbWVkaWF0ZWx5UmVwb3J0VW5zYWZlQWNjZXNzVG8oc3Rh dGUsIHRhcmdldERvY3VtZW50KTsKLQogICAgIHJldHVybiBmYWxzZTsKIH0KIAogYm9vbCBCaW5k aW5nU2VjdXJpdHk6OmNhbkFjY2Vzc0ZyYW1lKEJpbmRpbmdTdGF0ZSogc3RhdGUsIEZyYW1lKiB0 YXJnZXQsIGJvb2wgcmVwb3J0RXJyb3IpCiB7Ci0gICAgcmV0dXJuIHRhcmdldCAmJiBjYW5BY2Nl c3NEb2N1bWVudChzdGF0ZSwgdGFyZ2V0LT5kb2N1bWVudCgpLCByZXBvcnRFcnJvcik7CisgICAg aWYgKCF0YXJnZXQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghY2FuQWNjZXNz KGFjdGl2ZVdpbmRvdyhzdGF0ZSksIHRhcmdldC0+ZG9tV2luZG93KCkpKSB7CisgICAgICAgIGlm IChyZXBvcnRFcnJvcikKKyAgICAgICAgICAgIGltbWVkaWF0ZWx5UmVwb3J0VW5zYWZlQWNjZXNz VG8oc3RhdGUsIHRhcmdldCk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0 dXJuIHRydWU7CiB9CiAKIGJvb2wgQmluZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1Rv Tm9kZShCaW5kaW5nU3RhdGUqIHN0YXRlLCBOb2RlKiBub2RlKQpAQCAtNzEsNyArODMsNiBAQCBi b29sIEJpbmRpbmdTZWN1cml0eTo6c2hvdWxkQWxsb3dBY2Nlc3NUb05vZGUoQmluZGluZ1N0YXRl KiBzdGF0ZSwgTm9kZSogbm9kZSkKICAgICBpZiAoIW5vZGUpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAotICAgIC8vIEZJWE1FOiBXZSBzaG91bGRuJ3QgbmVlZCB0byBnbyB0aHJvdWdoIHRoZSBm cmFtZSBoZXJlIGJlY2F1c2Ugd2UgYWxyZWFkeSBoYXZlIHRoZSBkb2N1bWVudC4KICAgICBGcmFt ZSogdGFyZ2V0ID0gbm9kZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKICAgICBpZiAoIXRhcmdldCkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvQmluZGluZ1N0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRp bmdTdGF0ZS5jcHAKaW5kZXggZmRmNWMwNzA1YWRkZDFiYTI0YjZlYTA0OTk3NDQ4OWI2YjMzN2Zl Zi4uYzRkOTc4Nzc1YTExNjJjNDZjOWJlNjFhNDk4M2Y0ZGFiMmYxYmVkNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvQmluZGluZ1N0YXRlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9CaW5kaW5nU3RhdGUuY3BwCkBAIC04OSw5ICs4OSw5IEBAIEZy YW1lKiBjdXJyZW50RnJhbWUoQmluZGluZ1N0YXRlKikKICAgICByZXR1cm4gVjhQcm94eTo6cmV0 cmlldmVGcmFtZShjb250ZXh0KTsKIH0KIAotdm9pZCBpbW1lZGlhdGVseVJlcG9ydFVuc2FmZUFj Y2Vzc1RvKEJpbmRpbmdTdGF0ZSosIERvY3VtZW50KiB0YXJnZXREb2N1bWVudCkKK3ZvaWQgaW1t ZWRpYXRlbHlSZXBvcnRVbnNhZmVBY2Nlc3NUbyhCaW5kaW5nU3RhdGUqLCBGcmFtZSogdGFyZ2V0 KQogewotICAgIFY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKHRhcmdldERvY3VtZW50KTsK KyAgICBWOFByb3h5OjpyZXBvcnRVbnNhZmVBY2Nlc3NUbyh0YXJnZXQpOwogfQogCiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9CaW5kaW5nU3RhdGUuaCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5oCmluZGV4IDk3MTFlZTg5NGFjODIy YTIwZjg1ZjQxMmYzNDAzNDdjYTZiY2UwZmQuLjcwMDA4MDM2YWY2MjNkMjE2ZTdhZDk1MTU5ZWY0 N2E0N2ZjNDY1OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRp bmdTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5o CkBAIC0zNCw3ICszNCw2IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIERPTVdpbmRv dzsKLWNsYXNzIERvY3VtZW50OwogY2xhc3MgRnJhbWU7CiAKIGNsYXNzIEJpbmRpbmdTdGF0ZSB7 CkBAIC01NCw3ICs1Myw3IEBAIEZyYW1lKiBmaXJzdEZyYW1lKEJpbmRpbmdTdGF0ZSopOwogLy8g YXJlIGFueSBzdWJ0bGUgZGlmZmVyZW5jZXMgYmV0d2VlbiB0aGUgY3VycmVudEZyYW1lIGFuZCB0 aGUgbGV4aWNhbEdsb2JhbE9iamVjdC4KIEZyYW1lKiBjdXJyZW50RnJhbWUoQmluZGluZ1N0YXRl Kik7CiAKLXZvaWQgaW1tZWRpYXRlbHlSZXBvcnRVbnNhZmVBY2Nlc3NUbyhCaW5kaW5nU3RhdGUq LCBEb2N1bWVudCogdGFyZ2V0RG9jdW1lbnQpOwordm9pZCBpbW1lZGlhdGVseVJlcG9ydFVuc2Fm ZUFjY2Vzc1RvKEJpbmRpbmdTdGF0ZSosIEZyYW1lKik7CiAKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAppbmRleCBhYmY3OWIzNzBjZTgy OWU5YTlmYTlkMjc0ZTJjYTk1N2I1MzA4ZTdlLi5iZWFmNDc0Y2FjNzQ4N2Q5YzQ4NDE2YWFjMGMx NTg3Mjg1ZGY0ZWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERP TVdpbmRvd1NoZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdp bmRvd1NoZWxsLmNwcApAQCAtMTUyLDcgKzE1Miw3IEBAIHN0YXRpYyB2b2lkIHJlcG9ydFVuc2Fm ZUphdmFTY3JpcHRBY2Nlc3Modjg6OkxvY2FsPHY4OjpPYmplY3Q+IGhvc3QsIHY4OjpBY2Nlc3NU CiB7CiAgICAgRnJhbWUqIHRhcmdldCA9IGdldFRhcmdldEZyYW1lKGhvc3QsIGRhdGEpOwogICAg IGlmICh0YXJnZXQpCi0gICAgICAgIFY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKHRhcmdl dC0+ZG9jdW1lbnQoKSk7CisgICAgICAgIFY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKHRh cmdldCk7CiB9CiAKIFBhc3NSZWZQdHI8VjhET01XaW5kb3dTaGVsbD4gVjhET01XaW5kb3dTaGVs bDo6Y3JlYXRlKEZyYW1lKiBmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4UHJveHkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5j cHAKaW5kZXggYmU2OTZiNTE4MDU1NzU5YjFiMWI0MmJhZTU3ODdlYzI4YTk1NmE2MC4uNjgxZmMy M2E1MmJhM2JlNjMwNjQ0MWQ4ZDc4NjQ2OGQyNjJmOWRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhQcm94eS5jcHAKQEAgLTEyNCwxMiArMTI0LDEzIEBAIHR5cGVkZWYgSGFzaE1hcDxO b2RlKiwgdjg6Ok9iamVjdCo+IERPTU5vZGVNYXA7CiB0eXBlZGVmIEhhc2hNYXA8dm9pZCosIHY4 OjpPYmplY3QqPiBET01PYmplY3RNYXA7CiB0eXBlZGVmIEhhc2hNYXA8aW50LCB2ODo6RnVuY3Rp b25UZW1wbGF0ZSo+IEZ1bmN0aW9uVGVtcGxhdGVNYXA7CiAKLXZvaWQgVjhQcm94eTo6cmVwb3J0 VW5zYWZlQWNjZXNzVG8oRG9jdW1lbnQqIHRhcmdldERvY3VtZW50KQordm9pZCBWOFByb3h5Ojpy ZXBvcnRVbnNhZmVBY2Nlc3NUbyhGcmFtZSogdGFyZ2V0KQogeworICAgIEFTU0VSVCh0YXJnZXQp OworICAgIERvY3VtZW50KiB0YXJnZXREb2N1bWVudCA9IHRhcmdldC0+ZG9jdW1lbnQoKTsKICAg ICBpZiAoIXRhcmdldERvY3VtZW50KQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBGSVhNRTog V2Ugc2hvdWxkIHBhc3MgYm90aCB0aGUgYWN0aXZlIGFuZCB0YXJnZXQgZG9jdW1lbnRzIGluIGFz IGFyZ3VtZW50cy4KICAgICBGcmFtZSogc291cmNlID0gZmlyc3RGcmFtZShCaW5kaW5nU3RhdGU6 Omluc3RhbmNlKCkpOwogICAgIGlmICghc291cmNlKQogICAgICAgICByZXR1cm47CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKaW5kZXggZjM1MDU2NGQyYmE2NDhmMmIyZTRjMzljNDRm NDU5MmYxMzk5MTkzOC4uNDc4YTY0M2RkYmVmNGUxOThiNjdjMzg5MTY4YWU0ZmQyODcyMWNlMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaApAQCAtMjI0LDcgKzIyNCw4IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBzdGF0aWMgY29uc3QgVjhFeHRlbnNpb25zJiBl eHRlbnNpb25zKCk7CiAKLSAgICAgICAgc3RhdGljIHZvaWQgcmVwb3J0VW5zYWZlQWNjZXNzVG8o RG9jdW1lbnQqIHRhcmdldERvY3VtZW50KTsKKyAgICAgICAgLy8gUmVwb3J0IGFuIHVuc2FmZSBh dHRlbXB0IHRvIGFjY2VzcyB0aGUgZ2l2ZW4gZnJhbWUgb24gdGhlIGNvbnNvbGUuCisgICAgICAg IHN0YXRpYyB2b2lkIHJlcG9ydFVuc2FmZUFjY2Vzc1RvKEZyYW1lKiB0YXJnZXQpOwogCiAgICAg cHJpdmF0ZToKICAgICAgICAgdm9pZCByZXNldElzb2xhdGVkV29ybGRzKCk7Cg==