92921 2012-08-01 16:32:59 -0700 [Chromium] WebViewImpl::showTouchHighlightQuads isn't needed for Android 2012-08-02 09:48:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth dglazkov japhet trchen webkit.review.bot oldest_to_newest 684754 0 abarth 2012-08-01 16:32:59 -0700 [Chromium] WebViewImpl::showTouchHighlightQuads isn't needed for Android 684755 1 155919 abarth 2012-08-01 16:34:39 -0700 Created attachment 155919 Patch 684767 2 155919 webkit.review.bot 2012-08-01 16:47:48 -0700 Comment on attachment 155919 Patch Attachment 155919 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13403773 684775 3 155924 abarth 2012-08-01 16:55:36 -0700 Created attachment 155924 Patch 685500 4 155924 webkit.review.bot 2012-08-02 09:48:49 -0700 Comment on attachment 155924 Patch Clearing flags on attachment: 155924 Committed r124471: <http://trac.webkit.org/changeset/124471> 685501 5 webkit.review.bot 2012-08-02 09:48:53 -0700 All reviewed patches have been landed. Closing bug. 155919 2012-08-01 16:34:39 -0700 2012-08-01 16:55:33 -0700 Patch bug-92921-20120801163421.patch text/plain 3258 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGViM2Q4NjgxMGVjZGJkMWIxMWQ0NmViM2NjZDVkNjNiYjM4MTFiNjMuLjkxMzc5MTgwN2ExZGNl NDYxNDEzMDM1NWI0OTdjNDczYzVhNGU1MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYlZpZXdJbXBsOjpzaG93VG91Y2hIaWdobGlnaHRR dWFkcyBpc24ndCBuZWVkZWQgZm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyOTIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2Ugb3JpZ2luYWxseSBhZGRlZCBhIHN0dWIgaW1wbGVtZW50 YXRpb24gb2YgdGhpcyBmdW5jdGlvbiB0byBtYWtlCisgICAgICAgIG1lcmdpbmcgZGV0ZWN0Q29u dGVudE9uVG91Y2ggZWFzaWVyLCBidXQgc2hvd1RvdWNoSGlnaGxpZ2h0UXVhZHMgaXMKKyAgICAg ICAgYmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBjaHJvbWl1bS1hbmRyb2lkIGJyYW5jaCBpbiBmYXZv ciBvZiB0aGUgY29kZSBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ0ODcuIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUKKyAgICAgICAgc3R1Yi4KKwor ICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjpkZXRlY3RDb250ZW50SW50ZW50T25Ub3VjaCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJ bXBsLmg6CisgICAgICAgIChXZWJWaWV3SW1wbCk6CisKIDIwMTItMDgtMDEgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUm9sbCBjaHJvbWl1bSBERVBTIHRv IDE0OTQxNi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRl eCBkODc1MGUzOGEyODdlYjE5MDczNzQ0Y2MwMzllMmM0YTI0ZDRlYzk0Li45YjNmZmJiNzcwZWQx ZDVjZDk1YTFlOWU3NTJlNDg2MzY1NWU5YjYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCkBAIC0zODIwLDEyICszODIwLDYgQEAgV2ViR3JhcGhpY3NDb250 ZXh0M0QqIFdlYlZpZXdJbXBsOjpzaGFyZWRHcmFwaGljc0NvbnRleHQzRCgpCiAgICAgcmV0dXJu IEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6ZXh0cmFjdFdlYkdyYXBoaWNzQ29udGV4dDNEKFNo YXJlZEdyYXBoaWNzQ29udGV4dDNEOjpnZXQoKS5nZXQoKSk7CiB9CiAKLXZvaWQgV2ViVmlld0lt cGw6OnNob3dUb3VjaEhpZ2hsaWdodFF1YWRzKGNvbnN0IFdlYlZlY3RvcjxXZWJGbG9hdFF1YWQ+ JiBoaWdobGlnaHQsIFdlYkNvbG9yIGhpZ2hsaWdodENvbG9yKQotewotICAgIC8vIEZJWE1FOiBV cHN0cmVhbSB0aGlzIGZ1bmN0aW9uIGZyb20gdGhlIGNocm9taXVtLWFuZHJvaWQgYnJhbmNoLgot ICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KIHZvaWQgV2ViVmlld0ltcGw6OnNlbGVjdEF1dG9m aWxsU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogewogICAgIGlmIChtX2F1 dG9maWxsUG9wdXBDbGllbnQgJiYgbGlzdEluZGV4IDwgbV9hdXRvZmlsbFBvcHVwQ2xpZW50LT5n ZXRTdWdnZXN0aW9uc0NvdW50KCkpCkBAIC0zODU2LDExICszODUwLDYgQEAgYm9vbCBXZWJWaWV3 SW1wbDo6ZGV0ZWN0Q29udGVudEludGVudE9uVG91Y2goY29uc3QgV2ViUG9pbnQmIHBvc2l0aW9u LCBXZWJJbnB1dEUKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgLy8gVGVtcG9y YXJpbHkgaGlnaGxpZ2h0IHRoZSBjb250ZW50IGFzIHdlIGRvIHdpdGggbGlua3MuCi0gICAgQ29s b3IgdGFwSGlnaGxpZ2h0Q29sb3IgPSB0YXBIaWdobGlnaHRDb2xvckZvck5vZGUodG91Y2hIaXQu aW5uZXJOb2RlKCkpOwotICAgIFdlYlZlY3RvcjxXZWJGbG9hdFF1YWQ+IHF1YWRzID0gY29udGVu dC5yYW5nZSgpLnRleHRRdWFkcygpOwotICAgIHNob3dUb3VjaEhpZ2hsaWdodFF1YWRzKHF1YWRz LCB0YXBIaWdobGlnaHRDb2xvci5yZ2IoKSk7Ci0KICAgICBtX2NsaWVudC0+c2NoZWR1bGVDb250 ZW50SW50ZW50KGNvbnRlbnQuaW50ZW50KCkpOwogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggMGIxZGEyYTI3ZDU2OTEzYmU2 MjAwMWFlZmIwMjA1OWFmZmNkMDgwNS4uMDc0YTgzNjliZDNmN2RkODk3OWE3MzQ0N2RiMGJhMGIz YmE1NmM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0y ODUsOCArMjg1LDYgQEAgcHVibGljOgogICAgICAgICBjb25zdCBXZWJWZWN0b3I8aW50PiYgaXRl bUlEcywKICAgICAgICAgaW50IHNlcGFyYXRvckluZGV4KTsKICAgICB2aXJ0dWFsIHZvaWQgaGlk ZVBvcHVwcygpOwotICAgIC8vIEZJWE1FOiBFeHBvc2Ugc2hvd1RvdWNoSGlnaGxpZ2h0UXVhZHMg aW4gdGhlIHB1YmxpYyBXZWJWaWV3IEFQSSB3aGVuIGl0IGRvZXMgc29tZXRoaW5nLgotICAgIHZp cnR1YWwgdm9pZCBzaG93VG91Y2hIaWdobGlnaHRRdWFkcyhjb25zdCBXZWJWZWN0b3I8V2ViRmxv YXRRdWFkPiYgaGlnaGxpZ2h0LCBXZWJDb2xvciBoaWdobGlnaHRDb2xvcik7CiAgICAgdmlydHVh bCB2b2lkIHNlbGVjdEF1dG9maWxsU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4 KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2Nyb2xsYmFyQ29sb3JzKHVuc2lnbmVkIGluYWN0aXZl Q29sb3IsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBhY3Rp dmVDb2xvciwK 155924 2012-08-01 16:55:36 -0700 2012-08-02 09:48:49 -0700 Patch bug-92921-20120801165517.patch text/plain 3885 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY1MTgyMWQzOWNhMDgyYjk0MmI3YTc0ODFlOGYyMGFjZTUxNDg1NjguLjMyN2EyODMzNjA5Zjlh ZTQxZjlmNjFhNWEyMWJlMDI3YmFkNGRiODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYlZpZXdJbXBsOjpzaG93VG91Y2hIaWdobGlnaHRR dWFkcyBpc24ndCBuZWVkZWQgZm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyOTIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2Ugb3JpZ2luYWxseSBhZGRlZCBhIHN0dWIgaW1wbGVtZW50 YXRpb24gb2YgdGhpcyBmdW5jdGlvbiB0byBtYWtlCisgICAgICAgIG1lcmdpbmcgZGV0ZWN0Q29u dGVudE9uVG91Y2ggZWFzaWVyLCBidXQgc2hvd1RvdWNoSGlnaGxpZ2h0UXVhZHMgaXMKKyAgICAg ICAgYmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBjaHJvbWl1bS1hbmRyb2lkIGJyYW5jaCBpbiBmYXZv ciBvZiB0aGUgY29kZSBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQ0ODcuIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUKKyAgICAgICAgc3R1Yi4KKwor ICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjpkZXRlY3RDb250ZW50SW50ZW50T25Ub3VjaCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJ bXBsLmg6CisgICAgICAgIChXZWJWaWV3SW1wbCk6CisKIDIwMTItMDgtMDEgIEFudG9pbmUgTGFi b3VyICA8cGltYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRml4IGxvc3Qg Y29udGV4dCBoYW5kbGluZyBvbiBodWQgbGF5ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlZpZXdJbXBsLmNwcAppbmRleCBkODc1MGUzOGEyODdlYjE5MDczNzQ0Y2MwMzllMmM0YTI0 ZDRlYzk0Li44ZjU4ZGRiNjIzNTM1ZDliNTQ4NmE1OTM4MjRkNWYyYTVlNTYxMWViIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0yMjcsMTYgKzIyNyw2 IEBAIHN0YXRpYyBWZWN0b3I8UGFnZUdyb3VwTG9hZERlZmVycmVyKj4mIHBhZ2VHcm91cExvYWRE ZWZlcnJlclN0YWNrKCkKICAgICByZXR1cm4gZGVmZXJyZXJTdGFjazsKIH0KIAotI2lmIEVOQUJM RShUT1VDSF9FVkVOVFMpCi1zdGF0aWMgQ29sb3IgdGFwSGlnaGxpZ2h0Q29sb3JGb3JOb2RlKGNv bnN0IE5vZGUqIG5vZGUpCi17Ci0gICAgQ29sb3IgdGFwSGlnaGxpZ2h0Q29sb3IgPSBSZW5kZXJT dHlsZTo6aW5pdGlhbFRhcEhpZ2hsaWdodENvbG9yKCkucmdiKCk7Ci0gICAgaWYgKG5vZGUgJiYg bm9kZS0+cmVuZGVyZXIoKSkKLSAgICAgICAgdGFwSGlnaGxpZ2h0Q29sb3IgPSBub2RlLT5yZW5k ZXJlcigpLT5zdHlsZSgpLT50YXBIaWdobGlnaHRDb2xvcigpLnJnYigpOwotICAgIHJldHVybiB0 YXBIaWdobGlnaHRDb2xvcjsKLX0KLSNlbmRpZgotCiAvLyBFbnN1cmUgdGhhdCB0aGUgV2ViRHJh Z09wZXJhdGlvbiBlbnVtIHZhbHVlcyBzdGF5IGluIHN5bmMgd2l0aCB0aGUgb3JpZ2luYWwKIC8v IERyYWdPcGVyYXRpb24gY29uc3RhbnRzLgogI2RlZmluZSBDT01QSUxFX0FTU0VSVF9NQVRDSElO R19FTlVNKGNvcmVOYW1lKSBcCkBAIC0zODIwLDEyICszODEwLDYgQEAgV2ViR3JhcGhpY3NDb250 ZXh0M0QqIFdlYlZpZXdJbXBsOjpzaGFyZWRHcmFwaGljc0NvbnRleHQzRCgpCiAgICAgcmV0dXJu IEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6ZXh0cmFjdFdlYkdyYXBoaWNzQ29udGV4dDNEKFNo YXJlZEdyYXBoaWNzQ29udGV4dDNEOjpnZXQoKS5nZXQoKSk7CiB9CiAKLXZvaWQgV2ViVmlld0lt cGw6OnNob3dUb3VjaEhpZ2hsaWdodFF1YWRzKGNvbnN0IFdlYlZlY3RvcjxXZWJGbG9hdFF1YWQ+ JiBoaWdobGlnaHQsIFdlYkNvbG9yIGhpZ2hsaWdodENvbG9yKQotewotICAgIC8vIEZJWE1FOiBV cHN0cmVhbSB0aGlzIGZ1bmN0aW9uIGZyb20gdGhlIGNocm9taXVtLWFuZHJvaWQgYnJhbmNoLgot ICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KIHZvaWQgV2ViVmlld0ltcGw6OnNlbGVjdEF1dG9m aWxsU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4KQogewogICAgIGlmIChtX2F1 dG9maWxsUG9wdXBDbGllbnQgJiYgbGlzdEluZGV4IDwgbV9hdXRvZmlsbFBvcHVwQ2xpZW50LT5n ZXRTdWdnZXN0aW9uc0NvdW50KCkpCkBAIC0zODU2LDExICszODQwLDYgQEAgYm9vbCBXZWJWaWV3 SW1wbDo6ZGV0ZWN0Q29udGVudEludGVudE9uVG91Y2goY29uc3QgV2ViUG9pbnQmIHBvc2l0aW9u LCBXZWJJbnB1dEUKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgLy8gVGVtcG9y YXJpbHkgaGlnaGxpZ2h0IHRoZSBjb250ZW50IGFzIHdlIGRvIHdpdGggbGlua3MuCi0gICAgQ29s b3IgdGFwSGlnaGxpZ2h0Q29sb3IgPSB0YXBIaWdobGlnaHRDb2xvckZvck5vZGUodG91Y2hIaXQu aW5uZXJOb2RlKCkpOwotICAgIFdlYlZlY3RvcjxXZWJGbG9hdFF1YWQ+IHF1YWRzID0gY29udGVu dC5yYW5nZSgpLnRleHRRdWFkcygpOwotICAgIHNob3dUb3VjaEhpZ2hsaWdodFF1YWRzKHF1YWRz LCB0YXBIaWdobGlnaHRDb2xvci5yZ2IoKSk7Ci0KICAgICBtX2NsaWVudC0+c2NoZWR1bGVDb250 ZW50SW50ZW50KGNvbnRlbnQuaW50ZW50KCkpOwogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggMGIxZGEyYTI3ZDU2OTEzYmU2 MjAwMWFlZmIwMjA1OWFmZmNkMDgwNS4uMDc0YTgzNjliZDNmN2RkODk3OWE3MzQ0N2RiMGJhMGIz YmE1NmM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0y ODUsOCArMjg1LDYgQEAgcHVibGljOgogICAgICAgICBjb25zdCBXZWJWZWN0b3I8aW50PiYgaXRl bUlEcywKICAgICAgICAgaW50IHNlcGFyYXRvckluZGV4KTsKICAgICB2aXJ0dWFsIHZvaWQgaGlk ZVBvcHVwcygpOwotICAgIC8vIEZJWE1FOiBFeHBvc2Ugc2hvd1RvdWNoSGlnaGxpZ2h0UXVhZHMg aW4gdGhlIHB1YmxpYyBXZWJWaWV3IEFQSSB3aGVuIGl0IGRvZXMgc29tZXRoaW5nLgotICAgIHZp cnR1YWwgdm9pZCBzaG93VG91Y2hIaWdobGlnaHRRdWFkcyhjb25zdCBXZWJWZWN0b3I8V2ViRmxv YXRRdWFkPiYgaGlnaGxpZ2h0LCBXZWJDb2xvciBoaWdobGlnaHRDb2xvcik7CiAgICAgdmlydHVh bCB2b2lkIHNlbGVjdEF1dG9maWxsU3VnZ2VzdGlvbkF0SW5kZXgodW5zaWduZWQgbGlzdEluZGV4 KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2Nyb2xsYmFyQ29sb3JzKHVuc2lnbmVkIGluYWN0aXZl Q29sb3IsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBhY3Rp dmVDb2xvciwK