92822 2012-07-31 18:55:57 -0700 [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS 2012-07-31 20:29:47 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88970 1 yosin yosin tkent oldest_to_newest 683744 0 yosin 2012-07-31 18:55:57 -0700 This bug is one of preparation of landing multiple fields time UI for input type "time". Enabling ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS makes sure DateTimeFormat related functions, localizedTimeFormatText(), localizedShortTimeFormatText() and timeAMPMLabels(), built without failure. 683753 1 yosin 2012-07-31 19:09:40 -0700 Enabling ENABLE_INPUT_TYPE_MULTIPLE_FIELDS also adds localizedDecimalSeparator(). Following files have ENABLE_INPUT_TYPE_MULTIPLE_FIELDS Source/WebCore/platform/text/DateTimeFormat.h class DateTimeFormat Source/WebCore/platform/text/LocalizedNumber.h localizedDecimalSeparator() Source/WebCore/platform/text/LocalizedDate.h localizedTimeFormatText(), localizedShortTimeFormatText() and timeAMPMLabels() Source/WebCore/platform/text/LocaleWin.cpp include DateTimeFormat.h Source/WebCore/platform/text/LocalizedDateWin.cpp include LocalizedDate.h Source/WebCore/platform/text/DateTimeFormat.cpp include DateTimeFormat.h Source/WebCore/platform/text/LocalizedNumberICU.cpp include LocalizedNumber.h include LocaleICU.h Source/WebCore/platform/text/LocalizedNumberNone.cpp include LocalizedNumber.h Source/WebCore/platform/text/LocalizedDateICU.cpp include LocalizedDate.h include LocaleICU.h Source/WebCore/platform/text/LocaleICU.h Source/WebCore/platform/text/LocaleWin.h Source/WebCore/platform/text/mac/LocalizedDateMac.cpp include LocalizedDate.h Source/WebCore/platform/text/mac/LocaleMac.h Source/WebCore/platform/text/mac/LocaleMac.mm include LocalizedDate.h Source/WebCore/platform/text/mac/LocalizedNumberMac.mm include LocalizedNumber.h Source/WebCore/platform/text/LocaleICU.cpp include LocaleICU.h Source/WebKit/chromium/tests/DateTimeFormatTest.cpp include DateTimeFormat.h Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp include LocaleICU.h Source/WebKit/chromium/tests/LocaleMacTest.cpp include LocaleMac.h Source/WebKit/chromium/tests/LocaleWinTest.cpp include LocaleWin.h Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp include LocaleICU.h 683765 2 155704 yosin 2012-07-31 19:28:58 -0700 Created attachment 155704 Patch 1 683766 3 155704 yosin 2012-07-31 19:29:40 -0700 Comment on attachment 155704 Patch 1 Could you review this patch? Thanks in advance. 683814 4 155704 tkent 2012-07-31 20:25:47 -0700 Comment on attachment 155704 Patch 1 ok 683821 5 155704 yosin 2012-07-31 20:29:43 -0700 Comment on attachment 155704 Patch 1 Clearing flags on attachment: 155704 Committed r124290: <http://trac.webkit.org/changeset/124290> 683822 6 yosin 2012-07-31 20:29:47 -0700 All reviewed patches have been landed. Closing bug. 155704 2012-07-31 19:28:58 -0700 2012-07-31 20:29:43 -0700 Patch 1 bug-92822-20120801112840.patch text/plain 5248 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJlZGU2ZGUyZWQ3MzY3 OWQwYmFmNDc0NjQ3ZjNhZDgzYTI5YzZjNi4uNjc5NWI0N2IxYzU4ZDFmODg5YjE3YjE2YTExN2Rh ZDVhMzRmZjE1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTMxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBF bmFibGUgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9GSUVMRFMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyODIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCB0b3VjaGVzIGhl YWRlciBmaWxlcyBmb3IgY29tcGlsaW5nIGZpbGVzIHdoaWNoIGNvbnRhaW5zCisgICAgICAgIEVO QUJMRV9JTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIHBs YXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0xv Y2FsZUlDVS5oOgorICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlV2luLmg6CisgICAgICAg ICogcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZWREYXRlLmg6CisgICAgICAgICogcGxhdGZvcm0vdGV4 dC9Mb2NhbGl6ZWROdW1iZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVN YWMuaDoKKwogMjAxMi0wNy0zMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxMjA5NzkpOiBOb2RlIGxpc3QgcmV0dXJuZWQgYnkgZ2V0RWxl bWVudHNCeVRhZ05hbWVOUyBpc24ndCBpbnZhbGlkYXRlZCB3aGVuIGNoaWxkcmVuIGNoYW5nZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggODZhYWViMzdmMTBlMWU2ZTNhNjkwZTM4ZjUz MmFjNmFiM2U4MDk5NS4uNjQ1NzVkNzg0OWNlZGY1ZGE1MTZkNWM4NTkyZGQzYzY0ZDRhY2NmZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNy0zMSAg WW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gRW5hYmxlIEVOQUJMRV9JTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjgyMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZW5hYmxl cyBFTkFCTEVfSU5QVVRfVFlQRV9USU1FX01VTFRJUExFX0ZJRUxEUyBmb3IgQ2hyb21pdW0KKyAg ICAgICAgcG9ydCBleGNlcHQgZm9yIEFuZHJvaWQuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBp OiBBZGQgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9GSUVMRFM9MSB0byAiZmVhdHVy ZV9kZWZpbmVzIgorICAgICAgICBibG9jayBvZiBPUyAhPSAiYW5kcm9pZCIuCisKIDIwMTItMDct MzEgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W2Nocm9taXVtXSBVc2UgdGhlIGV2ZW50IGJvdW5kaW5nIGJveCB3aGVuIGNvbnN0cnVjdGluZyBh IFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Rl eHQvRGF0ZVRpbWVGb3JtYXQuaAppbmRleCBlN2Q1MzlmMmJkYzZiY2JjODUzOGRhYjJhYmIyMGQy MzBiMjViN2M2Li5iN2I3NDAyOTAzZjdiNmRmOWY2ZWNiZmFlNDI2ZDliZWI5ZTBjNjQ0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9EYXRlVGltZUZvcm1hdC5oCkBAIC0xMDgs NSArMTA4LDQgQEAgcHVibGljOgogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYKLQog I2VuZGlmIC8vIERhdGVUaW1lRm9ybWF0X2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvTG9jYWxlSUNVLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xv Y2FsZUlDVS5oCmluZGV4IDA4NjY3ODA2ZDNiYmFhNWZhZTI5Mjc5N2Y0Yjc3MjhkN2FmNTgyNTcu LmI1MGNmNDRjZjllNTkwYjRlMmRkYjZkMTgzZDhlYWE1NzVlNmE1MjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaApAQCAtMTMzLDUgKzEzMyw1IEBAIHByaXZhdGU6 CiAjZW5kaWYKIH07CiAKLX0KK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKICNlbmRpZgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVXaW4uaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlV2luLmgKaW5kZXggNmY0ZmQ4YmI4ZjJjNGFmOWU1 NjBiOTQxNDQ2NmZhOGU3MDEzYjQ0Zi4uOTI3MGYxNjlmNGIzNTk1ZTI5YzNhZDBkNzRjZTg3NDkw ZmJiNGY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVX aW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5oCkBAIC05 NCw1ICs5NCw1IEBAIHByaXZhdGU6CiAjZW5kaWYKIH07CiAKLX0KK30gLy8gbmFtZXNwYWNlIFdl YkNvcmUKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9M b2NhbGl6ZWREYXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplZERh dGUuaAppbmRleCBhYjY4NTRlNTNiNGZjNmU4MWE2YTAxNTY1NTMzMDNjODMwMTU4YTM2Li43NDQy MmFmYjg0MjZhNDQ4NWEyYjYyZDAzMzQwYTQxNDY3NGUzZjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplZERhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplZERhdGUuaApAQCAtNjAsNyArNjAsNiBAQCBjb25zdCBW ZWN0b3I8U3RyaW5nPiYgd2Vla0RheVNob3J0TGFiZWxzKCk7CiAKIC8vIFRoZSBmaXJzdCBkYXkg b2YgYSB3ZWVrLiAwIGlzIFN1bmRheSwgYW5kIDYgaXMgU2F0dXJkYXkuCiB1bnNpZ25lZCBmaXJz dERheU9mV2VlaygpOwotCiAjZW5kaWYKIAogI2lmIEVOQUJMRShJTlBVVF9UWVBFX1RJTUVfTVVM VElQTEVfRklFTERTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9M b2NhbGl6ZWROdW1iZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVk TnVtYmVyLmgKaW5kZXggODcwM2I3NGY0OTEzNTk5MmIzZGFiZjg4NWQxYWNmZTM0NWNiYzM4OC4u M2JmZGU1OGIyNTllN2Q2Y2ZlMjU2MWI4YjZkMTMzMDg2MGVhMmM2ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZWROdW1iZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplZE51bWJlci5oCkBAIC01MCw3ICs1MCw2IEBA IFN0cmluZyBjb252ZXJ0VG9Mb2NhbGl6ZWROdW1iZXIoY29uc3QgU3RyaW5nJiwgdW5zaWduZWQg ZnJhY3Rpb25EaWdpdHMpOwogLy8gcmVzcG9uc2libGUgdG8gY2hlY2sgdGhlIGZvcm1hdCBvZiB0 aGUgcmVzdWx0YW50IHN0cmluZy4KIFN0cmluZyBjb252ZXJ0RnJvbUxvY2FsaXplZE51bWJlcihj b25zdCBTdHJpbmcmKTsKIAotCiAjaWYgRU5BQkxFKElOUFVUX1RZUEVfVElNRV9NVUxUSVBMRV9G SUVMRFMpCiAvLyBSZXR1cm5zIGxvY2FsaXplZCBkZWNpbWFsIHNlcGFyYXRvciwgZS5nLiAiLiIg Zm9yIEVuZ2xpc2gsICIsIiBmb3IgRnJlbmNoLgogU3RyaW5nIGxvY2FsaXplZERlY2ltYWxTZXBh cmF0b3IoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvbWFjL0xv Y2FsZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgK aW5kZXggMDc0ZmUzZTEyYThiNTU0YzdiMWRhNmUwMWE4ZWU0NDU5YjZmOTFlOC4uZDkzN2RiNWZk YmJlYTYzZTFmMjI5MzcwN2Q2MTQ3MGM4NGE1ZTcxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKQEAgLTg1LDUgKzg1LDUgQEAgcHJpdmF0ZToKICNl bmRpZgogfTsKIAotfQorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogI2VuZGlmCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggNmFhNTdiZTNkZDlhZjVjYjRlZDU4NzY5MGE2OTA0 MWI0MWNmNzYzYy4uZjNjY2UxM2M3NmU2YWQ3YzkwODlhODM5MmZiMDA5YTMyYWJjOTY4MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAtMTcwLDYgKzE3MCw3IEBACiAgICAg ICAgICAgJ0VOQUJMRV9DQUxFTkRBUl9QSUNLRVI9MScsCiAgICAgICAgICAgJ0VOQUJMRV9JTlBV VF9TUEVFQ0g9MScsCiAgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX0NPTE9SPTEnLAorICAg ICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9USU1FX01VTFRJUExFX0ZJRUxEUz0xJywKICAgICAg ICAgICAnRU5BQkxFX0pBVkFTQ1JJUFRfSTE4Tl9BUEk9MScsCiAgICAgICAgICAgJ0VOQUJMRV9M RUdBQ1lfTk9USUZJQ0FUSU9OUz0xJywKICAgICAgICAgICAnRU5BQkxFX01FRElBX0NBUFRVUkU9 MCcsCg==