92715 2012-07-30 23:03:55 -0700 Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*) 2012-07-31 16:00:40 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92057 1 skyul skyul abarth eric oldest_to_newest 682744 0 skyul 2012-07-30 23:03:55 -0700 This is a follow-up patch for r123577. Changed oneBelowTop to oneBelowTopStackItem. 682746 1 155445 skyul 2012-07-30 23:05:46 -0700 Created attachment 155445 Patch 683176 2 155445 abarth 2012-07-31 09:15:18 -0700 Comment on attachment 155445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155445&action=review > Source/WebCore/html/parser/HTMLConstructionSite.h:116 > - Element* oneBelowTop() const { return m_openElements.oneBelowTop(); } > + HTMLStackItem* oneBelowTopStackItem() const { return m_openElements.oneBelowTopStackItem(); } You can also keep the same name since you're removing the old function. They types are incompatible, so it's not going to confuse anyone. 683561 3 skyul 2012-07-31 15:53:40 -0700 (In reply to comment #2) > You can also keep the same name since you're removing the old function. They types are incompatible, so it's not going to confuse anyone. Okay. I will keep the name. 683572 4 skyul 2012-07-31 16:00:40 -0700 Committed r124262: <http://trac.webkit.org/changeset/124262> 155445 2012-07-30 23:05:46 -0700 2012-07-31 09:15:18 -0700 Patch bug-92715-20120731150518.patch text/plain 4586 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDg0MzQ1MTQ4MjZjYzk4 N2ZmZDIzNTY3NjY0OTgwMDA2NGMzMjc3My4uNjE3NzkwZWYxNGI4NmU2ZmFkNGUwYjEwNmNkYjA3 MTk3ZTRlOGQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTMwICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmVhZCB0YWcgbmFt ZXMgYW5kIGF0dHJpYnV0ZXMgZnJvbSB0aGUgc2F2ZWQgdG9rZW5zIGluIEhUTUxUcmVlQnVpbGRl cjo6cHJvY2Vzc0VuZFRhZyhBdG9taWNIVE1MVG9rZW4qKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTI3MTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgZm9sbG93LXVwIHBhdGNoIGZvciBy MTIzNTc3LiBDaGFuZ2VkIG9uZUJlbG93VG9wIHRvIG9uZUJlbG93VG9wU3RhY2tJdGVtLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIGh0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmg6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6b25lQmVsb3dUb3BTdGFja0l0ZW0pOgorICAgICAgICAq IGh0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TEVsZW1lbnRTdGFjazo6b25lQmVsb3dUb3BTdGFja0l0ZW0pOgorICAgICAgICAqIGh0bWwvcGFy c2VyL0hUTUxFbGVtZW50U3RhY2suaDoKKyAgICAgICAgKEhUTUxFbGVtZW50U3RhY2spOgorICAg ICAgICAqIGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NFbmRUYWcpOgorCiAyMDEyLTA3LTI5ICBLd2FuZyBZ dWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBt ZXRob2QgSFRNTENvbnN0cnVjdGlvblNpdGVUYXNrOjp0YWtlKEhUTUxDb25zdHJ1Y3Rpb25TaXRl VGFzayYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3Ry dWN0aW9uU2l0ZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlv blNpdGUuaAppbmRleCBhODJjZGYxYjNlOTM0YjAwYmY2ZjM1OWUyOWQ3MjFkYTBhMzhmMmQ1Li5i OTY3OTJiMmNiMDNlNTdmMThjMjY5NzUzNDhkZDJiMDM5N2Y5OWY0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKQEAgLTExMyw3ICsx MTMsNyBAQCBwdWJsaWM6CiAgICAgRWxlbWVudCogY3VycmVudEVsZW1lbnQoKSBjb25zdCB7IHJl dHVybiBtX29wZW5FbGVtZW50cy50b3AoKTsgfQogICAgIENvbnRhaW5lck5vZGUqIGN1cnJlbnRO b2RlKCkgY29uc3QgeyByZXR1cm4gbV9vcGVuRWxlbWVudHMudG9wTm9kZSgpOyB9CiAgICAgSFRN TFN0YWNrSXRlbSogY3VycmVudFN0YWNrSXRlbSgpIGNvbnN0IHsgcmV0dXJuIG1fb3BlbkVsZW1l bnRzLnRvcFN0YWNrSXRlbSgpOyB9Ci0gICAgRWxlbWVudCogb25lQmVsb3dUb3AoKSBjb25zdCB7 IHJldHVybiBtX29wZW5FbGVtZW50cy5vbmVCZWxvd1RvcCgpOyB9CisgICAgSFRNTFN0YWNrSXRl bSogb25lQmVsb3dUb3BTdGFja0l0ZW0oKSBjb25zdCB7IHJldHVybiBtX29wZW5FbGVtZW50cy5v bmVCZWxvd1RvcFN0YWNrSXRlbSgpOyB9CiAKICAgICBIVE1MRWxlbWVudFN0YWNrKiBvcGVuRWxl bWVudHMoKSBjb25zdCB7IHJldHVybiAmbV9vcGVuRWxlbWVudHM7IH0KICAgICBIVE1MRm9ybWF0 dGluZ0VsZW1lbnRMaXN0KiBhY3RpdmVGb3JtYXR0aW5nRWxlbWVudHMoKSBjb25zdCB7IHJldHVy biAmbV9hY3RpdmVGb3JtYXR0aW5nRWxlbWVudHM7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFjay5jcHAKaW5kZXggZGYwNzRmZmQzYWExMTUzZWQ1OWE4 NmI5OTcyZmRkM2FkMmU2Zjg3Zi4uNTJjYzc0ODhjY2QyMTUzY2U0OTM1ZTljNmU2NGY5ZjZhZGE3 Y2JjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRT dGFjay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFj ay5jcHAKQEAgLTM4MywxMyArMzgzLDEzIEBAIEhUTUxFbGVtZW50U3RhY2s6OkVsZW1lbnRSZWNv cmQqIEhUTUxFbGVtZW50U3RhY2s6OnRvcFJlY29yZCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fdG9w LmdldCgpOwogfQogCi1FbGVtZW50KiBIVE1MRWxlbWVudFN0YWNrOjpvbmVCZWxvd1RvcCgpIGNv bnN0CitIVE1MU3RhY2tJdGVtKiBIVE1MRWxlbWVudFN0YWNrOjpvbmVCZWxvd1RvcFN0YWNrSXRl bSgpIGNvbnN0CiB7CiAgICAgLy8gV2Ugc2hvdWxkIG5ldmVyIGNhbGwgdGhpcyBpZiB0aGVyZSBh cmUgZmV3ZXIgdGhhbiAyIGVsZW1lbnRzIG9uIHRoZSBzdGFjay4KICAgICBBU1NFUlQobV90b3Ap OwogICAgIEFTU0VSVChtX3RvcC0+bmV4dCgpKTsKICAgICBpZiAobV90b3AtPm5leHQoKS0+c3Rh Y2tJdGVtKCktPmlzRWxlbWVudE5vZGUoKSkKLSAgICAgICAgcmV0dXJuIG1fdG9wLT5uZXh0KCkt PmVsZW1lbnQoKTsKKyAgICAgICAgcmV0dXJuIG1fdG9wLT5uZXh0KCktPnN0YWNrSXRlbSgpLmdl dCgpOwogICAgIHJldHVybiAwOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L3BhcnNlci9IVE1MRWxlbWVudFN0YWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MRWxlbWVudFN0YWNrLmgKaW5kZXggZjE5YmMzMDAxZmRjOWJlNTMwNjQ0NThhMTk2YjBlMzA3 YjkzNGQ3Yi4uMmYzYTA1N2NiMzc3MDA0Njc5OGIwOTU5NWU3YTgxNTA3ZWRiMDljZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTEVsZW1lbnRTdGFjay5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxFbGVtZW50U3RhY2suaApAQCAtOTgsNyAr OTgsNyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBtX3RvcC0+c3RhY2tJdGVtKCkuZ2V0KCk7 CiAgICAgfQogCi0gICAgRWxlbWVudCogb25lQmVsb3dUb3AoKSBjb25zdDsKKyAgICBIVE1MU3Rh Y2tJdGVtKiBvbmVCZWxvd1RvcFN0YWNrSXRlbSgpIGNvbnN0OwogICAgIEVsZW1lbnRSZWNvcmQq IHRvcFJlY29yZCgpIGNvbnN0OwogICAgIEVsZW1lbnQqIGJvdHRvbSgpIGNvbnN0OwogICAgIEVs ZW1lbnRSZWNvcmQqIGZpbmQoRWxlbWVudCopIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggMzUyNmFjYWZjNDg4MTgxOWE0NjY1 MjM5ZWMwYjY1MWJlMzBjNWY1OC4uMTAxM2FmMDBlN2M1YmEyYTdmYjc3ZDNhM2NlNzFiNDYwNTEz MzA1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWls ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIu Y3BwCkBAIC0yMTg1LDcgKzIxODUsNyBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0Vu ZFRhZyhBdG9taWNIVE1MVG9rZW4qIHRva2VuKQogICAgIGNhc2UgSW5TZWxlY3RNb2RlOgogICAg ICAgICBBU1NFUlQoaW5zZXJ0aW9uTW9kZSgpID09IEluU2VsZWN0TW9kZSB8fCBpbnNlcnRpb25N b2RlKCkgPT0gSW5TZWxlY3RJblRhYmxlTW9kZSk7CiAgICAgICAgIGlmICh0b2tlbi0+bmFtZSgp ID09IG9wdGdyb3VwVGFnKSB7Ci0gICAgICAgICAgICBpZiAobV90cmVlLmN1cnJlbnRTdGFja0l0 ZW0oKS0+aGFzVGFnTmFtZShvcHRpb25UYWcpICYmIG1fdHJlZS5vbmVCZWxvd1RvcCgpICYmIG1f dHJlZS5vbmVCZWxvd1RvcCgpLT5oYXNUYWdOYW1lKG9wdGdyb3VwVGFnKSkKKyAgICAgICAgICAg IGlmIChtX3RyZWUuY3VycmVudFN0YWNrSXRlbSgpLT5oYXNUYWdOYW1lKG9wdGlvblRhZykgJiYg bV90cmVlLm9uZUJlbG93VG9wU3RhY2tJdGVtKCkgJiYgbV90cmVlLm9uZUJlbG93VG9wU3RhY2tJ dGVtKCktPmhhc1RhZ05hbWUob3B0Z3JvdXBUYWcpKQogICAgICAgICAgICAgICAgIHByb2Nlc3NG YWtlRW5kVGFnKG9wdGlvblRhZyk7CiAgICAgICAgICAgICBpZiAobV90cmVlLmN1cnJlbnRTdGFj a0l0ZW0oKS0+aGFzVGFnTmFtZShvcHRncm91cFRhZykpIHsKICAgICAgICAgICAgICAgICBtX3Ry ZWUub3BlbkVsZW1lbnRzKCktPnBvcCgpOwo=