92669 2012-07-30 13:03:41 -0700 [Qt] load event fires on XMLHttpRequestUpload twice with Qt5 2012-09-26 13:10:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 79666 1 ossy marcelo.lira marcelo.lira ossy webkit.review.bot oldest_to_newest 682308 0 ossy 2012-07-30 13:03:41 -0700 Because of this bug there are two failing tests with Qt5 (WK1 and WK2 too): --- /storage/WebKit/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/upload-onprogress-event-expected.txt +++ /storage/WebKit/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/upload-onprogress-event-actual.txt @@ -2,4 +2,6 @@ PASS: onprogress event fired on XMLHttpRequestUpload. onprogress: [object XMLHttpRequestProgressEvent] [Loaded: 4 Total: 4] +PASS: onprogress event fired on XMLHttpRequestUpload. +onprogress: [object XMLHttpRequestProgressEvent] [Loaded: 0 Total: 0] --- /storage/WebKit/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/upload-progress-events-expected.txt +++ /storage/WebKit/WebKitBuild/Release/layout-test-results/http/tests/xmlhttprequest/upload-progress-events-actual.txt @@ -3,4 +3,5 @@ PASS: loadstart event fired on XMLHttpRequestUpload: [object XMLHttpRequestProgressEvent] PASS: onprogress event fired on XMLHttpRequestUpload: [object XMLHttpRequestProgressEvent] [Loaded: 4 Total: 4] PASS: load event fired on XMLHttpRequestUpload: [object XMLHttpRequestProgressEvent] +PASS: onprogress event fired on XMLHttpRequestUpload: [object XMLHttpRequestProgressEvent] [Loaded: 0 Total: 0] 682330 1 ossy 2012-07-30 13:26:28 -0700 They are on the qt-5.0/Skipped list. Please unskip them with the proper fix. 728758 2 165836 marcelo.lira 2012-09-26 11:10:57 -0700 Created attachment 165836 Patch 728865 3 165836 kenneth 2012-09-26 12:28:57 -0700 Comment on attachment 165836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165836&action=review > Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:586 > + if (!bytesTotal) > + return; I would add a comment if (!bytesTotal) { // When finished QNetworkReply emits a progress of 0 bytes. // Ignore that, to avoid firing twice. return; } 728871 4 165853 marcelo.lira 2012-09-26 12:34:53 -0700 Created attachment 165853 Patch 728899 5 165853 webkit.review.bot 2012-09-26 13:10:00 -0700 Comment on attachment 165853 Patch Clearing flags on attachment: 165853 Committed r129692: <http://trac.webkit.org/changeset/129692> 728900 6 webkit.review.bot 2012-09-26 13:10:03 -0700 All reviewed patches have been landed. Closing bug. 165836 2012-09-26 11:10:57 -0700 2012-09-26 12:34:49 -0700 Patch bug-92669-20120926151016.patch text/plain 3315 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZkYTMxM2ZjMzU0M2Vh NGIzYThmNzE5MDE3NzFmMmZlN2QyOWI2Zi4uZjI0OTI3YWNhNjI0ZGQ5YzE1OGJkODg3NWI1YjI5 NTk5NmQ0ZTQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTI2ICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdIGxv YWQgZXZlbnQgZmlyZXMgb24gWE1MSHR0cFJlcXVlc3RVcGxvYWQgdHdpY2Ugd2l0aCBRdDUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBmaW5pc2hp bmcsIGFmdGVyIHRoZSB1cGxvYWQgaGF2ZSBhbHJlYWR5IGJlZW4gZG9uZSwgUXQ1J3MKKyAgICAg ICAgUU5ldHdvcmtSZXBseSBlbWl0cyBhbiB1cGxvYWRQcm9ncmVzcyBzaWduYWwgd2l0aCB0b3Rh bCBieXRlcyBzZXQgdG8KKyAgICAgICAgemVyby4gU2luY2UgMCBvZiAwIGJ5dGVzIGRvZXNuJ3Qg bWFrZSBhbnkgc2Vuc2UgYXMgcHJvZ3Jlc3MsIGEKKyAgICAgICAgY29uZGl0aW9uYWwgd2FzIGFk ZGVkIHRvIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjp1cGxvYWRQcm9ncmVzcyB0byBtYWtlCisgICAg ICAgIGRvIG5vdGhpbmcgd2l0aCBzdWNoIHZhbHVlcy4KKworICAgICAgICBVbnNraXAgWE1MSHR0 cFJlcXVlc3RVcGxvYWQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FO ZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlI YW5kbGVyOjp1cGxvYWRQcm9ncmVzcyk6CisKIDIwMTItMDktMjYgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFNWR0ZvbnREYXRhIGZvciA4IGJp dCBUZXh0UnVuIGNoYW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKaW5kZXggOGQ0M2RkMDc2NDRk M2E5YzUxNDBjYjYyYTI1MmYxYzJmMjJkYWQ0ZS4uYTUwMzBkZjk0ZTZhYmE1OTMwNGU2ZDEzMjE3 ODA1N2QxZTEzYjAyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKQEAgLTU4Miw2ICs1ODIsOSBA QCB2b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjp1cGxvYWRQcm9ncmVzcyhxaW50NjQgYnl0ZXNT ZW50LCBxaW50NjQgYnl0ZXNUb3RhbCkKICAgICBpZiAoIWNsaWVudCkKICAgICAgICAgcmV0dXJu OwogCisgICAgaWYgKCFieXRlc1RvdGFsKQorICAgICAgICByZXR1cm47CisKICAgICBjbGllbnQt PmRpZFNlbmREYXRhKG1fcmVzb3VyY2VIYW5kbGUsIGJ5dGVzU2VudCwgYnl0ZXNUb3RhbCk7CiB9 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCAyZWIyY2EwMTlkNDA2YmU3ZjE3MTIzYzA1ZDU3Mjk4ODhiNTNjYzQ5Li4wMzgx ZjJiOTYzMWVhMjk0N2NjNTNhZDgzMDhjM2ZkNzY1ZWZjZmE0IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDktMjYgIE1hcmNlbG8gTGlyYSAgPG1hcmNlbG8ubGlyYUBvcGVuYm9zc2Eub3Jn PgorCisgICAgICAgIFtRdF0gbG9hZCBldmVudCBmaXJlcyBvbiBYTUxIdHRwUmVxdWVzdFVwbG9h ZCB0d2ljZSB3aXRoIFF0NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTI2NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIGZpbmlzaGluZywgYWZ0ZXIgdGhlIHVwbG9hZCBoYXZlIGFscmVhZHkgYmVl biBkb25lLCBRdDUncworICAgICAgICBRTmV0d29ya1JlcGx5IGVtaXRzIGFuIHVwbG9hZFByb2dy ZXNzIHNpZ25hbCB3aXRoIHRvdGFsIGJ5dGVzIHNldCB0bworICAgICAgICB6ZXJvLiBTaW5jZSAw IG9mIDAgYnl0ZXMgZG9lc24ndCBtYWtlIGFueSBzZW5zZSBhcyBwcm9ncmVzcywgYQorICAgICAg ICBjb25kaXRpb25hbCB3YXMgYWRkZWQgdG8gUU5ldHdvcmtSZXBseUhhbmRsZXI6OnVwbG9hZFBy b2dyZXNzIHRvIG1ha2UKKyAgICAgICAgZG8gbm90aGluZyB3aXRoIHN1Y2ggdmFsdWVzLgorCisg ICAgICAgIFVuc2tpcCBYTUxIdHRwUmVxdWVzdFVwbG9hZCB0ZXN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL3F0LTUuMC9Ta2lwcGVkOgorCiAyMDEyLTA5LTI2ICBTdGVwaGVuIENoZW5uZXkgIDxz Y2hlbm5leUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXggZm9yIENocm9t aXVtIFRlc3RFeHBlY3RhdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 LTUuMC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKaW5kZXgg MWYyMDEyNThlNDlmZDQzYTc4MWIyZWIwZjJhZTU2ZmQ4NjZkY2Y0NC4uZDgzNDBiMTgzZDE5M2Q0 ZGFkZTI2YTJhNzlmMzBiOWZhY2ZlMWZiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQtNS4wL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBw ZWQKQEAgLTEsOCArMSwzIEBACi0jIFtRdF0gbG9hZCBldmVudCBmaXJlcyBvbiBYTUxIdHRwUmVx dWVzdFVwbG9hZCB0d2ljZSB3aXRoIFF0NQotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTI2NjkKLWh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvdXBsb2FkLW9ucHJv Z3Jlc3MtZXZlbnQuaHRtbAotaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC91cGxvYWQtcHJvZ3Jl c3MtZXZlbnRzLmh0bWwKLQogIyB0aW1lb3V0CiBmYXN0L2V2ZW50cy9ib2d1cy1kcm9wRWZmZWN0 LWVmZmVjdEFsbG93ZWQuaHRtbAogZmFzdC9mb3Jtcy90ZXh0ZmllbGQtZHJhZy1pbnRvLWRpc2Fi bGVkLmh0bWwK 165853 2012-09-26 12:34:53 -0700 2012-09-26 13:10:00 -0700 Patch bug-92669-20120926163412.patch text/plain 3470 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTJlZDA0YjQzZTAzZTBm MWU0NzM3ZTQyMjc3OWIwZjJlMzQ5OGMyYi4uMGYwOWJhNTJmZmEwMWI4M2ZhMjJlMDcyNWQ4MjJk YjRmMDY1Njc1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTI2ICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdIGxv YWQgZXZlbnQgZmlyZXMgb24gWE1MSHR0cFJlcXVlc3RVcGxvYWQgdHdpY2Ugd2l0aCBRdDUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjY5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAg V2hlbiBmaW5pc2hpbmcsIGFmdGVyIHRoZSB1cGxvYWQgaGF2ZSBhbHJlYWR5IGJlZW4gZG9uZSwg UXQ1J3MKKyAgICAgICAgUU5ldHdvcmtSZXBseSBlbWl0cyBhbiB1cGxvYWRQcm9ncmVzcyBzaWdu YWwgd2l0aCB0b3RhbCBieXRlcyBzZXQgdG8KKyAgICAgICAgemVyby4gU2luY2UgMCBvZiAwIGJ5 dGVzIGRvZXNuJ3QgbWFrZSBhbnkgc2Vuc2UgYXMgcHJvZ3Jlc3MsIGEKKyAgICAgICAgY29uZGl0 aW9uYWwgd2FzIGFkZGVkIHRvIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjp1cGxvYWRQcm9ncmVzcyB0 byBtYWtlCisgICAgICAgIGRvIG5vdGhpbmcgd2l0aCBzdWNoIHZhbHVlcy4KKworICAgICAgICBV bnNraXAgWE1MSHR0cFJlcXVlc3RVcGxvYWQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFO ZXR3b3JrUmVwbHlIYW5kbGVyOjp1cGxvYWRQcm9ncmVzcyk6CisKIDIwMTItMDktMjYgIEFuZHJl YXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIDQuOTVNQiBiZWxvdyBSZW5k ZXJCbG9jazo6aW5zZXJ0SW50b1RyYWNrZWRSZW5kZXJlck1hcHMoKSBvbiBNZW1idXN0ZXIzLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3 b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCA4ZDQzZGQwNzY0NGQzYTljNTE0MGNiNjJhMjUyZjFj MmYyMmRhZDRlLi5kNjMyYzIzNDNhMjc5NmU1NTM0ZWMzM2UzNzNkNGQ2Njk0MzJjNmMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3 b3JrUmVwbHlIYW5kbGVyLmNwcApAQCAtNTgyLDYgKzU4MiwxMiBAQCB2b2lkIFFOZXR3b3JrUmVw bHlIYW5kbGVyOjp1cGxvYWRQcm9ncmVzcyhxaW50NjQgYnl0ZXNTZW50LCBxaW50NjQgYnl0ZXNU b3RhbCkKICAgICBpZiAoIWNsaWVudCkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKCFieXRl c1RvdGFsKSB7CisgICAgICAgIC8vIFdoZW4gZmluaXNoZWQgUU5ldHdvcmtSZXBseSBlbWl0cyBh IHByb2dyZXNzIG9mIDAgYnl0ZXMuCisgICAgICAgIC8vIElnbm9yZSB0aGF0LCB0byBhdm9pZCBm aXJpbmcgdHdpY2UuCisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBjbGllbnQtPmRpZFNl bmREYXRhKG1fcmVzb3VyY2VIYW5kbGUsIGJ5dGVzU2VudCwgYnl0ZXNUb3RhbCk7CiB9CiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCAwMmE0MmNiZjk3NWYwNjAyMDRhMGUzMDljYmY1ZmUxODcwMDczNDkwLi5lNGU3NGI1MzI5 MGIyZDRiZjAzNWI2ZjU3ZjA5NmFmYzNlOTk3NThjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIw MTItMDktMjYgIE1hcmNlbG8gTGlyYSAgPG1hcmNlbG8ubGlyYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtRdF0gbG9hZCBldmVudCBmaXJlcyBvbiBYTUxIdHRwUmVxdWVzdFVwbG9hZCB0d2lj ZSB3aXRoIFF0NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTI2NjkKKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KKworICAgICAgICBXaGVuIGZpbmlzaGluZywgYWZ0ZXIgdGhlIHVwbG9hZCBoYXZlIGFscmVh ZHkgYmVlbiBkb25lLCBRdDUncworICAgICAgICBRTmV0d29ya1JlcGx5IGVtaXRzIGFuIHVwbG9h ZFByb2dyZXNzIHNpZ25hbCB3aXRoIHRvdGFsIGJ5dGVzIHNldCB0bworICAgICAgICB6ZXJvLiBT aW5jZSAwIG9mIDAgYnl0ZXMgZG9lc24ndCBtYWtlIGFueSBzZW5zZSBhcyBwcm9ncmVzcywgYQor ICAgICAgICBjb25kaXRpb25hbCB3YXMgYWRkZWQgdG8gUU5ldHdvcmtSZXBseUhhbmRsZXI6OnVw bG9hZFByb2dyZXNzIHRvIG1ha2UKKyAgICAgICAgZG8gbm90aGluZyB3aXRoIHN1Y2ggdmFsdWVz LgorCisgICAgICAgIFVuc2tpcCBYTUxIdHRwUmVxdWVzdFVwbG9hZCB0ZXN0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL3F0LTUuMC9Ta2lwcGVkOgorCiAyMDEyLTA5LTI2ICBaYW4gRG9iZXJzZWsg IDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVu aW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBlZAppbmRleCAxZjIwMTI1OGU0OWZkNDNh NzgxYjJlYjBmMmFlNTZmZDg2NmRjZjQ0Li5kODM0MGIxODNkMTkzZDRkYWRlMjZhMmE3OWYzMGI5 ZmFjZmUxZmI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBl ZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBlZApAQCAtMSw4ICsxLDMg QEAKLSMgW1F0XSBsb2FkIGV2ZW50IGZpcmVzIG9uIFhNTEh0dHBSZXF1ZXN0VXBsb2FkIHR3aWNl IHdpdGggUXQ1Ci0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjY2 OQotaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC91cGxvYWQtb25wcm9ncmVzcy1ldmVudC5odG1s Ci1odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3VwbG9hZC1wcm9ncmVzcy1ldmVudHMuaHRtbAot CiAjIHRpbWVvdXQKIGZhc3QvZXZlbnRzL2JvZ3VzLWRyb3BFZmZlY3QtZWZmZWN0QWxsb3dlZC5o dG1sCiBmYXN0L2Zvcm1zL3RleHRmaWVsZC1kcmFnLWludG8tZGlzYWJsZWQuaHRtbAo=