92636 2012-07-30 05:20:04 -0700 [Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail 2012-09-26 01:02:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79666 92597 1 jbadics marcelo.lira jbadics marcelo.lira mitz ossy rniwa webkit.review.bot zarvai oldest_to_newest 681899 0 jbadics 2012-07-30 05:20:04 -0700 r123988 made this test fail on WebKit1. The diff is the following: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-actual.txt @@ -7,6 +7,6 @@ PASS: offset at (160,26) was 26. PASS: offset at (60,25) was 24. PASS: offset at (160,25) was 26. -PASS: offset at (60,24) was 26. +FAIL: offset at (60,24) was 24. Expected 26. PASS: offset at (160,24) was 26. You can see the original bug at ​https://bugs.webkit.org/show_bug.cgi?id=92597 681910 1 zarvai 2012-07-30 05:30:08 -0700 *** Bug 92639 has been marked as a duplicate of this bug. *** 681953 2 ossy 2012-07-30 06:18:42 -0700 Skipped by https://trac.webkit.org/changeset/124018, please unskip it with the proper fix. 681996 3 mitz 2012-07-30 07:16:06 -0700 The test is failing because of the different selection mode used in some non-OS X ports. 727980 4 165677 marcelo.lira 2012-09-25 14:38:01 -0700 Created attachment 165677 Patch 728127 5 rniwa 2012-09-25 18:42:45 -0700 Does the test pass now? Why can we unskip the test? 728289 6 165677 ossy 2012-09-26 00:58:07 -0700 Comment on attachment 165677 Patch It seems it passes now, so let's unskip it. 728293 7 165677 webkit.review.bot 2012-09-26 01:02:26 -0700 Comment on attachment 165677 Patch Clearing flags on attachment: 165677 Committed r129606: <http://trac.webkit.org/changeset/129606> 728294 8 webkit.review.bot 2012-09-26 01:02:29 -0700 All reviewed patches have been landed. Closing bug. 165677 2012-09-25 14:38:01 -0700 2012-09-26 01:02:25 -0700 Patch bug-92636-20120925183723.patch text/plain 1494 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzAwNzk2ZGQ1Mjc1NWNhZWFlNWZm YzFhNTAwNGQyYWU2YmE2NDJjMS4uYmJkODBjNGZmMzc5OGVkNzM0NDBlZjFkMmMwMmJlYjllMDFj MWE4MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5LTI1ICBNYXJjZWxvIExpcmEgIDxt YXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdW1dLMV0gUkVHUkVTU0lP TihyMTIzOTg4KSBJdCBtYWRlIGZhc3Qvd3JpdGluZy1tb2RlL2ZsaXBwZWQtYmxvY2tzLWhpdC10 ZXN0LWxpbmUtZWRnZXMuaHRtbCBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MjYzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVuc2tpcCBwYXNzaW5nIHRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9xdC01LjAtd2sxL1NraXBwZWQ6CisKIDIwMTItMDktMjUgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLCBz a2lwIGZhaWxpbmcgdGVzdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01 LjAtd2sxL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAtd2sxL1NraXBwZWQK aW5kZXggYWFhYjllMjMyYjM0NWVjOWZmMWZmMzNiM2RlYzc2NDRjNjFkNDEwZi4uODJhNmNjMTI4 YmY1NWNmNjRmZDhhZWQxNGYxNDQ0N2NhYWIxODVmNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQtNS4wLXdrMS9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 LTUuMC13azEvU2tpcHBlZApAQCAtNjEsMTAgKzYxLDYgQEAgc3ZnL2N1c3RvbS9nbHlwaC1zZWxl Y3Rpb24tbGFuZy1hdHRyaWJ1dGUuc3ZnCiBzdmcvZG9tL2Nzcy10cmFuc2Zvcm1zLnhodG1sCiB0 b3VjaGFkanVzdG1lbnQvZXZlbnQtdHJpZ2dlcmVkLXdpZGdldHMuaHRtbAogCi0jIFtRdF1bV0sx XSBSRUdSRVNTSU9OKHIxMjM5ODgpIEl0IG1hZGUgZmFzdC93cml0aW5nLW1vZGUvZmxpcHBlZC1i bG9ja3MtaGl0LXRlc3QtbGluZS1lZGdlcy5odG1sIGZhaWwKLSMgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjM2Ci1mYXN0L3dyaXRpbmctbW9kZS9mbGlwcGVkLWJs b2Nrcy1oaXQtdGVzdC1saW5lLWVkZ2VzLmh0bWwKLQogIyBbUXRdW1dLMV0gTmV3IHRvdWNoYWRq dXN0bWVudC9mb2N1c291dC1vbi10b3VjaC5odG1sIGZhaWxzCiAjIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTIwNQogdG91Y2hhZGp1c3RtZW50L2ZvY3Vzb3V0LW9u LXRvdWNoLmh0bWwK