92635 2012-07-30 05:05:05 -0700 atomicDecrement() never reach 0 on Android so no deref() will be called 2012-07-30 17:05:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91746 1 james.wei james.wei abarth aelias levin+threading peter webkit.review.bot oldest_to_newest 681892 0 james.wei 2012-07-30 05:05:05 -0700 atomicDecrement() never reach 0 on Android so no deref() will be called 681893 1 155265 james.wei 2012-07-30 05:08:37 -0700 Created attachment 155265 Patch 681896 2 155268 james.wei 2012-07-30 05:14:57 -0700 Created attachment 155268 Patch 681972 3 155268 peter 2012-07-30 06:38:29 -0700 Comment on attachment 155268 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155268&action=review This probably is something we should modify in the atomicDecrement() implementation in Atomics.h by substracting one from __atomic_dec()'s return value. Otherwise other potential other users of atomicDecrement() have to keep this in mind as well, while it actually is an issue with the implementation of that function. That also means that we'll only touch Chromium on Android specific code, while this solution touches general WTF code. > Source/WTF/wtf/ThreadSafeRefCounted.h:108 > +// atomicDecrement() on Android is implemented with __atomic_inc(), which is __atomic_inc -> __atomic_dec. 682012 4 155291 james.wei 2012-07-30 08:01:17 -0700 Created attachment 155291 Patch 682014 5 james.wei 2012-07-30 08:01:56 -0700 (In reply to comment #3) > (From update of attachment 155268 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155268&action=review > > This probably is something we should modify in the atomicDecrement() implementation in Atomics.h by substracting one from __atomic_dec()'s return value. > Otherwise other potential other users of atomicDecrement() have to keep this in mind as well, while it actually is an issue with the implementation of that function. That also means that we'll only touch Chromium on Android specific code, while this solution touches general WTF code. > > > Source/WTF/wtf/ThreadSafeRefCounted.h:108 > > +// atomicDecrement() on Android is implemented with __atomic_inc(), which is > > __atomic_inc -> __atomic_dec. fixed. thanks 682058 6 155291 peter 2012-07-30 08:56:06 -0700 Comment on attachment 155291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155291&action=review Looks good to me, thank you James! I also verified that this fixes the test failure in TestWebKitAPI. Adam, could you please do a formal review? I've set cq? on the patch too. > Source/WTF/ChangeLog:3 > + atomicDecrement() never reach 0 on Android so no deref() will be called nit: Prefixing bug titles with [Chromium] if all code-changes are Chromium specific generally is good practice. This already mentions "Android", though, so you're good. > Source/WTF/ChangeLog:8 > + With Android NDK 7rb and later, __atomic_dec() is implemented by nit: s/7rb/r7b/. 682082 7 abarth 2012-07-30 09:32:40 -0700 /me will fix up the ChangeLog for you. 682109 8 155309 abarth 2012-07-30 10:02:28 -0700 Created attachment 155309 Patch for landing 682534 9 155309 webkit.review.bot 2012-07-30 16:53:35 -0700 Comment on attachment 155309 Patch for landing Clearing flags on attachment: 155309 Committed r124115: <http://trac.webkit.org/changeset/124115> 682535 10 webkit.review.bot 2012-07-30 16:53:38 -0700 All reviewed patches have been landed. Closing bug. 682539 11 aelias 2012-07-30 17:05:18 -0700 Thanks for taking care of this. Our tests are passing now. 155265 2012-07-30 05:08:37 -0700 2012-07-30 05:14:52 -0700 Patch bug-92635-20120730200835.patch text/plain 1763 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3OWM2NjAyMDg0MmI4NjEzMTIxM2Y2 Mzc4YmMzYTczMDBhNmRmNmQuLjJiMWQ5YTU4YWZjZTVkYzg1NjAzZjY2ZDQ4MGEwMDVjZmIxMGIz ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDctMzAgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CisKKyAgICAgICAgYXRvbWljRGVjcmVtZW50KCkgbmV2ZXIgcmVhY2ggMCBv biBBbmRyb2lkIHNvIG5vIGRlcmVmKCkgd2lsbCBiZSBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjM1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT24gQW5kcm9pZCBOREsgN3JiIGFuZCBsYXRl ciwgX19hdG9taWNfZGVjKCkgIGlzIGltcGxlbWVudGVkIGJ5CisgICAgICAgIF9fc3luY19mZXRj aF9hbmRfc3ViKCksIHdoaWNoIHdpbGwgcmVzdWx0IGluIHRoYXQgYXRvbWljRGVjcmVtZW50KCkK KyAgICAgICAgcmV0dXJucyB0aGUgb2xkIHZhbHVlIGluc3RlYWQgb2YgbmV3IG9uZSwgd2hpY2gg aXMgZGlmZmVyZW50IHRoYW4KKyAgICAgICAgb3RoZXIgcGxhdGZvcm1zLiAKKworICAgICAgICAq IHd0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZC5oOgorICAgICAgICAoV1RGOjpUaHJlYWRTYWZlUmVm Q291bnRlZEJhc2U6OmRlcmVmQmFzZSk6CisKIDIwMTItMDctMzAgIFBhdHJpY2sgR2Fuc3RlcmVy ICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBVbmljb2RlV2luQ0Ugd2l0 aCBVbmljb2RlV2NoYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZFNhZmVSZWZD b3VudGVkLmggYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZC5oCmluZGV4IDQ0 MDM1ZTU0NzQ3YTY1YjVkNDFmZDEwYzQxNDc5ZjUzNTgwMTQzODYuLmU1ODZkYTZjYmJhNjZjZmRi YmU3YTJhNTMxMzA2M2NmNmU0NmE4ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RocmVh ZFNhZmVSZWZDb3VudGVkLmgKKysrIGIvU291cmNlL1dURi93dGYvVGhyZWFkU2FmZVJlZkNvdW50 ZWQuaApAQCAtMTA1LDcgKzEwNSwxNCBAQCBwcm90ZWN0ZWQ6CiAgICAgewogI2lmIFVTRShMT0NL RlJFRV9USFJFQURTQUZFUkVGQ09VTlRFRCkKICAgICAgICAgV1RGX0FOTk9UQVRFX0hBUFBFTlNf QkVGT1JFKCZtX3JlZkNvdW50KTsKKy8vIGF0b21pY0RlY3JlbWVudCgpIG9uIEFuZHJvaWQgaXMg aW1wbGVtZW50ZWQgd2l0aCBfX2F0b21pY19pbmMoKSwgd2hpY2ggaXMKKy8vIGltcGxlbWVudGVk IGJ5IF9fc3luY19mZXRjaF9hbmRfc3ViIGluIEFuZHJvaWQgTkRLIHI3YiBhbmQgbGF0ZXIuIFNv IGl0IHdpbGwKKy8vIHJldHVybiB0aGUgb2xkIHZhbHVlIGluc3RlYWQgb2YgdGhlIG5ldyBvbmUu CisjaWYgT1MoQU5EUk9JRCkKKyAgICAgICAgaWYgKGF0b21pY0RlY3JlbWVudCgmbV9yZWZDb3Vu dCkgPD0gMSkgeworI2Vsc2UKICAgICAgICAgaWYgKGF0b21pY0RlY3JlbWVudCgmbV9yZWZDb3Vu dCkgPD0gMCkgeworI2VuZGlmCiAgICAgICAgICAgICBXVEZfQU5OT1RBVEVfSEFQUEVOU19BRlRF UigmbV9yZWZDb3VudCk7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQo= 155268 2012-07-30 05:14:57 -0700 2012-07-30 08:01:13 -0700 Patch bug-92635-20120730201455.patch text/plain 1764 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3OWM2NjAyMDg0MmI4NjEzMTIxM2Y2 Mzc4YmMzYTczMDBhNmRmNmQuLmZlY2I4M2Q0ZmQ2YTlkY2UyZWM2MjYyNGU0NTUxNTA2ZjkxNTBm MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDctMzAgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CisKKyAgICAgICAgYXRvbWljRGVjcmVtZW50KCkgbmV2ZXIgcmVhY2ggMCBv biBBbmRyb2lkIHNvIG5vIGRlcmVmKCkgd2lsbCBiZSBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjM1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2l0aCBBbmRyb2lkIE5ESyA3cmIgYW5kIGxh dGVyLCBfX2F0b21pY19kZWMoKSAgaXMgaW1wbGVtZW50ZWQgYnkKKyAgICAgICAgX19zeW5jX2Zl dGNoX2FuZF9zdWIoKSwgd2hpY2ggd2lsbCByZXN1bHQgaW4gdGhhdCBhdG9taWNEZWNyZW1lbnQo KQorICAgICAgICByZXR1cm5zIHRoZSBvbGQgdmFsdWUgaW5zdGVhZCBvZiBuZXcgb25lLCB3aGlj aCBpcyBkaWZmZXJlbnQgdGhhbgorICAgICAgICBvdGhlciBwbGF0Zm9ybXMuCisKKyAgICAgICAg KiB3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaDoKKyAgICAgICAgKFdURjo6VGhyZWFkU2FmZVJl ZkNvdW50ZWRCYXNlOjpkZXJlZkJhc2UpOgorCiAyMDEyLTA3LTMwICBQYXRyaWNrIEdhbnN0ZXJl ciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlcGxhY2UgVW5pY29kZVdpbkNFIHdp dGggVW5pY29kZVdjaGFyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRTYWZlUmVm Q291bnRlZC5oIGIvU291cmNlL1dURi93dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaAppbmRleCA0 NDAzNWU1NDc0N2E2NWI1ZDQxZmQxMGM0MTQ3OWY1MzU4MDE0Mzg2Li5lNTg2ZGE2Y2JiYTY2Y2Zk YmJlN2EyYTUzMTMwNjNjZjZlNDZhOGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9UaHJl YWRTYWZlUmVmQ291bnRlZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZFNhZmVSZWZDb3Vu dGVkLmgKQEAgLTEwNSw3ICsxMDUsMTQgQEAgcHJvdGVjdGVkOgogICAgIHsKICNpZiBVU0UoTE9D S0ZSRUVfVEhSRUFEU0FGRVJFRkNPVU5URUQpCiAgICAgICAgIFdURl9BTk5PVEFURV9IQVBQRU5T X0JFRk9SRSgmbV9yZWZDb3VudCk7CisvLyBhdG9taWNEZWNyZW1lbnQoKSBvbiBBbmRyb2lkIGlz IGltcGxlbWVudGVkIHdpdGggX19hdG9taWNfaW5jKCksIHdoaWNoIGlzCisvLyBpbXBsZW1lbnRl ZCBieSBfX3N5bmNfZmV0Y2hfYW5kX3N1YiBpbiBBbmRyb2lkIE5ESyByN2IgYW5kIGxhdGVyLiBT byBpdCB3aWxsCisvLyByZXR1cm4gdGhlIG9sZCB2YWx1ZSBpbnN0ZWFkIG9mIHRoZSBuZXcgb25l LgorI2lmIE9TKEFORFJPSUQpCisgICAgICAgIGlmIChhdG9taWNEZWNyZW1lbnQoJm1fcmVmQ291 bnQpIDw9IDEpIHsKKyNlbHNlCiAgICAgICAgIGlmIChhdG9taWNEZWNyZW1lbnQoJm1fcmVmQ291 bnQpIDw9IDApIHsKKyNlbmRpZgogICAgICAgICAgICAgV1RGX0FOTk9UQVRFX0hBUFBFTlNfQUZU RVIoJm1fcmVmQ291bnQpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0K 155291 2012-07-30 08:01:17 -0700 2012-07-30 10:02:24 -0700 Patch bug-92635-20120730230115.patch text/plain 1850 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3OWM2NjAyMDg0MmI4NjEzMTIxM2Y2 Mzc4YmMzYTczMDBhNmRmNmQuLjM1YWUwN2VkMTM5MWM0OWNjNDdjYzNlNTRhOTliZjVjM2Y0MmY3 ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDctMzAgIFdlaSBKYW1lcyAgPGphbWVzLndl aUBpbnRlbC5jb20+CisKKyAgICAgICAgYXRvbWljRGVjcmVtZW50KCkgbmV2ZXIgcmVhY2ggMCBv biBBbmRyb2lkIHNvIG5vIGRlcmVmKCkgd2lsbCBiZSBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNjM1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2l0aCBBbmRyb2lkIE5ESyA3cmIgYW5kIGxh dGVyLCBfX2F0b21pY19kZWMoKSAgaXMgaW1wbGVtZW50ZWQgYnkKKyAgICAgICAgX19zeW5jX2Zl dGNoX2FuZF9zdWIoKSwgd2hpY2ggd2lsbCByZXN1bHQgaW4gdGhhdCBhdG9taWNEZWNyZW1lbnQo KQorICAgICAgICByZXR1cm5zIHRoZSBvbGQgdmFsdWUgaW5zdGVhZCBvZiBuZXcgb25lLgorCisg ICAgICAgICogd3RmL0F0b21pY3MuaDoKKyAgICAgICAgKFdURik6CisgICAgICAgIChXVEY6OmF0 b21pY0luY3JlbWVudCk6CisgICAgICAgIChXVEY6OmF0b21pY0RlY3JlbWVudCk6CisKIDIwMTIt MDctMzAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmVwbGFjZSBVbmljb2RlV2luQ0Ugd2l0aCBVbmljb2RlV2NoYXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL0F0b21pY3MuaCBiL1NvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAppbmRleCBhMmVm ZDk0OGM3M2M2ZGJkZDNhMjljNjIzZjFmNTQwOTY3MWE0NmJkLi45YmFlZTUwYzJkOTEzZDUyMzJh NWUyZDc3NTFmNTA1NzgyZmMxNGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9BdG9taWNz LmgKKysrIGIvU291cmNlL1dURi93dGYvQXRvbWljcy5oCkBAIC0xMDgsOCArMTA4LDkgQEAgaW5s aW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIHN0 YXRpY19jYXN0PGludD4oYXRvbWkKICNlbGlmIE9TKEFORFJPSUQpCiAjZGVmaW5lIFdURl9VU0Vf TE9DS0ZSRUVfVEhSRUFEU0FGRVJFRkNPVU5URUQgMQogCi1pbmxpbmUgaW50IGF0b21pY0luY3Jl bWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gX19hdG9taWNfaW5jKGFkZGVuZCk7 IH0KLWlubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJl dHVybiBfX2F0b21pY19kZWMoYWRkZW5kKTsgfQorLy8gTm90ZSwgX19hdG9taWNfe2luYywgZGVj fSgpIHJldHVybiB0aGUgcHJldmlvdXMgdmFsdWUgb2YgYWRkZW5kJ3MgY29udGVudC4KK2lubGlu ZSBpbnQgYXRvbWljSW5jcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBfX2F0 b21pY19pbmMoYWRkZW5kKSArIDE7IH0KK2lubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCB2 b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBfX2F0b21pY19kZWMoYWRkZW5kKSAtIDE7IH0KIAog I2VsaWYgQ09NUElMRVIoR0NDKSAmJiAhQ1BVKFNQQVJDNjQpIC8vIHNpemVvZihfQXRvbWljX3dv cmQpICE9IHNpemVvZihpbnQpIG9uIHNwYXJjNjQgZ2NjCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZS RUVfVEhSRUFEU0FGRVJFRkNPVU5URUQgMQo= 155309 2012-07-30 10:02:28 -0700 2012-07-30 16:53:35 -0700 Patch for landing bug-92635-20120730100212.patch text/plain 1717 abarth SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjQwMzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTMwICBXZWkgSmFtZXMgIDxqYW1lcy53 ZWlAaW50ZWwuY29tPgorCisgICAgICAgIGF0b21pY0RlY3JlbWVudCgpIG5ldmVyIHJlYWNoIDAg b24gQW5kcm9pZCBzbyBubyBkZXJlZigpIHdpbGwgYmUgY2FsbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjYzNQorCisgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gQmFydGguCisKKyAgICAgICAgV2l0aCBBbmRyb2lkIE5ESyA3YiBhbmQgbGF0ZXIs IF9fYXRvbWljX2RlYygpICBpcyBpbXBsZW1lbnRlZCBieQorICAgICAgICBfX3N5bmNfZmV0Y2hf YW5kX3N1YigpLCB3aGljaCB3aWxsIHJlc3VsdCBpbiB0aGF0IGF0b21pY0RlY3JlbWVudCgpCisg ICAgICAgIHJldHVybnMgdGhlIG9sZCB2YWx1ZSBpbnN0ZWFkIG9mIG5ldyBvbmUuCisKKyAgICAg ICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGKToKKyAgICAgICAgKFdURjo6YXRvbWlj SW5jcmVtZW50KToKKyAgICAgICAgKFdURjo6YXRvbWljRGVjcmVtZW50KToKKwogMjAxMi0wNy0z MCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXBs YWNlIFVuaWNvZGVXaW5DRSB3aXRoIFVuaWNvZGVXY2hhcgpJbmRleDogU291cmNlL1dURi93dGYv QXRvbWljcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAkocmV2aXNp b24gMTI0MDM1KQorKysgU291cmNlL1dURi93dGYvQXRvbWljcy5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMDgsOCArMTA4LDkgQEAgaW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxl KgogI2VsaWYgT1MoQU5EUk9JRCkKICNkZWZpbmUgV1RGX1VTRV9MT0NLRlJFRV9USFJFQURTQUZF UkVGQ09VTlRFRCAxCiAKLWlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGludCB2b2xhdGlsZSog YWRkZW5kKSB7IHJldHVybiBfX2F0b21pY19pbmMoYWRkZW5kKTsgfQotaW5saW5lIGludCBhdG9t aWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIF9fYXRvbWljX2RlYyhh ZGRlbmQpOyB9CisvLyBOb3RlLCBfX2F0b21pY197aW5jLCBkZWN9KCkgcmV0dXJuIHRoZSBwcmV2 aW91cyB2YWx1ZSBvZiBhZGRlbmQncyBjb250ZW50LgoraW5saW5lIGludCBhdG9taWNJbmNyZW1l bnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIF9fYXRvbWljX2luYyhhZGRlbmQpICsg MTsgfQoraW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsg cmV0dXJuIF9fYXRvbWljX2RlYyhhZGRlbmQpIC0gMTsgfQogCiAjZWxpZiBDT01QSUxFUihHQ0Mp ICYmICFDUFUoU1BBUkM2NCkgLy8gc2l6ZW9mKF9BdG9taWNfd29yZCkgIT0gc2l6ZW9mKGludCkg b24gc3BhcmM2NCBnY2MKICNkZWZpbmUgV1RGX1VTRV9MT0NLRlJFRV9USFJFQURTQUZFUkVGQ09V TlRFRCAxCg==