<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>92625</bug_id>
          
          <creation_ts>2012-07-30 02:35:56 -0700</creation_ts>
          <short_desc>Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.</short_desc>
          <delta_ts>2012-07-30 06:21:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>UI Events</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>91290</blocked>
    
    <blocked>92621</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Hayato Ito">hayato</reporter>
          <assigned_to name="Hayato Ito">hayato</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>dominicc</cc>
    
    <cc>morrita</cc>
    
    <cc>shinyak</cc>
    
    <cc>tasak</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>681807</commentid>
    <comment_count>0</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-07-30 02:35:56 -0700</bug_when>
    <thetext>EventDispatcher::m_shouldPreventDispatch does not make any sense. We can remove that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681809</commentid>
    <comment_count>1</comment_count>
      <attachid>155240</attachid>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-07-30 02:40:15 -0700</bug_when>
    <thetext>Created attachment 155240
remove EventDispatcher::m_shouldPreventDispatch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681956</commentid>
    <comment_count>2</comment_count>
      <attachid>155240</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-30 06:21:15 -0700</bug_when>
    <thetext>Comment on attachment 155240
remove EventDispatcher::m_shouldPreventDispatch

Clearing flags on attachment: 155240

Committed r124019: &lt;http://trac.webkit.org/changeset/124019&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>681957</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-30 06:21:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>155240</attachid>
            <date>2012-07-30 02:40:15 -0700</date>
            <delta_ts>2012-07-30 06:21:15 -0700</delta_ts>
            <desc>remove EventDispatcher::m_shouldPreventDispatch</desc>
            <filename>bug-92625-20120730183959.patch</filename>
            <type>text/plain</type>
            <size>2552</size>
            <attacher name="Hayato Ito">hayato</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIwODUwZjdiNWZhYWEx
MWRkNzhhNDkwNDQ2MmJmMDBlMWIzNzFkMi4uM2RmMDMwNjg0MjgxNWIwYjI3ZjBjMmUwYjMxZDkw
MzkzZTg1MTBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTMwICBIYXlh
dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgYW4gdXNlbGVz
cyBtZW1iZXIgdmFyaWFibGUsIG1fc2hvdWxkUHJldmVudERpc3BhdGNoLCBmcm9tIEV2ZW50RGlz
cGF0Y2hlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTkyNjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
RXZlbnREaXNwYXRjaGVyOjptX3Nob3VsZFByZXZlbnREaXNwYXRjaCBkb2VzIG5vdCBoYXZlIGFu
eSBlZmZlY3RzLiBXZSBjYW4gcmVtb3ZlIHRoYXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu
byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBkb20vRXZlbnREaXNwYXRjaGVyLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6RXZlbnREaXNwYXRjaGVyKToKKyAg
ICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudCk6CisgICAgICAg
ICogZG9tL0V2ZW50RGlzcGF0Y2hlci5oOgorICAgICAgICAoRXZlbnREaXNwYXRjaGVyKToKKwog
MjAxMi0wNy0yOCAgTWluIFFpbiAgPHFpbm1pbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRk
IGFuIG92ZXJsYXkgcGxheSBidXR0b24gdG8gbWVkaWEgY29udHJvbHMgb24gYW5kcm9pZApkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCBhNzVhYWIwZTM1ZDYyYzU4Yjhm
MDEwOWI5MDRiMmVkMGZhZjE1OWRjLi5jMTQ0OGY2OWQ1OTE5NGUwZjg5MTk5MTg4M2JjODA4ZjU1
NTFiZmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNw
cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMjAxLDcg
KzIwMSw2IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjphZGp1c3RSZWxhdGVkVGFyZ2V0KEV2ZW50
KiBldmVudCwgUGFzc1JlZlB0cjxFdmVudFRhcmdldD4KIEV2ZW50RGlzcGF0Y2hlcjo6RXZlbnRE
aXNwYXRjaGVyKE5vZGUqIG5vZGUpCiAgICAgOiBtX25vZGUobm9kZSkKICAgICAsIG1fYW5jZXN0
b3JzSW5pdGlhbGl6ZWQoZmFsc2UpCi0gICAgLCBtX3Nob3VsZFByZXZlbnREaXNwYXRjaChmYWxz
ZSkKIHsKICAgICBBU1NFUlQobm9kZSk7CiAgICAgbV92aWV3ID0gbm9kZS0+ZG9jdW1lbnQoKS0+
dmlldygpOwpAQCAtMjU0LDcgKzI1Myw3IEBAIGJvb2wgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRj
aEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KQogCiAgICAgLy8gR2l2ZSB0aGUgdGFyZ2V0
IG5vZGUgYSBjaGFuY2UgdG8gZG8gc29tZSB3b3JrIGJlZm9yZSBET00gZXZlbnQgaGFuZGxlcnMg
Z2V0IGEgY3JhY2suCiAgICAgdm9pZCogZGF0YSA9IG1fbm9kZS0+cHJlRGlzcGF0Y2hFdmVudEhh
bmRsZXIoZXZlbnQuZ2V0KCkpOwotICAgIGlmIChtX2FuY2VzdG9ycy5pc0VtcHR5KCkgfHwgbV9z
aG91bGRQcmV2ZW50RGlzcGF0Y2ggfHwgZXZlbnQtPnByb3BhZ2F0aW9uU3RvcHBlZCgpKQorICAg
IGlmIChtX2FuY2VzdG9ycy5pc0VtcHR5KCkgfHwgZXZlbnQtPnByb3BhZ2F0aW9uU3RvcHBlZCgp
KQogICAgICAgICBnb3RvIGRvbmVEaXNwYXRjaGluZzsKIAogICAgIC8vIFRyaWdnZXIgY2FwdHVy
aW5nIGV2ZW50IGhhbmRsZXJzLCBzdGFydGluZyBhdCB0aGUgdG9wIGFuZCB3b3JraW5nIG91ciB3
YXkgZG93bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIu
aCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuaAppbmRleCAzNGM1NWU0ZGIz
ZTU2YzYzOWI0NzAzMjBjYzVjNTg3ODhmNDRhYzMwLi5mOTlkYzhjZDJjMDFhMzhiNDI2YTYzOTk0
NDQ4Y2NjYmI3YTQ5NjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNw
YXRjaGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5oCkBAIC04
NSw3ICs4NSw2IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPEV2ZW50VGFyZ2V0PiBtX29yaWdpbmFs
VGFyZ2V0OwogICAgIFJlZlB0cjxGcmFtZVZpZXc+IG1fdmlldzsKICAgICBib29sIG1fYW5jZXN0
b3JzSW5pdGlhbGl6ZWQ7Ci0gICAgYm9vbCBtX3Nob3VsZFByZXZlbnREaXNwYXRjaDsKIH07CiAK
IGlubGluZSBOb2RlKiBFdmVudERpc3BhdGNoZXI6Om5vZGUoKSBjb25zdAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>