92494 2012-07-27 05:12:01 -0700 [EFL] Change the scrollbar behavior not to select the text when moving the scrollbar thumb 2012-11-23 22:28:43 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED INVALID P2 Normal --- 0 jinwoo7.song jinwoo7.song antognolli+webkit gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 680481 0 jinwoo7.song 2012-07-27 05:12:01 -0700 Set mouse pressed to false when the mouse is over the thumb of the scrollbar and change the variable name more clearly. 680487 1 154912 jinwoo7.song 2012-07-27 05:22:28 -0700 Created attachment 154912 patch 681341 2 155112 jinwoo7.song 2012-07-27 22:53:54 -0700 Created attachment 155112 patch2. Remove the unnecessary check statement. 681342 3 gyuyoung.kim 2012-07-27 22:57:34 -0700 Why do you only request cq ? Please request r? as well. And, did you check if this patch influences on layout test ? We need to verify it. 681346 4 jinwoo7.song 2012-07-27 23:05:12 -0700 I'll request r+ for this patch. I think this does not need layout test because the scrollbar layout tests use the mockup scrollbar and this patch does not change the mockup scrollbar. 681347 5 155113 jinwoo7.song 2012-07-27 23:12:21 -0700 Created attachment 155113 patch. request cq+ and r+. 681348 6 gyuyoung.kim 2012-07-27 23:23:42 -0700 (In reply to comment #4) > I'll request r+ for this patch. > I think this does not need layout test because the scrollbar layout tests use the mockup scrollbar and this patch does not change the mockup scrollbar. It seems to me this patch may influence on layout test result. If there are no differences in layout test result or no unskipped test cases, I can review this informally. See also, http://trac.webkit.org/wiki/WebKitEFLLayoutTest 681352 7 jinwoo7.song 2012-07-27 23:37:12 -0700 okay, I'll check the if the regression is happened and let you know. 681375 8 jinwoo7.song 2012-07-28 01:34:24 -0700 (In reply to comment #6) > (In reply to comment #4) > > I'll request r+ for this patch. > > I think this does not need layout test because the scrollbar layout tests use the mockup scrollbar and this patch does not change the mockup scrollbar. > > It seems to me this patch may influence on layout test result. If there are no differences in layout test result or no unskipped test cases, I can review this informally. > > See also, > http://trac.webkit.org/wiki/WebKitEFLLayoutTest I run the layout test and see no regression happened with my patch. 681407 9 155113 rakuco 2012-07-28 06:49:00 -0700 Comment on attachment 155113 patch. I don't think this is the right place for a "fix". I might be remembering things wrongly, but I think the current behavior is by design. If you want to change it, you should write another EDC theme. 681409 10 rakuco 2012-07-28 06:49:45 -0700 CC'ing a few people who might be more familiar with the history behind the current theme/behavior. 681410 11 rakuco 2012-07-28 06:50:54 -0700 Bug 87950 is related to this one. Technically speaking, this one is even a duplicate of that. 681433 12 jinwoo7.song 2012-07-28 09:25:27 -0700 (In reply to comment #9) > (From update of attachment 155113 [details]) > I don't think this is the right place for a "fix". > > I might be remembering things wrongly, but I think the current behavior is by design. If you want to change it, you should write another EDC theme. Actually, I'm curious about the current behavior is intended thing and by design. Because common users do not expect the text selection while scrolling the thumb. 681434 13 jinwoo7.song 2012-07-28 09:33:47 -0700 (In reply to comment #11) > Bug 87950 is related to this one. Technically speaking, this one is even a duplicate of that. Yes, you are right and I could not find that in advance. But it seems that there is no progress in Bug 87950. If so, I'd like to follow that in this bug. 697939 14 159011 jinwoo7.song 2012-08-16 23:39:54 -0700 Created attachment 159011 patch 697942 15 jinwoo7.song 2012-08-16 23:48:22 -0700 I've changed the title of this patch according to the Kubo's comment. So I propose to change the scrollbar behavior not to select the text while moving the scrollbar thumb. As the event is handled in the ScrollbarEfl.cpp, the evas_object_propagate_events_set() is used not to propagate the event to webview. 697944 16 159011 gyuyoung.kim 2012-08-16 23:55:04 -0700 Comment on attachment 159011 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159011&action=review > Source/WebCore/ChangeLog:9 > + while moving the scrollbar thumb with the mouse. But It is not s/It/it/g > Source/WebCore/platform/efl/ScrollbarEfl.cpp:71 > + ScrollbarEfl* scrollbar = static_cast<ScrollbarEfl*>(data); This coding style change is not related to this bug. I think it would be good to change when this function is modified. > Source/WebCore/platform/efl/ScrollbarEfl.cpp:110 > + evas_object_propagate_events_set(object, EINA_FALSE); Please use standard false instead of EINA_FALSE. 697956 17 159020 jinwoo7.song 2012-08-17 00:07:31 -0700 Created attachment 159020 patch 697957 18 jinwoo7.song 2012-08-17 00:08:52 -0700 (In reply to comment #16) > (From update of attachment 159011 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159011&action=review > > > Source/WebCore/ChangeLog:9 > > + while moving the scrollbar thumb with the mouse. But It is not > > s/It/it/g > Done. > > Source/WebCore/platform/efl/ScrollbarEfl.cpp:71 > > + ScrollbarEfl* scrollbar = static_cast<ScrollbarEfl*>(data); > > This coding style change is not related to this bug. I think it would be good to change when this function is modified. > Okay, I moved out the codes in this patch. > > Source/WebCore/platform/efl/ScrollbarEfl.cpp:110 > > + evas_object_propagate_events_set(object, EINA_FALSE); > > Please use standard false instead of EINA_FALSE. Done. 698921 19 159020 gyuyoung.kim 2012-08-17 22:50:09 -0700 Comment on attachment 159020 patch As kubo said, I also think we can decide if this patch is landed after getting original authors's opinions. Rafael, Demarchi and Leandro, could you guys take a look this patch ? 736203 20 jinwoo7.song 2012-10-06 00:46:18 -0700 (In reply to comment #19) > (From update of attachment 159020 [details]) > As kubo said, I also think we can decide if this patch is landed after getting original authors's opinions. > > Rafael, Demarchi and Leandro, could you guys take a look this patch ? Rafael, Demarchi and Leandro, don't you have any feedback? 774775 21 159020 gyuyoung.kim 2012-11-23 22:20:40 -0800 Comment on attachment 159020 patch I wonder if this patch is still valid. 774777 22 jinwoo7.song 2012-11-23 22:28:04 -0800 I'll make this bug invalid as there is no agreement and discussions any more. Instead, I'll start to look into the WebKit2/EFL scrollbar implementation and this issue may be discussed in that thread. 154912 2012-07-27 05:22:28 -0700 2012-07-27 22:53:54 -0700 patch scroll_drag_fix.patch text/plain 2243 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjNkYWU3Li44MGQ4YTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMjcgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCB0aGUgc2Nyb2xsYmFyIHNjcm9sbGluZyBub3QgdG8gY2F1c2Ug ZHJhZ2dpbmcKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI0OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT ZXQgbW91c2UgcHJlc3NlZCB0byBmYWxzZSB3aGVuIHRoZSBtb3VzZSBpcyBvdmVyIHRoZSB0aHVt YiBvZiB0aGUgc2Nyb2xsYmFyCisgICAgICAgIGFuZCBjaGFuZ2UgdGhlIHZhcmlhYmxlIG5hbWUg bW9yZSBjbGVhcmx5LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHA6 CisgICAgICAgIChzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSk6CisKIDIwMTItMDctMjYgIEtlaXNo aSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IENvbG9y U3VnZ2VzdGlvblBpY2tlciBwYWdlIHBvcHVwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9TY3JvbGxiYXJFZmwuY3BwCmluZGV4IGNlN2Y3YmYuLjYwMzQzYmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCkBAIC0yMyw2ICsyMyw3IEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyRWZsLmgiCiAKKyNpbmNsdWRl ICJFdmVudEhhbmRsZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lVmll dy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgpAQCAtNjgsNyArNjksNyBAQCBTY3Jv bGxiYXJFZmw6On5TY3JvbGxiYXJFZmwoKQogCiBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGpl TWVzc2FnZSh2b2lkKiBkYXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZ2VfVHlw ZSBtZXNzYWdlVHlwZSwgaW50IGlkLCB2b2lkKiBtZXNzYWdlKQogewotICAgIFNjcm9sbGJhckVm bCogdGhhdCA9IHN0YXRpY19jYXN0PFNjcm9sbGJhckVmbCo+KGRhdGEpOworICAgIFNjcm9sbGJh ckVmbCogc2Nyb2xsYmFyID0gc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyRWZsKj4oZGF0YSk7CiAgICAg RWRqZV9NZXNzYWdlX0Zsb2F0KiBtZXNzYWdlRmxvYXQ7CiAgICAgaW50IHZhbHVlOwogCkBAIC04 NCw5ICs4NSwxMiBAQCBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSh2b2lkKiBk YXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZwogICAgICAgICByZXR1cm47CiAg ICAgfQogCisgICAgaWYgKHNjcm9sbGJhci0+cGFyZW50KCkgJiYgc2Nyb2xsYmFyLT5wYXJlbnQo KS0+aXNGcmFtZVZpZXcoKSkKKyAgICAgICAgc3RhdGljX2Nhc3Q8RnJhbWVWaWV3Kj4oc2Nyb2xs YmFyLT5wYXJlbnQoKSktPmZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5zZXRNb3VzZVByZXNzZWQo ZmFsc2UpOworCiAgICAgbWVzc2FnZUZsb2F0ID0gc3RhdGljX2Nhc3Q8RWRqZV9NZXNzYWdlX0Zs b2F0Kj4obWVzc2FnZSk7Ci0gICAgdmFsdWUgPSBtZXNzYWdlRmxvYXQtPnZhbCAqICh0aGF0LT50 b3RhbFNpemUoKSAtIHRoYXQtPnZpc2libGVTaXplKCkpOwotICAgIHRoYXQtPnNjcm9sbGFibGVB cmVhKCktPnNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlvbih0aGF0LT5vcmllbnRhdGlvbigp LCB2YWx1ZSk7CisgICAgdmFsdWUgPSBtZXNzYWdlRmxvYXQtPnZhbCAqIChzY3JvbGxiYXItPnRv dGFsU2l6ZSgpIC0gc2Nyb2xsYmFyLT52aXNpYmxlU2l6ZSgpKTsKKyAgICBzY3JvbGxiYXItPnNj cm9sbGFibGVBcmVhKCktPnNjcm9sbFRvT2Zmc2V0V2l0aG91dEFuaW1hdGlvbihzY3JvbGxiYXIt Pm9yaWVudGF0aW9uKCksIHZhbHVlKTsKIH0KIAogdm9pZCBTY3JvbGxiYXJFZmw6OnNldFBhcmVu dChTY3JvbGxWaWV3KiB2aWV3KQo= 155112 2012-07-27 22:53:54 -0700 2012-07-27 23:12:21 -0700 patch2. Remove the unnecessary check statement. scroll_drag_fix.patch text/plain 2205 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjNkYWU3Li44MGQ4YTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMjcgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCB0aGUgc2Nyb2xsYmFyIHNjcm9sbGluZyBub3QgdG8gY2F1c2Ug ZHJhZ2dpbmcKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI0OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT ZXQgbW91c2UgcHJlc3NlZCB0byBmYWxzZSB3aGVuIHRoZSBtb3VzZSBpcyBvdmVyIHRoZSB0aHVt YiBvZiB0aGUgc2Nyb2xsYmFyCisgICAgICAgIGFuZCBjaGFuZ2UgdGhlIHZhcmlhYmxlIG5hbWUg bW9yZSBjbGVhcmx5LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHA6 CisgICAgICAgIChzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSk6CisKIDIwMTItMDctMjYgIEtlaXNo aSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IENvbG9y U3VnZ2VzdGlvblBpY2tlciBwYWdlIHBvcHVwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9TY3JvbGxiYXJFZmwuY3BwCmluZGV4IGNlN2Y3YmYuLmI2YzI1NmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCkBAIC0yMyw2ICsyMyw3IEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyRWZsLmgiCiAKKyNpbmNsdWRl ICJFdmVudEhhbmRsZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lVmll dy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgpAQCAtNjgsNyArNjksNyBAQCBTY3Jv bGxiYXJFZmw6On5TY3JvbGxiYXJFZmwoKQogCiBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGpl TWVzc2FnZSh2b2lkKiBkYXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZ2VfVHlw ZSBtZXNzYWdlVHlwZSwgaW50IGlkLCB2b2lkKiBtZXNzYWdlKQogewotICAgIFNjcm9sbGJhckVm bCogdGhhdCA9IHN0YXRpY19jYXN0PFNjcm9sbGJhckVmbCo+KGRhdGEpOworICAgIFNjcm9sbGJh ckVmbCogc2Nyb2xsYmFyID0gc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyRWZsKj4oZGF0YSk7CiAgICAg RWRqZV9NZXNzYWdlX0Zsb2F0KiBtZXNzYWdlRmxvYXQ7CiAgICAgaW50IHZhbHVlOwogCkBAIC04 NCw5ICs4NSwxMiBAQCBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSh2b2lkKiBk YXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZwogICAgICAgICByZXR1cm47CiAg ICAgfQogCisgICAgaWYgKHNjcm9sbGJhci0+cGFyZW50KCkpCisgICAgICAgIHN0YXRpY19jYXN0 PEZyYW1lVmlldyo+KHNjcm9sbGJhci0+cGFyZW50KCkpLT5mcmFtZSgpLT5ldmVudEhhbmRsZXIo KS0+c2V0TW91c2VQcmVzc2VkKGZhbHNlKTsKKwogICAgIG1lc3NhZ2VGbG9hdCA9IHN0YXRpY19j YXN0PEVkamVfTWVzc2FnZV9GbG9hdCo+KG1lc3NhZ2UpOwotICAgIHZhbHVlID0gbWVzc2FnZUZs b2F0LT52YWwgKiAodGhhdC0+dG90YWxTaXplKCkgLSB0aGF0LT52aXNpYmxlU2l6ZSgpKTsKLSAg ICB0aGF0LT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24o dGhhdC0+b3JpZW50YXRpb24oKSwgdmFsdWUpOworICAgIHZhbHVlID0gbWVzc2FnZUZsb2F0LT52 YWwgKiAoc2Nyb2xsYmFyLT50b3RhbFNpemUoKSAtIHNjcm9sbGJhci0+dmlzaWJsZVNpemUoKSk7 CisgICAgc2Nyb2xsYmFyLT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxUb09mZnNldFdpdGhvdXRB bmltYXRpb24oc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpLCB2YWx1ZSk7CiB9CiAKIHZvaWQgU2Ny b2xsYmFyRWZsOjpzZXRQYXJlbnQoU2Nyb2xsVmlldyogdmlldykK 155113 2012-07-27 23:12:21 -0700 2012-08-16 23:39:54 -0700 patch. scroll_drag_fix.patch text/plain 2205 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjNkYWU3Li44MGQ4YTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMjcgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEZpeCB0aGUgc2Nyb2xsYmFyIHNjcm9sbGluZyBub3QgdG8gY2F1c2Ug ZHJhZ2dpbmcKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTI0OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT ZXQgbW91c2UgcHJlc3NlZCB0byBmYWxzZSB3aGVuIHRoZSBtb3VzZSBpcyBvdmVyIHRoZSB0aHVt YiBvZiB0aGUgc2Nyb2xsYmFyCisgICAgICAgIGFuZCBjaGFuZ2UgdGhlIHZhcmlhYmxlIG5hbWUg bW9yZSBjbGVhcmx5LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHA6 CisgICAgICAgIChzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSk6CisKIDIwMTItMDctMjYgIEtlaXNo aSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IENvbG9y U3VnZ2VzdGlvblBpY2tlciBwYWdlIHBvcHVwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9TY3JvbGxiYXJFZmwuY3BwCmluZGV4IGNlN2Y3YmYuLmI2YzI1NmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwCkBAIC0yMyw2ICsyMyw3IEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyRWZsLmgiCiAKKyNpbmNsdWRl ICJFdmVudEhhbmRsZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lVmll dy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgpAQCAtNjgsNyArNjksNyBAQCBTY3Jv bGxiYXJFZmw6On5TY3JvbGxiYXJFZmwoKQogCiBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGpl TWVzc2FnZSh2b2lkKiBkYXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZ2VfVHlw ZSBtZXNzYWdlVHlwZSwgaW50IGlkLCB2b2lkKiBtZXNzYWdlKQogewotICAgIFNjcm9sbGJhckVm bCogdGhhdCA9IHN0YXRpY19jYXN0PFNjcm9sbGJhckVmbCo+KGRhdGEpOworICAgIFNjcm9sbGJh ckVmbCogc2Nyb2xsYmFyID0gc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyRWZsKj4oZGF0YSk7CiAgICAg RWRqZV9NZXNzYWdlX0Zsb2F0KiBtZXNzYWdlRmxvYXQ7CiAgICAgaW50IHZhbHVlOwogCkBAIC04 NCw5ICs4NSwxMiBAQCBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGplTWVzc2FnZSh2b2lkKiBk YXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZwogICAgICAgICByZXR1cm47CiAg ICAgfQogCisgICAgaWYgKHNjcm9sbGJhci0+cGFyZW50KCkpCisgICAgICAgIHN0YXRpY19jYXN0 PEZyYW1lVmlldyo+KHNjcm9sbGJhci0+cGFyZW50KCkpLT5mcmFtZSgpLT5ldmVudEhhbmRsZXIo KS0+c2V0TW91c2VQcmVzc2VkKGZhbHNlKTsKKwogICAgIG1lc3NhZ2VGbG9hdCA9IHN0YXRpY19j YXN0PEVkamVfTWVzc2FnZV9GbG9hdCo+KG1lc3NhZ2UpOwotICAgIHZhbHVlID0gbWVzc2FnZUZs b2F0LT52YWwgKiAodGhhdC0+dG90YWxTaXplKCkgLSB0aGF0LT52aXNpYmxlU2l6ZSgpKTsKLSAg ICB0aGF0LT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24o dGhhdC0+b3JpZW50YXRpb24oKSwgdmFsdWUpOworICAgIHZhbHVlID0gbWVzc2FnZUZsb2F0LT52 YWwgKiAoc2Nyb2xsYmFyLT50b3RhbFNpemUoKSAtIHNjcm9sbGJhci0+dmlzaWJsZVNpemUoKSk7 CisgICAgc2Nyb2xsYmFyLT5zY3JvbGxhYmxlQXJlYSgpLT5zY3JvbGxUb09mZnNldFdpdGhvdXRB bmltYXRpb24oc2Nyb2xsYmFyLT5vcmllbnRhdGlvbigpLCB2YWx1ZSk7CiB9CiAKIHZvaWQgU2Ny b2xsYmFyRWZsOjpzZXRQYXJlbnQoU2Nyb2xsVmlldyogdmlldykK 159011 2012-08-16 23:39:54 -0700 2012-08-17 00:07:31 -0700 patch scrollbar.patch text/plain 2834 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNjk2NGQxLi4zMzE2ZTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMDgtMTYgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIENoYW5nZSB0aGUgc2Nyb2xsYmFyIGJlaGF2aW9yIG5vdCB0byBzZWxl Y3QgdGhlIHRleHQgd2hlbiBtb3ZpbmcgdGhlIHNjcm9sbGJhciB0aHVtYgorICAgICAgICBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ5NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQgc2Nyb2xsYmFyIGJlaGF2 aW9yIGlzIHNldCB0byBjYXVzZSB0aGUgdGV4dCBzZWxlY3Rpb24gCisgICAgICAgIHdoaWxlIG1v dmluZyB0aGUgc2Nyb2xsYmFyIHRodW1iIHdpdGggdGhlIG1vdXNlLiBCdXQgSXQgaXMgbm90IAor ICAgICAgICBjb25zaXN0ZW50IHdpdGggb3RoZXIgY29tbW9uIGJyb3dzZXJzIGFuZCBhbHNvIGhh cm1zIHRoZSByZWFkaWJpbGl0eQorICAgICAgICB3aGlsZSBzY3JvbGxpbmcuIFRoaXMgcGF0Y2gg c2V0cyB0aGUgZXZlbnRzIG9uIHRoZSBzY3JvbGxiYXIgbm90IAorICAgICAgICB0byBwcm9wYWdh dGUgdG8gdGhlIHdlYnZpZXcgZXZhcyBvYmplY3Qgc28gdGhlIHRleHQgaXMgbm90IHNlbGVjdGVk IAorICAgICAgICB3aGVuIG1vdmluZyB0aGUgc2Nyb2xsYmFyIHRodW1iIHdpdGggdGhlIG1vdXNl LiBBbHNvLCB0aGlzIHBhdGNoIAorICAgICAgICBjaGFuZ2VzIHRoZSBzb21lIHZhcmlhYmxlIG5h bWUgbW9yZSBjbGVhcmx5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBpcyBuZWVkZWQgYmVjYXVz ZSB0aGUgc2Nyb2xsYmFyIGxheW91dCB0ZXN0IGlzIGRvbmUgd2l0aAorICAgICAgICB0aGUgbW9j ayBzY3JvbGxiYXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoK KyAgICAgICAgKHNjcm9sbGJhckVmbEVkamVNZXNzYWdlKToKKyAgICAgICAgKFNjcm9sbGJhckVm bDo6c2V0UGFyZW50KToKKwogMjAxMi0wOC0xNiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtZW1vcnkgaW5zdHJ1bWVudGF0 aW9uIGZvciBSZXNvdXJjZXtSZXF1ZXN0L1Jlc3BvbnNlfUJhc2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKaW5kZXggY2U3ZjdiZi4uOGIyZTUwMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKQEAgLTY4LDcg KzY4LDcgQEAgU2Nyb2xsYmFyRWZsOjp+U2Nyb2xsYmFyRWZsKCkKIAogc3RhdGljIHZvaWQgc2Ny b2xsYmFyRWZsRWRqZU1lc3NhZ2Uodm9pZCogZGF0YSwgRXZhc19PYmplY3QqIG9iamVjdCwgRWRq ZV9NZXNzYWdlX1R5cGUgbWVzc2FnZVR5cGUsIGludCBpZCwgdm9pZCogbWVzc2FnZSkKIHsKLSAg ICBTY3JvbGxiYXJFZmwqIHRoYXQgPSBzdGF0aWNfY2FzdDxTY3JvbGxiYXJFZmwqPihkYXRhKTsK KyAgICBTY3JvbGxiYXJFZmwqIHNjcm9sbGJhciA9IHN0YXRpY19jYXN0PFNjcm9sbGJhckVmbCo+ KGRhdGEpOwogICAgIEVkamVfTWVzc2FnZV9GbG9hdCogbWVzc2FnZUZsb2F0OwogICAgIGludCB2 YWx1ZTsKIApAQCAtODUsOCArODUsOCBAQCBzdGF0aWMgdm9pZCBzY3JvbGxiYXJFZmxFZGplTWVz c2FnZSh2b2lkKiBkYXRhLCBFdmFzX09iamVjdCogb2JqZWN0LCBFZGplX01lc3NhZwogICAgIH0K IAogICAgIG1lc3NhZ2VGbG9hdCA9IHN0YXRpY19jYXN0PEVkamVfTWVzc2FnZV9GbG9hdCo+KG1l c3NhZ2UpOwotICAgIHZhbHVlID0gbWVzc2FnZUZsb2F0LT52YWwgKiAodGhhdC0+dG90YWxTaXpl KCkgLSB0aGF0LT52aXNpYmxlU2l6ZSgpKTsKLSAgICB0aGF0LT5zY3JvbGxhYmxlQXJlYSgpLT5z Y3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24odGhhdC0+b3JpZW50YXRpb24oKSwgdmFsdWUp OworICAgIHZhbHVlID0gbWVzc2FnZUZsb2F0LT52YWwgKiAoc2Nyb2xsYmFyLT50b3RhbFNpemUo KSAtIHNjcm9sbGJhci0+dmlzaWJsZVNpemUoKSk7CisgICAgc2Nyb2xsYmFyLT5zY3JvbGxhYmxl QXJlYSgpLT5zY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24oc2Nyb2xsYmFyLT5vcmllbnRh dGlvbigpLCB2YWx1ZSk7CiB9CiAKIHZvaWQgU2Nyb2xsYmFyRWZsOjpzZXRQYXJlbnQoU2Nyb2xs VmlldyogdmlldykKQEAgLTEwNyw2ICsxMDcsNyBAQCB2b2lkIFNjcm9sbGJhckVmbDo6c2V0UGFy ZW50KFNjcm9sbFZpZXcqIHZpZXcpCiAgICAgICAgIH0KICAgICAgICAgZWRqZV9vYmplY3RfbWVz c2FnZV9oYW5kbGVyX3NldChvYmplY3QsIHNjcm9sbGJhckVmbEVkamVNZXNzYWdlLCB0aGlzKTsK ICAgICAgICAgc2V0RXZhc09iamVjdChvYmplY3QpOworICAgICAgICBldmFzX29iamVjdF9wcm9w YWdhdGVfZXZlbnRzX3NldChvYmplY3QsIEVJTkFfRkFMU0UpOwogICAgIH0gZWxzZSBpZiAoIXZp ZXcgfHwgIXZpZXctPmV2YXMoKSB8fCAhdmlldy0+ZXZhc09iamVjdCgpKSB7CiAgICAgICAgIGV2 YXNfb2JqZWN0X2hpZGUob2JqZWN0KTsKICAgICAgICAgcmV0dXJuOwo= 159020 2012-08-17 00:07:31 -0700 2012-11-23 22:28:43 -0800 patch scrollbar.patch text/plain 1788 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNjk2NGQxLi43OTQxODM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDgtMTYgIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIENoYW5nZSB0aGUgc2Nyb2xsYmFyIGJlaGF2aW9yIG5vdCB0byBzZWxl Y3QgdGhlIHRleHQgd2hlbiBtb3ZpbmcgdGhlIHNjcm9sbGJhciB0aHVtYgorICAgICAgICBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQ5NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnQgc2Nyb2xsYmFyIGJlaGF2 aW9yIGlzIHNldCB0byBjYXVzZSB0aGUgdGV4dCBzZWxlY3Rpb24gCisgICAgICAgIHdoaWxlIG1v dmluZyB0aGUgc2Nyb2xsYmFyIHRodW1iIHdpdGggdGhlIG1vdXNlLiBCdXQgaXQgaXMgbm90IAor ICAgICAgICBjb25zaXN0ZW50IHdpdGggb3RoZXIgY29tbW9uIGJyb3dzZXJzIGFuZCBhbHNvIGhh cm1zIHRoZSByZWFkaWJpbGl0eQorICAgICAgICB3aGlsZSBzY3JvbGxpbmcuIFRoaXMgcGF0Y2gg c2V0cyB0aGUgZXZlbnRzIG9uIHRoZSBzY3JvbGxiYXIgbm90IAorICAgICAgICB0byBwcm9wYWdh dGUgdG8gdGhlIHdlYnZpZXcgZXZhcyBvYmplY3Qgc28gdGhlIHRleHQgaXMgbm90IHNlbGVjdGVk IAorICAgICAgICB3aGVuIG1vdmluZyB0aGUgc2Nyb2xsYmFyIHRodW1iIHdpdGggdGhlIG1vdXNl LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBpcyBuZWVkZWQgYmVjYXVzZSB0aGUgc2Nyb2xsYmFy IGxheW91dCB0ZXN0IGlzIGRvbmUgd2l0aAorICAgICAgICB0aGUgbW9jayBzY3JvbGxiYXIuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2Nyb2xsYmFyRWZsLmNwcDoKKyAgICAgICAgKFNjcm9s bGJhckVmbDo6c2V0UGFyZW50KToKKwogMjAxMi0wOC0xNiAgWXVyeSBTZW1pa2hhdHNreSAgPHl1 cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtZW1vcnkgaW5zdHJ1 bWVudGF0aW9uIGZvciBSZXNvdXJjZXtSZXF1ZXN0L1Jlc3BvbnNlfUJhc2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TY3JvbGxiYXJFZmwuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKaW5kZXggY2U3ZjdiZi4uM2U5ZTJl YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Njcm9sbGJhckVmbC5jcHAKQEAg LTEwNyw2ICsxMDcsNyBAQCB2b2lkIFNjcm9sbGJhckVmbDo6c2V0UGFyZW50KFNjcm9sbFZpZXcq IHZpZXcpCiAgICAgICAgIH0KICAgICAgICAgZWRqZV9vYmplY3RfbWVzc2FnZV9oYW5kbGVyX3Nl dChvYmplY3QsIHNjcm9sbGJhckVmbEVkamVNZXNzYWdlLCB0aGlzKTsKICAgICAgICAgc2V0RXZh c09iamVjdChvYmplY3QpOworICAgICAgICBldmFzX29iamVjdF9wcm9wYWdhdGVfZXZlbnRzX3Nl dChvYmplY3QsIGZhbHNlKTsKICAgICB9IGVsc2UgaWYgKCF2aWV3IHx8ICF2aWV3LT5ldmFzKCkg fHwgIXZpZXctPmV2YXNPYmplY3QoKSkgewogICAgICAgICBldmFzX29iamVjdF9oaWRlKG9iamVj dCk7CiAgICAgICAgIHJldHVybjsK