92446 2012-07-26 18:50:31 -0700 [WK2][EFL] Add ewk_view_scale_{get|set} to EwkView. 2012-07-28 16:28:39 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 ryuan.choi ryuan.choi cdumez gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 680001 0 ryuan.choi 2012-07-26 18:50:31 -0700 We need a functionality to scale up/down page by user such as pinch zoom. 680012 1 154809 ryuan.choi 2012-07-26 19:05:35 -0700 Created attachment 154809 Patch 680395 2 154809 kenneth 2012-07-27 03:31:40 -0700 Comment on attachment 154809 Patch First of all, why are you storing a local copy of the variable? Are you sure they can never come out of sync? 680468 3 ryuan.choi 2012-07-27 05:02:47 -0700 (In reply to comment #2) > (From update of attachment 154809 [details]) > First of all, why are you storing a local copy of the variable? Are you sure they can never come out of sync? I want not to send IPC when same scale factor is requested. But, I think that it looks unnecessary. I will remove it. 681349 4 155114 ryuan.choi 2012-07-27 23:29:19 -0700 Created attachment 155114 Patch 681350 5 155114 gyuyoung.kim 2012-07-27 23:33:07 -0700 Comment on attachment 155114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:887 > +Eina_Bool ewk_view_scale_set(const Evas_Object* ewkView, double scaleFactor, int x, int y) EFL port has not used const keyword in _set function so far. > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); -1 => -1.0 ? > Source/WebKit2/UIProcess/API/efl/ewk_view.h:391 > +Eina_Bool ewk_view_scale_set(const Evas_Object* ewkView, double scaleFactor, int x, int y); ditto. 681351 6 155114 gyuyoung.kim 2012-07-27 23:34:20 -0700 Comment on attachment 155114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review BTW, don't you need to support API test as well ? >> Source/WebKit2/UIProcess/API/efl/ewk_view.h:391 >> +Eina_Bool ewk_view_scale_set(const Evas_Object* ewkView, double scaleFactor, int x, int y); > > ditto. Nit : Move '*' tovariable side. > Source/WebKit2/UIProcess/API/efl/ewk_view.h:403 > +double ewk_view_scale_get(const Evas_Object* ewkView); ditto. 681353 7 155114 cdumez 2012-07-27 23:38:57 -0700 Comment on attachment 155114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > -1 => -1.0 ? Gyuyoung, this would be against coding style. 681354 8 gyuyoung.kim 2012-07-27 23:41:23 -0700 (In reply to comment #7) > (From update of attachment 155114 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > -1 => -1.0 ? > > Gyuyoung, this would be against coding style. Where is the coding style ? please let me know. 681355 9 cdumez 2012-07-27 23:42:16 -0700 (In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 155114 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > > > -1 => -1.0 ? > > > > Gyuyoung, this would be against coding style. > > Where is the coding style ? please let me know. http://www.webkit.org/coding/coding-style.html -> earch for "Floating point literals" 681356 10 gyuyoung.kim 2012-07-27 23:44:39 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (From update of attachment 155114 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > > > > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > > > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > > > > > -1 => -1.0 ? > > > > > > Gyuyoung, this would be against coding style. > > > > Where is the coding style ? please let me know. > > http://www.webkit.org/coding/coding-style.html > -> earch for "Floating point literals" yes, I just check it. ok, let's use this. Ryuan, please use -1. 681363 11 gyuyoung.kim 2012-07-28 00:10:21 -0700 (In reply to comment #7) > (From update of attachment 155114 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > -1 => -1.0 ? > > Gyuyoung, this would be against coding style. I check this a little further. Are you sure we shouldn't use x.0 in return value case ? It seems to me we need to use casting in return value case. It looks there is no mention in return value case. See also, - http://trac.webkit.org/browser/trunk/Source/WebKit/mac/WebView/WebView.mm#L4220 - http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp#L4768 - http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp#L144 681365 12 cdumez 2012-07-28 00:23:30 -0700 (In reply to comment #11) > (In reply to comment #7) > > (From update of attachment 155114 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > > > -1 => -1.0 ? > > > > Gyuyoung, this would be against coding style. > > I check this a little further. Are you sure we shouldn't use x.0 in return value case ? It seems to me we need to use casting in return value case. It looks there is no mention in return value case. > > See also, > > - http://trac.webkit.org/browser/trunk/Source/WebKit/mac/WebView/WebView.mm#L4220 > - http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp#L4768 > - http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp#L144 Return value case is not any different than argument case in my opinion. The coding style gives this example: void setDiameter(float diameter) { // ... } setDiameter(10); If you look at WebKit source code, of course, you will find a lot of case where they don't follow coding style: nobody is perfect. 681366 13 cdumez 2012-07-28 00:27:40 -0700 (In reply to comment #11) > (In reply to comment #7) > > (From update of attachment 155114 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=155114&action=review > > > > >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:898 > > >> + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > > > > > > -1 => -1.0 ? > > > > Gyuyoung, this would be against coding style. > > I check this a little further. Are you sure we shouldn't use x.0 in return value case ? It seems to me we need to use casting in return value case. It looks there is no mention in return value case. The compiler will do an implicit conversion from int to float. The generated binary code will be the same (no performance impact). 681369 14 gyuyoung.kim 2012-07-28 00:37:53 -0700 (In reply to comment #13) > The compiler will do an implicit conversion from int to float. The generated binary code will be the same (no performance impact). Even if there is no performance impact, this is related to coding style. I would like to ask this to reviewers. Reviewer may decide this. This is not major issue in this bug. So, I don't wanna litter this bug's review thread anymore. 681486 15 155144 ryuan.choi 2012-07-28 15:18:24 -0700 Created attachment 155144 Patch 681488 16 155144 webkit.review.bot 2012-07-28 16:28:33 -0700 Comment on attachment 155144 Patch Clearing flags on attachment: 155144 Committed r123974: <http://trac.webkit.org/changeset/123974> 681489 17 webkit.review.bot 2012-07-28 16:28:39 -0700 All reviewed patches have been landed. Closing bug. 154809 2012-07-26 19:05:35 -0700 2012-07-27 23:29:12 -0700 Patch bug-92446-20120727110523.patch text/plain 3895 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTY5ZGQ3NWRiY2ExNThm MTc3MWRmYWQwMDhhNWJmYTU4Yjk4N2UxNS4uMDBkMTc3MDZiYjc2YWE3NTk5YjBmNjk3YWZkZmE5 YWNjNzRlYmU1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTI2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBld2tfdmlld19zY2FsZV97Z2V0fHNldH0gdG8gRXdrVmlldy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1ldGhvZHMgdG8gRXdrX1ZpZXcgdG8g Z2V0IG9yIHNldCB0aGUgc2NhbGUgZmFjdG9yIG9mIHBhZ2UuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChfRXdrX1ZpZXdfUHJpdmF0ZV9EYXRh KToKKyAgICAgICAgKF9Fd2tfVmlld19Qcml2YXRlX0RhdGE6Ol9Fd2tfVmlld19Qcml2YXRlX0Rh dGEpOgorICAgICAgICAoZXdrX3ZpZXdfc2NhbGVfc2V0KToKKyAgICAgICAgKGV3a192aWV3X3Nj YWxlX2dldCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKwogMjAx Mi0wNy0yNiAgWmVubyBBbGJpc3NlciAgPHplbm9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkIFF0IGJ1aWxkZml4IGFmdGVyIHIxMjM3ODYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggYjY3MWQ3NjI3NjlhOTQwMTY5NzFmOTlj ZjlkMWI0ZTk3YzA5YjRlYi4uNWQ3YmZiNjQ5ZDE5OTVhOGNhYjIzZTk0MmU4OTJhZmY2NWQ3YWI3 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApA QCAtNjQsNiArNjQsOCBAQCBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgRXZh c19PYmplY3QqIGN1cnNvck9iamVjdDsKICAgICBMb2FkaW5nUmVzb3VyY2VzTWFwIGxvYWRpbmdS ZXNvdXJjZXNNYXA7CiAKKyAgICBkb3VibGUgc2NhbGVGYWN0b3I7CisKICNpZmRlZiBIQVZFX0VD T1JFX1gKICAgICBib29sIGlzVXNpbmdFY29yZVg7CiAjZW5kaWYKQEAgLTc1LDYgKzc3LDcgQEAg c3RydWN0IF9Fd2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgICAgICAsIGN1c3RvbUVuY29kaW5n KDApCiAgICAgICAgICwgY3Vyc29yR3JvdXAoMCkKICAgICAgICAgLCBjdXJzb3JPYmplY3QoMCkK KyAgICAgICAgLCBzY2FsZUZhY3RvcigxKQogI2lmZGVmIEhBVkVfRUNPUkVfWAogICAgICAgICAs IGlzVXNpbmdFY29yZVgoZmFsc2UpCiAjZW5kaWYKQEAgLTc2Nyw2ICs3NzAsMjcgQEAgZG91Ymxl IGV3a192aWV3X2xvYWRfcHJvZ3Jlc3NfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQog ICAgIHJldHVybiBXS1BhZ2VHZXRFc3RpbWF0ZWRQcm9ncmVzcyh0b0FQSShwcml2LT5wYWdlQ2xp ZW50LT5wYWdlKCkpKTsKIH0KIAorRWluYV9Cb29sIGV3a192aWV3X3NjYWxlX3NldChjb25zdCBF dmFzX09iamVjdCogZXdrVmlldywgZG91YmxlIHNjYWxlRmFjdG9yLCBpbnQgeCwgaW50IHkpCit7 CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIGZhbHNl KTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2LCBmYWxz ZSk7CisKKyAgICBpZiAocHJpdi0+c2NhbGVGYWN0b3IgPT0gc2NhbGVGYWN0b3IpCisgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICBwcml2LT5zY2FsZUZhY3RvciA9IHNjYWxlRmFjdG9yOworCisg ICAgcHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpLT5zY2FsZVBhZ2Uoc2NhbGVGYWN0b3IsIEludFBv aW50KHgsIHkpKTsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKworZG91YmxlIGV3a192aWV3X3NjYWxl X2dldChjb25zdCBFdmFzX09iamVjdCogZXdrVmlldykKK3sKKyAgICBFV0tfVklFV19TRF9HRVRf T1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgLTEpOworICAgIEVXS19WSUVXX1BSSVZfR0VU X09SX1JFVFVSTihzbWFydERhdGEsIHByaXYsIC0xKTsKKworICAgIHJldHVybiBwcml2LT5zY2Fs ZUZhY3RvcjsKK30KKwogRWluYV9Cb29sIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQo RXZhc19PYmplY3QqIGV3a1ZpZXcsIGZsb2F0IHJhdGlvKQogewogICAgIEVXS19WSUVXX1NEX0dF VF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAppbmRleCBjNDEwNGJmOWIyNzBkZmMyM2M2OTdl OGMzM2U1ZmFiNWM1NjZmNGViLi4xYzAzZGE5Njg5ZTdhOTVkMmUwNGYzMzk4NGZjMzE4NjhiOGZi NGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll dy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKQEAg LTM2MCw2ICszNjAsMjcgQEAgRUFQSSBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQo Y29uc3QgRXZhc19PYmplY3QgKm8pOwogRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfaHRtbF9zdHJp bmdfbG9hZChFdmFzX09iamVjdCAqbywgY29uc3QgY2hhciAqaHRtbCwgY29uc3QgY2hhciAqYmFz ZVVybCwgY29uc3QgY2hhciAqdW5yZWFjaGFibGVVcmwpOwogCiAvKioKKyAqIFNjYWxlcyB0aGUg Y3VycmVudCBwYWdlLCBjZW50ZXJlZCBhdCB0aGUgZ2l2ZW4gcG9pbnQuCisgKgorICogQHBhcmFt IG8gdmlldyBvYmplY3QgdG8gc2V0IHRoZSB6b29tIGxldmVsCisgKiBAcGFyYW0gc2NhbGVfZmFj dG9yIGEgbmV3IGxldmVsIHRvIHNldAorICogQHBhcmFtIGN4IHggb2YgY2VudGVyIGNvb3JkaW5h dGUKKyAqIEBwYXJhbSBjeSB5IG9mIGNlbnRlciBjb29yZGluYXRlCisgKgorICogQHJldHVybiBA YyBFSU5BX1RSVUUgb24gc3VjY2VzcyBvciBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZQorICovCitF aW5hX0Jvb2wgZXdrX3ZpZXdfc2NhbGVfc2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3LCBk b3VibGUgc2NhbGVGYWN0b3IsIGludCB4LCBpbnQgeSk7CisKKy8qKgorICogR2V0cyB0aGUgY3Vy cmVudCBzY2FsZSBmYWN0b3Igb2YgdGhlIHBhZ2UuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmpl Y3QgdG8gZ2V0IHRoZSBzY2FsZSBmYWN0b3IKKyAqCisgKiBAcmV0dXJuIGN1cnJlbnQgc2NhbGUg ZmFjdG9yIGluIHVzZSBvbiBzdWNjZXNzIG9yIEBjIC0xLjAgb24gZmFpbHVyZQorICovCitkb3Vi bGUgZXdrX3ZpZXdfc2NhbGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KTsKKworLyoq CiAgKiBRdWVyaWVzIHRoZSByYXRpbyBiZXR3ZWVuIHRoZSBDU1MgdW5pdHMgYW5kIGRldmljZSBw aXhlbHMgd2hlbiB0aGUgY29udGVudCBpcyB1bnNjYWxlZC4KICAqCiAgKiBXaGVuIGRlc2lnbmlu ZyB0b3VjaC1mcmllbmRseSBjb250ZW50cywga25vd2luZyB0aGUgYXBwcm94aW1hdGVkIHRhcmdl dCBzaXplIG9uIGEgZGV2aWNlCg== 155114 2012-07-27 23:29:19 -0700 2012-07-28 15:18:17 -0700 Patch bug-92446-20120728152904.patch text/plain 3445 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODE0NTU1ZWU2Y2Y3ODg0 MzUyYzkxNzNlZjI4ZjJmZGY5NGFjNTEzZC4uMjAxZWQ5ZDIzNWI2ZjdhOThlNmU1NTlhNmNiOWIz ZTc3MzczYmQ0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI3ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBld2tfdmlld19zY2FsZV97Z2V0fHNldH0gdG8gRXdrVmlldy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1ldGhvZHMgdG8gRXdrX1ZpZXcgdG8g Z2V0IG9yIHNldCB0aGUgc2NhbGUgZmFjdG9yIG9mIHBhZ2UuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19zY2FsZV9zZXQpOgor ICAgICAgICAoZXdrX3ZpZXdfc2NhbGVfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5oOgorCiAyMDEyLTA3LTI3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3Bo ZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBBc3NlcnRpb24gaGl0IGlu IGV3a19jb29raWVfbWFuYWdlci5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3LmNwcAppbmRleCBmZmMwYzkxMTc5MTk2YTRhMGE1MDkyZTExYjMzZjk1MDBl ZmFkMTVmLi5mZTNkN2U3MzBmYzg0MjI1MGUyZWJmOWQ1YzY0YzM4MzIxYzEzMjNhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC04ODQsNiAr ODg0LDIzIEBAIGRvdWJsZSBld2tfdmlld19sb2FkX3Byb2dyZXNzX2dldChjb25zdCBFdmFzX09i amVjdCogZXdrVmlldykKICAgICByZXR1cm4gcHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpLT5lc3Rp bWF0ZWRQcm9ncmVzcygpOwogfQogCitFaW5hX0Jvb2wgZXdrX3ZpZXdfc2NhbGVfc2V0KGNvbnN0 IEV2YXNfT2JqZWN0KiBld2tWaWV3LCBkb3VibGUgc2NhbGVGYWN0b3IsIGludCB4LCBpbnQgeSkK K3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgZmFs c2UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHByaXYsIGZh bHNlKTsKKworICAgIHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKS0+c2NhbGVQYWdlKHNjYWxlRmFj dG9yLCBJbnRQb2ludCh4LCB5KSk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKK2RvdWJsZSBld2tf dmlld19zY2FsZV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCit7CisgICAgRVdLX1ZJ RVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIC0xKTsKKyAgICBFV0tfVklF V19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2LCAtMSk7CisKKyAgICByZXR1cm4g cHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpLT5wYWdlU2NhbGVGYWN0b3IoKTsKK30KKwogRWluYV9C b29sIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcs IGZsb2F0IHJhdGlvKQogewogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywg c21hcnREYXRhLCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXcuaAppbmRleCA5MWViYjNmZDM2ZjMzNzliNGYzOWRhYjA1ODFiNzIyMjU5YzhmMWQ4Li45 NDQ4YjE0NmExNGQ0ZmUzN2RhZjI0NDUzMzEzM2Y1ZGM5NWUyZDhjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKQEAgLTM3OSw2ICszNzksMzAgQEAgRUFQ SSBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQoY29uc3QgRXZhc19PYmplY3QgKm8p OwogRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZChFdmFzX09iamVjdCAq bywgY29uc3QgY2hhciAqaHRtbCwgY29uc3QgY2hhciAqYmFzZVVybCwgY29uc3QgY2hhciAqdW5y ZWFjaGFibGVVcmwpOwogCiAvKioKKyAqIFNjYWxlcyB0aGUgY3VycmVudCBwYWdlLCBjZW50ZXJl ZCBhdCB0aGUgZ2l2ZW4gcG9pbnQuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gc2V0 IHRoZSB6b29tIGxldmVsCisgKiBAcGFyYW0gc2NhbGVfZmFjdG9yIGEgbmV3IGxldmVsIHRvIHNl dAorICogQHBhcmFtIGN4IHggb2YgY2VudGVyIGNvb3JkaW5hdGUKKyAqIEBwYXJhbSBjeSB5IG9m IGNlbnRlciBjb29yZGluYXRlCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2Vz cyBvciBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZQorICovCitFaW5hX0Jvb2wgZXdrX3ZpZXdfc2Nh bGVfc2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3LCBkb3VibGUgc2NhbGVGYWN0b3IsIGlu dCB4LCBpbnQgeSk7CisKKy8qKgorICogUXVlcmllcyB0aGUgY3VycmVudCBzY2FsZSBmYWN0b3Ig b2YgdGhlIHBhZ2UuCisgKgorICogSXQgcmV0dXJucyBwcmV2aW91cyBzY2FsZSBmYWN0b3IgYWZ0 ZXIgZXdrX3ZpZXdfc2NhbGVfc2V0IGlzIGNhbGxlZCBpbW1lZGlhdGVseQorICogdW50aWwgc2Nh bGUgZmFjdG9yIG9mIHBhZ2UgaXMgcmVhbGx5IGNoYW5nZWQuCisgKgorICogQHBhcmFtIG8gdmll dyBvYmplY3QgdG8gZ2V0IHRoZSBzY2FsZSBmYWN0b3IKKyAqCisgKiBAcmV0dXJuIGN1cnJlbnQg c2NhbGUgZmFjdG9yIGluIHVzZSBvbiBzdWNjZXNzIG9yIEBjIC0xLjAgb24gZmFpbHVyZQorICov Citkb3VibGUgZXdrX3ZpZXdfc2NhbGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KTsK KworLyoqCiAgKiBRdWVyaWVzIHRoZSByYXRpbyBiZXR3ZWVuIHRoZSBDU1MgdW5pdHMgYW5kIGRl dmljZSBwaXhlbHMgd2hlbiB0aGUgY29udGVudCBpcyB1bnNjYWxlZC4KICAqCiAgKiBXaGVuIGRl c2lnbmluZyB0b3VjaC1mcmllbmRseSBjb250ZW50cywga25vd2luZyB0aGUgYXBwcm94aW1hdGVk IHRhcmdldCBzaXplIG9uIGEgZGV2aWNlCg== 155144 2012-07-28 15:18:24 -0700 2012-07-28 16:28:33 -0700 Patch bug-92446-20120729071810.patch text/plain 3427 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzOTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWZjNWNkMmE4NmE5ZTU5 MTdmYzE5ZGQ4MjE5MzllNmM2ZGM1YTBlNy4uMzA3MWU3NjNlYjUzNzdlOGQyNDA5M2I0MjBmNWZk ZjY5OThhMzczMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTI4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFk ZCBld2tfdmlld19zY2FsZV97Z2V0fHNldH0gdG8gRXdrVmlldy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkyNDQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1ldGhvZHMgdG8gRXdrX1ZpZXcgdG8g Z2V0IG9yIHNldCB0aGUgc2NhbGUgZmFjdG9yIG9mIHBhZ2UuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld19zY2FsZV9zZXQpOgor ICAgICAgICAoZXdrX3ZpZXdfc2NhbGVfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5oOgorCiAyMDEyLTA3LTI4ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNo ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV0syXVtHVEtdIEltcGxlbWVudCBhIG5ldyBzcGVs bCBjaGVja2VyIEFQSSBmb3IgV2ViS2l0MkdUSysKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCBmZmMwYzkxMTc5MTk2YTRhMGE1MDkyZTExYjMz Zjk1MDBlZmFkMTVmLi5iMWIxYmNjMDg5ZTIyMTk1MDVlMTg3ZTFlOGE1YzMwYzA0NWQxMTM1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC04 ODQsNiArODg0LDIzIEBAIGRvdWJsZSBld2tfdmlld19sb2FkX3Byb2dyZXNzX2dldChjb25zdCBF dmFzX09iamVjdCogZXdrVmlldykKICAgICByZXR1cm4gcHJpdi0+cGFnZUNsaWVudC0+cGFnZSgp LT5lc3RpbWF0ZWRQcm9ncmVzcygpOwogfQogCitFaW5hX0Jvb2wgZXdrX3ZpZXdfc2NhbGVfc2V0 KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBkb3VibGUgc2NhbGVGYWN0b3IsIGludCB4LCBpbnQgeSkK K3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgZmFs c2UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHByaXYsIGZh bHNlKTsKKworICAgIHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKS0+c2NhbGVQYWdlKHNjYWxlRmFj dG9yLCBJbnRQb2ludCh4LCB5KSk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKK2RvdWJsZSBld2tf dmlld19zY2FsZV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCit7CisgICAgRVdLX1ZJ RVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIC0xKTsKKyAgICBFV0tfVklF V19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2LCAtMSk7CisKKyAgICByZXR1cm4g cHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpLT5wYWdlU2NhbGVGYWN0b3IoKTsKK30KKwogRWluYV9C b29sIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcs IGZsb2F0IHJhdGlvKQogewogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywg c21hcnREYXRhLCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXcuaAppbmRleCA5MWViYjNmZDM2ZjMzNzliNGYzOWRhYjA1ODFiNzIyMjU5YzhmMWQ4Li4w NTdmNzI1YmQyZmI1NDAxMzMzNTNmMjA2N2E1Yzc2MjhjODc1MmQ1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKQEAgLTM3OSw2ICszNzksMzAgQEAgRUFQ SSBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQoY29uc3QgRXZhc19PYmplY3QgKm8p OwogRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZChFdmFzX09iamVjdCAq bywgY29uc3QgY2hhciAqaHRtbCwgY29uc3QgY2hhciAqYmFzZVVybCwgY29uc3QgY2hhciAqdW5y ZWFjaGFibGVVcmwpOwogCiAvKioKKyAqIFNjYWxlcyB0aGUgY3VycmVudCBwYWdlLCBjZW50ZXJl ZCBhdCB0aGUgZ2l2ZW4gcG9pbnQuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gc2V0 IHRoZSB6b29tIGxldmVsCisgKiBAcGFyYW0gc2NhbGVfZmFjdG9yIGEgbmV3IGxldmVsIHRvIHNl dAorICogQHBhcmFtIGN4IHggb2YgY2VudGVyIGNvb3JkaW5hdGUKKyAqIEBwYXJhbSBjeSB5IG9m IGNlbnRlciBjb29yZGluYXRlCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2Vz cyBvciBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZQorICovCitFaW5hX0Jvb2wgZXdrX3ZpZXdfc2Nh bGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBkb3VibGUgc2NhbGVGYWN0b3IsIGludCB4LCBpbnQgeSk7 CisKKy8qKgorICogUXVlcmllcyB0aGUgY3VycmVudCBzY2FsZSBmYWN0b3Igb2YgdGhlIHBhZ2Uu CisgKgorICogSXQgcmV0dXJucyBwcmV2aW91cyBzY2FsZSBmYWN0b3IgYWZ0ZXIgZXdrX3ZpZXdf c2NhbGVfc2V0IGlzIGNhbGxlZCBpbW1lZGlhdGVseQorICogdW50aWwgc2NhbGUgZmFjdG9yIG9m IHBhZ2UgaXMgcmVhbGx5IGNoYW5nZWQuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8g Z2V0IHRoZSBzY2FsZSBmYWN0b3IKKyAqCisgKiBAcmV0dXJuIGN1cnJlbnQgc2NhbGUgZmFjdG9y IGluIHVzZSBvbiBzdWNjZXNzIG9yIEBjIC0xLjAgb24gZmFpbHVyZQorICovCitkb3VibGUgZXdr X3ZpZXdfc2NhbGVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpvKTsKKworLyoqCiAgKiBRdWVyaWVz IHRoZSByYXRpbyBiZXR3ZWVuIHRoZSBDU1MgdW5pdHMgYW5kIGRldmljZSBwaXhlbHMgd2hlbiB0 aGUgY29udGVudCBpcyB1bnNjYWxlZC4KICAqCiAgKiBXaGVuIGRlc2lnbmluZyB0b3VjaC1mcmll bmRseSBjb250ZW50cywga25vd2luZyB0aGUgYXBwcm94aW1hdGVkIHRhcmdldCBzaXplIG9uIGEg ZGV2aWNlCg==