92235 2012-07-25 03:38:04 -0700 [EFL][WK2] Keyboard events miss key location data. 2012-07-27 03:47:43 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 677870 0 mikhail.pozdnyakov 2012-07-25 03:38:04 -0700 EFL WK2 does not initialize WebKeyboardEvent::m_isKeypad field. This causes failure of fast/events/keydown-numpad-keys.html test. 677874 1 154314 mikhail.pozdnyakov 2012-07-25 03:45:48 -0700 Created attachment 154314 patch 677892 2 154314 cdumez 2012-07-25 04:06:08 -0700 Comment on attachment 154314 patch View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > Source/WebKit2/Shared/efl/WebEventFactory.cpp:47 > +static const char* keyPadPrefix = "KP_"; Please use: static const char keyPadPrefix[] = "KP_"; > Source/WebKit2/Shared/efl/WebEventFactory.cpp:163 > + const String& keyName = String(event->key); Why not use simply "String keyName(event->key);" ? > Source/WebKit2/Shared/efl/WebEventFactory.cpp:180 > + const String& keyName = String(event->key); ditto. 677897 3 154314 gyuyoung.kim 2012-07-25 04:12:32 -0700 Comment on attachment 154314 patch View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > Source/WebKit2/ChangeLog:9 > + This caused failure of fast/events/keydown-numpad-keys.html test. Don't you need to unskip this test ? 677898 4 mikhail.pozdnyakov 2012-07-25 04:13:53 -0700 (In reply to comment #3) > (From update of attachment 154314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > > > Source/WebKit2/ChangeLog:9 > > + This caused failure of fast/events/keydown-numpad-keys.html test. > > Don't you need to unskip this test ? It's already unskipped and works well for EFL WK1. 677905 5 154323 mikhail.pozdnyakov 2012-07-25 04:23:05 -0700 Created attachment 154323 patch v2 Thanks for review, Chris! 677907 6 154323 cdumez 2012-07-25 04:26:52 -0700 Comment on attachment 154323 patch v2 LGTM. Thanks. 677940 7 154323 gyuyoung.kim 2012-07-25 05:12:51 -0700 Comment on attachment 154323 patch v2 Looks fine. 680408 8 154323 webkit.review.bot 2012-07-27 03:47:38 -0700 Comment on attachment 154323 patch v2 Clearing flags on attachment: 154323 Committed r123860: <http://trac.webkit.org/changeset/123860> 680409 9 webkit.review.bot 2012-07-27 03:47:43 -0700 All reviewed patches have been landed. Closing bug. 154314 2012-07-25 03:45:48 -0700 2012-07-25 04:23:05 -0700 patch bug92235 text/plain 3474 mikhail.pozdnyakov Y29tbWl0IGJiZjhiMDNkYmI1YWQ4NWFjZTUwYjQ1NGE5NDNmZjljZjg1ODQwZDcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEp1bCAyNSAxMzo0NDowNyAyMDEyICswMzAwCgogICAgYnVnOTIyMzUKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggZGNkODdmNS4uYjJkMDU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTI1ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gS2V5Ym9hcmQgZXZlbnRzIG1pc3Mga2V5IGxvY2F0aW9uIGRh dGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjIz NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCBX SzIgZGlkIG5vdCBpbml0aWFsaXplIFdlYktleWJvYXJkRXZlbnQ6Om1faXNLZXlwYWQgZmllbGQu CisgICAgICAgIFRoaXMgY2F1c2VkIGZhaWx1cmUgb2YgZmFzdC9ldmVudHMva2V5ZG93bi1udW1w YWQta2V5cy5odG1sIHRlc3QuCisKKyAgICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9y eS5jcHA6IFdlYktleWJvYXJkRXZlbnQ6Om1faXNLZXlwYWQgaXMgaW5pdGlhbGl6ZWQuCisgICAg ICAgIChXZWJLaXQ6OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5Ym9hcmRFdmVudCk6CisK IDIwMTItMDctMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl0gQWRkIGV3a192aWV3X2N1cnNvcl9zZXQgdG8gY2hhbmdlIGN1cnNvci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcAppbmRleCBm ZmUyY2I1Li5jNDgxNGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZWZsL1dl YkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVu dEZhY3RvcnkuY3BwCkBAIC00NCw2ICs0NCw4IEBAIGVudW0gewogICAgIFJpZ2h0QnV0dG9uID0g MwogfTsKIAorc3RhdGljIGNvbnN0IGNoYXIqIGtleVBhZFByZWZpeCA9ICJLUF8iOworCiBzdGF0 aWMgaW5saW5lIFdlYkV2ZW50OjpNb2RpZmllcnMgbW9kaWZpZXJzRm9yRXZlbnQoY29uc3QgRXZh c19Nb2RpZmllciogbW9kaWZpZXJzKQogewogICAgIHVuc2lnbmVkIHJlc3VsdCA9IDA7CkBAIC0x NTgsNyArMTYwLDcgQEAgV2ViV2hlZWxFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldo ZWVsRXZlbnQoY29uc3QgRXZhc19FdmVudF9Nb3VzZV9XaGVlbCoKIAogV2ViS2V5Ym9hcmRFdmVu dCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJvYXJkRXZlbnQoY29uc3QgRXZhc19FdmVu dF9LZXlfRG93biogZXZlbnQpCiB7Ci0gICAgU3RyaW5nIGtleU5hbWUgPSBTdHJpbmcoZXZlbnQt PmtleSk7CisgICAgY29uc3QgU3RyaW5nJiBrZXlOYW1lID0gU3RyaW5nKGV2ZW50LT5rZXkpOwog ICAgIHJldHVybiBXZWJLZXlib2FyZEV2ZW50KFdlYkV2ZW50OjpLZXlEb3duLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjgoZXZlbnQtPnN0cmluZyksCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nOjpmcm9tVVRGOChldmVudC0+c3RyaW5nKSwK QEAgLTE2Nyw3ICsxNjksNyBAQCBXZWJLZXlib2FyZEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3Jl YXRlV2ViS2V5Ym9hcmRFdmVudChjb25zdCBFdmFzX0V2ZW50X0tleV9EbwogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDAgLyogRklYTUU6IG5hdGl2ZVZpcnR1YWxLZXlDb2RlICovLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDAgLyogbWFjQ2hhckNvZGUgKi8sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmFsc2UgLyogRklYTUU6IGlzQXV0b1JlcGVhdCAqLywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSAvKiBGSVhNRTogaXNLZXlwYWQgKi8sCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAga2V5TmFtZS5zdGFydHNXaXRoKGtleVBhZFByZWZpeCks CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyogaXNTeXN0ZW1LZXkgKi8sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbW9kaWZpZXJzRm9yRXZlbnQoZXZlbnQtPm1vZGlm aWVycyksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQtPnRpbWVzdGFtcCk7CkBA IC0xNzUsNyArMTc3LDcgQEAgV2ViS2V5Ym9hcmRFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0 ZVdlYktleWJvYXJkRXZlbnQoY29uc3QgRXZhc19FdmVudF9LZXlfRG8KIAogV2ViS2V5Ym9hcmRF dmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJvYXJkRXZlbnQoY29uc3QgRXZhc19F dmVudF9LZXlfVXAqIGV2ZW50KQogewotICAgIFN0cmluZyBrZXlOYW1lID0gU3RyaW5nKGV2ZW50 LT5rZXkpOworICAgIGNvbnN0IFN0cmluZyYga2V5TmFtZSA9IFN0cmluZyhldmVudC0+a2V5KTsK ICAgICByZXR1cm4gV2ViS2V5Ym9hcmRFdmVudChXZWJFdmVudDo6S2V5VXAsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgU3RyaW5nOjpmcm9tVVRGOChldmVudC0+c3RyaW5nKSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmc6OmZyb21VVEY4KGV2ZW50LT5zdHJpbmcpLApA QCAtMTg0LDcgKzE4Niw3IEBAIFdlYktleWJvYXJkRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVh dGVXZWJLZXlib2FyZEV2ZW50KGNvbnN0IEV2YXNfRXZlbnRfS2V5X1VwCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgMCAvKiBGSVhNRTogbmF0aXZlVmlydHVhbEtleUNvZGUgKi8sCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgMCAvKiBtYWNDaGFyQ29kZSAqLywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBmYWxzZSAvKiBGSVhNRTogaXNBdXRvUmVwZWF0ICovLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIEZJWE1FOiBpc0tleXBhZCAqLywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBrZXlOYW1lLnN0YXJ0c1dpdGgoa2V5UGFkUHJlZml4KSwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSAvKiBpc1N5c3RlbUtleSAqLywKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RpZmllcnNGb3JFdmVudChldmVudC0+bW9kaWZp ZXJzKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBldmVudC0+dGltZXN0YW1wKTsK 154323 2012-07-25 04:23:05 -0700 2012-07-27 03:47:38 -0700 patch v2 bug92235_v2 text/plain 3455 mikhail.pozdnyakov Y29tbWl0IGNlMmU0MTc3YTA3YjY0ZDZlMmU2YzBmZjU3ZDM5YTY1ZTNjYzdiZTkKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEp1bCAyNSAxMzo0NDowNyAyMDEyICswMzAwCgogICAgYnVnOTIyMzUKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggZGNkODdmNS4uYjJkMDU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTI1ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gS2V5Ym9hcmQgZXZlbnRzIG1pc3Mga2V5IGxvY2F0aW9uIGRh dGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjIz NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCBX SzIgZGlkIG5vdCBpbml0aWFsaXplIFdlYktleWJvYXJkRXZlbnQ6Om1faXNLZXlwYWQgZmllbGQu CisgICAgICAgIFRoaXMgY2F1c2VkIGZhaWx1cmUgb2YgZmFzdC9ldmVudHMva2V5ZG93bi1udW1w YWQta2V5cy5odG1sIHRlc3QuCisKKyAgICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9y eS5jcHA6IFdlYktleWJvYXJkRXZlbnQ6Om1faXNLZXlwYWQgaXMgaW5pdGlhbGl6ZWQuCisgICAg ICAgIChXZWJLaXQ6OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5Ym9hcmRFdmVudCk6CisK IDIwMTItMDctMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl0gQWRkIGV3a192aWV3X2N1cnNvcl9zZXQgdG8gY2hhbmdlIGN1cnNvci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcAppbmRleCBm ZmUyY2I1Li43NGEwNTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZWZsL1dl YkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVu dEZhY3RvcnkuY3BwCkBAIC00NCw2ICs0NCw4IEBAIGVudW0gewogICAgIFJpZ2h0QnV0dG9uID0g MwogfTsKIAorc3RhdGljIGNvbnN0IGNoYXIga2V5UGFkUHJlZml4W10gPSAiS1BfIjsKKwogc3Rh dGljIGlubGluZSBXZWJFdmVudDo6TW9kaWZpZXJzIG1vZGlmaWVyc0ZvckV2ZW50KGNvbnN0IEV2 YXNfTW9kaWZpZXIqIG1vZGlmaWVycykKIHsKICAgICB1bnNpZ25lZCByZXN1bHQgPSAwOwpAQCAt MTU4LDcgKzE2MCw3IEBAIFdlYldoZWVsRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJX aGVlbEV2ZW50KGNvbnN0IEV2YXNfRXZlbnRfTW91c2VfV2hlZWwqCiAKIFdlYktleWJvYXJkRXZl bnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJLZXlib2FyZEV2ZW50KGNvbnN0IEV2YXNfRXZl bnRfS2V5X0Rvd24qIGV2ZW50KQogewotICAgIFN0cmluZyBrZXlOYW1lID0gU3RyaW5nKGV2ZW50 LT5rZXkpOworICAgIGNvbnN0IFN0cmluZyBrZXlOYW1lKGV2ZW50LT5rZXkpOwogICAgIHJldHVy biBXZWJLZXlib2FyZEV2ZW50KFdlYkV2ZW50OjpLZXlEb3duLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjgoZXZlbnQtPnN0cmluZyksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgU3RyaW5nOjpmcm9tVVRGOChldmVudC0+c3RyaW5nKSwKQEAgLTE2Nyw3 ICsxNjksNyBAQCBXZWJLZXlib2FyZEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5 Ym9hcmRFdmVudChjb25zdCBFdmFzX0V2ZW50X0tleV9EbwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDAgLyogRklYTUU6IG5hdGl2ZVZpcnR1YWxLZXlDb2RlICovLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDAgLyogbWFjQ2hhckNvZGUgKi8sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZmFsc2UgLyogRklYTUU6IGlzQXV0b1JlcGVhdCAqLywKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICBmYWxzZSAvKiBGSVhNRTogaXNLZXlwYWQgKi8sCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAga2V5TmFtZS5zdGFydHNXaXRoKGtleVBhZFByZWZpeCksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyogaXNTeXN0ZW1LZXkgKi8sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbW9kaWZpZXJzRm9yRXZlbnQoZXZlbnQtPm1vZGlmaWVycyksCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZXZlbnQtPnRpbWVzdGFtcCk7CkBAIC0xNzUsNyAr MTc3LDcgQEAgV2ViS2V5Ym9hcmRFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJv YXJkRXZlbnQoY29uc3QgRXZhc19FdmVudF9LZXlfRG8KIAogV2ViS2V5Ym9hcmRFdmVudCBXZWJF dmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJvYXJkRXZlbnQoY29uc3QgRXZhc19FdmVudF9LZXlf VXAqIGV2ZW50KQogewotICAgIFN0cmluZyBrZXlOYW1lID0gU3RyaW5nKGV2ZW50LT5rZXkpOwor ICAgIGNvbnN0IFN0cmluZyBrZXlOYW1lKGV2ZW50LT5rZXkpOwogICAgIHJldHVybiBXZWJLZXli b2FyZEV2ZW50KFdlYkV2ZW50OjpLZXlVcCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBT dHJpbmc6OmZyb21VVEY4KGV2ZW50LT5zdHJpbmcpLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFN0cmluZzo6ZnJvbVVURjgoZXZlbnQtPnN0cmluZyksCkBAIC0xODQsNyArMTg2LDcgQEAg V2ViS2V5Ym9hcmRFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJvYXJkRXZlbnQo Y29uc3QgRXZhc19FdmVudF9LZXlfVXAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8q IEZJWE1FOiBuYXRpdmVWaXJ0dWFsS2V5Q29kZSAqLywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAwIC8qIG1hY0NoYXJDb2RlICovLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZh bHNlIC8qIEZJWE1FOiBpc0F1dG9SZXBlYXQgKi8sCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UgLyogRklYTUU6IGlzS2V5cGFkICovLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGtleU5hbWUuc3RhcnRzV2l0aChrZXlQYWRQcmVmaXgpLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZhbHNlIC8qIGlzU3lzdGVtS2V5ICovLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG1vZGlmaWVyc0ZvckV2ZW50KGV2ZW50LT5tb2RpZmllcnMpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGV2ZW50LT50aW1lc3RhbXApOwo=