92230 2012-07-25 01:34:39 -0700 [Forms] Move HTMLInputElement::updateInnerTextValue to InputType class 2012-07-25 18:01:26 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88970 1 yosin yosin mifenton tkent webkit.review.bot oldest_to_newest 677785 0 yosin 2012-07-25 01:34:39 -0700 To implement, multiple field time input UI, we need to tell TimeInputType about changing value. This can be done by making HTMLInputElement::updateInnerTextValue() to call InputType::updateInnerValue(). Here is list of call site of updateInnerTextValue() - DateInputValue::handleBlurEvent() - HTMLInputElement::copyNonAttributePropertiesFromElement() - HTMLInputElement::parseAttribute() -- for changing value via setAttribute() - HTMLInputElement::setSuggestedValue() - HTMLInputElement::updateType() - NumberInputType::handleBlurEvent() - TextFieldInputType::setValue() 677803 1 154295 yosin 2012-07-25 02:02:11 -0700 Created attachment 154295 Patch 1 677815 2 154295 yosin 2012-07-25 02:15:08 -0700 Comment on attachment 154295 Patch 1 Could you review this patch? Thanks in advance. 677833 3 154295 tkent 2012-07-25 02:31:27 -0700 Comment on attachment 154295 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=154295&action=review > Source/WebCore/html/HTMLInputElement.cpp:493 > void HTMLInputElement::updateInnerTextValue() > { Please remove HTMLInputElement::updateInnerTextValue(). > Source/WebCore/html/InputType.h:262 > + virtual void updateInnerValue() { } Do not define function body in a header for virtual functions. It wastes build time. > Source/WebCore/html/TextFieldInputType.cpp:453 > +void TextFieldInputType::updateInnerValue() The function name should be updateInnerTextValue() because of consistency with 'innerText' functions though I don't like this name. 677853 4 154309 yosin 2012-07-25 03:04:28 -0700 Created attachment 154309 Patch 1 677854 5 154309 yosin 2012-07-25 03:06:11 -0700 Comment on attachment 154309 Patch 1 Could you review this patch? Thanks in advance. = Changes since the last review = * Remove HTMLInputElement::updateInnerTextValue() * Update call sites of HTMLInputElement::updateInnerTextValue() * Use InputType::updateInnerTextValue() instead of updateInnerValue() 677896 6 154309 tkent 2012-07-25 04:12:26 -0700 Comment on attachment 154309 Patch 1 ok 678682 7 154309 yosin 2012-07-25 18:01:21 -0700 Comment on attachment 154309 Patch 1 Clearing flags on attachment: 154309 Committed r123687: <http://trac.webkit.org/changeset/123687> 678683 8 yosin 2012-07-25 18:01:26 -0700 All reviewed patches have been landed. Closing bug. 154295 2012-07-25 02:02:11 -0700 2012-07-25 03:04:24 -0700 Patch 1 bug-92230-20120725180201.patch text/plain 4578 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTEwMmJkMjc0ZDhlODZk ZjdiYzkwYzE0MTcyOWU1ZjFjZGZhZDNkYy4uNzIxYjYyYTMyYmQxZjQ5NzI5MmYxZTA1YjViYjVm ZDJhN2FlY2I2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA3LTI1ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNb3Zl IEhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZUlubmVyVGV4dFZhbHVlIHRvIElucHV0VHlwZSBjbGFz cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyMzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBh dGNoIG1vdmVzIGltcGxlbWVudGF0aW9uIG9mIEhUTUxJbnB1dEVsZW1lbnQ6OnVwcGRhdGVJbm5l clRleHRWYWx1ZSgpCisgICAgICAgIHRvIFRleHRGaWVsZElucHV0VHlwZTo6dXBkYXRlSW5uZXJW YWx1ZSgpIHRvIHRlbGwgdmFsdWUgY2hhbmdlIHRvCisgICAgICAgIGlucHV0IHR5cGUgaW1wbGVt ZW50YXRpb25zLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNo YW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojp1cGRhdGVJbm5lclRleHRWYWx1ZSk6 IENoYW5nZWQgdG8gY2FsbCBJbnB1dFR5cGU6OnVwZGF0ZUlubmVyVmFsdWUoKS4KKyAgICAgICAg KiBodG1sL0lucHV0VHlwZS5oOgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRUeXBlOjp1cGRhdGVJ bm5lclZhbHVlKTogQWRkZWQgZGVmYXVsdCBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgKiBodG1s L1RleHRGaWVsZElucHV0VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGRJbnB1 dFR5cGU6OnVwZGF0ZUlubmVyVmFsdWUpOiBNb3ZlZCBjb2RlIGZyb20gSFRNTElucHV0RWxlbWVu dC4KKyAgICAgICAgKiBodG1sL1RleHRGaWVsZElucHV0VHlwZS5oOgorICAgICAgICAoVGV4dEZp ZWxkSW5wdXRUeXBlKToKKwogMjAxMi0wNy0yNCAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBh bnkxMDAubmV0PgogCiAgICAgICAgIFJlYWQgdGFnIG5hbWVzIGFuZCBhdHRyaWJ1dGVzIGZyb20g dGhlIHNhdmVkIHRva2VucyB3aGVyZSBwb3NzaWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwCmluZGV4IDQwN2MxMjMzYjAxZThhODMyOGI1ODg3YmJiMjM4ODdhMWZm YTI2NTIuLmQ3ZGU1MWMxOTVlMzMxYWI4NjM3MjFlNzE4ZGRlN2MxOGE5MzlmMWIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNDkxLDE4ICs0OTEsNyBAQCB2 b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZVR5cGUoKQogCiB2b2lkIEhUTUxJbnB1dEVsZW1l bnQ6OnVwZGF0ZUlubmVyVGV4dFZhbHVlKCkKIHsKLSAgICBpZiAoIWlzVGV4dEZpZWxkKCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIGlmICghc3VnZ2VzdGVkVmFsdWUoKS5pc051bGwoKSkgewot ICAgICAgICBzZXRJbm5lclRleHRWYWx1ZShzdWdnZXN0ZWRWYWx1ZSgpKTsKLSAgICAgICAgdXBk YXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KGZhbHNlKTsKLSAgICB9IGVsc2UgaWYgKCFmb3JtQ29u dHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCkpIHsKLSAgICAgICAgLy8gVXBkYXRlIHRoZSByZW5k ZXJlciB2YWx1ZSBpZiB0aGUgZm9ybUNvbnRyb2xWYWx1ZU1hdGNoZXNSZW5kZXJlcigpIGZsYWcg aXMgZmFsc2UuCi0gICAgICAgIC8vIEl0IHByb3RlY3RzIGFuIHVuYWNjZXB0YWJsZSByZW5kZXJl ciB2YWx1ZSBmcm9tIGJlaW5nIG92ZXJ3cml0dGVuIHdpdGggdGhlIERPTSB2YWx1ZS4KLSAgICAg ICAgc2V0SW5uZXJUZXh0VmFsdWUodmlzaWJsZVZhbHVlKCkpOwotICAgICAgICB1cGRhdGVQbGFj ZWhvbGRlclZpc2liaWxpdHkoZmFsc2UpOwotICAgIH0KKyAgICBtX2lucHV0VHlwZS0+dXBkYXRl SW5uZXJWYWx1ZSgpOwogfQogCiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnN1YnRyZWVIYXNDaGFu Z2VkKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCmluZGV4IDM0ODE0OGIxMDcyOWEwM2JmNTUxYWU5 Y2IxOTMyOGM0NWU1NDAyZmIuLjBmNzE1M2E0NmQ0MTY4YjllNjQwZDUyNjhlNjI1ZjZjNTFiNTAy ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaApAQCAtMjU5LDYgKzI1OSw3IEBAIHB1YmxpYzoK ICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkUmVzZXRPbkRvY3VtZW50QWN0aXZhdGlvbigpOwogICAg IHZpcnR1YWwgYm9vbCBzaG91bGRSZXNwZWN0TGlzdEF0dHJpYnV0ZSgpOwogICAgIHZpcnR1YWwg Ym9vbCBzaG91bGRSZXNwZWN0U3BlZWNoQXR0cmlidXRlKCk7CisgICAgdmlydHVhbCB2b2lkIHVw ZGF0ZUlubmVyVmFsdWUoKSB7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNFbnVtZXJhdGFibGUoKTsK ICAgICB2aXJ0dWFsIGJvb2wgaXNDaGVja2FibGUoKTsKICAgICB2aXJ0dWFsIGJvb2wgaXNTdGVw cGFibGUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxk SW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNw cAppbmRleCAxMGVkOGZiMGE5ZjA4ZTljY2Y1MTQyNjRjNzhlYzdlYzcxZmMzODBlLi5jYzAyMWI0 ZmJkMzI5ZTE4OWVlYTg0M2M2NGJkZDFhNGQ0ZDhlNDBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCkBAIC00NTAsNSArNDUwLDE3IEBAIHZvaWQgVGV4dEZp ZWxkSW5wdXRUeXBlOjpzcGluQnV0dG9uU3RlcFVwKCkKICAgICBzdGVwVXBGcm9tUmVuZGVyZXIo MSk7CiB9CiAKK3ZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjp1cGRhdGVJbm5lclZhbHVlKCkKK3sK KyAgICBpZiAoIWVsZW1lbnQoKS0+c3VnZ2VzdGVkVmFsdWUoKS5pc051bGwoKSkgeworICAgICAg ICBlbGVtZW50KCktPnNldElubmVyVGV4dFZhbHVlKGVsZW1lbnQoKS0+c3VnZ2VzdGVkVmFsdWUo KSk7CisgICAgICAgIGVsZW1lbnQoKS0+dXBkYXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KGZhbHNl KTsKKyAgICB9IGVsc2UgaWYgKCFlbGVtZW50KCktPmZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVu ZGVyZXIoKSkgeworICAgICAgICAvLyBVcGRhdGUgdGhlIHJlbmRlcmVyIHZhbHVlIGlmIHRoZSBm b3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCkgZmxhZyBpcyBmYWxzZS4KKyAgICAgICAg Ly8gSXQgcHJvdGVjdHMgYW4gdW5hY2NlcHRhYmxlIHJlbmRlcmVyIHZhbHVlIGZyb20gYmVpbmcg b3ZlcndyaXR0ZW4gd2l0aCB0aGUgRE9NIHZhbHVlLgorICAgICAgICBlbGVtZW50KCktPnNldElu bmVyVGV4dFZhbHVlKHZpc2libGVWYWx1ZSgpKTsKKyAgICAgICAgZWxlbWVudCgpLT51cGRhdGVQ bGFjZWhvbGRlclZpc2liaWxpdHkoZmFsc2UpOworICAgIH0KK30KIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5 cGUuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmgKaW5kZXggNGM3 YTliYWM0MzRiZjY4NmIxNWVkOGJhMzc5ZjNmMTdiOWQwYzZhYS4uODEyNzAyZmEzOTQ4N2MyMmUy Y2RkYjExNGFkODY5YTI3N2UwYTc5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9U ZXh0RmllbGRJbnB1dFR5cGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElu cHV0VHlwZS5oCkBAIC04NCw2ICs4NCw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHVw ZGF0ZVBsYWNlaG9sZGVyVGV4dCgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgYm9vbCBhcHBlbmRG b3JtRGF0YShGb3JtRGF0YUxpc3QmLCBib29sIG11bHRpcGFydCkgY29uc3QgT1ZFUlJJREU7CiAg ICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCB1cGRh dGVJbm5lclZhbHVlKCkgT1ZFUlJJREU7CiAKICAgICAvLyBTcGluQnV0dG9uRWxlbWVudDo6U3Rl cEFjdGlvbkhhbmRsZXIgZnVuY3Rpb25zLgogICAgIHZpcnR1YWwgdm9pZCBzcGluQnV0dG9uU3Rl cERvd24oKSBPVkVSUklERTsK 154309 2012-07-25 03:04:28 -0700 2012-07-25 18:01:20 -0700 Patch 1 bug-92230-20120725190418.patch text/plain 9332 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y3NDRhZjQzYWRkNDQ2 ZjkyYzViNDcxNzIxMmQ5ZDAzYmFlYjQxZC4uMDk1NTQ1YmVlZGRkNTQ3NzliMjhlMDBlMTNhNTE0 YTlkMzM5ZWIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDEyLTA3LTI1ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBNb3Zl IEhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZUlubmVyVGV4dFZhbHVlIHRvIElucHV0VHlwZSBjbGFz cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyMzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBh dGNoIG1vdmVzIGltcGxlbWVudGFpb24gb2YgSFRNTElucHV0RWxlbWVudDo6dXBkYXRlSW5uZXJU ZXh0VmFsdWUoKQorICAgICAgICBpbnRvIGlucHV0IHR5cGUgY2xhc3NlcywgcmVtb3ZlcyB1cGRh dGVJbm5lclRleHRWYWx1ZSgpIGZyb20gSFRNTElucHV0RWxlbWVudCwKKyAgICAgICAgYW5kIHVw ZGF0ZXMgY2FsbCBzaXRlIG9mIHVwZGF0ZUlubmVyVGV4dFZhbHVlKCkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIGJlaGF2aW9yLgorCisgICAgICAg ICogaHRtbC9EYXRlSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVJbnB1dFR5 cGU6OmhhbmRsZUJsdXJFdmVudCk6IFVwZGF0ZWQgY2FsbCBzaXRlIG9mIHVwZGF0ZUlubmVyVGV4 dFZhbHVlKCkuCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnVwZGF0ZVR5cGUpOiBVcGRhdGVkIGNhbGwgc2l0 ZSBvZiB1cGRhdGVJbm5lclRleHRWYWx1ZSgpLgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0 RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUpOiBVcGRhdGVkIGNhbGwgc2l0ZSBvZiB1cGRhdGVJbm5l clRleHRWYWx1ZSgpLgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6Y29weU5v bkF0dHJpYnV0ZVByb3BlcnRpZXNGcm9tRWxlbWVudCk6IFVwZGF0ZWQgY2FsbCBzaXRlIG9mIHVw ZGF0ZUlubmVyVGV4dFZhbHVlKCkuCisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50 OjpzZXRTdWdnZXN0ZWRWYWx1ZSk6IFVwZGF0ZWQgY2FsbCBzaXRlIG9mIHVwZGF0ZUlubmVyVGV4 dFZhbHVlKCkuCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChI VE1MSW5wdXRFbGVtZW50KTogUmVtb3ZlZCB1cGRhdGVJbm5lclRleHRWYWx1ZSgpLgorICAgICAg ICAqIGh0bWwvSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0VHlwZTo6dXBk YXRlSW5uZXJUZXh0VmFsdWUpOiBBZGRlZCBkZWZhdWx0IGltcGxlbWVudGFpb24uCisgICAgICAg ICogaHRtbC9JbnB1dFR5cGUuaDoKKyAgICAgICAgKElucHV0VHlwZSk6IEFkZGVkIGRlY2xhcmF0 aW9uIG9mIHVwZGF0ZUlubmVyVGV4dFZhbHVlKCkuCisgICAgICAgICogaHRtbC9OdW1iZXJJbnB1 dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TnVtYmVySW5wdXRUeXBlOjpoYW5kbGVCbHVy RXZlbnQpOiBVcGRhdGVkIGNhbGwgc2l0ZSBvZiB1cGRhdGVJbm5lclRleHRWYWx1ZSgpLgorICAg ICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRl eHRGaWVsZElucHV0VHlwZTo6c2V0VmFsdWUpOiBVcGRhdGVkIGNhbGwgc2l0ZSBvZiB1cGRhdGVJ bm5lclRleHRWYWx1ZSgpLgorICAgICAgICAoV2ViQ29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjp1 cGRhdGVJbm5lclRleHRWYWx1ZSk6IE1vdmVkIGltcGxlbWVudGFpb24gZnJvbSBIVE1MSW5wdXRF bGVtZW50LgorICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmg6CisgICAgICAgIChU ZXh0RmllbGRJbnB1dFR5cGUpOiBBZGRlZCBkZWNsYXJhdGlvbiBvZiB1cGRhdGVJbm5lclRleHRW YWx1ZSgpLgorCiAyMDEyLTA3LTI1ICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgog CiAgICAgICAgIFtRdF1bV0syXSBEaXNhYmxlIENvcHlUb1RleHR1cmUgZm9yIEdyYXBoaWNzU3Vy ZmFjZU1hYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUlucHV0VHlwZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVJbnB1dFR5cGUuY3BwCmluZGV4IGY1ZDFhMDI5 M2I5ZDIyYjhkOGQ4MWY2Y2I0ODljYmI5NGJhOTgzYTIuLjk2MjA0NmE0MmUxMmI3NDc5MGI1Zjc3 YWNkZTc0Nzg4MDhjNmM3ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUlu cHV0VHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9EYXRlSW5wdXRUeXBlLmNwcApA QCAtMTQ0LDcgKzE0NCw3IEBAIHZvaWQgRGF0ZUlucHV0VHlwZTo6aGFuZGxlQmx1ckV2ZW50KCkK ICAgICBlbGVtZW50KCktPnNldEZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVuZGVyZXIoZmFsc2Up OwogICAgIC8vIFdlIG5lZWQgdG8gcmVzZXQgdGhlIHJlbmRlcmVyIHZhbHVlIGV4cGxpY2l0bHkg YmVjYXVzZSBhbiB1bmFjY2VwdGFibGUKICAgICAvLyByZW5kZXJlciB2YWx1ZSBzaG91bGQgYmUg cHVyZ2VkIGJlZm9yZSBzdHlsZSBjYWxjdWxhdGlvbi4KLSAgICBlbGVtZW50KCktPnVwZGF0ZUlu bmVyVGV4dFZhbHVlKCk7CisgICAgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKTsKIH0KIAogYm9vbCBE YXRlSW5wdXRUeXBlOjpzdXBwb3J0c1BsYWNlaG9sZGVyKCkgY29uc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDQwN2MxMjMzYjAxZThhODMyOGI1ODg3YmJi MjM4ODdhMWZmYTI2NTIuLjU5YzYyMDVhODAxYTRmYmMxZWRhYjIzMTVkMjQ3MjBjNTA1YWFhMjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNDU2LDcgKzQ1 Niw3IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6dXBkYXRlVHlwZSgpCiAgICAgICAgIHVwZGF0 ZVZhbHVlSWZOZWVkZWQoKTsKIAogICAgIHNldEZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVuZGVy ZXIoZmFsc2UpOwotICAgIHVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7CisgICAgbV9pbnB1dFR5cGUt PnVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7CiAKICAgICBtX3dhc01vZGlmaWVkQnlVc2VyID0gZmFs c2U7CiAKQEAgLTQ4OSwyMiArNDg5LDYgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50Ojp1cGRhdGVU eXBlKCkKICAgICBub3RpZnlGb3JtU3RhdGVDaGFuZ2VkKCk7CiB9CiAKLXZvaWQgSFRNTElucHV0 RWxlbWVudDo6dXBkYXRlSW5uZXJUZXh0VmFsdWUoKQotewotICAgIGlmICghaXNUZXh0RmllbGQo KSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKCFzdWdnZXN0ZWRWYWx1ZSgpLmlzTnVsbCgp KSB7Ci0gICAgICAgIHNldElubmVyVGV4dFZhbHVlKHN1Z2dlc3RlZFZhbHVlKCkpOwotICAgICAg ICB1cGRhdGVQbGFjZWhvbGRlclZpc2liaWxpdHkoZmFsc2UpOwotICAgIH0gZWxzZSBpZiAoIWZv cm1Db250cm9sVmFsdWVNYXRjaGVzUmVuZGVyZXIoKSkgewotICAgICAgICAvLyBVcGRhdGUgdGhl IHJlbmRlcmVyIHZhbHVlIGlmIHRoZSBmb3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRlcmVyKCkg ZmxhZyBpcyBmYWxzZS4KLSAgICAgICAgLy8gSXQgcHJvdGVjdHMgYW4gdW5hY2NlcHRhYmxlIHJl bmRlcmVyIHZhbHVlIGZyb20gYmVpbmcgb3ZlcndyaXR0ZW4gd2l0aCB0aGUgRE9NIHZhbHVlLgot ICAgICAgICBzZXRJbm5lclRleHRWYWx1ZSh2aXNpYmxlVmFsdWUoKSk7Ci0gICAgICAgIHVwZGF0 ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShmYWxzZSk7Ci0gICAgfQotfQotCiB2b2lkIEhUTUxJbnB1 dEVsZW1lbnQ6OnN1YnRyZWVIYXNDaGFuZ2VkKCkKIHsKICAgICBBU1NFUlQoaXNUZXh0RmllbGQo KSk7CkBAIC03MjcsNyArNzExLDcgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpwYXJzZUF0dHJp YnV0ZShjb25zdCBBdHRyaWJ1dGUmIGF0dHJpYnV0ZSkKICNlbmRpZgogICAgIGVsc2UKICAgICAg ICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGF0dHJpYnV0ZSk7 Ci0gICAgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKTsKKyAgICBtX2lucHV0VHlwZS0+dXBkYXRlSW5u ZXJUZXh0VmFsdWUoKTsKIH0KIAogdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpmaW5pc2hQYXJzaW5n Q2hpbGRyZW4oKQpAQCAtOTAyLDcgKzg4Niw3IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6Y29w eU5vbkF0dHJpYnV0ZVByb3BlcnRpZXNGcm9tRWxlbWVudChjb25zdCBFbGVtZW50JiBzb3VyCiAg ICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmNvcHlOb25BdHRyaWJ1dGVQcm9wZXJ0aWVz RnJvbUVsZW1lbnQoc291cmNlKTsKIAogICAgIHNldEZvcm1Db250cm9sVmFsdWVNYXRjaGVzUmVu ZGVyZXIoZmFsc2UpOwotICAgIHVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7CisgICAgbV9pbnB1dFR5 cGUtPnVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7CiB9CiAKIFN0cmluZyBIVE1MSW5wdXRFbGVtZW50 Ojp2YWx1ZSgpIGNvbnN0CkBAIC05NTAsNyArOTM0LDcgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50 OjpzZXRTdWdnZXN0ZWRWYWx1ZShjb25zdCBTdHJpbmcmIHZhbHVlKQogICAgIHNldEZvcm1Db250 cm9sVmFsdWVNYXRjaGVzUmVuZGVyZXIoZmFsc2UpOwogICAgIG1fc3VnZ2VzdGVkVmFsdWUgPSBz YW5pdGl6ZVZhbHVlKHZhbHVlKTsKICAgICBzZXROZWVkc1N0eWxlUmVjYWxjKCk7Ci0gICAgdXBk YXRlSW5uZXJUZXh0VmFsdWUoKTsKKyAgICBtX2lucHV0VHlwZS0+dXBkYXRlSW5uZXJUZXh0VmFs dWUoKTsKIH0KIAogdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpzZXRFZGl0aW5nVmFsdWUoY29uc3Qg U3RyaW5nJiB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXgg M2ZkNjZjOWU0YjFmZDNmY2IzYjk0MzEwM2U0NWIzZmRiMzkzZTViMS4uMDc3Njc5MWRkNDA3ZmRk M2QzZGRkYTEwMmNiMTdlYjk2MTUxY2U2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmgKQEAgLTE1Myw4ICsxNTMsNiBAQCBwdWJsaWM6CiAKICAgICBTdHJpbmcgbG9jYWxp emVWYWx1ZShjb25zdCBTdHJpbmcmKSBjb25zdDsKIAotICAgIHZvaWQgdXBkYXRlSW5uZXJUZXh0 VmFsdWUoKTsKLQogICAgIC8vIFRoZSB2YWx1ZSB3aGljaCBpcyBkcmF3biBieSBhIHJlbmRlcmVy LgogICAgIFN0cmluZyB2aXNpYmxlVmFsdWUoKSBjb25zdDsKICAgICBTdHJpbmcgY29udmVydEZy b21WaXNpYmxlVmFsdWUoY29uc3QgU3RyaW5nJikgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlw ZS5jcHAKaW5kZXggZDkwOTdjNGRlM2RmMmUwYjJiNjVkN2EzOGNhZjY0ZjMyMDJmYzQxYi4uZjVk OTYzMzFhZmM0MWQyZjQ5NGJjYzI5YzkzYzc3OWRhOWUwYjM2YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5w dXRUeXBlLmNwcApAQCAtODYzLDYgKzg2MywxMCBAQCBTdHJpbmcgSW5wdXRUeXBlOjpmaXhlZFBs YWNlaG9sZGVyKCkKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKK3ZvaWQgSW5wdXRUeXBlOjp1 cGRhdGVJbm5lclRleHRWYWx1ZSgpCit7Cit9CisKIHZvaWQgSW5wdXRUeXBlOjp1cGRhdGVQbGFj ZWhvbGRlclRleHQoKQogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1 dFR5cGUuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKaW5kZXggMzQ4MTQ4YjEw NzI5YTAzYmY1NTFhZTljYjE5MzI4YzQ1ZTU0MDJmYi4uYWUwZTY1Mzc5YjI3ZDljYWZhNTUxZDQ4 OGRiOTI4NzVkYjY3MmVjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5 cGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCkBAIC0yNzEsNiArMjcx LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c1BsYWNlaG9sZGVyKCkgY29u c3Q7CiAgICAgdmlydHVhbCBib29sIHVzZXNGaXhlZFBsYWNlaG9sZGVyKCkgY29uc3Q7CiAgICAg dmlydHVhbCBTdHJpbmcgZml4ZWRQbGFjZWhvbGRlcigpOworICAgIHZpcnR1YWwgdm9pZCB1cGRh dGVJbm5lclRleHRWYWx1ZSgpOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVQbGFjZWhvbGRlclRl eHQoKTsKICAgICB2aXJ0dWFsIHZvaWQgbXVsdGlwbGVBdHRyaWJ1dGVDaGFuZ2VkKCk7CiAgICAg dmlydHVhbCB2b2lkIGRpc2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9OdW1iZXJJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9OdW1iZXJJbnB1dFR5cGUuY3BwCmluZGV4IGViMTU3ZjEwYzJkN2ZjNTVlNzU3MzA0ZDM5NmJi N2FkODhlY2Y0NDguLjhiZWZmMjhhZmIyODNmOGJkZDEzNTc3ODBlYTk5ZDFjZTY5NzhmMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTnVtYmVySW5wdXRUeXBlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL051bWJlcklucHV0VHlwZS5jcHAKQEAgLTIyNCw3ICsyMjQsNyBA QCB2b2lkIE51bWJlcklucHV0VHlwZTo6aGFuZGxlQmx1ckV2ZW50KCkKIAogICAgIC8vIFdlIG5l ZWQgdG8gcmVzZXQgdGhlIHJlbmRlcmVyIHZhbHVlIGV4cGxpY2l0bHkgYmVjYXVzZSBhbiB1bmFj Y2VwdGFibGUKICAgICAvLyByZW5kZXJlciB2YWx1ZSBzaG91bGQgYmUgcHVyZ2VkIGJlZm9yZSBz dHlsZSBjYWxjdWxhdGlvbi4KLSAgICBlbGVtZW50KCktPnVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7 CisgICAgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKTsKIH0KIAogc3RhdGljIGJvb2wgaXNFKFVDaGFy IGNoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCmluZGV4IDEw ZWQ4ZmIwYTlmMDhlOWNjZjUxNDI2NGM3OGVjN2VjNzFmYzM4MGUuLmYxMTRlZWI1ZTI1ODhlNzAw NmEzMGJhZjZkNzI1MjE4MDM1YjAwZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv VGV4dEZpZWxkSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVs ZElucHV0VHlwZS5jcHAKQEAgLTEwMyw3ICsxMDMsNyBAQCB2b2lkIFRleHRGaWVsZElucHV0VHlw ZTo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiBzYW5pdGl6ZWRWYWx1ZSwgYm9vbCB2YWx1ZUNoYW5n ZQogICAgIElucHV0VHlwZTo6c2V0VmFsdWUoc2FuaXRpemVkVmFsdWUsIHZhbHVlQ2hhbmdlZCwg RGlzcGF0Y2hOb0V2ZW50KTsKIAogICAgIGlmICh2YWx1ZUNoYW5nZWQpCi0gICAgICAgIGlucHV0 LT51cGRhdGVJbm5lclRleHRWYWx1ZSgpOworICAgICAgICB1cGRhdGVJbm5lclRleHRWYWx1ZSgp OwogCiAgICAgdW5zaWduZWQgbWF4ID0gdmlzaWJsZVZhbHVlKCkubGVuZ3RoKCk7CiAgICAgaWYg KGlucHV0LT5mb2N1c2VkKCkpCkBAIC00NTAsNSArNDUwLDE3IEBAIHZvaWQgVGV4dEZpZWxkSW5w dXRUeXBlOjpzcGluQnV0dG9uU3RlcFVwKCkKICAgICBzdGVwVXBGcm9tUmVuZGVyZXIoMSk7CiB9 CiAKK3ZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjp1cGRhdGVJbm5lclRleHRWYWx1ZSgpCit7Cisg ICAgaWYgKCFlbGVtZW50KCktPnN1Z2dlc3RlZFZhbHVlKCkuaXNOdWxsKCkpIHsKKyAgICAgICAg ZWxlbWVudCgpLT5zZXRJbm5lclRleHRWYWx1ZShlbGVtZW50KCktPnN1Z2dlc3RlZFZhbHVlKCkp OworICAgICAgICBlbGVtZW50KCktPnVwZGF0ZVBsYWNlaG9sZGVyVmlzaWJpbGl0eShmYWxzZSk7 CisgICAgfSBlbHNlIGlmICghZWxlbWVudCgpLT5mb3JtQ29udHJvbFZhbHVlTWF0Y2hlc1JlbmRl cmVyKCkpIHsKKyAgICAgICAgLy8gVXBkYXRlIHRoZSByZW5kZXJlciB2YWx1ZSBpZiB0aGUgZm9y bUNvbnRyb2xWYWx1ZU1hdGNoZXNSZW5kZXJlcigpIGZsYWcgaXMgZmFsc2UuCisgICAgICAgIC8v IEl0IHByb3RlY3RzIGFuIHVuYWNjZXB0YWJsZSByZW5kZXJlciB2YWx1ZSBmcm9tIGJlaW5nIG92 ZXJ3cml0dGVuIHdpdGggdGhlIERPTSB2YWx1ZS4KKyAgICAgICAgZWxlbWVudCgpLT5zZXRJbm5l clRleHRWYWx1ZSh2aXNpYmxlVmFsdWUoKSk7CisgICAgICAgIGVsZW1lbnQoKS0+dXBkYXRlUGxh Y2Vob2xkZXJWaXNpYmlsaXR5KGZhbHNlKTsKKyAgICB9Cit9CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBl LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5oCmluZGV4IDRjN2E5 YmFjNDM0YmY2ODZiMTVlZDhiYTM3OWYzZjE3YjlkMGM2YWEuLmJlNmM2NjZlNGI5MWQyMDBhMWY1 ZTIwMTJkNWZmNDkyNDEzY2YyYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4 dEZpZWxkSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1 dFR5cGUuaApAQCAtNjYsNiArNjYsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGRp c2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCByZWFk b25seUF0dHJpYnV0ZUNoYW5nZWQoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxl Qmx1ckV2ZW50KCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUlubmVyVGV4dFZh bHVlKCkgT1ZFUlJJREU7CiAKIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzS2V5Ym9hcmRG b2N1c2FibGUoS2V5Ym9hcmRFdmVudCopIGNvbnN0IE9WRVJSSURFOwo=