9223 2006-06-01 17:17:11 -0700 Resize handles should be on the lower left corner for rtl 2023-05-07 09:44:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ All All RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 adele webkit-unassigned adele aharon ahmad.saleem792 ap dglazkov hbono hyatt ian karlcow leviw leviw mitz playmobil progame+wk rchandia rniwa simon.fraser webkit.review.bot xji zalan oldest_to_newest 44315 0 adele 2006-06-01 17:17:11 -0700 Consider adding the ability to resize the lower left corner for rtl textareas 44487 1 hyatt 2006-06-02 18:11:33 -0700 Should only do this if we also move the scrollers. Having the scrollers on the right but the resizer on the left would be pretty strange. 104778 2 playmobil 2009-01-07 13:57:12 -0800 http://code.google.com/p/chromium/issues/detail?id=6097 104782 3 playmobil 2009-01-07 14:11:16 -0800 Having the grabber on the right can lead to some pretty unintuitive behavior. e.g.: 1. open the attached test case. 2. Hold down the mouse button over the grabber of the rtl textarea and then move the mouse a little to the right of the grabber graphic. 2. Continue holding down the mouse button and move the mouse up and down vertically. What happens: * The grabber doesn't "stay under the mouse" like it does in ltr textareas so the act of moving the grabber up and down vertically causes the textarea to continue to grow *horizontally* in an unbounded manner. 104783 4 26508 playmobil 2009-01-07 14:11:55 -0800 Created attachment 26508 Test case 121252 5 progame+wk 2009-05-14 03:55:57 -0700 this is not only a mac issue of course 346699 6 playmobil 2011-02-07 11:46:59 -0800 *** Bug 53913 has been marked as a duplicate of this bug. *** 563322 7 rniwa 2012-02-23 11:52:29 -0800 This bug is independent of scrollbars. 563438 8 ojan 2012-02-23 13:54:39 -0800 (In reply to comment #7) > This bug is independent of scrollbars. I don't think it is. As per comment 1, which I think is correct. I think we should both move scrollbars and the resize handle. But we should *not* do one without the other. 563454 9 rniwa 2012-02-23 14:01:58 -0800 (In reply to comment #8) > (In reply to comment #7) > > This bug is independent of scrollbars. > > I don't think it is. As per comment 1, which I think is correct. I think we should both move scrollbars and the resize handle. But we should *not* do one without the other. That's a good point. This is a dup. of the bug 54623 then. 568305 10 hbono 2012-02-29 21:14:22 -0800 Greetings Jeremy, Even though my change for Bug 54623 moves a resizer to the left side, I wonder if it totally satisfies your request. (It does not change the bitmap used for a resizer and it may look weird for you. Also, does this Bug expect that an RTL resizer increases its size when we drag it to the left side?) Regards, Hironori Bono 568384 11 rniwa 2012-02-29 23:35:15 -0800 (In reply to comment #10) > Even though my change for Bug 54623 moves a resizer to the left side, I wonder if it totally satisfies your request. (It does not change the bitmap used for a resizer and it may look weird for you. Also, does this Bug expect that an RTL resizer increases its size when we drag it to the left side?) We should definitely mirror the image. I think we want it to resize to the left ideally. But I guess that's possible only if the containing block is RTL? 568481 12 hbono 2012-03-01 01:54:50 -0800 Greetings Niwa-san, Yes, they are possible. (We also need a Chromium change to add a bitmap resource, though.) I will upload a change and a resizer test when I land my change. (This was a reason why I did not add a resizer test to my change for Bug 54623.) Regards, Hironori Bono 568503 13 playmobil 2012-03-01 02:47:17 -0800 Bono-san: Can we mirror the resizer image using css? IMHO you can fix the left drag behavior in a followup patch... 568515 14 progame+wk 2012-03-01 03:18:34 -0800 if left drag is only possible when the containing block is RTL, would the re-sizer of an RTLed textarea work in a reasonable way if it's in an LTR block? (having the resize bitmap on the left and yet resize to the right) Because if not (if it would be just like resizing a textarea in an RTLed block right now- awkward) than should the resizer really move with the scrollbar and not be influenced solely by the containing block? 568804 15 rniwa 2012-03-01 11:58:46 -0800 (In reply to comment #14) > if left drag is only possible when the containing block is RTL, > would the re-sizer of an RTLed textarea work in a reasonable way if it's in an LTR block? (having the resize bitmap on the left and yet resize to the right) > > Because if not (if it would be just like resizing a textarea in an RTLed block right now- awkward) than should the resizer really move with the scrollbar and not be influenced solely by the containing block? That would be weird though. I've started to think that maybe we can place scrollbar on the left for RTL textareas only if the containing block is also RTL. 568806 16 rniwa 2012-03-01 12:01:34 -0800 In fact, maybe scrollbar should be placed on either side based on the direction of the containing block. 569220 17 hbono 2012-03-01 21:17:00 -0800 Greetings Jeremy, Thanks for your feedback. In brief, we can mirror a resizer image as CSS does. Nevertheless, it means we need to mirror a resizer image every time when we render it. Even though I have not measured the speed of mirroring a resizer image, it may hurt the rendering speed. Would it be possible to give me your preference: using CSS or using a mirrored image? Regards, Hironori Bono (In reply to comment #13) > Bono-san: Can we mirror the resizer image using css? 569569 18 playmobil 2012-03-02 04:59:45 -0800 I'm not sure how much weight my opinion has since I'm not a reviewer and have little knowledge of the likely performance characteristics. But IMHO we can try mirroring with css first and if we see a performance hit then a new resource can be added. Does that sound OK to everyone? 569743 19 ojan 2012-03-02 10:24:54 -0800 (In reply to comment #18) > I'm not sure how much weight my opinion has since I'm not a reviewer and have little knowledge of the likely performance characteristics. > > But IMHO we can try mirroring with css first and if we see a performance hit then a new resource can be added. > > Does that sound OK to everyone? Sounds fine to me. 570218 20 aharon 2012-03-04 01:11:49 -0800 Took a look at textarea resizing in Canary. Currently, resizing an RTL textarea is badly broken (besides the non-flipped image): - Dragging the bottom left corner to the left does not do anything. It should widen the textarea by the distance from the mouse to the left corner. - Dragging the bottom left corner to the right widens the textarea, crazily. It should not do anything. I think that the most important test case is: data:text/html,<html dir=rtl><textarea></textarea></html> It should work as the exact mirror image of: data:text/html,<html><textarea></textarea></html> Please check out how it works in FF, which has it correct. IMO, this is a severe regression and has to be fixed ASAP. Now, regarding an RTL textarea in an LTR div, i.e.: data:text/html,<html><textarea dir=rtl></textarea></html> It has been suggested above that in this case the resizer should be on the bottom right and widen the textarea when dragged to the right. It has also been suggested that generally the resizer location and action should depend on the directionality of the textarea's containing block, not the directionality of the textarea itself. And that the resizer and the scrollbar should always be on the same side, so that in the case above the textarea's scrollbar should also be on the right. Now, I agree that in the case above, the best UX would be to have the resizer on the bottom right, widening the textarea when dragged to the right. However, this has *nothing* to do with the directionality of either the textarea or its containing block. The exact same issue exists in the following three cases, *none* of which have any RTL in them: data:text/html,<div style="text-align:right"><textarea></textarea> *** </div> data:text/html,<div style="text-align:right"><div style="display:inline-block; text-align:left"><textarea></textarea> *** </div></div> data:text/html,<div style="float:right"><textarea></textarea> *** </div> If someone can figure how to handle these better than we do currently, that's fine. (BTW, please note that FF handles them more simply - and arguably better - than WebKit.) But it is not imperative to do so immediately. And the fix, although it will also improve the RTL textarea in LTR container (and LTR textarea in RTL container) case, has nothing to do with directionality. As for the resizer and the scrollbar having to be on the same side of the textarea, I completely disagree with that conclusion. Yes, ideally the resizer should be on the end side of the textarea, for the same reason that the scrollbar should be there. But having a reasonable UX for the resizer is much more important. If that means moving it to the start side of the textarea in certain cases, so be it. But I see absolutely no reason to move the scrollbar to the same side in those cases. Whatever we do, we should keep the scrollbar side interoperable with other browsers, which the recent fix to Bug 54623 finally achieved (for elements below body). 570541 21 130086 hbono 2012-03-05 02:43:20 -0800 Created attachment 130086 A quick fix v1 Greetings, Many thanks for your feedback. I have quickly implemented a change that mirrors a resizer image and its behavior. (This change is not so tricky as the one for Bug 54623.) Regards, Hironori Bono 570554 22 130086 webkit.review.bot 2012-03-05 03:33:23 -0800 Comment on attachment 130086 A quick fix v1 Attachment 130086 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11803942 New failing tests: platform/chromium/scrollbers/drag-rtl-resizer.html 570906 23 130086 tony 2012-03-05 11:50:50 -0800 Comment on attachment 130086 A quick fix v1 This seems fine. Is the test failing because RTL_SCROLLBAR isn't defined? Please fix the test before landing. Aharon makes a lot of good points in comment #20, but we should file a new bug for those issues. 571715 24 130351 hbono 2012-03-06 04:15:42 -0800 Created attachment 130351 A quick fix v2 (fixed the layout test) Greetings Tony, Thanks for your review and comment. Sorry, this test failure is totally my fault. The previous test does not work well on Chromium DumpRenderTree due to a variable-name conflict: this uses a variable 'top', which causes a conflict with 'window.top'. (I have tested my previous test only on Safari DumpRenderTree with WTF_USE_RTL_SCROLLBAR enabled.) I have updated the layout test. (It should work well with Chromium DumpRenderTree.) Regards, Hironori Bono (In reply to comment #23) > (From update of attachment 130086 [details]) > This seems fine. Is the test failing because RTL_SCROLLBAR isn't defined? Please fix the test before landing. > > Aharon makes a lot of good points in comment #20, but we should file a new bug for those issues. 571945 25 130351 tony 2012-03-06 10:14:27 -0800 Comment on attachment 130351 A quick fix v2 (fixed the layout test) View in context: https://bugs.webkit.org/attachment.cgi?id=130351&action=review > LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:13 > +<div id="console"> > +</div> Nit: The console div now gets created lazily so you don't need this. > LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:33 > +if (window.layoutTestController) > + layoutTestController.dumpAsText(); Nit: You can remove these, the test harness does this automatically. > LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:46 > +var successfullyParsed = true; Nit: You don't need this anymore. It shouldn't change the output. 572691 26 130567 hbono 2012-03-07 01:30:13 -0800 Created attachment 130567 A quick fix v3 (Applied comments, for landing) 572692 27 130351 hbono 2012-03-07 01:32:03 -0800 Comment on attachment 130351 A quick fix v2 (fixed the layout test) View in context: https://bugs.webkit.org/attachment.cgi?id=130351&action=review >> LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:13 >> +</div> > > Nit: The console div now gets created lazily so you don't need this. Done. Thanks for point it out. >> LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:33 >> + layoutTestController.dumpAsText(); > > Nit: You can remove these, the test harness does this automatically. Done. Thanks for point it out. (I did not notice it.) >> LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html:46 >> +var successfullyParsed = true; > > Nit: You don't need this anymore. It shouldn't change the output. Done. 573026 28 130567 webkit.review.bot 2012-03-07 11:08:18 -0800 Comment on attachment 130567 A quick fix v3 (Applied comments, for landing) Clearing flags on attachment: 130567 Committed r110073: <http://trac.webkit.org/changeset/110073> 573027 29 webkit.review.bot 2012-03-07 11:08:25 -0800 All reviewed patches have been landed. Closing bug. 574173 30 aharon 2012-03-08 14:03:40 -0800 Looks good in Chrome Canary. 574190 31 playmobil 2012-03-08 14:14:37 -0800 Very nice work!!! There is still a small visual glitch on the Mac - filed as bug 80640. 574586 32 ap 2012-03-08 21:20:50 -0800 Why was this marked resolved? It's exceedingly obvious that this bug requests a Safari fix, not a Chrome one. 574602 33 hbono 2012-03-08 21:40:38 -0800 Greetings, Sorry for closing this issue without fixing it on Safari. I made this change Chromium-only just because Dave wrote "I also don't believe we want this change on Mac OS X..." at <http://webkit.org/b/54623#c12>. Even though I may misunderstand his comment, I thought Safari did not need to move scrollbars or resizers. (This change moves scrollbars and resizers only when WTF_USE_RTL_SCROLLBAR is 1. This flag is set only on Chromium.) Regardless whether Safari needs to move scrollbars and resizers, we should have kept this issue open until Safari does move them as you noted. Regards, Hironori Bono (In reply to comment #32) > Why was this marked resolved? It's exceedingly obvious that this bug requests a Safari fix, not a Chrome one. 589174 34 130086 eric 2012-03-27 12:51:25 -0700 Comment on attachment 130086 A quick fix v1 Cleared Tony Chang's review+ from obsolete attachment 130086 so that this bug does not appear in http://webkit.org/pending-commit. 589175 35 130351 eric 2012-03-27 12:51:30 -0700 Comment on attachment 130351 A quick fix v2 (fixed the layout test) Cleared Tony Chang's review+ from obsolete attachment 130351 so that this bug does not appear in http://webkit.org/pending-commit. 1953481 36 ahmad.saleem792 2023-05-07 00:01:54 -0700 Attached test case does not show any 'grabber' cursor on Safari Technology Preview 169 & WebKit ToT (263769@main) while it does show for Chrome Canary 115. 1953513 37 zalan 2023-05-07 09:44:08 -0700 "Resize handles should be on the lower left corner for rtl" <- Safari on macOS places resize control at the lower left for rtl text area. 26508 2009-01-07 14:11:55 -0800 2009-01-07 14:11:55 -0800 Test case form.html text/html 505 playmobil PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPiANCjxodG1sPiANCgk8aGVhZD4gDQoJPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1U eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiIC8+IA0KCQk8dGl0bGU+Z3Jh YmJlciB0ZXN0PC90aXRsZT4gDQoJPC9oZWFkPiANCgk8Ym9keT4gDQoJPGgxPmdyYWJiZXIgdGVz dDwvaDE+IA0KCTxmb3JtIGFjdGlvbj0iIyI+IA0KCTxwIGRpcj0icnRsIj4JPHRleHRhcmVhIGRp cj0icnRsIiBjb2xzPSIzMCI+UlRMIHRleHQgYXJlYTwvdGV4dGFyZWE+IA0KPC9wPiANCjxwIGRp cj0ibHRyIj4JPHRleHRhcmVhIGRpcj0ibHRyIiBjb2xzPSIzMCI+bHRyIHRleHQgYXJlYTwvdGV4 dGFyZWE+IA0KPC9wPiANCgkNCgk8L2Zvcm0+IA0KCTwvYm9keT4gDQo8L2h0bWw+IA== 130086 2012-03-05 02:43:20 -0800 2012-03-27 12:51:25 -0700 A quick fix v1 issue9223-patch0.txt text/plain 7629 hbono SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTcyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTA1ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTWlycm9y IHRoZSByZXNpemVyIGltYWdlIG9mIGFuIFJUTCBlbGVtZW50IHdoZW4gV1RGX1VTRV9SVExfU0NS T0xMQkFSIGlzIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNoYW5nZSBtaXJyb3JzIGEgcmVzaXplciBpbWFnZSBvZiBhbiBSVEwgZWxlbWVudCBo b3Jpem9udGFsbCBhcyBGaXJlZm94CisgICAgICAgIGRvZXMuIFRoaXMgY2hhbmdlIGFsc28gbWly cm9ycyBpdHMgZHJhZ2dpbmcgYmVoYXZpb3IsIGkuZS4gZHJhZ2luZyB0aGUgcmVzaXplcgorICAg ICAgICBvZiBhbiBSVEwgZWxlbWVudCB0byB0aGUgbGVmdCBzaWRlIGluY3JlYXNlcyBpdHMgd2lk dGguIChUaGlzIGZlYXR1cmUgaXMgZW5hYmxlZAorICAgICAgICBvbmx5IHdoZW4gV1RGX1VTRV9S VExfU0NST0xMQkFSIGlzIDEuKQorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL2Nocm9taXVtL3Nj cm9sbGJlcnMvZHJhZy1ydGwtcmVzaXplci5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnJlc2l6ZSk6IE1p cnJvcmVkIHRoZSB4IGNvb3JkaW5hdGUgb2YgbW91c2UgcG9zaXRpb25zCisgICAgICAgIHdoZW4g bWlycm9yaW5nIGEgcmVzaXplci4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpvZmZz ZXRGcm9tUmVzaXplQ29ybmVyKTogUmV0dXJuZWQgdGhlIG9mZnNldCBmcm9tIHRoZQorICAgICAg ICBib3R0b20tbGVmdCBjb3JuZXIgd2hlbiByZW5kZXJpbmcgYSByZXNpemVyIHRoZXJlLgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmRyYXdQbGF0Zm9ybVJlc2l6ZXJJbWFnZSk6IE1p cnJvcmVkIHRoZSByZXNpemVyIGJpdG1hcAorICAgICAgICBob3Jpem9udGFsbHkgd2hlbiByZW5k ZXJpbmcgYSByZXNpemVyIHRvIHRoZSBib3R0b20tbGVmdCBjb3JuZXIuCisKIDIwMTItMDMtMDIg IEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgaW5z dHJ1bWVudGF0aW9uIGZvciBmcmFtZSBzdGFydC9lbmQgb24gdGltZWxpbmUuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDEwOTcwMykKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE3MzgsNiArMTczOCwxMCBAQCB2b2lkIFJlbmRlckxheWVyOjpyZXNpemUoY29uc3QgUGxh dGZvcm1NCiAgICAgZWxlbWVudC0+c2V0TWluaW11bVNpemVGb3JSZXNpemluZyhtaW5pbXVtU2l6 ZSk7CiAgICAgCiAgICAgTGF5b3V0U2l6ZSBhZGp1c3RlZE9sZE9mZnNldCA9IExheW91dFNpemUo b2xkT2Zmc2V0LndpZHRoKCkgLyB6b29tRmFjdG9yLCBvbGRPZmZzZXQuaGVpZ2h0KCkgLyB6b29t RmFjdG9yKTsKKyAgICBpZiAocmVuZGVyZXItPnN0eWxlKCktPnNob3VsZFBsYWNlQmxvY2tEaXJl Y3Rpb25TY3JvbGxiYXJPbkxvZ2ljYWxMZWZ0KCkpIHsKKyAgICAgICAgbmV3T2Zmc2V0LnNldFdp ZHRoKC1uZXdPZmZzZXQud2lkdGgoKSk7CisgICAgICAgIGFkanVzdGVkT2xkT2Zmc2V0LnNldFdp ZHRoKC1hZGp1c3RlZE9sZE9mZnNldC53aWR0aCgpKTsKKyAgICB9CiAgICAgCiAgICAgTGF5b3V0 U2l6ZSBkaWZmZXJlbmNlID0gKGN1cnJlbnRTaXplICsgbmV3T2Zmc2V0IC0gYWRqdXN0ZWRPbGRP ZmZzZXQpLmV4cGFuZGVkVG8obWluaW11bVNpemUpIC0gY3VycmVudFNpemU7CiAKQEAgLTIxNzQs MTEgKzIxNzgsMTQgQEAgaW50IFJlbmRlckxheWVyOjpob3Jpem9udGFsU2Nyb2xsYmFySGVpZwog CiBJbnRTaXplIFJlbmRlckxheWVyOjpvZmZzZXRGcm9tUmVzaXplQ29ybmVyKGNvbnN0IEludFBv aW50JiBhYnNvbHV0ZVBvaW50KSBjb25zdAogewotICAgIC8vIEN1cnJlbnRseSB0aGUgcmVzaXpl IGNvcm5lciBpcyBhbHdheXMgdGhlIGJvdHRvbSByaWdodCBjb3JuZXIKKyAgICAvLyBDdXJyZW50 bHkgdGhlIHJlc2l6ZSBjb3JuZXIgaXMgZWl0aGVyIHRoZSBib3R0b20gcmlnaHQgY29ybmVyIG9y IHRoZSBib3R0b20gbGVmdCBjb3JuZXIuCiAgICAgLy8gRklYTUU6IFRoaXMgYXNzdW1lcyB0aGUg bG9jYXRpb24gaXMgMCwgMC4gSXMgdGhpcyBndWFyYW50ZWVkIHRvIGFsd2F5cyBiZSB0aGUgY2Fz ZT8KLSAgICBJbnRQb2ludCBib3R0b21SaWdodCA9IHRvUG9pbnQoc2l6ZSgpKTsKKyAgICBJbnRT aXplIGVsZW1lbnRTaXplID0gc2l6ZSgpOworICAgIGlmIChyZW5kZXJlcigpLT5zdHlsZSgpLT5z aG91bGRQbGFjZUJsb2NrRGlyZWN0aW9uU2Nyb2xsYmFyT25Mb2dpY2FsTGVmdCgpKQorICAgICAg ICBlbGVtZW50U2l6ZS5zZXRXaWR0aCgwKTsKKyAgICBJbnRQb2ludCByZXNpemVyUG9pbnQgPSB0 b1BvaW50KGVsZW1lbnRTaXplKTsKICAgICBJbnRQb2ludCBsb2NhbFBvaW50ID0gcm91bmRlZElu dFBvaW50KGFic29sdXRlVG9Db250ZW50cyhhYnNvbHV0ZVBvaW50KSk7Ci0gICAgcmV0dXJuIGxv Y2FsUG9pbnQgLSBib3R0b21SaWdodDsKKyAgICByZXR1cm4gbG9jYWxQb2ludCAtIHJlc2l6ZXJQ b2ludDsKIH0KIAogYm9vbCBSZW5kZXJMYXllcjo6aGFzT3ZlcmZsb3dDb250cm9scygpIGNvbnN0 CkBAIC0yNTE2LDYgKzI1MjMsMTYgQEAgdm9pZCBSZW5kZXJMYXllcjo6ZHJhd1BsYXRmb3JtUmVz aXplckltYQogICAgIH0KIAogICAgIEludFJlY3QgaW1hZ2VSZWN0KHJlc2l6ZXJDb3JuZXJSZWN0 Lm1heFhNYXhZQ29ybmVyKCkgLSBjb3JuZXJSZXNpemVyU2l6ZSwgY29ybmVyUmVzaXplclNpemUp OworICAgIGlmIChyZW5kZXJlcigpLT5zdHlsZSgpLT5zaG91bGRQbGFjZUJsb2NrRGlyZWN0aW9u U2Nyb2xsYmFyT25Mb2dpY2FsTGVmdCgpKSB7CisgICAgICAgIGNvbnRleHQtPnNhdmUoKTsKKyAg ICAgICAgY29udGV4dC0+dHJhbnNsYXRlKGltYWdlUmVjdC54KCksIGltYWdlUmVjdC55KCkpOwor ICAgICAgICBpbWFnZVJlY3Quc2V0WCgwKTsKKyAgICAgICAgaW1hZ2VSZWN0LnNldFkoMCk7Cisg ICAgICAgIGNvbnRleHQtPnNjYWxlKEZsb2F0U2l6ZSgtMS4wLCAxLjApKTsKKyAgICAgICAgY29u dGV4dC0+ZHJhd0ltYWdlKHJlc2l6ZUNvcm5lckltYWdlLmdldCgpLCByZW5kZXJlcigpLT5zdHls ZSgpLT5jb2xvclNwYWNlKCksIGltYWdlUmVjdCk7CisgICAgICAgIGNvbnRleHQtPnJlc3RvcmUo KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICBjb250ZXh0LT5kcmF3SW1hZ2UocmVzaXpl Q29ybmVySW1hZ2UuZ2V0KCksIHJlbmRlcmVyKCktPnN0eWxlKCktPmNvbG9yU3BhY2UoKSwgaW1h Z2VSZWN0KTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTA5NzI2KQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDMtMDUgIEhp cm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBN aXJyb3IgdGhlIHJlc2l6ZXIgaW1hZ2Ugb2YgYW4gUlRMIGVsZW1lbnQgd2hlbiBXVEZfVVNFX1JU TF9TQ1JPTExCQVIgaXMgMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTIyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgY2hhbmdlIG1pcnJvcnMgYSByZXNpemVyIGltYWdlIG9mIGFuIFJUTCBlbGVt ZW50IGhvcml6b250YWxsIGFzIEZpcmVmb3gKKyAgICAgICAgZG9lcy4gVGhpcyBjaGFuZ2UgYWxz byBtaXJyb3JzIGl0cyBkcmFnZ2luZyBiZWhhdmlvciwgaS5lLiBkcmFnaW5nIHRoZSByZXNpemVy CisgICAgICAgIG9mIGFuIFJUTCBlbGVtZW50IHRvIHRoZSBsZWZ0IHNpZGUgaW5jcmVhc2VzIGl0 cyB3aWR0aC4gKFRoaXMgZmVhdHVyZSBpcyBlbmFibGVkCisgICAgICAgIG9ubHkgd2hlbiBXVEZf VVNFX1JUTF9TQ1JPTExCQVIgaXMgMS4pCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9z Y3JvbGxiZXJzOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9zY3JvbGxiZXJz L2RyYWctcnRsLXJlc2l6ZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS9zY3JvbGxiZXJzL2RyYWctcnRsLXJlc2l6ZXIuaHRtbDogQWRkZWQuCisKIDIw MTItMDMtMDUgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIGdhcmRlbmluZywgc2tpcCBhIG5ldyBmYWlsaW5nIHRlc3QuCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9zY3JvbGxiZXJzL2RyYWctcnRsLXJlc2l6ZXIt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L3Njcm9sbGJlcnMvZHJhZy1ydGwtcmVzaXplci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9zY3JvbGxiZXJzL2RyYWctcnRsLXJlc2l6 ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACitUZXN0IHRoYXQg YW4gUlRMIGVsZW1lbnQgcmVuZGVycyBhIHJlc2l6ZXIgdG8gaXRzIGJvdHRvbS1sZWZ0IGNvcm5l ciBhbmQgZHJhZ2dpbmcgdGhpcyByZXNpemVyIHRvIHRoZSBsZWZ0IGNoYW5nZXMgaXRzIHdpZHRo LiBUbyB0ZXN0IG1hbnVhbGx5LCBkcmFnZ2luZyB0aGUgcmVzaXplciBvZiB0aGUgYmVsb3cgZWxl bWVudCB0byBsZWZ0LCBhbmQgc2VlIHRoaXMgZWxlbWVudCBpbmNyZWFzZXMgaXRzIHdpZHRoLgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworCitQQVNTIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdvdmVyZmxvdycpLm9mZnNldFdpZHRoID4gb2Zmc2V0V2lkdGggaXMgdHJ1ZQorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJlcnMvZHJhZy1ydGwtcmVzaXplci5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJl cnMvZHJhZy1ydGwtcmVzaXplci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vc2Nyb2xsYmVycy9kcmFnLXJ0bC1yZXNpemVyLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNTAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzx0 aXRsZT5CdWcgOTIyMzwvdGl0bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgZGlyPSJydGwi IHN0eWxlPSJtYXJnaW46MHB4Ij4KKzxkaXYgaWQ9Im92ZXJmbG93IiBkaXI9InJ0bCIgc3R5bGU9 ImJvcmRlcjoycHggc29saWQgYmxhY2s7IG92ZXJmbG93OmF1dG87IHdpZHRoOiA0MDBweDsgaGVp Z2h0OiA0MDBweDsgcmVzaXplOmJvdGg7Ij4KKzxkaXYgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6 cmVkO2hlaWdodDo3MjBweCI+PC9kaXY+Cis8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOmdy ZWVuO2hlaWdodDoxNjAwcHgiPjwvZGl2PgorPC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj4KKzwv ZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0IHRoYXQgYW4gUlRMIGVsZW1lbnQgcmVu ZGVycyBhIHJlc2l6ZXIgdG8gaXRzIGJvdHRvbS1sZWZ0IGNvcm5lciBhbmQgJyArCisgICAgICAg ICAgICAnZHJhZ2dpbmcgdGhpcyByZXNpemVyIHRvIHRoZSBsZWZ0IGNoYW5nZXMgaXRzIHdpZHRo LiAnICsKKyAgICAgICAgICAgICdUbyB0ZXN0IG1hbnVhbGx5LCBkcmFnZ2luZyB0aGUgcmVzaXpl ciBvZiB0aGUgYmVsb3cgZWxlbWVudCB0byBsZWZ0LCBhbmQgJyArCisgICAgICAgICAgICAnc2Vl IHRoaXMgZWxlbWVudCBpbmNyZWFzZXMgaXRzIHdpZHRoLicpOworCisvLyBUaGlzIHRlc3QgbXVz dCBiZSBhc3luYyBvbmUgYmVjYXVzZSBpdCBuZWVkcyB0byB3YWl0IGZvciBXZWJLaXQgdG8gZmlu aXNoIHJlLWxheW91dGluZyBlbGVtZW50cworLy8gYWZ0ZXIgc2VuZGluZyBtb3VzZSBldmVudHMu Citqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworZnVuY3Rpb24gZmluaXNoZWQoKQoreworICAgIHNo b3VsZEJlVHJ1ZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoXCdvdmVyZmxvd1wnKS5vZmZzZXRX aWR0aCA+IG9mZnNldFdpZHRoJyk7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK3ZhciBvZmZz ZXRXaWR0aCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdmVyZmxvdycpLm9mZnNldFdpZHRo OworCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKKworaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgIHZh ciBub2RlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ292ZXJmbG93Jyk7CisgICAgdmFyIGxl ZnQgPSBub2RlLm9mZnNldExlZnQgKyA1OworICAgIHZhciB0b3AgPSBub2RlLm9mZnNldFRvcCAr IG5vZGUub2Zmc2V0SGVpZ2h0IC0gNTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhsZWZ0 LCB0b3ApOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1v dXNlTW92ZVRvKGxlZnQgLSAzMCwgdG9wKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cisg ICAgc2V0VGltZW91dChmaW5pc2hlZCwgMCk7Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 130351 2012-03-06 04:15:42 -0800 2012-03-27 12:51:30 -0700 A quick fix v2 (fixed the layout test) issue9223-patch1.txt text/plain 7614 hbono SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwOTg4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTA2ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTWlycm9y IHRoZSByZXNpemVyIGltYWdlIG9mIGFuIFJUTCBlbGVtZW50IHdoZW4gV1RGX1VTRV9SVExfU0NS T0xMQkFSIGlzIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNoYW5nZSBtaXJyb3JzIGEgcmVzaXplciBpbWFnZSBvZiBhbiBSVEwgZWxlbWVudCBo b3Jpem9udGFsbCBhcyBGaXJlZm94CisgICAgICAgIGRvZXMuIFRoaXMgY2hhbmdlIGFsc28gbWly cm9ycyBpdHMgZHJhZ2dpbmcgYmVoYXZpb3IsIGkuZS4gZHJhZ2luZyB0aGUgcmVzaXplcgorICAg ICAgICBvZiBhbiBSVEwgZWxlbWVudCB0byB0aGUgbGVmdCBzaWRlIGluY3JlYXNlcyBpdHMgd2lk dGguIChUaGlzIGZlYXR1cmUgaXMgZW5hYmxlZAorICAgICAgICBvbmx5IHdoZW4gV1RGX1VTRV9S VExfU0NST0xMQkFSIGlzIDEuKQorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL2Nocm9taXVtL3Nj cm9sbGJhcnMvZHJhZy1ydGwtcmVzaXplci5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnJlc2l6ZSk6IE1p cnJvcmVkIHRoZSB4IGNvb3JkaW5hdGUgb2YgbW91c2UgcG9zaXRpb25zCisgICAgICAgIHdoZW4g bWlycm9yaW5nIGEgcmVzaXplci4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpvZmZz ZXRGcm9tUmVzaXplQ29ybmVyKTogUmV0dXJuZWQgdGhlIG9mZnNldCBmcm9tIHRoZQorICAgICAg ICBib3R0b20tbGVmdCBjb3JuZXIgd2hlbiByZW5kZXJpbmcgYSByZXNpemVyIHRoZXJlLgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmRyYXdQbGF0Zm9ybVJlc2l6ZXJJbWFnZSk6IE1p cnJvcmVkIHRoZSByZXNpemVyIGJpdG1hcAorICAgICAgICBob3Jpem9udGFsbHkgd2hlbiByZW5k ZXJpbmcgYSByZXNpemVyIHRvIHRoZSBib3R0b20tbGVmdCBjb3JuZXIuCisKIDIwMTItMDMtMDYg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBdHRlbXB0IHRvIGZp eCB0aGUgUXQgbWluaW1hbCBidWlsZC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcAkocmV2aXNpb24gMTA5ODM4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTczOCw2ICsxNzM4LDEwIEBA IHZvaWQgUmVuZGVyTGF5ZXI6OnJlc2l6ZShjb25zdCBQbGF0Zm9ybU0KICAgICBlbGVtZW50LT5z ZXRNaW5pbXVtU2l6ZUZvclJlc2l6aW5nKG1pbmltdW1TaXplKTsKICAgICAKICAgICBMYXlvdXRT aXplIGFkanVzdGVkT2xkT2Zmc2V0ID0gTGF5b3V0U2l6ZShvbGRPZmZzZXQud2lkdGgoKSAvIHpv b21GYWN0b3IsIG9sZE9mZnNldC5oZWlnaHQoKSAvIHpvb21GYWN0b3IpOworICAgIGlmIChyZW5k ZXJlci0+c3R5bGUoKS0+c2hvdWxkUGxhY2VCbG9ja0RpcmVjdGlvblNjcm9sbGJhck9uTG9naWNh bExlZnQoKSkgeworICAgICAgICBuZXdPZmZzZXQuc2V0V2lkdGgoLW5ld09mZnNldC53aWR0aCgp KTsKKyAgICAgICAgYWRqdXN0ZWRPbGRPZmZzZXQuc2V0V2lkdGgoLWFkanVzdGVkT2xkT2Zmc2V0 LndpZHRoKCkpOworICAgIH0KICAgICAKICAgICBMYXlvdXRTaXplIGRpZmZlcmVuY2UgPSAoY3Vy cmVudFNpemUgKyBuZXdPZmZzZXQgLSBhZGp1c3RlZE9sZE9mZnNldCkuZXhwYW5kZWRUbyhtaW5p bXVtU2l6ZSkgLSBjdXJyZW50U2l6ZTsKIApAQCAtMjE3NCwxMSArMjE3OCwxNCBAQCBpbnQgUmVu ZGVyTGF5ZXI6Omhvcml6b250YWxTY3JvbGxiYXJIZWlnCiAKIEludFNpemUgUmVuZGVyTGF5ZXI6 Om9mZnNldEZyb21SZXNpemVDb3JuZXIoY29uc3QgSW50UG9pbnQmIGFic29sdXRlUG9pbnQpIGNv bnN0CiB7Ci0gICAgLy8gQ3VycmVudGx5IHRoZSByZXNpemUgY29ybmVyIGlzIGFsd2F5cyB0aGUg Ym90dG9tIHJpZ2h0IGNvcm5lcgorICAgIC8vIEN1cnJlbnRseSB0aGUgcmVzaXplIGNvcm5lciBp cyBlaXRoZXIgdGhlIGJvdHRvbSByaWdodCBjb3JuZXIgb3IgdGhlIGJvdHRvbSBsZWZ0IGNvcm5l ci4KICAgICAvLyBGSVhNRTogVGhpcyBhc3N1bWVzIHRoZSBsb2NhdGlvbiBpcyAwLCAwLiBJcyB0 aGlzIGd1YXJhbnRlZWQgdG8gYWx3YXlzIGJlIHRoZSBjYXNlPwotICAgIEludFBvaW50IGJvdHRv bVJpZ2h0ID0gdG9Qb2ludChzaXplKCkpOworICAgIEludFNpemUgZWxlbWVudFNpemUgPSBzaXpl KCk7CisgICAgaWYgKHJlbmRlcmVyKCktPnN0eWxlKCktPnNob3VsZFBsYWNlQmxvY2tEaXJlY3Rp b25TY3JvbGxiYXJPbkxvZ2ljYWxMZWZ0KCkpCisgICAgICAgIGVsZW1lbnRTaXplLnNldFdpZHRo KDApOworICAgIEludFBvaW50IHJlc2l6ZXJQb2ludCA9IHRvUG9pbnQoZWxlbWVudFNpemUpOwog ICAgIEludFBvaW50IGxvY2FsUG9pbnQgPSByb3VuZGVkSW50UG9pbnQoYWJzb2x1dGVUb0NvbnRl bnRzKGFic29sdXRlUG9pbnQpKTsKLSAgICByZXR1cm4gbG9jYWxQb2ludCAtIGJvdHRvbVJpZ2h0 OworICAgIHJldHVybiBsb2NhbFBvaW50IC0gcmVzaXplclBvaW50OwogfQogCiBib29sIFJlbmRl ckxheWVyOjpoYXNPdmVyZmxvd0NvbnRyb2xzKCkgY29uc3QKQEAgLTI1MTYsNiArMjUyMywxNiBA QCB2b2lkIFJlbmRlckxheWVyOjpkcmF3UGxhdGZvcm1SZXNpemVySW1hCiAgICAgfQogCiAgICAg SW50UmVjdCBpbWFnZVJlY3QocmVzaXplckNvcm5lclJlY3QubWF4WE1heFlDb3JuZXIoKSAtIGNv cm5lclJlc2l6ZXJTaXplLCBjb3JuZXJSZXNpemVyU2l6ZSk7CisgICAgaWYgKHJlbmRlcmVyKCkt PnN0eWxlKCktPnNob3VsZFBsYWNlQmxvY2tEaXJlY3Rpb25TY3JvbGxiYXJPbkxvZ2ljYWxMZWZ0 KCkpIHsKKyAgICAgICAgY29udGV4dC0+c2F2ZSgpOworICAgICAgICBjb250ZXh0LT50cmFuc2xh dGUoaW1hZ2VSZWN0LngoKSwgaW1hZ2VSZWN0LnkoKSk7CisgICAgICAgIGltYWdlUmVjdC5zZXRY KDApOworICAgICAgICBpbWFnZVJlY3Quc2V0WSgwKTsKKyAgICAgICAgY29udGV4dC0+c2NhbGUo RmxvYXRTaXplKC0xLjAsIDEuMCkpOworICAgICAgICBjb250ZXh0LT5kcmF3SW1hZ2UocmVzaXpl Q29ybmVySW1hZ2UuZ2V0KCksIHJlbmRlcmVyKCktPnN0eWxlKCktPmNvbG9yU3BhY2UoKSwgaW1h Z2VSZWN0KTsKKyAgICAgICAgY29udGV4dC0+cmVzdG9yZSgpOworICAgICAgICByZXR1cm47Cisg ICAgfQogICAgIGNvbnRleHQtPmRyYXdJbWFnZShyZXNpemVDb3JuZXJJbWFnZS5nZXQoKSwgcmVu ZGVyZXIoKS0+c3R5bGUoKS0+Y29sb3JTcGFjZSgpLCBpbWFnZVJlY3QpOwogfQogCkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMDk4ODYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wMy0wNiAgSGlyb25vcmkgQm9ubyAgPGhib25vQGNo cm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1pcnJvciB0aGUgcmVzaXplciBpbWFn ZSBvZiBhbiBSVEwgZWxlbWVudCB3aGVuIFdURl9VU0VfUlRMX1NDUk9MTEJBUiBpcyAxCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjIzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgbWly cm9ycyBhIHJlc2l6ZXIgaW1hZ2Ugb2YgYW4gUlRMIGVsZW1lbnQgaG9yaXpvbnRhbGwgYXMgRmly ZWZveAorICAgICAgICBkb2VzLiBUaGlzIGNoYW5nZSBhbHNvIG1pcnJvcnMgaXRzIGRyYWdnaW5n IGJlaGF2aW9yLCBpLmUuIGRyYWdpbmcgdGhlIHJlc2l6ZXIKKyAgICAgICAgb2YgYW4gUlRMIGVs ZW1lbnQgdG8gdGhlIGxlZnQgc2lkZSBpbmNyZWFzZXMgaXRzIHdpZHRoLiAoVGhpcyBmZWF0dXJl IGlzIGVuYWJsZWQKKyAgICAgICAgb25seSB3aGVuIFdURl9VU0VfUlRMX1NDUk9MTEJBUiBpcyAx LikKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnM6IEFkZGVkLgorICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMvZHJhZy1ydGwtcmVzaXplci1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMv ZHJhZy1ydGwtcmVzaXplci5odG1sOiBBZGRlZC4KKwogMjAxMi0wMy0wNiAgS2VudGFybyBIYXJh ICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZ2FyZGVuaW5n LgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vc2Nyb2xsYmFycy9kcmFnLXJ0 bC1yZXNpemVyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS9zY3JvbGxiYXJzL2RyYWctcnRsLXJlc2l6ZXItZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vc2Nyb2xsYmFycy9kcmFn LXJ0bC1yZXNpemVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAor VGVzdCB0aGF0IGFuIFJUTCBlbGVtZW50IHJlbmRlcnMgYSByZXNpemVyIHRvIGl0cyBib3R0b20t bGVmdCBjb3JuZXIgYW5kIGRyYWdnaW5nIHRoaXMgcmVzaXplciB0byB0aGUgbGVmdCBjaGFuZ2Vz IGl0cyB3aWR0aC4gVG8gdGVzdCBtYW51YWxseSwgZHJhZ2dpbmcgdGhlIHJlc2l6ZXIgb2YgdGhl IGJlbG93IGVsZW1lbnQgdG8gbGVmdCwgYW5kIHNlZSB0aGlzIGVsZW1lbnQgaW5jcmVhc2VzIGl0 cyB3aWR0aC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKKworUEFTUyBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnb3ZlcmZsb3cnKS5vZmZzZXRXaWR0aCA+IG9mZnNldFdpZHRoIGlz IHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9zY3JvbGxiYXJzL2RyYWctcnRs LXJlc2l6ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS9zY3JvbGxiYXJzL2RyYWctcnRsLXJlc2l6ZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMvZHJhZy1ydGwtcmVzaXplci5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8dGl0bGU+QnVnIDkyMjM8L3RpdGxlPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 IGRpcj0icnRsIiBzdHlsZT0ibWFyZ2luOjBweCI+Cis8ZGl2IGlkPSJvdmVyZmxvdyIgZGlyPSJy dGwiIHN0eWxlPSJib3JkZXI6MnB4IHNvbGlkIGJsYWNrOyBvdmVyZmxvdzphdXRvOyB3aWR0aDog NDAwcHg7IGhlaWdodDogNDAwcHg7IHJlc2l6ZTpib3RoOyI+Cis8ZGl2IHN0eWxlPSJiYWNrZ3Jv dW5kLWNvbG9yOnJlZDtoZWlnaHQ6NzIwcHgiPjwvZGl2PgorPGRpdiBzdHlsZT0iYmFja2dyb3Vu ZC1jb2xvcjpncmVlbjtoZWlnaHQ6MTYwMHB4Ij48L2Rpdj4KKzwvZGl2PgorPGRpdiBpZD0iY29u c29sZSI+Cis8L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCB0aGF0IGFuIFJUTCBl bGVtZW50IHJlbmRlcnMgYSByZXNpemVyIHRvIGl0cyBib3R0b20tbGVmdCBjb3JuZXIgYW5kICcg KworICAgICAgICAgICAgJ2RyYWdnaW5nIHRoaXMgcmVzaXplciB0byB0aGUgbGVmdCBjaGFuZ2Vz IGl0cyB3aWR0aC4gJyArCisgICAgICAgICAgICAnVG8gdGVzdCBtYW51YWxseSwgZHJhZ2dpbmcg dGhlIHJlc2l6ZXIgb2YgdGhlIGJlbG93IGVsZW1lbnQgdG8gbGVmdCwgYW5kICcgKworICAgICAg ICAgICAgJ3NlZSB0aGlzIGVsZW1lbnQgaW5jcmVhc2VzIGl0cyB3aWR0aC4nKTsKKworLy8gVGhp cyB0ZXN0IG11c3QgYmUgYXN5bmMgYmVjYXVzZSBpdCBuZWVkcyB0byB3YWl0IGZvciBXZWJLaXQg dG8gZmluaXNoIHJlLWxheW91dGluZyBlbGVtZW50cworLy8gYWZ0ZXIgc2VuZGluZyBtb3VzZSBl dmVudHMuCitqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworZnVuY3Rpb24gZmluaXNoZWQoKQorewor ICAgIHNob3VsZEJlVHJ1ZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoXCdvdmVyZmxvd1wnKS5v ZmZzZXRXaWR0aCA+IG9mZnNldFdpZHRoJyk7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK3Zh ciBvZmZzZXRXaWR0aCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdvdmVyZmxvdycpLm9mZnNl dFdpZHRoOworCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgewor ICAgIHZhciBub2RlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ292ZXJmbG93Jyk7CisgICAg dmFyIG9mZnNldExlZnQgPSBub2RlLm9mZnNldExlZnQgKyA1OworICAgIHZhciBvZmZzZXRUb3Ag PSBub2RlLm9mZnNldFRvcCArIG5vZGUub2Zmc2V0SGVpZ2h0IC0gNTsKKyAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbyhvZmZzZXRMZWZ0LCBvZmZzZXRUb3ApOworICAgIGV2ZW50U2VuZGVyLm1v dXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKG9mZnNldExlZnQgLSAzMCwg b2Zmc2V0VG9wKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgc2V0VGltZW91dChm aW5pc2hlZCwgMCk7Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 130567 2012-03-07 01:30:13 -0800 2012-03-07 11:08:18 -0800 A quick fix v3 (Applied comments, for landing) issue9223-patch2.txt text/plain 7535 hbono SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDAzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTA3ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTWlycm9y IHRoZSByZXNpemVyIGltYWdlIG9mIGFuIFJUTCBlbGVtZW50IHdoZW4gV1RGX1VTRV9SVExfU0NS T0xMQkFSIGlzIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNoYW5nZSBtaXJyb3JzIGEgcmVzaXplciBpbWFnZSBvZiBhbiBSVEwgZWxlbWVudCBo b3Jpem9udGFsbCBhcyBGaXJlZm94CisgICAgICAgIGRvZXMuIFRoaXMgY2hhbmdlIGFsc28gbWly cm9ycyBpdHMgZHJhZ2dpbmcgYmVoYXZpb3IsIGkuZS4gZHJhZ2luZyB0aGUgcmVzaXplcgorICAg ICAgICBvZiBhbiBSVEwgZWxlbWVudCB0byB0aGUgbGVmdCBzaWRlIGluY3JlYXNlcyBpdHMgd2lk dGguIChUaGlzIGZlYXR1cmUgaXMgZW5hYmxlZAorICAgICAgICBvbmx5IHdoZW4gV1RGX1VTRV9S VExfU0NST0xMQkFSIGlzIDEuKQorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL2Nocm9taXVtL3Nj cm9sbGJhcnMvZHJhZy1ydGwtcmVzaXplci5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnJlc2l6ZSk6IE1p cnJvcmVkIHRoZSB4IGNvb3JkaW5hdGUgb2YgbW91c2UgcG9zaXRpb25zCisgICAgICAgIHdoZW4g bWlycm9yaW5nIGEgcmVzaXplci4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpvZmZz ZXRGcm9tUmVzaXplQ29ybmVyKTogUmV0dXJuZWQgdGhlIG9mZnNldCBmcm9tIHRoZQorICAgICAg ICBib3R0b20tbGVmdCBjb3JuZXIgd2hlbiByZW5kZXJpbmcgYSByZXNpemVyIHRoZXJlLgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmRyYXdQbGF0Zm9ybVJlc2l6ZXJJbWFnZSk6IE1p cnJvcmVkIHRoZSByZXNpemVyIGJpdG1hcAorICAgICAgICBob3Jpem9udGFsbHkgd2hlbiByZW5k ZXJpbmcgYSByZXNpemVyIHRvIHRoZSBib3R0b20tbGVmdCBjb3JuZXIuCisKIDIwMTItMDMtMDcg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENsZWFudXAgb2Yg UmVuZGVyVGV4dENvbnRyb2w6OmFkanVzdENvbnRyb2xIZWlnaHRCYXNlZE9uTGluZUhlaWdodCgp CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9u IDExMDAxOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE3MzgsNiArMTczOCwxMCBAQCB2b2lkIFJlbmRlckxheWVyOjpyZXNp emUoY29uc3QgUGxhdGZvcm1NCiAgICAgZWxlbWVudC0+c2V0TWluaW11bVNpemVGb3JSZXNpemlu ZyhtaW5pbXVtU2l6ZSk7CiAgICAgCiAgICAgTGF5b3V0U2l6ZSBhZGp1c3RlZE9sZE9mZnNldCA9 IExheW91dFNpemUob2xkT2Zmc2V0LndpZHRoKCkgLyB6b29tRmFjdG9yLCBvbGRPZmZzZXQuaGVp Z2h0KCkgLyB6b29tRmFjdG9yKTsKKyAgICBpZiAocmVuZGVyZXItPnN0eWxlKCktPnNob3VsZFBs YWNlQmxvY2tEaXJlY3Rpb25TY3JvbGxiYXJPbkxvZ2ljYWxMZWZ0KCkpIHsKKyAgICAgICAgbmV3 T2Zmc2V0LnNldFdpZHRoKC1uZXdPZmZzZXQud2lkdGgoKSk7CisgICAgICAgIGFkanVzdGVkT2xk T2Zmc2V0LnNldFdpZHRoKC1hZGp1c3RlZE9sZE9mZnNldC53aWR0aCgpKTsKKyAgICB9CiAgICAg CiAgICAgTGF5b3V0U2l6ZSBkaWZmZXJlbmNlID0gKGN1cnJlbnRTaXplICsgbmV3T2Zmc2V0IC0g YWRqdXN0ZWRPbGRPZmZzZXQpLmV4cGFuZGVkVG8obWluaW11bVNpemUpIC0gY3VycmVudFNpemU7 CiAKQEAgLTIxNzQsMTEgKzIxNzgsMTQgQEAgaW50IFJlbmRlckxheWVyOjpob3Jpem9udGFsU2Ny b2xsYmFySGVpZwogCiBJbnRTaXplIFJlbmRlckxheWVyOjpvZmZzZXRGcm9tUmVzaXplQ29ybmVy KGNvbnN0IEludFBvaW50JiBhYnNvbHV0ZVBvaW50KSBjb25zdAogewotICAgIC8vIEN1cnJlbnRs eSB0aGUgcmVzaXplIGNvcm5lciBpcyBhbHdheXMgdGhlIGJvdHRvbSByaWdodCBjb3JuZXIKKyAg ICAvLyBDdXJyZW50bHkgdGhlIHJlc2l6ZSBjb3JuZXIgaXMgZWl0aGVyIHRoZSBib3R0b20gcmln aHQgY29ybmVyIG9yIHRoZSBib3R0b20gbGVmdCBjb3JuZXIuCiAgICAgLy8gRklYTUU6IFRoaXMg YXNzdW1lcyB0aGUgbG9jYXRpb24gaXMgMCwgMC4gSXMgdGhpcyBndWFyYW50ZWVkIHRvIGFsd2F5 cyBiZSB0aGUgY2FzZT8KLSAgICBJbnRQb2ludCBib3R0b21SaWdodCA9IHRvUG9pbnQoc2l6ZSgp KTsKKyAgICBJbnRTaXplIGVsZW1lbnRTaXplID0gc2l6ZSgpOworICAgIGlmIChyZW5kZXJlcigp LT5zdHlsZSgpLT5zaG91bGRQbGFjZUJsb2NrRGlyZWN0aW9uU2Nyb2xsYmFyT25Mb2dpY2FsTGVm dCgpKQorICAgICAgICBlbGVtZW50U2l6ZS5zZXRXaWR0aCgwKTsKKyAgICBJbnRQb2ludCByZXNp emVyUG9pbnQgPSB0b1BvaW50KGVsZW1lbnRTaXplKTsKICAgICBJbnRQb2ludCBsb2NhbFBvaW50 ID0gcm91bmRlZEludFBvaW50KGFic29sdXRlVG9Db250ZW50cyhhYnNvbHV0ZVBvaW50KSk7Ci0g ICAgcmV0dXJuIGxvY2FsUG9pbnQgLSBib3R0b21SaWdodDsKKyAgICByZXR1cm4gbG9jYWxQb2lu dCAtIHJlc2l6ZXJQb2ludDsKIH0KIAogYm9vbCBSZW5kZXJMYXllcjo6aGFzT3ZlcmZsb3dDb250 cm9scygpIGNvbnN0CkBAIC0yNTE2LDYgKzI1MjMsMTYgQEAgdm9pZCBSZW5kZXJMYXllcjo6ZHJh d1BsYXRmb3JtUmVzaXplckltYQogICAgIH0KIAogICAgIEludFJlY3QgaW1hZ2VSZWN0KHJlc2l6 ZXJDb3JuZXJSZWN0Lm1heFhNYXhZQ29ybmVyKCkgLSBjb3JuZXJSZXNpemVyU2l6ZSwgY29ybmVy UmVzaXplclNpemUpOworICAgIGlmIChyZW5kZXJlcigpLT5zdHlsZSgpLT5zaG91bGRQbGFjZUJs b2NrRGlyZWN0aW9uU2Nyb2xsYmFyT25Mb2dpY2FsTGVmdCgpKSB7CisgICAgICAgIGNvbnRleHQt PnNhdmUoKTsKKyAgICAgICAgY29udGV4dC0+dHJhbnNsYXRlKGltYWdlUmVjdC54KCksIGltYWdl UmVjdC55KCkpOworICAgICAgICBpbWFnZVJlY3Quc2V0WCgwKTsKKyAgICAgICAgaW1hZ2VSZWN0 LnNldFkoMCk7CisgICAgICAgIGNvbnRleHQtPnNjYWxlKEZsb2F0U2l6ZSgtMS4wLCAxLjApKTsK KyAgICAgICAgY29udGV4dC0+ZHJhd0ltYWdlKHJlc2l6ZUNvcm5lckltYWdlLmdldCgpLCByZW5k ZXJlcigpLT5zdHlsZSgpLT5jb2xvclNwYWNlKCksIGltYWdlUmVjdCk7CisgICAgICAgIGNvbnRl eHQtPnJlc3RvcmUoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICBjb250ZXh0LT5kcmF3 SW1hZ2UocmVzaXplQ29ybmVySW1hZ2UuZ2V0KCksIHJlbmRlcmVyKCktPnN0eWxlKCktPmNvbG9y U3BhY2UoKSwgaW1hZ2VSZWN0KTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwMDM0KQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTItMDMtMDcgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg W0Nocm9taXVtXSBNaXJyb3IgdGhlIHJlc2l6ZXIgaW1hZ2Ugb2YgYW4gUlRMIGVsZW1lbnQgd2hl biBXVEZfVVNFX1JUTF9TQ1JPTExCQVIgaXMgMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1pcnJvcnMgYSByZXNpemVyIGltYWdlIG9m IGFuIFJUTCBlbGVtZW50IGhvcml6b250YWxsIGFzIEZpcmVmb3gKKyAgICAgICAgZG9lcy4gVGhp cyBjaGFuZ2UgYWxzbyBtaXJyb3JzIGl0cyBkcmFnZ2luZyBiZWhhdmlvciwgaS5lLiBkcmFnaW5n IHRoZSByZXNpemVyCisgICAgICAgIG9mIGFuIFJUTCBlbGVtZW50IHRvIHRoZSBsZWZ0IHNpZGUg aW5jcmVhc2VzIGl0cyB3aWR0aC4gKFRoaXMgZmVhdHVyZSBpcyBlbmFibGVkCisgICAgICAgIG9u bHkgd2hlbiBXVEZfVVNFX1JUTF9TQ1JPTExCQVIgaXMgMS4pCisKKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS9zY3JvbGxiYXJzOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1 bS9zY3JvbGxiYXJzL2RyYWctcnRsLXJlc2l6ZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9zY3JvbGxiYXJzL2RyYWctcnRsLXJlc2l6ZXIuaHRtbDog QWRkZWQuCisKIDIwMTItMDMtMDcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtEUlRdIFJlbW92ZSBQbGFpblRleHRDb250cm9sbGVyIGltcGxlbWVudGF0 aW9ucy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMvZHJh Zy1ydGwtcmVzaXplci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vc2Nyb2xsYmFycy9kcmFnLXJ0bC1yZXNpemVyLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMv ZHJhZy1ydGwtcmVzaXplci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAg QEAKK1Rlc3QgdGhhdCBhbiBSVEwgZWxlbWVudCByZW5kZXJzIGEgcmVzaXplciB0byBpdHMgYm90 dG9tLWxlZnQgY29ybmVyIGFuZCBkcmFnZ2luZyB0aGlzIHJlc2l6ZXIgdG8gdGhlIGxlZnQgY2hh bmdlcyBpdHMgd2lkdGguIFRvIHRlc3QgbWFudWFsbHksIGRyYWdnaW5nIHRoZSByZXNpemVyIG9m IHRoZSBiZWxvdyBlbGVtZW50IHRvIGxlZnQsIGFuZCBzZWUgdGhpcyBlbGVtZW50IGluY3JlYXNl cyBpdHMgd2lkdGguCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdvdmVyZmxvdycpLm9mZnNldFdpZHRoID4gb2Zmc2V0V2lkdGgg aXMgdHJ1ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF CisKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Njcm9sbGJhcnMvZHJhZy1y dGwtcmVzaXplci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtL3Njcm9sbGJhcnMvZHJhZy1ydGwtcmVzaXplci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vc2Nyb2xsYmFycy9kcmFnLXJ0bC1yZXNpemVyLmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8aGVhZD4KKzx0aXRsZT5CdWcgOTIyMzwvdGl0bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4v ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHkgZGlyPSJydGwiIHN0eWxlPSJtYXJnaW46MHB4Ij4KKzxkaXYgaWQ9Im92ZXJmbG93IiBkaXI9 InJ0bCIgc3R5bGU9ImJvcmRlcjoycHggc29saWQgYmxhY2s7IG92ZXJmbG93OmF1dG87IHdpZHRo OiA0MDBweDsgaGVpZ2h0OiA0MDBweDsgcmVzaXplOmJvdGg7Ij4KKzxkaXYgc3R5bGU9ImJhY2tn cm91bmQtY29sb3I6cmVkO2hlaWdodDo3MjBweCI+PC9kaXY+Cis8ZGl2IHN0eWxlPSJiYWNrZ3Jv dW5kLWNvbG9yOmdyZWVuO2hlaWdodDoxNjAwcHgiPjwvZGl2PgorPC9kaXY+Cis8c2NyaXB0Pgor ZGVzY3JpcHRpb24oJ1Rlc3QgdGhhdCBhbiBSVEwgZWxlbWVudCByZW5kZXJzIGEgcmVzaXplciB0 byBpdHMgYm90dG9tLWxlZnQgY29ybmVyIGFuZCAnICsKKyAgICAgICAgICAgICdkcmFnZ2luZyB0 aGlzIHJlc2l6ZXIgdG8gdGhlIGxlZnQgY2hhbmdlcyBpdHMgd2lkdGguICcgKworICAgICAgICAg ICAgJ1RvIHRlc3QgbWFudWFsbHksIGRyYWdnaW5nIHRoZSByZXNpemVyIG9mIHRoZSBiZWxvdyBl bGVtZW50IHRvIGxlZnQsIGFuZCAnICsKKyAgICAgICAgICAgICdzZWUgdGhpcyBlbGVtZW50IGlu Y3JlYXNlcyBpdHMgd2lkdGguJyk7CisKKy8vIFRoaXMgdGVzdCBtdXN0IGJlIGFzeW5jIGJlY2F1 c2UgaXQgbmVlZHMgdG8gd2FpdCBmb3IgV2ViS2l0IHRvIGZpbmlzaCByZS1sYXlvdXRpbmcgZWxl bWVudHMKKy8vIGFmdGVyIHNlbmRpbmcgbW91c2UgZXZlbnRzLgoranNUZXN0SXNBc3luYyA9IHRy dWU7CisKK2Z1bmN0aW9uIGZpbmlzaGVkKCkKK3sKKyAgICBzaG91bGRCZVRydWUoJ2RvY3VtZW50 LmdldEVsZW1lbnRCeUlkKFwnb3ZlcmZsb3dcJykub2Zmc2V0V2lkdGggPiBvZmZzZXRXaWR0aCcp OworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCit2YXIgb2Zmc2V0V2lkdGggPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnb3ZlcmZsb3cnKS5vZmZzZXRXaWR0aDsKKworaWYgKHdpbmRvdy5ldmVu dFNlbmRlcikgeworICAgIHZhciBub2RlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ292ZXJm bG93Jyk7CisgICAgdmFyIG9mZnNldExlZnQgPSBub2RlLm9mZnNldExlZnQgKyA1OworICAgIHZh ciBvZmZzZXRUb3AgPSBub2RlLm9mZnNldFRvcCArIG5vZGUub2Zmc2V0SGVpZ2h0IC0gNTsKKyAg ICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhvZmZzZXRMZWZ0LCBvZmZzZXRUb3ApOworICAgIGV2 ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKG9mZnNl dExlZnQgLSAzMCwgb2Zmc2V0VG9wKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAg c2V0VGltZW91dChmaW5pc2hlZCwgMCk7Cit9Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8u Li8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgo=