92164 2012-07-24 14:36:17 -0700 [CSS Shapes] Shapes should not cause relayout when they are equivalent 2023-08-01 11:38:23 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 89256 1 betravis betravis ahmad.saleem792 bjonesbe commit-queue donggwan.kim esprehn+autocc glenn koivisto zalan zoltan oldest_to_newest 677211 0 betravis 2012-07-24 14:36:17 -0700 RenderStyle::diff should not cause relayout and RenderBlock::styleDidChange should not generate a new WrapShapeInfo for two different but equivalent WrapShapes Currently, just pointers are used for comparison, but eventually they should use a deep compare 831297 1 bjonesbe 2013-02-12 14:58:08 -0800 This also affects shape-outside, not just shape-inside. 831306 2 thakis 2013-02-12 15:07:30 -0800 *** Bug 100811 has been marked as a duplicate of this bug. *** 900696 3 204744 betravis 2013-06-14 16:10:43 -0700 Created attachment 204744 Initial patch 900852 4 204744 sam 2013-06-15 20:23:37 -0700 Comment on attachment 204744 Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=204744&action=review > Source/WebCore/ChangeLog:11 > + The two layouts are equivalent, so there are no new tests. If this is being done for performance, do you have any perf results that this made better? Is there a benchmark you are using or a test case you are investigating? > Source/WebCore/rendering/style/BasicShapes.h:98 > + virtual bool operator==(const BasicShape& other) You should add OVERRIDE here (and on all the others below). Given that this is a virtual function, does this really need to be inline? > Source/WebCore/rendering/style/BasicShapes.h:211 > + for (size_t i = 0; i < values().size(); i++) > + if (getXAt(i) != otherPolygon->getXAt(i) || getYAt(i) != otherPolygon->getYAt(i)) > + return false; The for-loop needs braces. 977869 5 204744 zoltan 2014-02-07 10:15:00 -0800 Comment on attachment 204744 Initial patch Pulling this out from the review queue, since it's need to be updated. (Changelog: [CSS Exclusions]) 977872 6 zoltan 2014-02-07 10:16:04 -0800 Closing bug until we have a perf test to verify the improvement. 1969099 7 ahmad.saleem792 2023-08-01 11:38:09 -0700 Just to add we do have FIXME still in our code referring to bug, which is marked duplicate of this: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#447 // FIXME: A future optimization would do a deep comparison for equality. (bug 100811) if (shapeOutside == oldShapeOutside && shapeMargin == oldShapeMargin && shapeImageThreshold == oldShapeImageThreshold) return; 204744 2013-06-14 16:10:43 -0700 2014-02-07 10:15:00 -0800 Initial patch bug-92164-20130614160901.patch text/plain 6221 betravis U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUyZTM5YzQ3NDg0N2E0 MWNiMWE2YTU0NmU4NzUzMjM3YTUxZGMwZi4uZjM3MTFhZmE5NWViNTUyOTcwYzkxYjRkZTgzNzJk NDVmZjY1NWYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA2LTE0ICBCZWFy IFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNd IGV4Y2x1c2lvbiBzaGFwZXMgc2hvdWxkIG5vdCBjYXVzZSByZWxheW91dCB3aGVuIHRoZXkgYXJl IGVxdWl2YWxlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG8gYSBkZWVwIGNvbXBhcmlzaW9uIG9mIG5ldyBzaGFwZSB2YWx1ZXMgdG8gc2VlIHdoZXRo ZXIgcmVsYXlvdXQgaXMKKyAgICAgICAgcmVxdWlyZWQuCisKKyAgICAgICAgVGhlIHR3byBsYXlv dXRzIGFyZSBlcXVpdmFsZW50LCBzbyB0aGVyZSBhcmUgbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJs b2NrOjp1cGRhdGVTaGFwZUluc2lkZUluZm9BZnRlclN0eWxlQ2hhbmdlKTogSW4gYWRkaXRpb24g dG8KKyAgICAgICAgY2hlY2tpbmcgd2hldGhlciB0aGUgc2hhcGUgcG9pbnRlcnMgYXJlIGRpZmZl cmVudCwgY2hlY2sgdGhlIHNoYXBlJ3MgbWVtYmVyIHZhbHVlcy4KKyAgICAgICAgKiByZW5kZXJp bmcvc3R5bGUvQmFzaWNTaGFwZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkJhc2ljU2hhcGVSZWN0 YW5nbGU6Om9wZXJhdG9yPT0pOiBJbXBsZW1lbnQgdGhlID09IG9wZXJhdG9yIGZvciBCYXNpY1No YXBlcy4KKyAgICAgICAgKFdlYkNvcmU6OkJhc2ljU2hhcGVDaXJjbGU6Om9wZXJhdG9yPT0pOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkJhc2ljU2hhcGVFbGxpcHNlOjpvcGVyYXRvcj09KTog RGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpCYXNpY1NoYXBlUG9seWdvbjo6b3BlcmF0b3I9PSk6 IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6QmFzaWNTaGFwZUluc2V0UmVjdGFuZ2xlOjpvcGVy YXRvcj09KTogRGl0dG8uCisKIDIwMTMtMDYtMTQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW50cm9kdWNlIFVTRShXSU5HREkpIGZvciB0aGUgV2lu ZG93cyBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA1 YWEyOTAyM2YwOGI0Zjg3OTk4YjdkN2JlMzljZGY4ZDhlYjY2YzM3Li43ZDc0MDZiOTljOTAwNzMw NWRhZGY1M2YwMDMxYTM4ZTdmMjM1ZjI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAKQEAgLTE0NDEsNiArMTQ0MSw5IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnVwZGF0 ZVNoYXBlSW5zaWRlSW5mb0FmdGVyU3R5bGVDaGFuZ2UoY29uc3QgU2hhcGVWYWx1ZSogc2hhcGVJ CiAgICAgaWYgKHNoYXBlSW5zaWRlID09IG9sZFNoYXBlSW5zaWRlKQogICAgICAgICByZXR1cm47 CiAKKyAgICBpZiAoc2hhcGVJbnNpZGUgJiYgb2xkU2hhcGVJbnNpZGUgJiYgKnNoYXBlSW5zaWRl ID09ICpvbGRTaGFwZUluc2lkZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKHNoYXBlSW5z aWRlKSB7CiAgICAgICAgIFNoYXBlSW5zaWRlSW5mbyogc2hhcGVJbnNpZGVJbmZvID0gZW5zdXJl U2hhcGVJbnNpZGVJbmZvKCk7CiAgICAgICAgIHNoYXBlSW5zaWRlSW5mby0+ZGlydHlTaGFwZVNp emUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9CYXNpY1No YXBlcy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmgKaW5k ZXggZWMwMjdmZTkxMWU0MDNlMGZiODdjMmNhZWU1NDIwYWMyYWQxMTc2ZC4uMTUxMDhhZWZhNGI5 NTk2ZmUzNDdkNTRlMWM5ODI4ZWE1NzZhMmQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmgKQEAgLTYwLDYgKzYwLDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgUGFzc1JlZlB0cjxCYXNpY1NoYXBlPiBibGVuZChjb25zdCBCYXNpY1NoYXBlKiwgZG91 YmxlKSBjb25zdCA9IDA7CiAKICAgICB2aXJ0dWFsIFR5cGUgdHlwZSgpIGNvbnN0ID0gMDsKKyAg ICB2aXJ0dWFsIGJvb2wgb3BlcmF0b3I9PShjb25zdCBCYXNpY1NoYXBlJiBvdGhlcikgPSAwOwog cHJvdGVjdGVkOgogICAgIEJhc2ljU2hhcGUoKSB7IH0KIH07CkBAIC05NCw2ICs5NSwxNSBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCBQYXNzUmVmUHRyPEJhc2ljU2hhcGU+IGJsZW5kKGNvbnN0IEJh c2ljU2hhcGUqLCBkb3VibGUpIGNvbnN0IE9WRVJSSURFOwogCiAgICAgdmlydHVhbCBUeXBlIHR5 cGUoKSBjb25zdCB7IHJldHVybiBCYXNpY1NoYXBlUmVjdGFuZ2xlVHlwZTsgfQorICAgIHZpcnR1 YWwgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEJhc2ljU2hhcGUmIG90aGVyKQorICAgIHsKKyAgICAg ICAgaWYgKG90aGVyLnR5cGUoKSAhPSBCYXNpY1NoYXBlUmVjdGFuZ2xlVHlwZSkKKyAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgY29uc3QgQmFzaWNTaGFwZVJlY3RhbmdsZSogb3Ro ZXJSZWN0YW5nbGUgPSBzdGF0aWNfY2FzdDxjb25zdCBCYXNpY1NoYXBlUmVjdGFuZ2xlKj4oJm90 aGVyKTsKKyAgICAgICAgcmV0dXJuIHgoKSA9PSBvdGhlclJlY3RhbmdsZS0+eCgpICYmIHkoKSA9 PSBvdGhlclJlY3RhbmdsZS0+eSgpCisgICAgICAgICAgICAmJiB3aWR0aCgpID09IG90aGVyUmVj dGFuZ2xlLT53aWR0aCgpICYmIGhlaWdodCgpID09IG90aGVyUmVjdGFuZ2xlLT5oZWlnaHQoKQor ICAgICAgICAgICAgJiYgY29ybmVyUmFkaXVzWCgpID09IG90aGVyUmVjdGFuZ2xlLT5jb3JuZXJS YWRpdXNYKCkgJiYgY29ybmVyUmFkaXVzWSgpID09IG90aGVyUmVjdGFuZ2xlLT5jb3JuZXJSYWRp dXNZKCk7CisgICAgfQogcHJpdmF0ZToKICAgICBCYXNpY1NoYXBlUmVjdGFuZ2xlKCkgeyB9CiAK QEAgLTEyMSw2ICsxMzEsMTQgQEAgcHVibGljOgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxCYXNp Y1NoYXBlPiBibGVuZChjb25zdCBCYXNpY1NoYXBlKiwgZG91YmxlKSBjb25zdCBPVkVSUklERTsK IAogICAgIHZpcnR1YWwgVHlwZSB0eXBlKCkgY29uc3QgeyByZXR1cm4gQmFzaWNTaGFwZUNpcmNs ZVR5cGU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgb3BlcmF0b3I9PShjb25zdCBCYXNpY1NoYXBlJiBv dGhlcikKKyAgICB7CisgICAgICAgIGlmIChvdGhlci50eXBlKCkgIT0gQmFzaWNTaGFwZUNpcmNs ZVR5cGUpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGNvbnN0IEJhc2ljU2hh cGVDaXJjbGUqIG90aGVyQ2lyY2xlID0gc3RhdGljX2Nhc3Q8Y29uc3QgQmFzaWNTaGFwZUNpcmNs ZSo+KCZvdGhlcik7CisgICAgICAgIHJldHVybiBjZW50ZXJYKCkgPT0gb3RoZXJDaXJjbGUtPmNl bnRlclgoKSAmJiBjZW50ZXJZKCkgPT0gb3RoZXJDaXJjbGUtPmNlbnRlclkoKQorICAgICAgICAg ICAgJiYgcmFkaXVzKCkgPT0gb3RoZXJDaXJjbGUtPnJhZGl1cygpOworICAgIH0KIHByaXZhdGU6 CiAgICAgQmFzaWNTaGFwZUNpcmNsZSgpIHsgfQogCkBAIC0xNDcsNiArMTY1LDE0IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8QmFzaWNTaGFwZT4gYmxlbmQoY29uc3QgQmFzaWNT aGFwZSosIGRvdWJsZSkgY29uc3QgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIFR5cGUgdHlwZSgp IGNvbnN0IHsgcmV0dXJuIEJhc2ljU2hhcGVFbGxpcHNlVHlwZTsgfSAKKyAgICB2aXJ0dWFsIGJv b2wgb3BlcmF0b3I9PShjb25zdCBCYXNpY1NoYXBlJiBvdGhlcikKKyAgICB7CisgICAgICAgIGlm IChvdGhlci50eXBlKCkgIT0gQmFzaWNTaGFwZUVsbGlwc2VUeXBlKQorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgICAgICBjb25zdCBCYXNpY1NoYXBlRWxsaXBzZSogb3RoZXJFbGxpcHNl ID0gc3RhdGljX2Nhc3Q8Y29uc3QgQmFzaWNTaGFwZUVsbGlwc2UqPigmb3RoZXIpOworICAgICAg ICByZXR1cm4gY2VudGVyWCgpID09IG90aGVyRWxsaXBzZS0+Y2VudGVyWCgpICYmIGNlbnRlclko KSA9PSBvdGhlckVsbGlwc2UtPmNlbnRlclkoKQorICAgICAgICAgICAgJiYgcmFkaXVzWCgpID09 IG90aGVyRWxsaXBzZS0+cmFkaXVzWCgpICYmIHJhZGl1c1koKSA9PSBvdGhlckVsbGlwc2UtPnJh ZGl1c1koKTsKKyAgICB9CiBwcml2YXRlOgogICAgIEJhc2ljU2hhcGVFbGxpcHNlKCkgeyB9CiAK QEAgLTE3Myw2ICsxOTksMTggQEAgcHVibGljOgogICAgIHZpcnR1YWwgV2luZFJ1bGUgd2luZFJ1 bGUoKSBjb25zdCB7IHJldHVybiBtX3dpbmRSdWxlOyB9CiAKICAgICB2aXJ0dWFsIFR5cGUgdHlw ZSgpIGNvbnN0IHsgcmV0dXJuIEJhc2ljU2hhcGVQb2x5Z29uVHlwZTsgfQorICAgIHZpcnR1YWwg Ym9vbCBvcGVyYXRvcj09KGNvbnN0IEJhc2ljU2hhcGUmIG90aGVyKQorICAgIHsKKyAgICAgICAg aWYgKG90aGVyLnR5cGUoKSAhPSBCYXNpY1NoYXBlUG9seWdvblR5cGUpCisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIGNvbnN0IEJhc2ljU2hhcGVQb2x5Z29uKiBvdGhlclBvbHln b24gPSBzdGF0aWNfY2FzdDxjb25zdCBCYXNpY1NoYXBlUG9seWdvbio+KCZvdGhlcik7CisgICAg ICAgIGlmICh3aW5kUnVsZSgpICE9IG90aGVyUG9seWdvbi0+d2luZFJ1bGUoKSB8fCB2YWx1ZXMo KS5zaXplKCkgIT0gb3RoZXJQb2x5Z29uLT52YWx1ZXMoKS5zaXplKCkpCisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdmFsdWVzKCkuc2l6 ZSgpOyBpKyspCisgICAgICAgICAgICBpZiAoZ2V0WEF0KGkpICE9IG90aGVyUG9seWdvbi0+Z2V0 WEF0KGkpIHx8IGdldFlBdChpKSAhPSBvdGhlclBvbHlnb24tPmdldFlBdChpKSkKKyAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KIHByaXZh dGU6CiAgICAgQmFzaWNTaGFwZVBvbHlnb24oKQogICAgICAgICA6IG1fd2luZFJ1bGUoUlVMRV9O T05aRVJPKQpAQCAtMjEyLDYgKzI1MCwxNSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBQYXNzUmVm UHRyPEJhc2ljU2hhcGU+IGJsZW5kKGNvbnN0IEJhc2ljU2hhcGUqLCBkb3VibGUpIGNvbnN0IE9W RVJSSURFOwogCiAgICAgdmlydHVhbCBUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVybiBCYXNpY1No YXBlSW5zZXRSZWN0YW5nbGVUeXBlOyB9CisgICAgdmlydHVhbCBib29sIG9wZXJhdG9yPT0oY29u c3QgQmFzaWNTaGFwZSYgb3RoZXIpCisgICAgeworICAgICAgICBpZiAob3RoZXIudHlwZSgpICE9 IEJhc2ljU2hhcGVJbnNldFJlY3RhbmdsZVR5cGUpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIGNvbnN0IEJhc2ljU2hhcGVJbnNldFJlY3RhbmdsZSogb3RoZXJSZWN0YW5nbGUg PSBzdGF0aWNfY2FzdDxjb25zdCBCYXNpY1NoYXBlSW5zZXRSZWN0YW5nbGUqPigmb3RoZXIpOwor ICAgICAgICByZXR1cm4gdG9wKCkgPT0gb3RoZXJSZWN0YW5nbGUtPnRvcCgpICYmIHJpZ2h0KCkg PT0gb3RoZXJSZWN0YW5nbGUtPnJpZ2h0KCkKKyAgICAgICAgICAgICYmIGJvdHRvbSgpID09IG90 aGVyUmVjdGFuZ2xlLT5ib3R0b20oKSAmJiBsZWZ0KCkgPT0gb3RoZXJSZWN0YW5nbGUtPmxlZnQo KQorICAgICAgICAgICAgJiYgY29ybmVyUmFkaXVzWCgpID09IG90aGVyUmVjdGFuZ2xlLT5jb3Ju ZXJSYWRpdXNYKCkgJiYgY29ybmVyUmFkaXVzWSgpID09IG90aGVyUmVjdGFuZ2xlLT5jb3JuZXJS YWRpdXNZKCk7CisgICAgfQogcHJpdmF0ZToKICAgICBCYXNpY1NoYXBlSW5zZXRSZWN0YW5nbGUo KSB7IH0KIAo=