92126 2012-07-24 09:05:27 -0700 Android-chromium layout tests failing with GPU related crash 2012-07-24 12:40:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 benm peter abarth dpranke ojan peter wangxianzhu webkit.review.bot oldest_to_newest 676885 0 benm 2012-07-24 09:05:27 -0700 It appears that the --enable-hardware-gpu flag is not being propogated into Android's DRT correctly, which means that we end up falling back to the software renderer, which leads to CHECK failures in chromium code. If I hardcode the --enable-hardware-gpu flag on in DRT with the following patch: --- a/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp +++ b/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp @@ -201,6 +203,7 @@ int main(int argc, char* argv[]) return EXIT_FAILURE; } + hardwareAcceleratedGL = true; webkit_support::SetUpGLBindings(hardwareAcceleratedGL ? webkit_support::GL_BINDING_DEFAULT : webkit_support::GL_BINDING_SOFTWARE_RENDERER); if (startupDialog) I don't see the crashes. 676903 1 peter 2012-07-24 09:21:37 -0700 I found the issue and will upload a patch soon. Just trying to figure out how to run the unit tests now.. 676912 2 154085 peter 2012-07-24 09:33:48 -0700 Created attachment 154085 Patch 676935 3 peter 2012-07-24 10:05:09 -0700 Ben verified that this fixes the issue :). 677114 4 154085 webkit.review.bot 2012-07-24 12:40:47 -0700 Comment on attachment 154085 Patch Clearing flags on attachment: 154085 Committed r123507: <http://trac.webkit.org/changeset/123507> 677115 5 webkit.review.bot 2012-07-24 12:40:51 -0700 All reviewed patches have been landed. Closing bug. 154085 2012-07-24 09:33:48 -0700 2012-07-24 12:40:46 -0700 Patch bug-92126-20120724173339.patch text/plain 4042 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzEyNGEzZWQzMGQ4ZGNjNTBlMDhlNDNmYTRmMDhkNDlh YTFmYWRkMy4uN2I5ZjhjODkxNmIzZmFlZGU1MjdhNzYyMjdhZjNjYTU3OTMzOTNmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDEyLTA3LTI0ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBBbmRyb2lkLWNocm9taXVtIGxheW91dCB0ZXN0cyBmYWlsaW5nIHdpdGggR1BVIHJl bGF0ZWQgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkyMTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIHN1cHBvcnQgZm9yIHRoZSAiLS1lbmFibGUtaGFyZHdhcmUtZ3B1IiBmbGFnIGZy b20gcnVuX3dlYmtpdF90ZXN0cywKKyAgICAgICAgYXMgaXQncyBub3QgYmVpbmcgdXNlZCBieSBh bnkgcG9ydCBhbnltb3JlLCBhbmQgbmVpdGhlciBpcyBiZWluZyBwYXNzZWQKKyAgICAgICAgb24g dG8gdGhlIHRlc3QgcnVubmVyLiBJbnN0ZWFkLCBhcHBlbmQgdGhlIGZsYWcgZGlyZWN0bHkgdG8g RFJUIGZvciB0aGUKKyAgICAgICAgQ2hyb21pdW0gQW5kcm9pZCBwb3J0LCB3aGljaCBkb2VzIHJl bHkgb24gdGhpcyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgIFRoZSBDaHJvbWl1bUFuZHJvaWRV bml0VGVzdCB0ZXN0cyBkaWRuJ3QgY2F0Y2ggdGhpcyBhcyB0aGUgcHJvcGVydHkgd2FzCisgICAg ICAgIHNldCB0byBUcnVlLCBidXQgaXQncyB1bmFibGUgdG8gZGV0ZWN0IHdoZXRoZXIgdGhleSds bCBhY3R1YWxseSBiZSB1c2VkLgorICAgICAgICBObyBvY2N1cnJhbmNlcyBvZiAiLS1lbmFibGUt aGFyZHdhcmUtZ3B1IiBleGlzdCBpbiBlaXRoZXIgVG9vbHMvU2NyaXB0cy8KKyAgICAgICAgb3Ig VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvLCBzbyBub3RoaW5nIHVwc3RyZWFtIHNlZW1zIHRvIHJl bHkgb24gdGhlIGZsYWcuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQb3J0 Ll9faW5pdF9fKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX2FuZHJvaWRfdW5pdHRlc3QucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRQ b3J0VGVzdC50ZXN0X2F0dHJpYnV0ZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChwYXJzZV9hcmdzKToKKwog MjAxMi0wNy0yNCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAK ICAgICAgICAgW1F0XSBNU1ZDOiB1bnJlc29sdmVkIGV4dGVybmFsIHN5bWJvbCBfX0RsbE1haW5D UlRTdGFydHVwQDEyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKaW5kZXggZWI0ZGNlYzk1NTYyYzVh NDA4ODc3MjRmMGJhNzlhZDVjYmEwYmQ3Zi4uNWI0OGZmMGY0YjhiY2IzYzI3Mzk1NTI5NTQ2YmYx ZDRhZDE3ZDFlZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weQpAQCAtMTYxLDcgKzE2MSw3IEBA IGNsYXNzIENocm9taXVtQW5kcm9pZFBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0KToKICAgICAg ICAgc2VsZi5fb3B0aW9ucy5hZGRpdGlvbmFsX2RydF9mbGFnLmFwcGVuZCgnLS1lbmNvZGUtYmlu YXJ5JykKIAogICAgICAgICAjIFRoZSBDaHJvbWl1bSBwb3J0IGZvciBBbmRyb2lkIGFsd2F5cyB1 c2VzIHRoZSBoYXJkd2FyZSBHUFUgcGF0aC4KLSAgICAgICAgc2VsZi5fb3B0aW9ucy5lbmFibGVf aGFyZHdhcmVfZ3B1ID0gVHJ1ZQorICAgICAgICBzZWxmLl9vcHRpb25zLmFkZGl0aW9uYWxfZHJ0 X2ZsYWcuYXBwZW5kKCctLWVuYWJsZS1oYXJkd2FyZS1ncHUnKQogCiAgICAgICAgICMgU2hhcmQg cmVmIHRlc3RzIHNvIHRoYXQgdGhleSBydW4gdG9nZXRoZXIgdG8gYXZvaWQgcmVwZWF0ZWRseSBk cml2ZXIgcmVzdGFydHMuCiAgICAgICAgIHNlbGYuX29wdGlvbnMuc2hhcmRfcmVmX3Rlc3RzID0g VHJ1ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV9hbmRyb2lkX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkX3VuaXR0ZXN0LnB5CmluZGV4IDBlMjgw MWE1NzNmZjAxMDhhZDIwNTAxYjRlZTZjZjNlZWE1MTg5OTMuLmNlNzQ4MDUwMjFlZTM5OTAzNWE2 Yzg1ZWZmY2I1MTliNmU3MTc1MjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZF91bml0dGVzdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWRfdW5p dHRlc3QucHkKQEAgLTQ4LDcgKzQ4LDYgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydFRlc3Qo Y2hyb21pdW1fcG9ydF90ZXN0Y2FzZS5DaHJvbWl1bVBvcnRUZXN0Q2FzZSk6CiAKICAgICBkZWYg dGVzdF9hdHRyaWJ1dGVzKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQot ICAgICAgICBzZWxmLmFzc2VydFRydWUocG9ydC5nZXRfb3B0aW9uKCdlbmFibGVfaGFyZHdhcmVf Z3B1JykpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfcGF0aCgpLCBw b3J0Ll93ZWJraXRfYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0tYW5kcm9pZCcpKQogCiAgICAgZGVm IHRlc3RfZGVmYXVsdF90aW1lb3V0X21zKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggNDU1YThj MmRjMjViMjdlNmRlNTRlNzVlMDEwOGEwZDFjMmRhMGE1My4uNWVhZjMxMjIxOTBhZWU0MWVhMzY4 MzJhMTkxYzEzNWQxOTZhNDAzZSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0yNDYsMTAgKzI0Niw2IEBA IGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgICAgICBhY3Rpb249InN0b3JlX3Ry dWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgIGhlbHA9IlVzZSBo YXJkd2FyZSBhY2NlbGVyYXRlZCBwYWludGluZyBvZiBjb21wb3NpdGVkIHBhZ2VzIiksCi0gICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWVuYWJsZS1oYXJkd2FyZS1ncHUiLAotICAgICAg ICAgICAgYWN0aW9uPSJzdG9yZV90cnVlIiwKLSAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCi0g ICAgICAgICAgICBoZWxwPSJSdW4gZ3JhcGhpY3MgdGVzdHMgb24gcmVhbCBHUFUgaGFyZHdhcmUg dnMgc29mdHdhcmUiKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tcGVyLXRpbGUt cGFpbnRpbmciLAogICAgICAgICAgICAgYWN0aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAg IGhlbHA9IlVzZSBwZXItdGlsZSBwYWludGluZyBvZiBjb21wb3NpdGVkIHBhZ2VzIiksCg==