92103 2012-07-24 05:44:29 -0700 HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz 2012-07-24 07:41:13 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91853 1 d-r d-r eric gustavo jochen kenneth morrita pnormand rniwa webkit.review.bot oldest_to_newest 676705 0 d-r 2012-07-24 05:44:29 -0700 I'd suggest to include the header instead. 676711 1 154030 d-r 2012-07-24 05:50:21 -0700 Created attachment 154030 Patch 676721 2 154030 jochen 2012-07-24 06:00:02 -0700 Comment on attachment 154030 Patch The patch looks good View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35 > +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0. I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough. 676749 3 154042 d-r 2012-07-24 06:32:05 -0700 Created attachment 154042 Including header instead of fw declarations. 676750 4 d-r 2012-07-24 06:32:47 -0700 (In reply to comment #2) > (From update of attachment 154030 [details]) > The patch looks good > > View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review > > > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35 > > +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0. > > I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough. Done. Thanks for taking a look. 676800 5 154042 webkit.review.bot 2012-07-24 07:41:08 -0700 Comment on attachment 154042 Including header instead of fw declarations. Clearing flags on attachment: 154042 Committed r123475: <http://trac.webkit.org/changeset/123475> 676801 6 webkit.review.bot 2012-07-24 07:41:13 -0700 All reviewed patches have been landed. Closing bug. 154030 2012-07-24 05:50:21 -0700 2012-07-24 06:31:57 -0700 Patch bug-92103-20120724155229.patch text/plain 1861 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM5ODFkMTFjNGRhZWRm Yjg3MjA1YzI1ODhkMDI4OTgxYTY1N2U0MC4uOGJjZDY3ZmMwNzE0ZWVjOGMxZmE3NmFmZTM1OWUx Y2VhYzJiNGNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI0ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg SGFyZkJ1enpGYWNlTkcuaCBmb3J3YXJkIGRlY2xhcmF0aW9ucyBjb25mbGljdCB3aXRoIG5ld2Vy IHZlcnNpb25zIG9mIEhhcmZidXp6CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MjEwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFzIHByZXBhcmF0aW9uIGZvciBlbmFibGluZyBoYXJmYnV6ei1uZyBmb3Ig RUZMLCBJIHdvdWxkIGxpa2UgdG8gaW5jbHVkZSB0aGUgaGVhZGVyCisgICAgICAgIGhlcmUgc2lu Y2UgdGhlIGZvcndhcmQgZGVjbGFyYXRpb25zIGFyZSBjb25mbGljdGluZyB3aXRoIHRoZSBoYXJm YnV6eiB2ZXJzaW9uCisgICAgICAgIHdlIHdpbGwgdXNlIGZvciBFRkwuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ek5HRmFjZS5oOgorCiAyMDEyLTA3LTI0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXBsYWNlIHNvbWUgY2Fs bHNpdGVzIG9mIHNoYWRvd0FuY2VzdG9yTm9kZSgpIHdpdGggc2hhZG93SG9zdCgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 ek5HRmFjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcv SGFyZkJ1enpOR0ZhY2UuaAppbmRleCBmM2M2MzVhZjA5NzJiN2FkNmQyYjc1MDYyZDkxYzFjNzA3 YTIyYzMwLi5iNzRmOTc3ZWFlZmE5ZDQ3MmExNGE4ZjVlYjhlMTAzZmFmNGQ1MWU3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 ek5HRmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6 L25nL0hhcmZCdXp6TkdGYWNlLmgKQEAgLTMxLDE1ICszMSwxMyBAQAogI2lmbmRlZiBIYXJmQnV6 ek5HRmFjZV9oCiAjZGVmaW5lIEhhcmZCdXp6TkdGYWNlX2gKIAorLy8gSW5jbHVkaW5nIHRoZSB3 aG9sZSBoZWFkZXIgaGVyZSBpbnN0ZWFkIG9mIGRvaW5nIGZvcndhcmQgZGVjbGFyYXRpb25zLCBz aW5jZSBDaHJvbWl1bSdzIGhhcmZidXp6IHZlcnNpb24KKy8vIHVzZXMgZGlmZmVyZW50IHR5cGVk ZWZzIGZvciBoYl9mb250X3QgYW5kIGhiX2ZhY2VfdCBjb21wYXJlZCB0byBoYXJmYnV6eiByZWxl YXNlIDAuOS4wLgorI2luY2x1ZGUgPGhiLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4K ICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAot c3RydWN0IF9oYl9mYWNlX3Q7Ci10eXBlZGVmIF9oYl9mYWNlX3QgaGJfZmFjZV90Owotc3RydWN0 IF9oYl9mb250X3Q7Ci10eXBlZGVmIF9oYl9mb250X3QgaGJfZm9udF90OwotCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIGNsYXNzIEZvbnRQbGF0Zm9ybURhdGE7Cg== 154042 2012-07-24 06:32:05 -0700 2012-07-24 07:41:07 -0700 Including header instead of fw declarations. bug-92103-20120724163413.patch text/plain 1660 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM5ODFkMTFjNGRhZWRm Yjg3MjA1YzI1ODhkMDI4OTgxYTY1N2U0MC4uOGJjZDY3ZmMwNzE0ZWVjOGMxZmE3NmFmZTM1OWUx Y2VhYzJiNGNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTI0ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg SGFyZkJ1enpGYWNlTkcuaCBmb3J3YXJkIGRlY2xhcmF0aW9ucyBjb25mbGljdCB3aXRoIG5ld2Vy IHZlcnNpb25zIG9mIEhhcmZidXp6CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MjEwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFzIHByZXBhcmF0aW9uIGZvciBlbmFibGluZyBoYXJmYnV6ei1uZyBmb3Ig RUZMLCBJIHdvdWxkIGxpa2UgdG8gaW5jbHVkZSB0aGUgaGVhZGVyCisgICAgICAgIGhlcmUgc2lu Y2UgdGhlIGZvcndhcmQgZGVjbGFyYXRpb25zIGFyZSBjb25mbGljdGluZyB3aXRoIHRoZSBoYXJm YnV6eiB2ZXJzaW9uCisgICAgICAgIHdlIHdpbGwgdXNlIGZvciBFRkwuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6ek5HRmFjZS5oOgorCiAyMDEyLTA3LTI0ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXBsYWNlIHNvbWUgY2Fs bHNpdGVzIG9mIHNoYWRvd0FuY2VzdG9yTm9kZSgpIHdpdGggc2hhZG93SG9zdCgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 ek5HRmFjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcv SGFyZkJ1enpOR0ZhY2UuaAppbmRleCBmM2M2MzVhZjA5NzJiN2FkNmQyYjc1MDYyZDkxYzFjNzA3 YTIyYzMwLi5iNmU5MWUyZWIxYjkzNDRhY2YyOGM2NGEwNGM3ZWUwOWFhNDMyYTg5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 ek5HRmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6 L25nL0hhcmZCdXp6TkdGYWNlLmgKQEAgLTMxLDE1ICszMSwxMSBAQAogI2lmbmRlZiBIYXJmQnV6 ek5HRmFjZV9oCiAjZGVmaW5lIEhhcmZCdXp6TkdGYWNlX2gKIAorI2luY2x1ZGUgPGhiLmg+CiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgog I2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KIAotc3RydWN0IF9oYl9mYWNlX3Q7Ci10eXBlZGVmIF9o Yl9mYWNlX3QgaGJfZmFjZV90Owotc3RydWN0IF9oYl9mb250X3Q7Ci10eXBlZGVmIF9oYl9mb250 X3QgaGJfZm9udF90OwotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEZvbnRQbGF0Zm9y bURhdGE7Cg==