92077 2012-07-24 01:11:25 -0700 [EFL][WK2] Fix possible crash in didSendRequestForResource 2012-07-24 02:22:00 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 91345 1 cdumez cdumez gyuyoung.kim kenneth tonikitoo webkit.review.bot oldest_to_newest 676496 0 cdumez 2012-07-24 01:11:25 -0700 In ewk_view_resource_load_client's didSendRequestForResource(), we need to check that the wkRedirectResponse is not NULL before using it. The redirect response may indeed may NULL if there was no redirection. 676502 1 153984 cdumez 2012-07-24 01:19:13 -0700 Created attachment 153984 Patch 676507 2 153984 kenneth 2012-07-24 01:24:46 -0700 Comment on attachment 153984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153984&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.h:164 > + Ewk_Url_Response *redirect_response; /**< Possible redirect response for the resource (may be @c NULL) */ Redirect response if a redirect occurred or NULL (or similar) 676511 3 153985 cdumez 2012-07-24 01:30:12 -0700 Created attachment 153985 Patch for landing Fixed Kenneth's nit. Could someone please cq+ ? 676555 4 153985 webkit.review.bot 2012-07-24 02:21:55 -0700 Comment on attachment 153985 Patch for landing Clearing flags on attachment: 153985 Committed r123444: <http://trac.webkit.org/changeset/123444> 676556 5 webkit.review.bot 2012-07-24 02:22:00 -0700 All reviewed patches have been landed. Closing bug. 153984 2012-07-24 01:19:13 -0700 2012-07-24 01:30:12 -0700 Patch 92077_didSendRequestForResource_crash.patch text/plain 3147 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZTI0Y2Q1Li4xZjhhNjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZpeCBwb3NzaWJsZSBjcmFzaCBpbiBkaWRTZW5k UmVxdWVzdEZvclJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MjA3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBOVUxMIGNoZWNrIGZvciB3a1JlZGlyZWN0UmVzcG9uc2UgaW4KKyAgICAg ICAgZGlkU2VuZFJlcXVlc3RGb3JSZXNvdXJjZSgpIGJlZm9yZSB1c2luZyBpdC4gVGhlCisgICAg ICAgIGFyZ3VtZW50IG1heSBiZSBOVUxMIGlmIHRoZXJlIHdhcyBubyByZWRpcmVjdGlvbi4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3Lmg6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3BwOgorICAgICAgICAo ZGlkU2VuZFJlcXVlc3RGb3JSZXNvdXJjZSk6CisKIDIwMTItMDctMjMgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMjMxODQsIHIxMjMxOTUsIGFuZCByMTIzMTk3LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKaW5kZXggNmE4ZTc0Zi4uODY1NGY2MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBAIC0xNjEsNyArMTYx LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgX0V3a19XZWJfUmVzb3VyY2VfUmVxdWVzdCBFd2tfV2ViX1Jl c291cmNlX1JlcXVlc3Q7CiBzdHJ1Y3QgX0V3a19XZWJfUmVzb3VyY2VfUmVxdWVzdCB7CiAgICAg RXdrX1dlYl9SZXNvdXJjZSAqcmVzb3VyY2U7IC8qKjwgcmVzb3VyY2UgYmVpbmcgcmVxdWVzdGVk ICovCiAgICAgRXdrX1VybF9SZXF1ZXN0ICpyZXF1ZXN0OyAvKio8IFVSTCByZXF1ZXN0IGZvciB0 aGUgcmVzb3VyY2UgKi8KLSAgICBFd2tfVXJsX1Jlc3BvbnNlICpyZWRpcmVjdF9yZXNwb25zZTsg LyoqPCBQb3NzaWJsZSByZWRpcmVjdCByZXNwb25zZSBmb3IgdGhlIHJlc291cmNlICovCisgICAg RXdrX1VybF9SZXNwb25zZSAqcmVkaXJlY3RfcmVzcG9uc2U7IC8qKjwgUG9zc2libGUgcmVkaXJl Y3QgcmVzcG9uc2UgZm9yIHRoZSByZXNvdXJjZSAobWF5IGJlIEBjIE5VTEwpICovCiB9OwogCiAv Ly8gQ3JlYXRlcyBhIHR5cGUgbmFtZSBmb3IgX0V3a19XZWJfUmVzb3VyY2VfTG9hZF9SZXNwb25z ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 X3Jlc291cmNlX2xvYWRfY2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3X3Jlc291cmNlX2xvYWRfY2xpZW50LmNwcAppbmRleCA1MDViYmVkLi4xMTNl MTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll d19yZXNvdXJjZV9sb2FkX2NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3BwCkBAIC00NCw2ICs0NCw3 IEBACiAjaW5jbHVkZSAiZXdrX3dlYl9yZXNvdXJjZV9wcml2YXRlLmgiCiAjaW5jbHVkZSA8d3Rm L3RleHQvQ1N0cmluZy5oPgogCit1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVz cGFjZSBXZWJLaXQ7CiAKIHN0YXRpYyBpbmxpbmUgRXZhc19PYmplY3QqIHRvRXdrVmlldyhjb25z dCB2b2lkKiBjbGllbnRJbmZvKQpAQCAtNjYsMTAgKzY3LDExIEBAIHN0YXRpYyB2b2lkIGRpZElu aXRpYXRlTG9hZEZvclJlc291cmNlKFdLUGFnZVJlZiwgV0tGcmFtZVJlZiB3a0ZyYW1lLCB1aW50 NjRfdCByCiBzdGF0aWMgdm9pZCBkaWRTZW5kUmVxdWVzdEZvclJlc291cmNlKFdLUGFnZVJlZiwg V0tGcmFtZVJlZiwgdWludDY0X3QgcmVzb3VyY2VJZGVudGlmaWVyLCBXS1VSTFJlcXVlc3RSZWYg d2tSZXF1ZXN0LCBXS1VSTFJlc3BvbnNlUmVmIHdrUmVkaXJlY3RSZXNwb25zZSwgY29uc3Qgdm9p ZCogY2xpZW50SW5mbykKIHsKICAgICBFd2tfVXJsX1JlcXVlc3QqIHJlcXVlc3QgPSBld2tfdXJs X3JlcXVlc3RfbmV3KHdrUmVxdWVzdCk7Ci0gICAgRXdrX1VybF9SZXNwb25zZSogcmVkaXJlY3RS ZXNwb25zZSA9IGV3a191cmxfcmVzcG9uc2VfbmV3KHRvSW1wbCh3a1JlZGlyZWN0UmVzcG9uc2Up LT5yZXNvdXJjZVJlc3BvbnNlKCkpOworICAgIEV3a19VcmxfUmVzcG9uc2UqIHJlZGlyZWN0UmVz cG9uc2UgPSB3a1JlZGlyZWN0UmVzcG9uc2UgPyBld2tfdXJsX3Jlc3BvbnNlX25ldyh0b0ltcGwo d2tSZWRpcmVjdFJlc3BvbnNlKS0+cmVzb3VyY2VSZXNwb25zZSgpKSA6IDA7CiAgICAgZXdrX3Zp ZXdfcmVzb3VyY2VfcmVxdWVzdF9zZW50KHRvRXdrVmlldyhjbGllbnRJbmZvKSwgcmVzb3VyY2VJ ZGVudGlmaWVyLCByZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKICAgICBld2tfdXJsX3JlcXVl c3RfdW5yZWYocmVxdWVzdCk7Ci0gICAgZXdrX3VybF9yZXNwb25zZV91bnJlZihyZWRpcmVjdFJl c3BvbnNlKTsKKyAgICBpZiAocmVkaXJlY3RSZXNwb25zZSkKKyAgICAgICAgZXdrX3VybF9yZXNw b25zZV91bnJlZihyZWRpcmVjdFJlc3BvbnNlKTsKIH0KIAogc3RhdGljIHZvaWQgZGlkUmVjZWl2 ZVJlc3BvbnNlRm9yUmVzb3VyY2UoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCB1aW50NjRfdCByZXNv dXJjZUlkZW50aWZpZXIsIFdLVVJMUmVzcG9uc2VSZWYgd2tSZXNwb25zZSwgY29uc3Qgdm9pZCog Y2xpZW50SW5mbykK 153985 2012-07-24 01:30:12 -0700 2012-07-24 02:21:55 -0700 Patch for landing 92077_didSendRequestForResource_crash.patch text/plain 3153 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZTI0Y2Q1Li5jNzU2NDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMjQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZpeCBwb3NzaWJsZSBjcmFzaCBpbiBkaWRTZW5k UmVxdWVzdEZvclJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MjA3NworCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hy aXN0aWFuc2VuLgorCisgICAgICAgIEFkZCBOVUxMIGNoZWNrIGZvciB3a1JlZGlyZWN0UmVzcG9u c2UgaW4KKyAgICAgICAgZGlkU2VuZFJlcXVlc3RGb3JSZXNvdXJjZSgpIGJlZm9yZSB1c2luZyBp dC4gVGhlCisgICAgICAgIGFyZ3VtZW50IG1heSBiZSBOVUxMIGlmIHRoZXJlIHdhcyBubyByZWRp cmVjdGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3Lmg6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3Bw OgorICAgICAgICAoZGlkU2VuZFJlcXVlc3RGb3JSZXNvdXJjZSk6CisKIDIwMTItMDctMjMgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjMxODQsIHIxMjMxOTUsIGFuZCByMTIzMTk3LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKaW5kZXggNmE4ZTc0Zi4uOTI0 ZGJjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Zp ZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBA IC0xNjEsNyArMTYxLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgX0V3a19XZWJfUmVzb3VyY2VfUmVxdWVz dCBFd2tfV2ViX1Jlc291cmNlX1JlcXVlc3Q7CiBzdHJ1Y3QgX0V3a19XZWJfUmVzb3VyY2VfUmVx dWVzdCB7CiAgICAgRXdrX1dlYl9SZXNvdXJjZSAqcmVzb3VyY2U7IC8qKjwgcmVzb3VyY2UgYmVp bmcgcmVxdWVzdGVkICovCiAgICAgRXdrX1VybF9SZXF1ZXN0ICpyZXF1ZXN0OyAvKio8IFVSTCBy ZXF1ZXN0IGZvciB0aGUgcmVzb3VyY2UgKi8KLSAgICBFd2tfVXJsX1Jlc3BvbnNlICpyZWRpcmVj dF9yZXNwb25zZTsgLyoqPCBQb3NzaWJsZSByZWRpcmVjdCByZXNwb25zZSBmb3IgdGhlIHJlc291 cmNlICovCisgICAgRXdrX1VybF9SZXNwb25zZSAqcmVkaXJlY3RfcmVzcG9uc2U7IC8qKjwgUG9z c2libGUgcmVkaXJlY3QgcmVzcG9uc2UgZm9yIHRoZSByZXNvdXJjZSBvciBAYyBOVUxMICovCiB9 OwogCiAvLy8gQ3JlYXRlcyBhIHR5cGUgbmFtZSBmb3IgX0V3a19XZWJfUmVzb3VyY2VfTG9hZF9S ZXNwb25zZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3X3Jlc291cmNlX2xvYWRfY2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3X3Jlc291cmNlX2xvYWRfY2xpZW50LmNwcAppbmRleCA1MDViYmVk Li4xMTNlMTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlld19yZXNvdXJjZV9sb2FkX2NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcmVzb3VyY2VfbG9hZF9jbGllbnQuY3BwCkBAIC00NCw2 ICs0NCw3IEBACiAjaW5jbHVkZSAiZXdrX3dlYl9yZXNvdXJjZV9wcml2YXRlLmgiCiAjaW5jbHVk ZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCit1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5n IG5hbWVzcGFjZSBXZWJLaXQ7CiAKIHN0YXRpYyBpbmxpbmUgRXZhc19PYmplY3QqIHRvRXdrVmll dyhjb25zdCB2b2lkKiBjbGllbnRJbmZvKQpAQCAtNjYsMTAgKzY3LDExIEBAIHN0YXRpYyB2b2lk IGRpZEluaXRpYXRlTG9hZEZvclJlc291cmNlKFdLUGFnZVJlZiwgV0tGcmFtZVJlZiB3a0ZyYW1l LCB1aW50NjRfdCByCiBzdGF0aWMgdm9pZCBkaWRTZW5kUmVxdWVzdEZvclJlc291cmNlKFdLUGFn ZVJlZiwgV0tGcmFtZVJlZiwgdWludDY0X3QgcmVzb3VyY2VJZGVudGlmaWVyLCBXS1VSTFJlcXVl c3RSZWYgd2tSZXF1ZXN0LCBXS1VSTFJlc3BvbnNlUmVmIHdrUmVkaXJlY3RSZXNwb25zZSwgY29u c3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICBFd2tfVXJsX1JlcXVlc3QqIHJlcXVlc3QgPSBl d2tfdXJsX3JlcXVlc3RfbmV3KHdrUmVxdWVzdCk7Ci0gICAgRXdrX1VybF9SZXNwb25zZSogcmVk aXJlY3RSZXNwb25zZSA9IGV3a191cmxfcmVzcG9uc2VfbmV3KHRvSW1wbCh3a1JlZGlyZWN0UmVz cG9uc2UpLT5yZXNvdXJjZVJlc3BvbnNlKCkpOworICAgIEV3a19VcmxfUmVzcG9uc2UqIHJlZGly ZWN0UmVzcG9uc2UgPSB3a1JlZGlyZWN0UmVzcG9uc2UgPyBld2tfdXJsX3Jlc3BvbnNlX25ldyh0 b0ltcGwod2tSZWRpcmVjdFJlc3BvbnNlKS0+cmVzb3VyY2VSZXNwb25zZSgpKSA6IDA7CiAgICAg ZXdrX3ZpZXdfcmVzb3VyY2VfcmVxdWVzdF9zZW50KHRvRXdrVmlldyhjbGllbnRJbmZvKSwgcmVz b3VyY2VJZGVudGlmaWVyLCByZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKICAgICBld2tfdXJs X3JlcXVlc3RfdW5yZWYocmVxdWVzdCk7Ci0gICAgZXdrX3VybF9yZXNwb25zZV91bnJlZihyZWRp cmVjdFJlc3BvbnNlKTsKKyAgICBpZiAocmVkaXJlY3RSZXNwb25zZSkKKyAgICAgICAgZXdrX3Vy bF9yZXNwb25zZV91bnJlZihyZWRpcmVjdFJlc3BvbnNlKTsKIH0KIAogc3RhdGljIHZvaWQgZGlk UmVjZWl2ZVJlc3BvbnNlRm9yUmVzb3VyY2UoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCB1aW50NjRf dCByZXNvdXJjZUlkZW50aWZpZXIsIFdLVVJMUmVzcG9uc2VSZWYgd2tSZXNwb25zZSwgY29uc3Qg dm9pZCogY2xpZW50SW5mbykK