91804 2012-07-19 20:33:21 -0700 REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms 2012-07-25 18:36:56 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 23346 1 tkent tkent morrita oldest_to_newest 674094 0 tkent 2012-07-19 20:33:21 -0700 http://code.google.com/p/chromium/issues/detail?id=137395 The function createKey() introduced by r121420 can be O(N^2) if a page has multiple form elements with an identical action URL. http://www.reddit.com/r/AskReddit/comments/wjr6y/every_time_i_leave_a_hotel_i_strip_the_beds_fold/ contains 202 <form> elements with action="#". Chromium saves form state whenever a page is scrolled. 674170 1 153412 tkent 2012-07-19 22:33:05 -0700 Created attachment 153412 Patch 674295 2 153412 morrita 2012-07-20 01:01:45 -0700 Comment on attachment 153412 Patch Okay. I should have caught this at the original review... 674298 3 tkent 2012-07-20 01:04:15 -0700 Committed r123191: <http://trac.webkit.org/changeset/123191> 677312 4 tkent 2012-07-24 16:13:03 -0700 Reverted r123191 for reason: It might cause another performance regression. Committed r123547: <http://trac.webkit.org/changeset/123547> 678716 5 tkent 2012-07-25 18:36:56 -0700 Committed r123691: <http://trac.webkit.org/changeset/123691> 153412 2012-07-19 22:33:05 -0700 2012-07-20 01:01:45 -0700 Patch bug-91804-20120720143301.patch text/plain 4833 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJlZDk3ZDZkNWRkZTRi MWM1YmY5ODQxZGQzYzRjNGUxY2VlYjU4YS4uZDVjMWI3MjlmNjBiNWVmMjI5NzUwN2E4YjYwNzcw MTY1YTk1MGE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA3LTIwICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIxMjE0 MjApOiBQZXJmb3JtYW5jZSByZWdyZXNzaW9uIG9mIGZvcm0gc3RhdGUgc2F2aW5nIGZvciBwYWdl cyB3aXRoIG11bHRpcGxlIGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTgwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBjb21wbGV4aXR5IG9mIEZvcm1LZXlHZW5lcmF0b3I6OmZvcm1LZXko KSB3YXMgTyhOKSB3aGVyZSBOIGlzIHRoZQorICAgICAgICBudW1iZXIgZm9ybSBlbGVtZW50cyB3 aXRoIGFuIGlkZW50aWNhbCBhY3Rpb24gVVJMLCBhbmQgZm9ybUtleSgpIGlzCisgICAgICAgIGNh bGxlZCBmb3IgZXZlcnkgZm9ybS4gU28sIGl0J3MgTyhOXjIpLiBBIHBhZ2UgaW4gd3d3LnJlZGRp dC5jb20KKyAgICAgICAgY29udGFpbnMgaHVuZHJlZHMgb2YgZm9ybSBlbGVtZW50cyB3aXRoIGFj dGlvbj0iIyIuIFNvIEZvcm1Db250cm9sbGVyOjoKKyAgICAgICAgZm9ybUVsZW1lbnRzU3RhdGUo KSB0b29rIGEgZmV3IHNlY29uZHMgb24gYSBzbG93IG1hY2hpbmUuCisKKyAgICAgICAgSW4gb3Jk ZXIgdG8gYXZvaWQgTyhOXjIpIG9wZXJhdGlvbiwgc3RvcmluZyBhIG1hcCBmcm9tIGZvcm0gc2ln bmF0dXJlcworICAgICAgICB0byBuZXh0IGluZGV4IG51bWJlcnMsIGluc3RlYWQgb2Ygc3Rvcmlu ZyBleGlzdGluZyBmb3JtS2V5IHN0cmluZ3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBKdXN0 IGEgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQuCisKKyAgICAgICAgKiBodG1sL0Zvcm1Db250cm9s bGVyLmNwcDoKKyAgICAgICAgKEZvcm1LZXlHZW5lcmF0b3IpOiBSZW1vdmUgbV9leGlzdGluZ0tl eXMuIEFkZCBhIG1hcCBmcm9tIGEgZm9ybQorICAgICAgICBzaWduYXR1cmUgc3RyaW5nIHRvIHRo ZSBuZXh0IGluZGV4IG51bWJlci4KKyAgICAgICAgKFdlYkNvcmU6OmZvcm1TaWduYXR1cmUpOiBS ZXR1cm5zIGEgc2lnbmF0dXJlIHN0cmluZyBmb3IgYSBmb3JtLCB3aXRob3V0CisgICAgICAgIGFu IGluZGV4IG51bWJlci4gVGhpcyBpcyBsaWtlICJhY3Rpb25VUkwgW25hbWUxIG5hbWUyIF0iCisg ICAgICAgIChXZWJDb3JlOjpGb3JtS2V5R2VuZXJhdG9yOjpmb3JtS2V5KToKKyAgICAgICAgQ3Jl YXRlcyBhIGZvcm1LZXkgc3RyaW5nIGJ5IGNvbmNhdGVuYXRpbmcgYSBmb3JtU2lnbmF0dXJlIGFu ZCAjbi4gTiBpcworICAgICAgICBvYnRhaW5lZCBmcm9tIG1fZm9ybVNpZ25hdHVyZVRvTmV4dElu ZGV4TWFwIGluIE8oMSkuCisgICAgICAgIChXZWJDb3JlOjpGb3JtS2V5R2VuZXJhdG9yOjp3aWxs RGVsZXRlRm9ybSk6CisgICAgICAgIFJlbW92ZSB0aGUgY29kZSBmb3IgbV9leGlzdGluZ0tleXMu CisKIDIwMTItMDctMTkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIEZvcm0gc3RhdGUgcmVzdG9yZTogTmVlZCB0byBpZGVudGlmeSBhIGZvcm0gYnkgaXRzIGNv bnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5jcHAKaW5kZXggMzU1OTRiODk3 NmQ5MTcwZTEwMmVlNTgyZDhjNGJkNDFhZGZjYWU3Yi4uNWUzOWZlMjI5MzliNzQ5NDBlYzU0NDk0 MTY4ZWQ5YzUyODliYzk3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29udHJvbGxlci5jcHAK QEAgLTI3OCw4ICsyNzgsOSBAQCBwcml2YXRlOgogICAgIEZvcm1LZXlHZW5lcmF0b3IoKSB7IH0K IAogICAgIHR5cGVkZWYgSGFzaE1hcDxIVE1MRm9ybUVsZW1lbnQqLCBBdG9taWNTdHJpbmc+IEZv cm1Ub0tleU1hcDsKKyAgICB0eXBlZGVmIEhhc2hNYXA8U3RyaW5nLCB1bnNpZ25lZD4gRm9ybVNp Z25hdHVyZVRvTmV4dEluZGV4TWFwOwogICAgIEZvcm1Ub0tleU1hcCBtX2Zvcm1Ub0tleU1hcDsK LSAgICBIYXNoU2V0PEF0b21pY1N0cmluZz4gbV9leGlzdGluZ0tleXM7CisgICAgRm9ybVNpZ25h dHVyZVRvTmV4dEluZGV4TWFwIG1fZm9ybVNpZ25hdHVyZVRvTmV4dEluZGV4TWFwOwogfTsKIAog c3RhdGljIGlubGluZSB2b2lkIHJlY29yZEZvcm1TdHJ1Y3R1cmUoY29uc3QgSFRNTEZvcm1FbGVt ZW50JiBmb3JtLCBTdHJpbmdCdWlsZGVyJiBidWlsZGVyKQpAQCAtMzA0LDEwICszMDUsOSBAQCBz dGF0aWMgaW5saW5lIHZvaWQgcmVjb3JkRm9ybVN0cnVjdHVyZShjb25zdCBIVE1MRm9ybUVsZW1l bnQmIGZvcm0sIFN0cmluZ0J1aWxkZQogICAgIGJ1aWxkZXIuYXBwZW5kKCJdIik7CiB9CiAKLXN0 YXRpYyBpbmxpbmUgQXRvbWljU3RyaW5nIGNyZWF0ZUtleShIVE1MRm9ybUVsZW1lbnQqIGZvcm0s IHVuc2lnbmVkIGluZGV4KQorc3RhdGljIGlubGluZSBTdHJpbmcgZm9ybVNpZ25hdHVyZShjb25z dCBIVE1MRm9ybUVsZW1lbnQmIGZvcm0pCiB7Ci0gICAgQVNTRVJUKGZvcm0pOwotICAgIEtVUkwg YWN0aW9uVVJMID0gZm9ybS0+Z2V0VVJMQXR0cmlidXRlKGFjdGlvbkF0dHIpOworICAgIEtVUkwg YWN0aW9uVVJMID0gZm9ybS5nZXRVUkxBdHRyaWJ1dGUoYWN0aW9uQXR0cik7CiAgICAgLy8gUmVt b3ZlIHRoZSBxdWVyeSBwYXJ0IGJlY2F1c2UgaXQgbWlnaHQgY29udGFpbiB2b2xhdGlsZSBwYXJh bWV0ZXJzIHN1Y2gKICAgICAvLyBhcyBhIHNlc3Npb24ga2V5LgogICAgIGFjdGlvblVSTC5zZXRR dWVyeShTdHJpbmcoKSk7CkBAIC0zMTUsMTEgKzMxNSw4IEBAIHN0YXRpYyBpbmxpbmUgQXRvbWlj U3RyaW5nIGNyZWF0ZUtleShIVE1MRm9ybUVsZW1lbnQqIGZvcm0sIHVuc2lnbmVkIGluZGV4KQog ICAgIGlmICghYWN0aW9uVVJMLmlzRW1wdHkoKSkKICAgICAgICAgYnVpbGRlci5hcHBlbmQoYWN0 aW9uVVJMLnN0cmluZygpKTsKIAotICAgIHJlY29yZEZvcm1TdHJ1Y3R1cmUoKmZvcm0sIGJ1aWxk ZXIpOwotCi0gICAgYnVpbGRlci5hcHBlbmQoIiAjIik7Ci0gICAgYnVpbGRlci5hcHBlbmQoU3Ry aW5nOjpudW1iZXIoaW5kZXgpKTsKLSAgICByZXR1cm4gYnVpbGRlci50b0F0b21pY1N0cmluZygp OworICAgIHJlY29yZEZvcm1TdHJ1Y3R1cmUoZm9ybSwgYnVpbGRlcik7CisgICAgcmV0dXJuIGJ1 aWxkZXIudG9TdHJpbmcoKTsKIH0KIAogQXRvbWljU3RyaW5nIEZvcm1LZXlHZW5lcmF0b3I6OmZv cm1LZXkoY29uc3QgSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZSYgY29udHJvbCkKQEAg LTMzMywxMyArMzMwLDE4IEBAIEF0b21pY1N0cmluZyBGb3JtS2V5R2VuZXJhdG9yOjpmb3JtS2V5 KGNvbnN0IEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGUmIGNvCiAgICAgaWYgKGl0ICE9 IG1fZm9ybVRvS2V5TWFwLmVuZCgpKQogICAgICAgICByZXR1cm4gaXQtPnNlY29uZDsKIAotICAg IEF0b21pY1N0cmluZyBjYW5kaWRhdGVLZXk7Ci0gICAgdW5zaWduZWQgaW5kZXggPSAwOwotICAg IGRvIHsKLSAgICAgICAgY2FuZGlkYXRlS2V5ID0gY3JlYXRlS2V5KGZvcm0sIGluZGV4KyspOwot ICAgIH0gd2hpbGUgKCFtX2V4aXN0aW5nS2V5cy5hZGQoY2FuZGlkYXRlS2V5KS5pc05ld0VudHJ5 KTsKLSAgICBtX2Zvcm1Ub0tleU1hcC5hZGQoZm9ybSwgY2FuZGlkYXRlS2V5KTsKLSAgICByZXR1 cm4gY2FuZGlkYXRlS2V5OworICAgIFN0cmluZyBzaWduYXR1cmUgPSBmb3JtU2lnbmF0dXJlKCpm b3JtKTsKKyAgICBBU1NFUlQoIXNpZ25hdHVyZS5pc051bGwoKSk7CisgICAgRm9ybVNpZ25hdHVy ZVRvTmV4dEluZGV4TWFwOjpBZGRSZXN1bHQgcmVzdWx0ID0gbV9mb3JtU2lnbmF0dXJlVG9OZXh0 SW5kZXhNYXAuYWRkKHNpZ25hdHVyZSwgMCk7CisgICAgdW5zaWduZWQgbmV4dEluZGV4ID0gcmVz dWx0Lml0ZXJhdG9yLT5zZWNvbmQrKzsKKworICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAg ICBidWlsZGVyLmFwcGVuZChzaWduYXR1cmUpOworICAgIGJ1aWxkZXIuYXBwZW5kKCIgIyIpOwor ICAgIGJ1aWxkZXIuYXBwZW5kKFN0cmluZzo6bnVtYmVyKG5leHRJbmRleCkpOworICAgIEF0b21p Y1N0cmluZyBmb3JtS2V5ID0gYnVpbGRlci50b0F0b21pY1N0cmluZygpOworICAgIG1fZm9ybVRv S2V5TWFwLmFkZChmb3JtLCBmb3JtS2V5KTsKKyAgICByZXR1cm4gZm9ybUtleTsKIH0KIAogdm9p ZCBGb3JtS2V5R2VuZXJhdG9yOjp3aWxsRGVsZXRlRm9ybShIVE1MRm9ybUVsZW1lbnQqIGZvcm0p CkBAIC0zNTAsNyArMzUyLDYgQEAgdm9pZCBGb3JtS2V5R2VuZXJhdG9yOjp3aWxsRGVsZXRlRm9y bShIVE1MRm9ybUVsZW1lbnQqIGZvcm0pCiAgICAgRm9ybVRvS2V5TWFwOjppdGVyYXRvciBpdCA9 IG1fZm9ybVRvS2V5TWFwLmZpbmQoZm9ybSk7CiAgICAgaWYgKGl0ID09IG1fZm9ybVRvS2V5TWFw LmVuZCgpKQogICAgICAgICByZXR1cm47Ci0gICAgbV9leGlzdGluZ0tleXMucmVtb3ZlKGl0LT5z ZWNvbmQpOwogICAgIG1fZm9ybVRvS2V5TWFwLnJlbW92ZShpdCk7CiB9CiAK