91609 2012-07-18 03:25:53 -0700 [Qt][WK2] Caching of ShareableSurfaces breaks tiling. 2012-07-18 04:54:11 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno allan.jensen noam oldest_to_newest 672192 0 zeno 2012-07-18 03:25:53 -0700 This regression was triggered by r122554. We should only cache ShareableSurfaces, when they are GraphicsSurface based. 672213 1 152979 zeno 2012-07-18 03:46:43 -0700 Created attachment 152979 patch for review. 672250 2 zeno 2012-07-18 04:54:11 -0700 Committed r122948: <http://trac.webkit.org/changeset/122948> 152979 2012-07-18 03:46:43 -0700 2012-07-18 03:49:13 -0700 patch for review. 91609_20120718-124559.patch text/plain 3076 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkMmE5YzQ0Li4wM2NlMTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMTggIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIENhY2hpbmcgb2YgU2hhcmVhYmxlU3VyZmFjZXMgYnJlYWtzIHRpbGluZy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjA5CisK KyAgICAgICAgQSBTaGFyZWFibGVTdXJmYWNlIHNob3VsZCBvbmx5IGJlIGNhY2hlZCwKKyAgICAg ICAgd2hlbiBpdCBpcyBHcmFwaGljc1N1cmZhY2UgYmFzZWQuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF5ZXJUcmVlQ29vcmRp bmF0b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUNvb3JkaW5hdG9yUHJv eHk6OnVwZGF0ZVRpbGVGb3JMYXllcik6CisgICAgICAgICogVUlQcm9jZXNzL0xheWVyVHJlZUNv b3JkaW5hdG9yUHJveHkuaDoKKyAgICAgICAgKExheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkpOgor CiAyMDEyLTA3LTE3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5j b20+CiAKICAgICAgICAgW0VGTF0gUmVwbGFjZSAwIGJ5IE5VTEwgaW4gcHVibGljIGhlYWRlcnMg ZG9jdW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xheWVy VHJlZUNvb3JkaW5hdG9yUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xheWVy VHJlZUNvb3JkaW5hdG9yUHJveHkuY3BwCmluZGV4IGRhZDkwOTMuLjYyOTI5MWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXllclRyZWVDb29yZGluYXRvclByb3h5LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94 eS5jcHAKQEAgLTYxLDI2ICs2MSwyMCBAQCB2b2lkIExheWVyVHJlZUNvb3JkaW5hdG9yUHJveHk6 OmNyZWF0ZVRpbGVGb3JMYXllcihpbnQgbGF5ZXJJRCwgaW50IHRpbGVJRCwgY29ucwogICAgIHVw ZGF0ZVRpbGVGb3JMYXllcihsYXllcklELCB0aWxlSUQsIHRhcmdldFJlY3QsIHVwZGF0ZUluZm8p OwogfQogCi1zdGF0aWMgaW5saW5lIHVpbnQ2NF90IGNyZWF0ZUxheWVyVGlsZVVuaXF1ZUtleShp bnQgbGF5ZXJJRCwgaW50IHRpbGVJRCkKLXsKLSAgICB1aW50NjRfdCBrZXkgPSBsYXllcklEOwot ICAgIGtleSA8PD0gMzI7Ci0gICAga2V5IHw9IHRpbGVJRDsKLSAgICByZXR1cm4ga2V5OwotfQot CiB2b2lkIExheWVyVHJlZUNvb3JkaW5hdG9yUHJveHk6OnVwZGF0ZVRpbGVGb3JMYXllcihpbnQg bGF5ZXJJRCwgaW50IHRpbGVJRCwgY29uc3QgSW50UmVjdCYgdGFyZ2V0UmVjdCwgY29uc3QgV2Vi S2l0OjpTdXJmYWNlVXBkYXRlSW5mbyYgdXBkYXRlSW5mbykKIHsKICAgICBSZWZQdHI8U2hhcmVh YmxlU3VyZmFjZT4gc3VyZmFjZTsKICNpZiBVU0UoR1JBUEhJQ1NfU1VSRkFDRSkKLSAgICB1aW50 NjRfdCBrZXkgPSBjcmVhdGVMYXllclRpbGVVbmlxdWVLZXkobGF5ZXJJRCwgdGlsZUlEKTsKLQot ICAgIEhhc2hNYXA8dWludDY0X3QsIFJlZlB0cjxTaGFyZWFibGVTdXJmYWNlPiA+OjppdGVyYXRv ciBpdCA9IG1fc3VyZmFjZXMuZmluZChrZXkpOwotICAgIGlmIChpdCA9PSBtX3N1cmZhY2VzLmVu ZCgpKSB7Ci0gICAgICAgIHN1cmZhY2UgPSBTaGFyZWFibGVTdXJmYWNlOjpjcmVhdGUodXBkYXRl SW5mby5zdXJmYWNlSGFuZGxlKTsKLSAgICAgICAgbV9zdXJmYWNlcy5hZGQoa2V5LCBzdXJmYWNl KTsKKyAgICBpbnQgdG9rZW4gPSB1cGRhdGVJbmZvLnN1cmZhY2VIYW5kbGUuZ3JhcGhpY3NTdXJm YWNlVG9rZW4oKTsKKyAgICBpZiAodG9rZW4pIHsKKyAgICAgICAgSGFzaE1hcDx1aW50MzJfdCwg UmVmUHRyPFNoYXJlYWJsZVN1cmZhY2U+ID46Oml0ZXJhdG9yIGl0ID0gbV9zdXJmYWNlcy5maW5k KHRva2VuKTsKKyAgICAgICAgaWYgKGl0ID09IG1fc3VyZmFjZXMuZW5kKCkpIHsKKyAgICAgICAg ICAgIHN1cmZhY2UgPSBTaGFyZWFibGVTdXJmYWNlOjpjcmVhdGUodXBkYXRlSW5mby5zdXJmYWNl SGFuZGxlKTsKKyAgICAgICAgICAgIG1fc3VyZmFjZXMuYWRkKHRva2VuLCBzdXJmYWNlKTsKKyAg ICAgICAgfSBlbHNlCisgICAgICAgICAgICBzdXJmYWNlID0gaXQtPnNlY29uZDsKICAgICB9IGVs c2UKLSAgICAgICAgc3VyZmFjZSA9IGl0LT5zZWNvbmQ7CisgICAgICAgIHN1cmZhY2UgPSBTaGFy ZWFibGVTdXJmYWNlOjpjcmVhdGUodXBkYXRlSW5mby5zdXJmYWNlSGFuZGxlKTsKICNlbHNlCiAg ICAgc3VyZmFjZSA9IFNoYXJlYWJsZVN1cmZhY2U6OmNyZWF0ZSh1cGRhdGVJbmZvLnN1cmZhY2VI YW5kbGUpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF5 ZXJUcmVlQ29vcmRpbmF0b3JQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xheWVy VHJlZUNvb3JkaW5hdG9yUHJveHkuaAppbmRleCBjMGVkYjY2Li5iNGU3YjdjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94eS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXllclRyZWVDb29yZGluYXRvclByb3h5LmgK QEAgLTc5LDcgKzc5LDcgQEAgcHJvdGVjdGVkOgogICAgIERyYXdpbmdBcmVhUHJveHkqIG1fZHJh d2luZ0FyZWFQcm94eTsKICAgICBSZWZQdHI8V2ViTGF5ZXJUcmVlUmVuZGVyZXI+IG1fcmVuZGVy ZXI7CiAjaWYgVVNFKEdSQVBISUNTX1NVUkZBQ0UpCi0gICAgSGFzaE1hcDx1aW50NjRfdCwgUmVm UHRyPFNoYXJlYWJsZVN1cmZhY2U+ID4gbV9zdXJmYWNlczsKKyAgICBIYXNoTWFwPHVpbnQzMl90 LCBSZWZQdHI8U2hhcmVhYmxlU3VyZmFjZT4gPiBtX3N1cmZhY2VzOwogI2VuZGlmCiB9OwogCg==