91608 2012-07-18 03:10:04 -0700 [EFL][WK2] Too early assertion failure if default theme is not available 2012-07-18 04:30:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 90788 1 d-r d-r gyuyoung.kim gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 672184 0 d-r 2012-07-18 03:10:04 -0700 After bug 90107 we're setting a default theme path, which leads to a "themeChanged()" call initializing createEdje() - if that theme path is not available we run into a premature assertion failure. We need to give the embedder a chance to override the theme path before failing - so only the usages of m_edje should be guarded with assertions. 672210 1 152978 d-r 2012-07-18 03:45:38 -0700 Created attachment 152978 Patch 672239 2 152978 webkit.review.bot 2012-07-18 04:30:50 -0700 Comment on attachment 152978 Patch Clearing flags on attachment: 152978 Committed r122946: <http://trac.webkit.org/changeset/122946> 672241 3 webkit.review.bot 2012-07-18 04:30:55 -0700 All reviewed patches have been landed. Closing bug. 152978 2012-07-18 03:45:38 -0700 2012-07-18 04:30:50 -0700 Patch bug-91608-20120718134751.patch text/plain 2204 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFmMzUzNjI3NTA3MDAx NTAwYWJhYzFkYjk0N2ZmYjA5MTc4MmIwMi4uNDY0OTRmOTgzMzBhOGVjM2UwYWU3NGMwYWVmNWY3 YTY3NWE2MGJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTE4ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W0VGTF1bV0syXSBUb28gZWFybHkgYXNzZXJ0aW9uIGZhaWx1cmUgaWYgZGVmYXVsdCB0aGVtZSBp cyBub3QgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MTYwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFmdGVyIGJ1ZyA5MDEwNyB3ZSdyZSBzZXR0aW5nIGEgZGVmYXVsdCB0aGVtZSBwYXRo LCB3aGljaCBsZWFkcyB0byBhCisgICAgICAgIHRoZW1lQ2hhbmdlZCgpIGNhbGwgaW5pdGlhbGl6 aW5nIGVkamUgaW4gY3JlYXRlRWRqZSgpIC0gaWYgdGhhdCB0aGVtZQorICAgICAgICBwYXRoIGlz IG5vdCBhdmFpbGFibGUgd2UgcnVuIGludG8gYSBwcmVtYXR1cmUgYXNzZXJ0aW9uIGZhaWx1cmUu CisgICAgICAgIFdlIG5lZWQgdG8gZ2l2ZSB0aGUgZW1iZWRkZXIgYSBjaGFuY2UgdG8gb3ZlcnJp ZGUgdGhlIGRlZmF1bHQgdGhlbWUgcGF0aAorICAgICAgICBiZWZvcmUgZmFpbGluZyAtIHNvIG9u bHkgdGhlIHVzYWdlcyBvZiBtX2VkamUgc2hvdWxkIGJlIGd1YXJkZWQgd2l0aCBhc3NlcnRpb25z LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIHJlbmRlcmluZyBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVJlc2V0KTogQWRk aW5nIGFuIGFzc2VydGlvbiB0byBlbnN1cmUgbV9lZGplIGlzIHByZXNlbnQgLSBzbyB0aGF0IGFs bCB1c2FnZXMgb2YgbV9lZGplIGFyZSBub3cgZ3VhcmRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lRWZsOjpjcmVhdGVFZGplKTogTm90IGhpdHRpbmcgYXNzZXJ0aW9uIGlmIHRoZW1l IHBhdGggZG9lc24ndCBjb250YWluIHRoZSB0aGVtZSBvYmplY3QgZmlsZSwgYWxsb3dpbmcgdGhl IGVtYmVkZGVyIHRvIG92ZXJyaWRlIHdpdGggYSBuZXcgcGF0aC4KKwogMjAxMi0wNy0xOCAgUnl1 YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQ3Vyc29y IGlzIG5vdCBkcmF3biB3aGVuIG9wZW5nbF94MTEgYmFja2VuZCBpcyBjaG9vc2VuLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggZWQzZDY5 MjY4NzQ0ZGViNzljMmJlMWM2OWQwZDAyNzQ4MDcwODBjMC4uOTAyMzQxYWFhYjk3Nzg0ODAxZWQy NTBjNjkxMTExMzU2ODZiY2JkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v ZWZsL1JlbmRlclRoZW1lRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuY3BwCkBAIC0xMDAsNiArMTAwLDcgQEAgYm9vbCBSZW5kZXJUaGVtZUVm bDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVJlc2V0KHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5KiBl bnRyeSwKICAgICBjb25zdCBjaGFyICpmaWxlLCAqZ3JvdXA7CiAKICAgICBBU1NFUlQoZW50cnkp OworICAgIEFTU0VSVChtX2VkamUpOwogCiAgICAgZWRqZV9vYmplY3RfZmlsZV9nZXQobV9lZGpl LCAmZmlsZSwgMCk7CiAgICAgZ3JvdXAgPSBlZGplR3JvdXBGcm9tRm9ybVR5cGUodHlwZSk7CkBA IC00NjQsNyArNDY1LDYgQEAgdm9pZCBSZW5kZXJUaGVtZUVmbDo6Y3JlYXRlRWRqZSgpCiAjdW5k ZWYgQ09OTkVDVAogICAgICAgICB9CiAgICAgfQotICAgIEFTU0VSVChtX2VkamUpOwogfQogCiB2 b2lkIFJlbmRlclRoZW1lRWZsOjphcHBseUVkamVDb2xvcnMoKQo=