<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91488</bug_id>
          
          <creation_ts>2012-07-17 04:00:46 -0700</creation_ts>
          <short_desc>AuthorShadowDOM for keygen element</short_desc>
          <delta_ts>2012-08-05 20:42:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>82313</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Shinya Kawanaka">shinyak</reporter>
          <assigned_to name="Dominic Cooney">dominicc</assigned_to>
          <cc>dominicc</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>671147</commentid>
    <comment_count>0</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-07-17 04:00:46 -0700</bug_when>
    <thetext>When we add an AuthorShadowDOM to keygen element, it should be rendered correctly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>686131</commentid>
    <comment_count>1</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2012-08-02 19:14:58 -0700</bug_when>
    <thetext>I will take a look at this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>686135</commentid>
    <comment_count>2</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2012-08-02 19:16:39 -0700</bug_when>
    <thetext>*** Bug 91491 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687586</commentid>
    <comment_count>3</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2012-08-05 07:03:07 -0700</bug_when>
    <thetext>I tried attaching an author ShadowRoot to a keygen element and the rendering looks fine to me. The shadow element produces the select element used in the UA ShadowRoot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687717</commentid>
    <comment_count>4</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 19:45:17 -0700</bug_when>
    <thetext>Actually it&apos;s not working</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687718</commentid>
    <comment_count>5</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 19:45:48 -0700</bug_when>
    <thetext>Repro:
http://jsfiddle.net/vctmc/

In this case, the keygen selector should disappear.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687719</commentid>
    <comment_count>6</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 19:47:29 -0700</bug_when>
    <thetext>Repro:
http://jsfiddle.net/XNNZw/

In this case, the keygen selector should have 10px margins for each direction.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687720</commentid>
    <comment_count>7</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 19:49:09 -0700</bug_when>
    <thetext>Attaching Shadow DOM to &lt;keygen&gt; works, but the problem is that rendering is not correctly.
The replaced element should behave like having its contents in UserAgentShadowRoot.

Please see my design doc...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687723</commentid>
    <comment_count>8</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2012-08-05 20:03:35 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Repro:
&gt; http://jsfiddle.net/vctmc/
&gt; 
&gt; In this case, the keygen selector should disappear.

No it shouldn’t; the repro has this code;

var sr = new WebKitShadowDOM(host);
console.log(sr);
sr.innerHTML = &quot;&lt;div style=&apos;10px 10px 10px 10px&apos;&gt;&lt;/div&gt;&quot;
​
but WebKitShadowDOM is not defined. Hence no ShadowRoot is created and the rendering shouldn’t change. Also the inline style is not valid – there is no property name, for example.

(In reply to comment #6)
&gt; Repro:
&gt; http://jsfiddle.net/XNNZw/
&gt; 
&gt; In this case, the keygen selector should have 10px margins for each direction.

This repro has the same problems: it writes WebKitShadowDOM which is undefined, and the inline style is invalid.

If I fix these problems:

var sr = new WebKitShadowRoot(host);
sr.innerHTML = &quot;&lt;div style=&apos;margin: 10px 10px 10px 10px&apos;&gt;&lt;shadow&gt;&lt;/shadow&gt;&lt;/div&gt;&quot;
​
then the div has 10px margins as expected.

I’m going to close this again, I think this is working fine, the repros are invalid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687727</commentid>
    <comment_count>9</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 20:15:39 -0700</bug_when>
    <thetext>It&apos;s my failure that I wrongly typed &quot;new WebKitShadowDOM&quot; instead of &quot;new WebKitShadowRoot&quot;.
Sorry for that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687737</commentid>
    <comment_count>10</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 20:39:57 -0700</bug_when>
    <thetext>By the way, can you provide a layout test?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>687738</commentid>
    <comment_count>11</comment_count>
    <who name="Shinya Kawanaka">shinyak</who>
    <bug_when>2012-08-05 20:42:07 -0700</bug_when>
    <thetext>OK... &lt;keygen&gt; does not provide any host special renderer... Great. In that case it&apos;s very easy to AuthorShadowDOM-ready. Then there is basically nothing to work for it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>