91375 2012-07-16 04:47:17 -0700 [Qt] Fix inconsistent DLL linkage on Windows with WebKit1 2012-07-16 07:56:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88300 1 hausmann hausmann webkit.review.bot oldest_to_newest 670241 0 hausmann 2012-07-16 04:47:17 -0700 Linking on Windows fails: link /LIBPATH:"c:\dev\qt5\qtbase\lib" /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO /DLL /MANIFEST /MANIFESTFILE:"obj/release\QtWebKit.intermediate.manifest" /VERSION:5.00 /OUT:..\lib\QtWebKit5.dll @C:\Users\SIMONH~1\AppData\Local\Temp\nmE740.tmp Creating library ..\lib\QtWebKit5.lib and object ..\lib\QtWebKit5.exp WebKit1.lib(DumpRenderTreeSupportQt.obj) : warning LNK4217: locally defined symbol ?core@QWebHistoryItemPrivate@@SAPAVHistoryItem@WebCore@@PBVQWebHistoryItem@@@Z (public: static class WebCore::HistoryItem * __cdecl QWebHistoryItemPrivate::core(class QWebHistoryItem const *)) imported in function "public: static bool __cdecl DumpRenderTreeSupportQt::isTargetItem(class QWebHistoryItem const &)" (?isTargetItem@DumpRenderTreeSupportQt@@SA_NABVQWebHistoryItem@@@Z) WebKit1.lib(DumpRenderTreeSupportQt.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall QWebHistoryItemPrivate::QWebHistoryItemPrivate(class WebCore::HistoryItem *)" (__imp_??0QWebHistoryItemPrivate@@QAE@PAVHistoryItem@WebCore@@@Z) referenced in function "public: static class QMap<class QString,class QWebHistoryItem> __cdecl DumpRenderTreeSupportQt::getChildHistoryItems(class QWebHistoryItem const &)" (?getChildHistoryItems@DumpRenderTreeSupportQt@@SA?AV?$QMap@VQString@@VQWebHistoryItem@@@@ABVQWebHistoryItem@@@Z) WebKit1.lib(qwebhistory.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __thiscall QWebHistoryItemPrivate::QWebHistoryItemPrivate(class WebCore::HistoryItem *)" (__imp_??0QWebHistoryItemPrivate@@QAE@PAVHistoryItem@WebCore@@@Z) WebKit1.lib(FrameLoaderClientQt.obj) : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __thiscall QWebHistoryItemPrivate::QWebHistoryItemPrivate(class WebCore::HistoryItem *)" (__imp_??0QWebHistoryItemPrivate@@QAE@PAVHistoryItem@WebCore@@@Z) WebKit1.lib(qwebhistory.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall QWebHistoryItemPrivate::~QWebHistoryItemPrivate(void)" (__imp_??1QWebHistoryItemPrivate@@QAE@XZ) referenced in function "public: void * __thiscall QWebHistoryItemPrivate::`scalar deleting destructor'(unsigned int)" (??_GQWebHistoryItemPrivate@@QAEPAXI@Z) ..\lib\QtWebKit5.dll : fatal error LNK1120: 2 unresolved externals QWebHistoryItemPrivate is marked with Q_AUTOTEST_EXPORT. However that macro only works for libraries inside of Qt - we choose not to define things like QT_BUILDING_QT and QT_BUILD_INTERNAL. We could introduce our own Q_AUTOTEST_EXPORT macro or we could simply export this one class that exists only in a private header file only. I'm going to take the latter approach. 670244 1 152511 hausmann 2012-07-16 04:49:41 -0700 Created attachment 152511 Patch 670287 2 152511 laszlo.gombos 2012-07-16 06:28:44 -0700 Comment on attachment 152511 Patch Looks good to me. I assume this was the only place where we had Q_AUTOTEST_EXPORT. 670336 3 152511 webkit.review.bot 2012-07-16 07:56:23 -0700 Comment on attachment 152511 Patch Clearing flags on attachment: 152511 Committed r122727: <http://trac.webkit.org/changeset/122727> 670337 4 webkit.review.bot 2012-07-16 07:56:27 -0700 All reviewed patches have been landed. Closing bug. 152511 2012-07-16 04:49:41 -0700 2012-07-16 07:56:23 -0700 Patch bug-91375-20120716134950.patch text/plain 1484 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDk4YjJiNmI4ZDA4 NjFiY2FkYmY1YTdiMjY0Y2ViYTRlZDVjY2I3ZjUuLjgxMTAwN2M1YmVmOTIzZGM4YTRlMmI2MDkz ODU2ZWIzNjk5NWVjNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDct MTYgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCisgICAgICAg IFtRdF0gRml4IGluY29uc2lzdGVudCBETEwgbGlua2FnZSBvbiBXaW5kb3dzIHdpdGggV2ViS2l0 MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEzNzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvcnQg UVdlYkhpc3RvcnlJdGVtUHJpdmF0ZSBhcyByZXF1aXJlZCBmb3IgdGVzdHMuIFVuZm9ydHVuYXRl bHkgd2UgY2Fubm90IHVzZQorICAgICAgICBRX0FVVE9URVNUX0VYUE9SVCBvdXRzaWRlIG9mIFF0 LgorCisgICAgICAgICogQXBpL3F3ZWJoaXN0b3J5X3AuaDoKKwogMjAxMi0wNy0xNiAgRnJlZGVy aWsgR2xhZGhvcm4gIDxmcmVkZXJpay5nbGFkaG9ybkBub2tpYS5jb20+CiAKICAgICAgICAgQWNj ZXNzaWJsZSBXaWRnZXQgZm9yIFFXZWJWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0FwaS9xd2ViaGlzdG9yeV9wLmggYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2ViaGlzdG9yeV9w LmgKaW5kZXggNDQ3OTNiOTkwNjcyOGNiNGYwYTc0ZWRjY2MxOGM2OWZlMWQyZWMxZC4uYWFlZTM4 NjMyOWMwNWZjNTdjMTcyZGI2ZTY4MzY5NjIxYjJhZmIzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYmhpc3RvcnlfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3 ZWJoaXN0b3J5X3AuaApAQCAtMjIsMTIgKzIyLDEzIEBACiAKICNpbmNsdWRlICJCYWNrRm9yd2Fy ZExpc3RJbXBsLmgiCiAjaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKKyNpbmNsdWRlICJxd2Via2l0 Z2xvYmFsLmgiCiAjaW5jbHVkZSA8UXRDb3JlL3FnbG9iYWwuaD4KICNpbmNsdWRlIDxRdENvcmUv cXNoYXJlZGRhdGEuaD4KIAogY2xhc3MgUVdlYlBhZ2VQcml2YXRlOwogCi1jbGFzcyBRX0FVVE9U RVNUX0VYUE9SVCBRV2ViSGlzdG9yeUl0ZW1Qcml2YXRlIDogcHVibGljIFFTaGFyZWREYXRhIHsK K2NsYXNzIFFXRUJLSVRfRVhQT1JUIFFXZWJIaXN0b3J5SXRlbVByaXZhdGUgOiBwdWJsaWMgUVNo YXJlZERhdGEgewogcHVibGljOgogICAgIHN0YXRpYyBRRXhwbGljaXRseVNoYXJlZERhdGFQb2lu dGVyPFFXZWJIaXN0b3J5SXRlbVByaXZhdGU+IGdldChRV2ViSGlzdG9yeUl0ZW0qIHEpCiAgICAg ewo=