91232 2012-07-13 06:29:17 -0700 [EFL][WK2] Make new public Ewk headers as installable 2012-07-13 10:09:21 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 1 cdumez cdumez gustavo gyuyoung.kim kenneth rakuco rwlbuis ryuan.choi tmpsantos tonikitoo webkit.review.bot oldest_to_newest 668954 0 cdumez 2012-07-13 06:29:17 -0700 New public Ewk headers have been added but they were not marked as installable. We need to fix this. 668955 1 152242 cdumez 2012-07-13 06:30:28 -0700 Created attachment 152242 Patch 669041 2 152242 rakuco 2012-07-13 08:06:13 -0700 Comment on attachment 152242 Patch LGTM. Do you really need to specify the absolute paths in the list, BTW? 669045 3 cdumez 2012-07-13 08:08:48 -0700 (In reply to comment #2) > (From update of attachment 152242 [details]) > LGTM. Do you really need to specify the absolute paths in the list, BTW? no clue, I merely followed the existing style. 669085 4 tmpsantos 2012-07-13 08:52:22 -0700 LGTM. 669092 5 tmpsantos 2012-07-13 08:55:53 -0700 (In reply to comment #2) > (From update of attachment 152242 [details]) > LGTM. Do you really need to specify the absolute paths in the list, BTW? Or you can define a new variable for this path. But since this is the only place using the particular path, IMO it is not necessary. The patch is fine the way it is now. 669128 6 rakuco 2012-07-13 09:27:06 -0700 (In reply to comment #5) > (In reply to comment #2) > > (From update of attachment 152242 [details] [details]) > > LGTM. Do you really need to specify the absolute paths in the list, BTW? > > Or you can define a new variable for this path. But since this is the only place using the particular path, IMO it is not necessary. The patch is fine the way it is now. What I mean is that it shouldn't be necessary to define an absolute path at all. 669160 7 152242 webkit.review.bot 2012-07-13 10:09:14 -0700 Comment on attachment 152242 Patch Clearing flags on attachment: 152242 Committed r122597: <http://trac.webkit.org/changeset/122597> 669161 8 webkit.review.bot 2012-07-13 10:09:21 -0700 All reviewed patches have been landed. Closing bug. 152242 2012-07-13 06:30:28 -0700 2012-07-13 10:09:14 -0700 Patch 91232_install_ewk_headers.patch text/plain 1700 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyOTk0ZmJmLi44YzI5YzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDctMTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIE1ha2UgbmV3IHB1YmxpYyBFd2sgaGVhZGVycyBh cyBpbnN0YWxsYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTEyMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNYWtlIG5ldyBwdWJsaWMgRXdrIGhlYWRlcnMgaW5zdGFsbGFibGUuCisKKyAgICAgICAg KiBQbGF0Zm9ybUVmbC5jbWFrZToKKwogMjAxMi0wNy0xMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gV2ViS2l0MiBjcmFzaCB3aGVu IGdvaW5nIGJhY2svZm9yd2FyZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1F ZmwuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCBlNWU1NGU2 Li41Mzc0YWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMTcwLDcgKzE3MCwxNCBA QCBDT05GSUdVUkVfRklMRShlZmwvZXdlYmtpdDIucGMuaW4gJHtDTUFLRV9CSU5BUllfRElSfS9X ZWJLaXQyL2VmbC9ld2Via2l0Mi5wYyBATwogU0VUIChFV2ViS2l0Ml9IRUFERVJTCiAgICAgIiR7 Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9VSVByb2Nlc3MvQVBJL2VmbC9FV2ViS2l0Mi5oIgog ICAgICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Nv bnRleHQuaCIKKyAgICAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a19pbnRlbnQuaCIKKyAgICAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a19pbnRlbnRfc2VydmljZS5oIgorICAgICIke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vVUlQcm9jZXNzL0FQSS9lZmwvZXdrX25hdmlnYXRpb25fcG9saWN5X2RlY2lz aW9uLmgiCisgICAgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdXJsX3JlcXVlc3QuaCIKKyAgICAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a191cmxfcmVzcG9uc2UuaCIKICAgICAiJHtDTUFLRV9DVVJSRU5U X1NPVVJDRV9ESVJ9L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgiCisgICAgIiR7Q01BS0Vf Q1VSUkVOVF9TT1VSQ0VfRElSfS9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfd2ViX2Vycm9yLmgiCisg ICAgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfd2Vi X3Jlc291cmNlLmgiCiApCiAKIElOU1RBTEwoRklMRVMgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJL aXQyL2VmbC9ld2Via2l0Mi5wYyBERVNUSU5BVElPTiBsaWIvcGtnY29uZmlnKQo=