91014 2012-07-11 14:12:22 -0700 Static NodeList needs to to keep item wrappers alive 2013-03-19 13:23:44 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 arv webkit-unassigned ap ggaren haraken rniwa sam webkit.review.bot oldest_to_newest 667041 0 151772 arv 2012-07-11 14:12:22 -0700 Created attachment 151772 Layout test Currently we do not keep the wrappers of static node lists alive. Both the JSC and V8 bindings get this wrong. document.body.innerHTML = '<b></b>'; var elements = document.body.querySelectorAll('*'); elements[0].customProperty = 42; document.body.textContent = ''; gc(); shouldBe('elements[0].customProperty', '42'); 670528 1 ggaren 2012-07-16 11:50:30 -0700 Does this problem only apply to StaticNodeList? What about StaticHashSetNodeList and DynamicNodeList? In JSC, the way to fix this is to make the node list wrapper's visit function add its document to the opaque root set. This will require giving all NodeLists, and not just DynamicNodeLists, owner document pointers. 670665 2 arv 2012-07-16 14:29:37 -0700 (In reply to comment #1) > Does this problem only apply to StaticNodeList? What about StaticHashSetNodeList and DynamicNodeList? Most (all?) of the DynamicNodeLists keep the wrappers alive though other means. For example the nodes in a childNodes NodeList are kept alive as long as the parent node is kept alive. 670671 3 ggaren 2012-07-16 14:33:55 -0700 How do they keep the parent node alive? 670674 4 rniwa 2012-07-16 14:35:02 -0700 (In reply to comment #3) > How do they keep the parent node alive? DynamicNodeList has a RefPtr to its owner. 670687 5 ggaren 2012-07-16 14:46:37 -0700 But what keeps the JavaScript wrapper alive? 858674 6 adamk 2013-03-19 13:23:44 -0700 *** Bug 105666 has been marked as a duplicate of this bug. *** 151772 2012-07-11 14:12:22 -0700 2012-07-11 14:12:22 -0700 Layout test nodelist-reachable-item.html text/html 374 arv PCFET0NUWVBFIGh0bWw+Cjxib2R5PjwvYm9keT4KPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjxzY3JpcHQ+Cgpkb2N1bWVudC5ib2R5Lmlu bmVySFRNTCA9ICc8Yj48L2I+JzsKdmFyIGVsZW1lbnRzID0gZG9jdW1lbnQuYm9keS5xdWVyeVNl bGVjdG9yQWxsKCcqJyk7CmVsZW1lbnRzWzBdLmN1c3RvbVByb3BlcnR5ID0gNDI7CmRvY3VtZW50 LmJvZHkudGV4dENvbnRlbnQgPSAnJzsKZ2MoKTsKc2hvdWxkQmUoJ2VsZW1lbnRzWzBdLmN1c3Rv bVByb3BlcnR5JywgJzQyJykKCjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cgo=